)]}'
{"horizon/static/framework/util/tech-debt/helper-functions.service.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a21a90d4c8bc84556f529ce58f5be63d0f1ab402","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      $rootScope.$apply();"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    function getParamsFromQueryString(query) {"},{"line_number":43,"context_line":"      var params \u003d {};"},{"line_number":44,"context_line":"      if (angular.isDefined(query) \u0026\u0026 query !\u003d\u003d \"\") {"},{"line_number":45,"context_line":"        var queryParts \u003d query.split(\"\u0026\");"},{"line_number":46,"context_line":"        queryParts.forEach(function (queryPart) {"},{"line_number":47,"context_line":"          var queryKeyValue \u003d queryPart.split(\"\u003d\");"},{"line_number":48,"context_line":"          params[queryKeyValue[0]] \u003d queryKeyValue[1];"},{"line_number":49,"context_line":"        });"},{"line_number":50,"context_line":"        return params;"},{"line_number":51,"context_line":"      }"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":17,"id":"bacf61ea_85905597","line":52,"range":{"start_line":42,"start_character":3,"end_line":52,"end_character":5},"updated":"2016-07-27 16:39:18.000000000","message":"There\u0027s a better place/way of doing this parsing.  Start with:\n\nhttps://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/magic-search/magic-search.service.js#L99\n\nThat will handle much of what you need here.  I would argue that you should add a new service method to the magic-search service if anything.\n\nI would say something in either a new function in the magic-search service or in the controller, like:\n\nfunction getQueryObject (data) {\n  getSearchTermsFromQueryString(data)\n    .map(getSearchTermObject)\n    .reduce(addToObject, {});\n\n  function addToObject(orig, curr) {\n    orig[curr.type] \u003d curr.value;\n    return orig;\n  }\n}\n\nor something like that.  Using those existing functions helps reduce the amount of re-coding the parsing features and adds consistency.  Putting it in the tech-debt legacy code doesn\u0027t really help its visibility.","commit_id":"6d78d12d293a567639008f465de111a2149cd5cc"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"087fe029e7d6489a12f20d4e6be1ac6be230803e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      $rootScope.$apply();"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    function getParamsFromQueryString(query) {"},{"line_number":43,"context_line":"      var params \u003d {};"},{"line_number":44,"context_line":"      if (angular.isDefined(query) \u0026\u0026 query !\u003d\u003d \"\") {"},{"line_number":45,"context_line":"        var queryParts \u003d query.split(\"\u0026\");"},{"line_number":46,"context_line":"        queryParts.forEach(function (queryPart) {"},{"line_number":47,"context_line":"          var queryKeyValue \u003d queryPart.split(\"\u003d\");"},{"line_number":48,"context_line":"          params[queryKeyValue[0]] \u003d queryKeyValue[1];"},{"line_number":49,"context_line":"        });"},{"line_number":50,"context_line":"        return params;"},{"line_number":51,"context_line":"      }"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":17,"id":"9ad45d7e_9d57ef01","line":52,"range":{"start_line":42,"start_character":3,"end_line":52,"end_character":5},"in_reply_to":"bacf61ea_85905597","updated":"2016-08-08 20:52:55.000000000","message":"Done. I moved the function to the magic-search service","commit_id":"6d78d12d293a567639008f465de111a2149cd5cc"}],"horizon/static/framework/widgets/magic-search/magic-search.controller.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"35a883b7c9d7f1a9551809f6650e32ea0b3121fa","unresolved":false,"context_lines":[{"line_number":291,"context_line":"      if (facets.length \u003e 0 \u0026\u0026 facets[0].isServer) {"},{"line_number":292,"context_line":"        return true;"},{"line_number":293,"context_line":"      }"},{"line_number":294,"context_line":"      return false;"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    function removeChoice() {"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_596fcdfb","line":294,"updated":"2016-06-13 22:51:43.000000000","message":"wondering if there is a graceful way to let users know there isn\u0027t a client-side search... because for the table magic search, it defaults to the client tablesorter","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"2bbd32938b0ab5b602804456df25072f9d091340","unresolved":false,"context_lines":[{"line_number":291,"context_line":"      if (facets.length \u003e 0 \u0026\u0026 facets[0].isServer) {"},{"line_number":292,"context_line":"        return true;"},{"line_number":293,"context_line":"      }"},{"line_number":294,"context_line":"      return false;"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    function removeChoice() {"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_16588030","line":294,"in_reply_to":"7aa08908_596fcdfb","updated":"2016-06-17 21:33:10.000000000","message":"like showing some help text to the user? or what do you mean?","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"35a883b7c9d7f1a9551809f6650e32ea0b3121fa","unresolved":false,"context_lines":[{"line_number":294,"context_line":"      return false;"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    function removeChoice() {"},{"line_number":298,"context_line":"      // prune facets as needed from menus"},{"line_number":299,"context_line":"      var newFacet \u003d ctrl.currentSearch[ctrl.currentSearch.length - 1].name;"},{"line_number":300,"context_line":"      var facetParts \u003d service.getSearchTermObject(newFacet);"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_a414c443","line":297,"updated":"2016-06-13 22:51:43.000000000","message":"don\u0027t think it should be called removeChoice... maybe removeDisplayItem?","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"2bbd32938b0ab5b602804456df25072f9d091340","unresolved":false,"context_lines":[{"line_number":294,"context_line":"      return false;"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    function removeChoice() {"},{"line_number":298,"context_line":"      // prune facets as needed from menus"},{"line_number":299,"context_line":"      var newFacet \u003d ctrl.currentSearch[ctrl.currentSearch.length - 1].name;"},{"line_number":300,"context_line":"      var facetParts \u003d service.getSearchTermObject(newFacet);"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_563e88b8","line":297,"in_reply_to":"7aa08908_a414c443","updated":"2016-06-17 21:33:10.000000000","message":"Done, not need since I changed the way this code uses magic search","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"231ea8da3048687e56523c2ed650d10d6509e32c","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        resetState();"},{"line_number":322,"context_line":"        $scope.$emit(\u0027searchUpdated\u0027, \u0027\u0027);"},{"line_number":323,"context_line":"        emitTextSearch(\u0027\u0027);"},{"line_number":324,"context_line":"        $scope.$emit(\u0027serverSearchUpdated\u0027, \u0027\u0027);"},{"line_number":325,"context_line":"      }"},{"line_number":326,"context_line":"    }"},{"line_number":327,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_d4287099","line":324,"range":{"start_line":324,"start_character":22,"end_line":324,"end_character":41},"updated":"2016-06-14 17:40:56.000000000","message":"-1: Previously, \"serverSearchUpdated\" was an event from st-magic-search which translated the generic magic-search \"searchUpdated\" event, and sorted out the \"isServer\" portion of the query. Why add this knowledge into magic-search itself?\n\nMagic search\u0027s job seems to me notify consumers that the user has changed the text or facets of a search query. It is up to consumers to decide what to do on that change. Some consumers will do local filtering in their data structures, others will make API calls for portions of the query.\n\nIn either case, I don\u0027t think magic search itself wants to have the knowledge of what parts of a query (if any) are \"server\" or \"local\" or any other future kind of way of generating search results from the new query.","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"2bbd32938b0ab5b602804456df25072f9d091340","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        resetState();"},{"line_number":322,"context_line":"        $scope.$emit(\u0027searchUpdated\u0027, \u0027\u0027);"},{"line_number":323,"context_line":"        emitTextSearch(\u0027\u0027);"},{"line_number":324,"context_line":"        $scope.$emit(\u0027serverSearchUpdated\u0027, \u0027\u0027);"},{"line_number":325,"context_line":"      }"},{"line_number":326,"context_line":"    }"},{"line_number":327,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_965bd021","line":324,"range":{"start_line":324,"start_character":22,"end_line":324,"end_character":41},"in_reply_to":"7aa08908_d4287099","updated":"2016-06-17 21:33:10.000000000","message":"Created a wrapper for magic search taking as base the searchlight-ui code you showed me.","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"7121a75eb1ba2bf4d594fe82b61fdc850e0d618c","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        }"},{"line_number":292,"context_line":"      });"},{"line_number":293,"context_line":"      var serverQuery \u003d serverQueries.join(\"\u0026\");"},{"line_number":294,"context_line":"      $scope.$emit(\u0027serverSearchUpdated\u0027, serverQuery);"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    function isServerSideFacet(query) {"}],"source_content_type":"text/javascript","patch_set":10,"id":"3aaa91ec_d9276410","line":294,"range":{"start_line":294,"start_character":5,"end_line":294,"end_character":55},"updated":"2016-06-29 14:47:46.000000000","message":"I think this entire function is unnecessary; when I use your code for my server-side magic search, I get 2 serverSearchUpdated: one that just contains \u0027disk_format\u003dami\u0027 as its data instead of the expected {magicSearchQuery: \u0027disk_format\u003dami\u0027...then I get the correct serverSearchUpdated.\n\nWhat is the justification for this function and its inclusion above?","commit_id":"3e589d8c4c9d2f46ff0c4139d61038f0648f0667"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"4c0a2cc599359b2d96354c3e566fb2d1672bdd74","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        }"},{"line_number":292,"context_line":"      });"},{"line_number":293,"context_line":"      var serverQuery \u003d serverQueries.join(\"\u0026\");"},{"line_number":294,"context_line":"      $scope.$emit(\u0027serverSearchUpdated\u0027, serverQuery);"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    function isServerSideFacet(query) {"}],"source_content_type":"text/javascript","patch_set":10,"id":"3aaa91ec_9c230a58","line":294,"range":{"start_line":294,"start_character":5,"end_line":294,"end_character":55},"in_reply_to":"3aaa91ec_b987f8b3","updated":"2016-06-29 14:59:17.000000000","message":"Yeah, this code should not be here, changes I did should affect any current magic search functionality. my bad","commit_id":"3e589d8c4c9d2f46ff0c4139d61038f0648f0667"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"ec638f037cc9c1da0588f7afe0179e880a4c2a97","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        }"},{"line_number":292,"context_line":"      });"},{"line_number":293,"context_line":"      var serverQuery \u003d serverQueries.join(\"\u0026\");"},{"line_number":294,"context_line":"      $scope.$emit(\u0027serverSearchUpdated\u0027, serverQuery);"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    function isServerSideFacet(query) {"}],"source_content_type":"text/javascript","patch_set":10,"id":"3aaa91ec_b987f8b3","line":294,"range":{"start_line":294,"start_character":5,"end_line":294,"end_character":55},"in_reply_to":"3aaa91ec_d9276410","updated":"2016-06-29 14:49:59.000000000","message":"FYI, it works fine when I remove L293-294.  I think it\u0027s just an unnecessary emit.","commit_id":"3e589d8c4c9d2f46ff0c4139d61038f0648f0667"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6703a71d2b66c1bfb62525e4a1d5a0777e826e46","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        resetState();"},{"line_number":333,"context_line":"        $scope.$emit(magicSearchEvents.SEARCH_UPDATED, \u0027\u0027);"},{"line_number":334,"context_line":"        emitTextSearch(\u0027\u0027);"},{"line_number":335,"context_line":"        $scope.$emit(\u0027serverSearchUpdated\u0027, \u0027\u0027);"},{"line_number":336,"context_line":"      }"},{"line_number":337,"context_line":"    }"},{"line_number":338,"context_line":""}],"source_content_type":"text/javascript","patch_set":10,"id":"3aaa91ec_5919b487","line":335,"range":{"start_line":335,"start_character":8,"end_line":335,"end_character":48},"updated":"2016-06-29 14:51:47.000000000","message":"This also causes problems.  It\u0027s sending a string instead of an object.  Look at the what serverSearchUpdated usually emits and you\u0027ll see what I mean.","commit_id":"3e589d8c4c9d2f46ff0c4139d61038f0648f0667"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"7d89d267de0a77b594059d8056ee199a03e9786a","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        resetState();"},{"line_number":333,"context_line":"        $scope.$emit(magicSearchEvents.SEARCH_UPDATED, \u0027\u0027);"},{"line_number":334,"context_line":"        emitTextSearch(\u0027\u0027);"},{"line_number":335,"context_line":"        $scope.$emit(\u0027serverSearchUpdated\u0027, \u0027\u0027);"},{"line_number":336,"context_line":"      }"},{"line_number":337,"context_line":"    }"},{"line_number":338,"context_line":""}],"source_content_type":"text/javascript","patch_set":10,"id":"3aaa91ec_9c54aafe","line":335,"range":{"start_line":335,"start_character":8,"end_line":335,"end_character":48},"in_reply_to":"3aaa91ec_5919b487","updated":"2016-06-29 14:52:33.000000000","message":"I think it\u0027s good to emit this event, but make sure you\u0027re creating a proper object...thanks!","commit_id":"3e589d8c4c9d2f46ff0c4139d61038f0648f0667"}],"horizon/static/framework/widgets/magic-search/magic-search.controller.spec.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"35a883b7c9d7f1a9551809f6650e32ea0b3121fa","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            {name: \u0027text\u003dsearchval\u0027, label: [\u0027stringtext\u0027, \u0027searchval\u0027]}]);"},{"line_number":305,"context_line":"        });"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        it(\"calls serverSearchUpdated if currenSearch is related to a server facet\", function() {"},{"line_number":308,"context_line":"          delete ctrl.facetSelected;"},{"line_number":309,"context_line":"          spyOn(scope, \"$emit\");"},{"line_number":310,"context_line":"          spyOn(searchInput, \u0027val\u0027).and.returnValue(\u0027test\u0027);"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_c4be30ad","line":307,"updated":"2016-06-13 22:51:43.000000000","message":"currentSearch*\n\ncalls serverSearchUpdated if currentSearch is a server-side facet?","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"2bbd32938b0ab5b602804456df25072f9d091340","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            {name: \u0027text\u003dsearchval\u0027, label: [\u0027stringtext\u0027, \u0027searchval\u0027]}]);"},{"line_number":305,"context_line":"        });"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        it(\"calls serverSearchUpdated if currenSearch is related to a server facet\", function() {"},{"line_number":308,"context_line":"          delete ctrl.facetSelected;"},{"line_number":309,"context_line":"          spyOn(scope, \"$emit\");"},{"line_number":310,"context_line":"          spyOn(searchInput, \u0027val\u0027).and.returnValue(\u0027test\u0027);"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_d69f18b2","line":307,"in_reply_to":"7aa08908_c4be30ad","updated":"2016-06-17 21:33:10.000000000","message":"Done. Not needed anymore, changed the way using magic search to avoid the usage of events","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"}],"horizon/static/framework/widgets/magic-search/magic-search.scss":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"e20e442128604de8ec791db96e569c9892c9da0a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"// Helper variable"},{"line_number":8,"context_line":"$magic-search-padding: ceil($input-height-base - $font-size-small * $line-height-base - $padding-small-vertical * 2)/2;"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"hz-magic-search-bar, magic-search-wrapper-bar {"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  .input-group {"},{"line_number":13,"context_line":"    width: 100%;"}],"source_content_type":"text/x-scss","patch_set":3,"id":"3aaa91ec_a4e38f32","line":10,"updated":"2016-06-22 17:36:22.000000000","message":"Can we float these to the next line for readability?","commit_id":"6f9035723bf4b27c20338e80e609e714226f0c0b"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"5c89a15f6221422c4116b8e91453aac90518e906","unresolved":false,"context_lines":[{"line_number":7,"context_line":"// Helper variable"},{"line_number":8,"context_line":"$magic-search-padding: ceil($input-height-base - $font-size-small * $line-height-base - $padding-small-vertical * 2)/2;"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"hz-magic-search-bar, magic-search-wrapper-bar {"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  .input-group {"},{"line_number":13,"context_line":"    width: 100%;"}],"source_content_type":"text/x-scss","patch_set":3,"id":"3aaa91ec_f6442675","line":10,"in_reply_to":"3aaa91ec_a4e38f32","updated":"2016-06-22 19:33:59.000000000","message":"Done","commit_id":"6f9035723bf4b27c20338e80e609e714226f0c0b"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"e20e442128604de8ec791db96e569c9892c9da0a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  .input-group {"},{"line_number":13,"context_line":"    width: 100%;"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    .magic-search.form-control, \u0026 \u003e magic-search-wrapper .magic-search.form-control {"},{"line_number":16,"context_line":"      padding: 0 $padding-xs-horizontal 0 0;"},{"line_number":17,"context_line":"      min-height: $input-height-base + 2;"},{"line_number":18,"context_line":"      height: 100%;"}],"source_content_type":"text/x-scss","patch_set":3,"id":"3aaa91ec_84c5b38f","line":15,"updated":"2016-06-22 17:36:22.000000000","message":"Can we float these to the next line for readability?\n\nAlso, does it absolutely need the added specificity?","commit_id":"6f9035723bf4b27c20338e80e609e714226f0c0b"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"5c89a15f6221422c4116b8e91453aac90518e906","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  .input-group {"},{"line_number":13,"context_line":"    width: 100%;"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    .magic-search.form-control, \u0026 \u003e magic-search-wrapper .magic-search.form-control {"},{"line_number":16,"context_line":"      padding: 0 $padding-xs-horizontal 0 0;"},{"line_number":17,"context_line":"      min-height: $input-height-base + 2;"},{"line_number":18,"context_line":"      height: 100%;"}],"source_content_type":"text/x-scss","patch_set":3,"id":"3aaa91ec_7659565a","line":15,"in_reply_to":"3aaa91ec_84c5b38f","updated":"2016-06-22 19:33:59.000000000","message":"Done","commit_id":"6f9035723bf4b27c20338e80e609e714226f0c0b"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"082e4ab50ab6e50202f98d7b9a1ec6d2ad59d473","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      height: 100%;"},{"line_number":40,"context_line":"      line-height: $input-height-base - 2;"},{"line_number":41,"context_line":"    }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    magic-search-wrapper {"},{"line_number":44,"context_line":"      width: 100%;"},{"line_number":45,"context_line":"      \u0026 \u003e magic-search.form-control {"}],"source_content_type":"text/x-scss","patch_set":11,"id":"3aaa91ec_5104e416","line":42,"updated":"2016-06-29 16:34:41.000000000","message":"Magic search can be used without the wrapper, right?","commit_id":"e9e67cd49595ee8204e5a39d7de40ff1f793b7ba"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"082e4ab50ab6e50202f98d7b9a1ec6d2ad59d473","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      line-height: $input-height-base - 2;"},{"line_number":41,"context_line":"    }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    magic-search-wrapper {"},{"line_number":44,"context_line":"      width: 100%;"},{"line_number":45,"context_line":"      \u0026 \u003e magic-search.form-control {"},{"line_number":46,"context_line":"        max-width:100%;"}],"source_content_type":"text/x-scss","patch_set":11,"id":"3aaa91ec_34182675","line":43,"updated":"2016-06-29 16:34:41.000000000","message":"The spacing on these rules aren\u0027t consistent with the rest of our css.","commit_id":"e9e67cd49595ee8204e5a39d7de40ff1f793b7ba"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"082e4ab50ab6e50202f98d7b9a1ec6d2ad59d473","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      color:$gray;"},{"line_number":53,"context_line":"      font-size:$font-size-base;"},{"line_number":54,"context_line":"      padding:0.5em;"},{"line_number":55,"context_line":"      z-index:99;"},{"line_number":56,"context_line":"      right:0.5em;"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":11,"id":"3aaa91ec_b40b7623","line":55,"updated":"2016-06-29 16:34:41.000000000","message":"z-index should not be set this way.  This is a hardcoded value.","commit_id":"e9e67cd49595ee8204e5a39d7de40ff1f793b7ba"}],"openstack_dashboard/api/rest/swift.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"35a883b7c9d7f1a9551809f6650e32ea0b3121fa","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @rest_utils.ajax()"},{"line_number":52,"context_line":"    def get(self, request):"},{"line_number":53,"context_line":"        \"\"\"Get the list of containers for this account"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        TODO(neillc): Add pagination"},{"line_number":56,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_b927d110","line":53,"updated":"2016-06-13 22:51:43.000000000","message":"give description of filtering/prefix","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"2bbd32938b0ab5b602804456df25072f9d091340","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @rest_utils.ajax()"},{"line_number":52,"context_line":"    def get(self, request):"},{"line_number":53,"context_line":"        \"\"\"Get the list of containers for this account"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        TODO(neillc): Add pagination"},{"line_number":56,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_569328a3","line":53,"in_reply_to":"7aa08908_b927d110","updated":"2016-06-17 21:33:10.000000000","message":"Done","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/containers-model.service.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"35a883b7c9d7f1a9551809f6650e32ea0b3121fa","unresolved":false,"context_lines":[{"line_number":374,"context_line":"      });"},{"line_number":375,"context_line":"    }"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    function getContainers(query) {"},{"line_number":378,"context_line":"      $q.all(["},{"line_number":379,"context_line":"        swiftAPI.getContainers(query).then(function onContainers(data) {"},{"line_number":380,"context_line":"          model.containers.length \u003d 0;"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_3961213a","line":377,"updated":"2016-06-13 22:51:43.000000000","message":"add ng docs","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"2bbd32938b0ab5b602804456df25072f9d091340","unresolved":false,"context_lines":[{"line_number":374,"context_line":"      });"},{"line_number":375,"context_line":"    }"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    function getContainers(query) {"},{"line_number":378,"context_line":"      $q.all(["},{"line_number":379,"context_line":"        swiftAPI.getContainers(query).then(function onContainers(data) {"},{"line_number":380,"context_line":"          model.containers.length \u003d 0;"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_96891072","line":377,"in_reply_to":"7aa08908_3961213a","updated":"2016-06-17 21:33:10.000000000","message":"Done","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a21a90d4c8bc84556f529ce58f5be63d0f1ab402","unresolved":false,"context_lines":[{"line_number":385,"context_line":"     *"},{"line_number":386,"context_line":"       */"},{"line_number":387,"context_line":"    function getContainers(params) {"},{"line_number":388,"context_line":"      $q.all(["},{"line_number":389,"context_line":"        swiftAPI.getContainers(params).then(function onContainers(data) {"},{"line_number":390,"context_line":"          model.containers.length \u003d 0;"},{"line_number":391,"context_line":"          push.apply(model.containers, data.data.items);"}],"source_content_type":"text/javascript","patch_set":17,"id":"bacf61ea_8f9356fa","line":388,"range":{"start_line":388,"start_character":6,"end_line":388,"end_character":14},"updated":"2016-07-27 16:39:18.000000000","message":"Doesn\u0027t seem $q.all() is needed here...just chain the .then() on L393 onto the end of the .then() on 389....right?","commit_id":"6d78d12d293a567639008f465de111a2149cd5cc"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"087fe029e7d6489a12f20d4e6be1ac6be230803e","unresolved":false,"context_lines":[{"line_number":385,"context_line":"     *"},{"line_number":386,"context_line":"       */"},{"line_number":387,"context_line":"    function getContainers(params) {"},{"line_number":388,"context_line":"      $q.all(["},{"line_number":389,"context_line":"        swiftAPI.getContainers(params).then(function onContainers(data) {"},{"line_number":390,"context_line":"          model.containers.length \u003d 0;"},{"line_number":391,"context_line":"          push.apply(model.containers, data.data.items);"}],"source_content_type":"text/javascript","patch_set":17,"id":"9ad45d7e_5d74579b","line":388,"range":{"start_line":388,"start_character":6,"end_line":388,"end_character":14},"in_reply_to":"bacf61ea_8f9356fa","updated":"2016-08-08 20:52:55.000000000","message":"Done","commit_id":"6d78d12d293a567639008f465de111a2149cd5cc"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/containers.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"35a883b7c9d7f1a9551809f6650e32ea0b3121fa","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                \u003c/li\u003e"},{"line_number":66,"context_line":"              \u003c/ul\u003e"},{"line_number":67,"context_line":"            \u003c/accordion-group\u003e"},{"line_number":68,"context_line":"          \u003c/accordion\u003e"},{"line_number":69,"context_line":"        \u003c/hz-magic-search-context\u003e"},{"line_number":70,"context_line":"      \u003c/div\u003e"},{"line_number":71,"context_line":"    \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"7aa08908_5984ed09","line":68,"updated":"2016-06-13 22:51:43.000000000","message":"show a \u0027no container found\u0027 message if search returns 0","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"2bbd32938b0ab5b602804456df25072f9d091340","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                \u003c/li\u003e"},{"line_number":66,"context_line":"              \u003c/ul\u003e"},{"line_number":67,"context_line":"            \u003c/accordion-group\u003e"},{"line_number":68,"context_line":"          \u003c/accordion\u003e"},{"line_number":69,"context_line":"        \u003c/hz-magic-search-context\u003e"},{"line_number":70,"context_line":"      \u003c/div\u003e"},{"line_number":71,"context_line":"    \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"7aa08908_d6ed5826","line":68,"in_reply_to":"7aa08908_5984ed09","updated":"2016-06-17 21:33:10.000000000","message":"Done","commit_id":"5ba16f8e82a70020f3551d32cd37d1290ea0ee04"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"e20e442128604de8ec791db96e569c9892c9da0a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                  \u003cdiv class\u003d\"progress-bar\" style\u003d\"width: 100%\"\u003e\u003c/div\u003e"},{"line_number":49,"context_line":"                \u003c/div\u003e"},{"line_number":50,"context_line":"              \u003c/div\u003e"},{"line_number":51,"context_line":"              \u003cul ng-if\u003d\"container.is_fetched\" class\u003d\"hz-object-detail\"\u003e"},{"line_number":52,"context_line":"                \u003cli class\u003d\"hz-object-count row\"\u003e"},{"line_number":53,"context_line":"                  \u003cspan class\u003d\"hz-object-label col-lg-7 col-md-12\" translate\u003eObject Count\u003c/span\u003e"},{"line_number":54,"context_line":"                  \u003cspan class\u003d\"hz-object-val col-lg-5 col-md-12\"\u003e{$container.count$}\u003c/span\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"3aaa91ec_242aff2c","line":51,"updated":"2016-06-22 17:36:22.000000000","message":"would this be better as a dl list?","commit_id":"6f9035723bf4b27c20338e80e609e714226f0c0b"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"5c89a15f6221422c4116b8e91453aac90518e906","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                  \u003cdiv class\u003d\"progress-bar\" style\u003d\"width: 100%\"\u003e\u003c/div\u003e"},{"line_number":49,"context_line":"                \u003c/div\u003e"},{"line_number":50,"context_line":"              \u003c/div\u003e"},{"line_number":51,"context_line":"              \u003cul ng-if\u003d\"container.is_fetched\" class\u003d\"hz-object-detail\"\u003e"},{"line_number":52,"context_line":"                \u003cli class\u003d\"hz-object-count row\"\u003e"},{"line_number":53,"context_line":"                  \u003cspan class\u003d\"hz-object-label col-lg-7 col-md-12\" translate\u003eObject Count\u003c/span\u003e"},{"line_number":54,"context_line":"                  \u003cspan class\u003d\"hz-object-val col-lg-5 col-md-12\"\u003e{$container.count$}\u003c/span\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"3aaa91ec_56025a0c","line":51,"in_reply_to":"3aaa91ec_242aff2c","updated":"2016-06-22 19:33:59.000000000","message":"not sure how can I fully take advantage of a dl list here? what would be the terms (dt)?","commit_id":"6f9035723bf4b27c20338e80e609e714226f0c0b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"04663b9b0d72871e71e4776a77c3555c00453045","unresolved":false,"context_lines":[{"line_number":79,"context_line":"      \u003c/div\u003e"},{"line_number":80,"context_line":"    \u003c/div\u003e"},{"line_number":81,"context_line":"    \u003cdiv class\u003d\"col-xs-12\" ng-if\u003d\"cc.model.containers.length \u003d\u003d 0\"\u003e"},{"line_number":82,"context_line":"      \u003cp\u003e\u003ctraslate\u003eNo items to display.\u003c/traslate\u003e\u003c/p\u003e"},{"line_number":83,"context_line":"    \u003c/div\u003e"},{"line_number":84,"context_line":"  \u003c/div\u003e"},{"line_number":85,"context_line":""}],"source_content_type":"text/html","patch_set":7,"id":"3aaa91ec_b2c30638","line":82,"range":{"start_line":82,"start_character":10,"end_line":82,"end_character":18},"updated":"2016-06-27 17:01:19.000000000","message":"\u0027translate\u0027 (both tags)","commit_id":"1927d38f45936c5c9793a89bdcd152aa88ece714"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"d0f7adad363a4cad1fa1590f97548144f466e5db","unresolved":false,"context_lines":[{"line_number":79,"context_line":"      \u003c/div\u003e"},{"line_number":80,"context_line":"    \u003c/div\u003e"},{"line_number":81,"context_line":"    \u003cdiv class\u003d\"col-xs-12\" ng-if\u003d\"cc.model.containers.length \u003d\u003d 0\"\u003e"},{"line_number":82,"context_line":"      \u003cp\u003e\u003ctraslate\u003eNo items to display.\u003c/traslate\u003e\u003c/p\u003e"},{"line_number":83,"context_line":"    \u003c/div\u003e"},{"line_number":84,"context_line":"  \u003c/div\u003e"},{"line_number":85,"context_line":""}],"source_content_type":"text/html","patch_set":7,"id":"3aaa91ec_36db4eef","line":82,"range":{"start_line":82,"start_character":10,"end_line":82,"end_character":18},"in_reply_to":"3aaa91ec_b2c30638","updated":"2016-06-28 15:49:47.000000000","message":"Done","commit_id":"1927d38f45936c5c9793a89bdcd152aa88ece714"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a21a90d4c8bc84556f529ce58f5be63d0f1ab402","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                \u003c/li\u003e"},{"line_number":49,"context_line":"                \u003cli class\u003d\"hz-object-timestamp row\"\u003e"},{"line_number":50,"context_line":"                  \u003cspan class\u003d\"hz-object-label col-lg-7 col-md-12\" translate\u003eDate Created\u003c/span\u003e"},{"line_number":51,"context_line":"                  \u003cspan class\u003d\"hz-object-val col-lg-5 col-md-12\"\u003e{$container.timestamp | date$}\u003c/span\u003e"},{"line_number":52,"context_line":"                \u003c/li\u003e"},{"line_number":53,"context_line":"                \u003cli class\u003d\"hz-object-link row\"\u003e"},{"line_number":54,"context_line":"                  \u003cdiv class\u003d\"themable-checkbox col-lg-7 col-md-12\"\u003e"}],"source_content_type":"text/html","patch_set":17,"id":"bacf61ea_f2a915e1","line":51,"range":{"start_line":51,"start_character":67,"end_line":51,"end_character":93},"updated":"2016-07-27 16:39:18.000000000","message":"Add space for reusability: {$ container.timestamp | date $}\n\nApply to above as well.","commit_id":"6d78d12d293a567639008f465de111a2149cd5cc"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"087fe029e7d6489a12f20d4e6be1ac6be230803e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                \u003c/li\u003e"},{"line_number":49,"context_line":"                \u003cli class\u003d\"hz-object-timestamp row\"\u003e"},{"line_number":50,"context_line":"                  \u003cspan class\u003d\"hz-object-label col-lg-7 col-md-12\" translate\u003eDate Created\u003c/span\u003e"},{"line_number":51,"context_line":"                  \u003cspan class\u003d\"hz-object-val col-lg-5 col-md-12\"\u003e{$container.timestamp | date$}\u003c/span\u003e"},{"line_number":52,"context_line":"                \u003c/li\u003e"},{"line_number":53,"context_line":"                \u003cli class\u003d\"hz-object-link row\"\u003e"},{"line_number":54,"context_line":"                  \u003cdiv class\u003d\"themable-checkbox col-lg-7 col-md-12\"\u003e"}],"source_content_type":"text/html","patch_set":17,"id":"9ad45d7e_9d6ecfc7","line":51,"range":{"start_line":51,"start_character":67,"end_line":51,"end_character":93},"in_reply_to":"bacf61ea_f2a915e1","updated":"2016-08-08 20:52:55.000000000","message":"Done","commit_id":"6d78d12d293a567639008f465de111a2149cd5cc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"49cf30a4102492636b66fbce6ef88f77894de030","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                \u003c/li\u003e"},{"line_number":49,"context_line":"                \u003cli class\u003d\"hz-object-timestamp row\"\u003e"},{"line_number":50,"context_line":"                  \u003cspan class\u003d\"hz-object-label col-lg-7 col-md-12\" translate\u003eDate Created\u003c/span\u003e"},{"line_number":51,"context_line":"                  \u003cspan class\u003d\"hz-object-val col-lg-5 col-md-12\"\u003e{$container.timestamp | date$}\u003c/span\u003e"},{"line_number":52,"context_line":"                \u003c/li\u003e"},{"line_number":53,"context_line":"                \u003cli class\u003d\"hz-object-link row\"\u003e"},{"line_number":54,"context_line":"                  \u003cdiv class\u003d\"themable-checkbox col-lg-7 col-md-12\"\u003e"}],"source_content_type":"text/html","patch_set":17,"id":"bacf61ea_8555f5c7","line":51,"range":{"start_line":51,"start_character":67,"end_line":51,"end_character":93},"in_reply_to":"bacf61ea_f2a915e1","updated":"2016-07-27 16:40:38.000000000","message":"Sorry...\u0027readability.\u0027 :)","commit_id":"6d78d12d293a567639008f465de111a2149cd5cc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a21a90d4c8bc84556f529ce58f5be63d0f1ab402","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                  \u003c/div\u003e"},{"line_number":60,"context_line":"                  \u003cspan class\u003d\"hz-object-val col-lg-5 col-md-12\"\u003e"},{"line_number":61,"context_line":"                    \u003ca href\u003d\"{$ container.public_url $}\" target\u003d\"_blank\""},{"line_number":62,"context_line":"                       ng-show\u003d\"container.public_url\" translate\u003elink\u003c/a\u003e"},{"line_number":63,"context_line":"                    \u003cspan ng-hide\u003d\"container.public_url\" translate\u003edisabled\u003c/span\u003e"},{"line_number":64,"context_line":"                  \u003c/span\u003e"},{"line_number":65,"context_line":"                \u003c/li\u003e"}],"source_content_type":"text/html","patch_set":17,"id":"bacf61ea_32656de1","line":62,"range":{"start_line":62,"start_character":64,"end_line":62,"end_character":68},"updated":"2016-07-27 16:39:18.000000000","message":"Seems odd that it\u0027s lower case...I know that it\u0027s not new code, but just wondering why that is that way.","commit_id":"6d78d12d293a567639008f465de111a2149cd5cc"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"087fe029e7d6489a12f20d4e6be1ac6be230803e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                  \u003c/div\u003e"},{"line_number":60,"context_line":"                  \u003cspan class\u003d\"hz-object-val col-lg-5 col-md-12\"\u003e"},{"line_number":61,"context_line":"                    \u003ca href\u003d\"{$ container.public_url $}\" target\u003d\"_blank\""},{"line_number":62,"context_line":"                       ng-show\u003d\"container.public_url\" translate\u003elink\u003c/a\u003e"},{"line_number":63,"context_line":"                    \u003cspan ng-hide\u003d\"container.public_url\" translate\u003edisabled\u003c/span\u003e"},{"line_number":64,"context_line":"                  \u003c/span\u003e"},{"line_number":65,"context_line":"                \u003c/li\u003e"}],"source_content_type":"text/html","patch_set":17,"id":"9ad45d7e_dd6847bd","line":62,"range":{"start_line":62,"start_character":64,"end_line":62,"end_character":68},"in_reply_to":"bacf61ea_32656de1","updated":"2016-08-08 20:52:55.000000000","message":"Done","commit_id":"6d78d12d293a567639008f465de111a2149cd5cc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a21a90d4c8bc84556f529ce58f5be63d0f1ab402","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                  \u003cspan class\u003d\"hz-object-val col-lg-5 col-md-12\"\u003e"},{"line_number":61,"context_line":"                    \u003ca href\u003d\"{$ container.public_url $}\" target\u003d\"_blank\""},{"line_number":62,"context_line":"                       ng-show\u003d\"container.public_url\" translate\u003elink\u003c/a\u003e"},{"line_number":63,"context_line":"                    \u003cspan ng-hide\u003d\"container.public_url\" translate\u003edisabled\u003c/span\u003e"},{"line_number":64,"context_line":"                  \u003c/span\u003e"},{"line_number":65,"context_line":"                \u003c/li\u003e"},{"line_number":66,"context_line":"              \u003c/ul\u003e"}],"source_content_type":"text/html","patch_set":17,"id":"bacf61ea_926259d7","line":63,"range":{"start_line":63,"start_character":67,"end_line":63,"end_character":75},"updated":"2016-07-27 16:39:18.000000000","message":"seems odd that it\u0027s lower case.","commit_id":"6d78d12d293a567639008f465de111a2149cd5cc"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"087fe029e7d6489a12f20d4e6be1ac6be230803e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                  \u003cspan class\u003d\"hz-object-val col-lg-5 col-md-12\"\u003e"},{"line_number":61,"context_line":"                    \u003ca href\u003d\"{$ container.public_url $}\" target\u003d\"_blank\""},{"line_number":62,"context_line":"                       ng-show\u003d\"container.public_url\" translate\u003elink\u003c/a\u003e"},{"line_number":63,"context_line":"                    \u003cspan ng-hide\u003d\"container.public_url\" translate\u003edisabled\u003c/span\u003e"},{"line_number":64,"context_line":"                  \u003c/span\u003e"},{"line_number":65,"context_line":"                \u003c/li\u003e"},{"line_number":66,"context_line":"              \u003c/ul\u003e"}],"source_content_type":"text/html","patch_set":17,"id":"9ad45d7e_bd6593e2","line":63,"range":{"start_line":63,"start_character":67,"end_line":63,"end_character":75},"in_reply_to":"bacf61ea_926259d7","updated":"2016-08-08 20:52:55.000000000","message":"Done","commit_id":"6d78d12d293a567639008f465de111a2149cd5cc"}],"openstack_dashboard/static/app/core/openstack-service-api/swift.service.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e4222c6068d6b800ea67682e99b2c568a6ccdb81","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      return \u0027/api/swift/containers/\u0027 + encodeURIComponent(container);"},{"line_number":65,"context_line":"    }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    // internal use only"},{"line_number":68,"context_line":"    function getContainersURL(query) {"},{"line_number":69,"context_line":"      if (angular.isDefined(query)) {"},{"line_number":70,"context_line":"        return \u0027/api/swift/containers?\u0027 + encodeURIComponent(query).replace(/%3D/g, \u0027\u003d\u0027);"},{"line_number":71,"context_line":"      }"},{"line_number":72,"context_line":"      else {"},{"line_number":73,"context_line":"        return \u0027/api/swift/containers/\u0027;"},{"line_number":74,"context_line":"      }"},{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    /**"},{"line_number":78,"context_line":"     * @name getObjectURL"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_fddcc1e5","line":75,"range":{"start_line":67,"start_character":0,"end_line":75,"end_character":5},"updated":"2016-06-29 17:59:45.000000000","message":"I think that this is accommodated by the $http service via data passed in a get call.  No need to rewrite.\n\nYou can call apiService.get(\u0027/some/path\u0027, dataObject) and I believe that is all placed onto the URL for you.","commit_id":"c255ab9c882154e35f82b768916085aab21a9530"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e4222c6068d6b800ea67682e99b2c568a6ccdb81","unresolved":false,"context_lines":[{"line_number":115,"context_line":"     *"},{"line_number":116,"context_line":"     */"},{"line_number":117,"context_line":"    function getContainers(query) {"},{"line_number":118,"context_line":"      return apiService.get(getContainersURL(query))"},{"line_number":119,"context_line":"        .error(function() {"},{"line_number":120,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to get the Swift container listing.\u0027));"},{"line_number":121,"context_line":"        });"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_9da13d49","line":118,"range":{"start_line":118,"start_character":28,"end_line":118,"end_character":52},"updated":"2016-06-29 17:59:45.000000000","message":"Yeah, I\u0027m not so hot on just accepting a predefined query string and passing it through as the URL.  Lots of things that can go wrong.  Define an object and pass it as the second argument to .get().","commit_id":"c255ab9c882154e35f82b768916085aab21a9530"}]}
