)]}'
{"openstack_dashboard/dashboards/admin/aggregates/panel.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"1357745e6632dc8cd409ba86fa40e092ade4899b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        try:"},{"line_number":33,"context_line":"            request \u003d context[\u0027request\u0027]"},{"line_number":34,"context_line":"            if (api.base.is_service_enabled(request, \u0027compute\u0027) and"},{"line_number":35,"context_line":"                    api.nova.extension_supported(\u0027Aggregates\u0027, request)):"},{"line_number":36,"context_line":"                return True"},{"line_number":37,"context_line":"            else:"},{"line_number":38,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_12e65044","line":35,"updated":"2016-06-15 16:43:49.000000000","message":"I thought with microversioning, extensions were going away in nova, does it make sense to add more queries about extensions in that light?","commit_id":"c246e726b1ffb972b098f9aab6881f27b6eed012"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"b529c651b12cfa3360dba805704aad1e3f8e6826","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        try:"},{"line_number":33,"context_line":"            request \u003d context[\u0027request\u0027]"},{"line_number":34,"context_line":"            if (api.base.is_service_enabled(request, \u0027compute\u0027) and"},{"line_number":35,"context_line":"                    api.nova.extension_supported(\u0027Aggregates\u0027, request)):"},{"line_number":36,"context_line":"                return True"},{"line_number":37,"context_line":"            else:"},{"line_number":38,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_15b8a1c6","line":35,"in_reply_to":"7aa08908_12e65044","updated":"2016-06-17 06:38:25.000000000","message":"Sorry that I\u0027m not familiar with nova extension.\nAt the moment, horizon is supporting nova v1.1 and v2.\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L51\n\nIn this case, \"Aggregates\" is already provided from nova v1.1.\nSo, we don\u0027t need to check this ?\n\nIf my comment doesn\u0027t have a point, very sorry and please let me know.","commit_id":"c246e726b1ffb972b098f9aab6881f27b6eed012"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"03cfda9f90c98864413811feece60d5de3674962","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            request \u003d context[\u0027request\u0027]"},{"line_number":34,"context_line":"            if (api.base.is_service_enabled(request, \u0027compute\u0027) and"},{"line_number":35,"context_line":"                    api.nova.extension_supported(\u0027Aggregates\u0027, request)):"},{"line_number":36,"context_line":"                return True"},{"line_number":37,"context_line":"            else:"},{"line_number":38,"context_line":"                return False"},{"line_number":39,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b2d8b8f0","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":27},"updated":"2016-06-17 10:42:29.000000000","message":"If here directly return True, you will miss the Line 44 which includes some policy check.","commit_id":"c246e726b1ffb972b098f9aab6881f27b6eed012"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"b66ced6598d54e3ab7aedd06226fc92eec73c788","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            request \u003d context[\u0027request\u0027]"},{"line_number":34,"context_line":"            if (api.base.is_service_enabled(request, \u0027compute\u0027) and"},{"line_number":35,"context_line":"                    api.nova.extension_supported(\u0027Aggregates\u0027, request)):"},{"line_number":36,"context_line":"                return True"},{"line_number":37,"context_line":"            else:"},{"line_number":38,"context_line":"                return False"},{"line_number":39,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_21ece8c6","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":27},"in_reply_to":"7aa08908_b2d8b8f0","updated":"2016-06-20 07:48:03.000000000","message":"Done","commit_id":"c246e726b1ffb972b098f9aab6881f27b6eed012"}]}