)]}'
{"openstack_dashboard/dashboards/identity/projects/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"adc6ff18035faad49be9996d58a599b88ce74233","unresolved":false,"context_lines":[{"line_number":974,"context_line":"    def test_update_project_save(self, nova\u003dTrue):"},{"line_number":975,"context_line":"        self._test_update_project_save(nova\u003dnova)"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"    def _test_update_project_save(self, nova\u003dTrue):"},{"line_number":978,"context_line":"        keystone_api_version \u003d api.keystone.VERSIONS.active"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"        project \u003d self.tenants.first()"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_423f0ad6","line":977,"range":{"start_line":977,"start_character":40,"end_line":977,"end_character":44},"updated":"2016-10-12 03:40:15.000000000","message":"Nit: \u0027nova_enabled\u0027 looks better.","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"5105727b150f5430743f94f6c4e7a655018aa9a1","unresolved":false,"context_lines":[{"line_number":974,"context_line":"    def test_update_project_save(self, nova\u003dTrue):"},{"line_number":975,"context_line":"        self._test_update_project_save(nova\u003dnova)"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"    def _test_update_project_save(self, nova\u003dTrue):"},{"line_number":978,"context_line":"        keystone_api_version \u003d api.keystone.VERSIONS.active"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"        project \u003d self.tenants.first()"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_d75116da","line":977,"range":{"start_line":977,"start_character":40,"end_line":977,"end_character":44},"in_reply_to":"fa6399be_423f0ad6","updated":"2016-10-12 08:13:16.000000000","message":"Done","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"adc6ff18035faad49be9996d58a599b88ce74233","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"                                         project.id,"},{"line_number":1070,"context_line":"                                         **nova_updated_quota)"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"            cinder_updated_quota \u003d dict([(key, updated_quota[key]) for key in"},{"line_number":1073,"context_line":"                                         quotas.CINDER_QUOTA_FIELDS])"},{"line_number":1074,"context_line":"            api.cinder.tenant_quota_update(IsA(http.HttpRequest),"},{"line_number":1075,"context_line":"                                           project.id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_2213f667","line":1072,"range":{"start_line":1072,"start_character":40,"end_line":1072,"end_character":41},"updated":"2016-10-12 03:40:15.000000000","message":"In python 2.7, we no longer need the outer-most []).\n\n dict((key, update_quota[key]) for key ...)","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"5105727b150f5430743f94f6c4e7a655018aa9a1","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"                                         project.id,"},{"line_number":1070,"context_line":"                                         **nova_updated_quota)"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"            cinder_updated_quota \u003d dict([(key, updated_quota[key]) for key in"},{"line_number":1073,"context_line":"                                         quotas.CINDER_QUOTA_FIELDS])"},{"line_number":1074,"context_line":"            api.cinder.tenant_quota_update(IsA(http.HttpRequest),"},{"line_number":1075,"context_line":"                                           project.id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_b75662d0","line":1072,"range":{"start_line":1072,"start_character":40,"end_line":1072,"end_character":41},"in_reply_to":"fa6399be_2213f667","updated":"2016-10-12 08:13:16.000000000","message":"Done","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"}],"openstack_dashboard/dashboards/identity/projects/workflows.py":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"35317fcbd2d617f8ec42402b43aa51324f6cd1b8","unresolved":false,"context_lines":[{"line_number":936,"context_line":"            # Update quota when steps have a quota tab"},{"line_number":937,"context_line":"            has_quota_tab \u003d False"},{"line_number":938,"context_line":"            for step in self.steps:"},{"line_number":939,"context_line":"                if step.slug \u003d\u003d \u0027update_quotas\u0027:"},{"line_number":940,"context_line":"                    has_quota_tab \u003d True"},{"line_number":941,"context_line":"                    break"},{"line_number":942,"context_line":"            if has_quota_tab:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_9f297d8c","line":939,"updated":"2016-07-19 09:49:52.000000000","message":"Maybe we can make it a little bit more flexible? Like `UpdateProjectQuotaAction.slug`?","commit_id":"b9147ed5ed8a419f151053667d34138efc9f2831"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"acea31a0d45b1d48354da59f7d4daa092345f194","unresolved":false,"context_lines":[{"line_number":936,"context_line":"            # Update quota when steps have a quota tab"},{"line_number":937,"context_line":"            has_quota_tab \u003d False"},{"line_number":938,"context_line":"            for step in self.steps:"},{"line_number":939,"context_line":"                if step.slug \u003d\u003d \u0027update_quotas\u0027:"},{"line_number":940,"context_line":"                    has_quota_tab \u003d True"},{"line_number":941,"context_line":"                    break"},{"line_number":942,"context_line":"            if has_quota_tab:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_e41ebc0a","line":939,"in_reply_to":"dada55a8_9f297d8c","updated":"2016-07-21 06:49:27.000000000","message":"Done","commit_id":"b9147ed5ed8a419f151053667d34138efc9f2831"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"adc6ff18035faad49be9996d58a599b88ce74233","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        super(UpdateProjectQuotaAction, self).__init__(request,"},{"line_number":98,"context_line":"                                                       *args,"},{"line_number":99,"context_line":"                                                       **kwargs)"},{"line_number":100,"context_line":"        project_id \u003d \u0027\u0027"},{"line_number":101,"context_line":"        if \u0027project_id\u0027 in self.initial:"},{"line_number":102,"context_line":"            project_id \u003d self.initial[\u0027project_id\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # get initial project quota"},{"line_number":105,"context_line":"        if keystone.is_cloud_admin(self.request):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_a207061b","line":102,"range":{"start_line":100,"start_character":8,"end_line":102,"end_character":51},"updated":"2016-10-12 03:40:15.000000000","message":"Doesn\u0027t the following work?\n\n  project_id \u003d self.initial.get(\u0027project_id\u0027, \u0027\u0027)","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"5105727b150f5430743f94f6c4e7a655018aa9a1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        super(UpdateProjectQuotaAction, self).__init__(request,"},{"line_number":98,"context_line":"                                                       *args,"},{"line_number":99,"context_line":"                                                       **kwargs)"},{"line_number":100,"context_line":"        project_id \u003d \u0027\u0027"},{"line_number":101,"context_line":"        if \u0027project_id\u0027 in self.initial:"},{"line_number":102,"context_line":"            project_id \u003d self.initial[\u0027project_id\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # get initial project quota"},{"line_number":105,"context_line":"        if keystone.is_cloud_admin(self.request):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_1762aead","line":102,"range":{"start_line":100,"start_character":8,"end_line":102,"end_character":51},"in_reply_to":"fa6399be_a207061b","updated":"2016-10-12 08:13:16.000000000","message":"Done","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"adc6ff18035faad49be9996d58a599b88ce74233","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    self.request, tenant_id\u003dproject_id)"},{"line_number":113,"context_line":"            for field_name in quotas.QUOTA_FIELDS:"},{"line_number":114,"context_line":"                self.fields[field_name].initial \u003d \\"},{"line_number":115,"context_line":"                    quota_data.get(field_name).limit"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def clean(self):"},{"line_number":118,"context_line":"        cleaned_data \u003d super(UpdateProjectQuotaAction, self).clean()"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_a56390db","line":115,"range":{"start_line":115,"start_character":20,"end_line":115,"end_character":45},"updated":"2016-10-12 03:40:15.000000000","message":"QuotaSet supports [] operation.\n\n quota_data[field_name].limit\n\nIt may fit in a single line.","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"d06c26958cd229cd8d5434e56bed146a3490965c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    self.request, tenant_id\u003dproject_id)"},{"line_number":113,"context_line":"            for field_name in quotas.QUOTA_FIELDS:"},{"line_number":114,"context_line":"                self.fields[field_name].initial \u003d \\"},{"line_number":115,"context_line":"                    quota_data.get(field_name).limit"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def clean(self):"},{"line_number":118,"context_line":"        cleaned_data \u003d super(UpdateProjectQuotaAction, self).clean()"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_acdee26a","line":115,"range":{"start_line":115,"start_character":20,"end_line":115,"end_character":45},"in_reply_to":"fa6399be_4d4c8442","updated":"2016-10-13 07:16:42.000000000","message":"This docstring is correct, although it may a little confuse. We can use [] to add new value and can use \"get\" to get a value.\nHowever, we cannot use [] to get a value with specifying a key. It allowes only index. \n\n----\nquota \u003d Quota(\"cpu\", 100)\nquota_set \u003d QuotaSet()\n\nquota_set[\"cpu\"] \u003d 100 // OK \nquota_set.get(\"cpu\") //OK\nquota_set[\"cpu\"] // NG\nquota_set[0] // OK","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dd08086d3f28cb37630d6fc905eecfda5fee553d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    self.request, tenant_id\u003dproject_id)"},{"line_number":113,"context_line":"            for field_name in quotas.QUOTA_FIELDS:"},{"line_number":114,"context_line":"                self.fields[field_name].initial \u003d \\"},{"line_number":115,"context_line":"                    quota_data.get(field_name).limit"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def clean(self):"},{"line_number":118,"context_line":"        cleaned_data \u003d super(UpdateProjectQuotaAction, self).clean()"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_4d4c8442","line":115,"range":{"start_line":115,"start_character":20,"end_line":115,"end_character":45},"in_reply_to":"fa6399be_7f21004d","updated":"2016-10-12 14:24:12.000000000","message":"Does not QuotaSet support [] operation (more precisely, __getitem__ method of QuotaSet)? According to the docstring, QuotaSet class supports \u0027list\u0027 and \u0027dict\u0027 methods. [] operation exist on both \u0027list\u0027 and \u0027dict\u0027, so there might be some limitations. I just would like to clarify the current situation.","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1528b3bb34cd3353ce7a1268e7b891c21ec6a7d5","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    self.request, tenant_id\u003dproject_id)"},{"line_number":113,"context_line":"            for field_name in quotas.QUOTA_FIELDS:"},{"line_number":114,"context_line":"                self.fields[field_name].initial \u003d \\"},{"line_number":115,"context_line":"                    quota_data.get(field_name).limit"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def clean(self):"},{"line_number":118,"context_line":"        cleaned_data \u003d super(UpdateProjectQuotaAction, self).clean()"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_7f21004d","line":115,"range":{"start_line":115,"start_character":20,"end_line":115,"end_character":45},"in_reply_to":"fa6399be_a56390db","updated":"2016-10-12 09:04:40.000000000","message":"quota_data is the type of List, so when I do like quota_data[field_name], error would occur.\n(index must be integer, not str)","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"adc6ff18035faad49be9996d58a599b88ce74233","unresolved":false,"context_lines":[{"line_number":973,"context_line":""},{"line_number":974,"context_line":"        if api.keystone.is_cloud_admin(request):"},{"line_number":975,"context_line":"            # Update quota when steps have a quota tab"},{"line_number":976,"context_line":"            has_quota_tab \u003d False"},{"line_number":977,"context_line":"            for step in self.steps:"},{"line_number":978,"context_line":"                if step.slug \u003d\u003d UpdateProjectQuotaAction.slug:"},{"line_number":979,"context_line":"                    has_quota_tab \u003d True"},{"line_number":980,"context_line":"                    break"},{"line_number":981,"context_line":"            if has_quota_tab:"},{"line_number":982,"context_line":"                ret \u003d self._update_project_quota(request, data, project_id)"},{"line_number":983,"context_line":"                if not ret:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_052a7c7e","line":980,"range":{"start_line":976,"start_character":12,"end_line":980,"end_character":25},"updated":"2016-10-12 03:40:15.000000000","message":"I think you can use any():\n\n  has_quota_tab \u003d any(step.slug \u003d\u003d UpdateProjectQuotaAction.slug\n                      for step in self.steps)","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"5105727b150f5430743f94f6c4e7a655018aa9a1","unresolved":false,"context_lines":[{"line_number":973,"context_line":""},{"line_number":974,"context_line":"        if api.keystone.is_cloud_admin(request):"},{"line_number":975,"context_line":"            # Update quota when steps have a quota tab"},{"line_number":976,"context_line":"            has_quota_tab \u003d False"},{"line_number":977,"context_line":"            for step in self.steps:"},{"line_number":978,"context_line":"                if step.slug \u003d\u003d UpdateProjectQuotaAction.slug:"},{"line_number":979,"context_line":"                    has_quota_tab \u003d True"},{"line_number":980,"context_line":"                    break"},{"line_number":981,"context_line":"            if has_quota_tab:"},{"line_number":982,"context_line":"                ret \u003d self._update_project_quota(request, data, project_id)"},{"line_number":983,"context_line":"                if not ret:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_89cf827e","line":980,"range":{"start_line":976,"start_character":12,"end_line":980,"end_character":25},"in_reply_to":"fa6399be_052a7c7e","updated":"2016-10-12 08:13:16.000000000","message":"Done. Thank you for good information!","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"adc6ff18035faad49be9996d58a599b88ce74233","unresolved":false,"context_lines":[{"line_number":982,"context_line":"                ret \u003d self._update_project_quota(request, data, project_id)"},{"line_number":983,"context_line":"                if not ret:"},{"line_number":984,"context_line":"                    return False"},{"line_number":985,"context_line":"            else:"},{"line_number":986,"context_line":"                return True"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"        return True"},{"line_number":989,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_05519c0e","line":986,"range":{"start_line":985,"start_character":12,"end_line":986,"end_character":27},"updated":"2016-10-12 03:40:15.000000000","message":"This looks unnecessary. L.988 works as a sentinel.","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"5105727b150f5430743f94f6c4e7a655018aa9a1","unresolved":false,"context_lines":[{"line_number":982,"context_line":"                ret \u003d self._update_project_quota(request, data, project_id)"},{"line_number":983,"context_line":"                if not ret:"},{"line_number":984,"context_line":"                    return False"},{"line_number":985,"context_line":"            else:"},{"line_number":986,"context_line":"                return True"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"        return True"},{"line_number":989,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_89214250","line":986,"range":{"start_line":985,"start_character":12,"end_line":986,"end_character":27},"in_reply_to":"fa6399be_05519c0e","updated":"2016-10-12 08:13:16.000000000","message":"Done","commit_id":"298d20729eb3981ba20fe11f348d561d00dea69b"}]}
