)]}'
{"openstack_dashboard/dashboards/project/networks/views.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7f5ae6be85b37b82f3da72431d788ad19b0de472","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # this returns the default dns servers to be used for new subnets"},{"line_number":64,"context_line":"        dns_default \u003d \"\\n\".join(getattr(settings, \u0027OPENSTACK_NEUTRON_NETWORK\u0027,"},{"line_number":65,"context_line":"                                        {}).get(\u0027default_dns_nameservers\u0027, \u0027\u0027))"},{"line_number":66,"context_line":"        return dns_default"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class CreateView(DefaultSubnetWorkflowMixin, workflows.WorkflowView):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_fb0fdb2b","line":66,"updated":"2016-07-05 13:26:29.000000000","message":"Why can\u0027t this just be a function? I can\u0027t see it using ``self`` anywhere?","commit_id":"b5611b14b20c29bd6881cb1648188a2fea676fed"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"aa60ae96f9709f7a4ea26c44fa8f8db5ee9d27d3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # this returns the default dns servers to be used for new subnets"},{"line_number":64,"context_line":"        dns_default \u003d \"\\n\".join(getattr(settings, \u0027OPENSTACK_NEUTRON_NETWORK\u0027,"},{"line_number":65,"context_line":"                                        {}).get(\u0027default_dns_nameservers\u0027, \u0027\u0027))"},{"line_number":66,"context_line":"        return dns_default"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class CreateView(DefaultSubnetWorkflowMixin, workflows.WorkflowView):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_d6e84119","line":66,"in_reply_to":"1aa78d24_fb0fdb2b","updated":"2016-07-15 19:26:20.000000000","message":"The advantage of having this be a class bound method, just a function, is that other things are present with the use of self.\n\nIn our deployment, we would like different default DNS servers for each region.   Since I can access self.request.user.services_region by doing a simple override.   If this was a simpler function, I no longer have access to this information.","commit_id":"b5611b14b20c29bd6881cb1648188a2fea676fed"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"f95812536bbd9e0b57d9609d48fc652b7636780f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # this returns the default dns servers to be used for new subnets"},{"line_number":64,"context_line":"        dns_default \u003d \"\\n\".join(getattr(settings, \u0027OPENSTACK_NEUTRON_NETWORK\u0027,"},{"line_number":65,"context_line":"                                        {}).get(\u0027default_dns_nameservers\u0027, \u0027\u0027))"},{"line_number":66,"context_line":"        return dns_default"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class CreateView(DefaultSubnetWorkflowMixin, workflows.WorkflowView):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_89c29551","line":66,"in_reply_to":"dada55a8_41040417","updated":"2016-07-26 15:26:18.000000000","message":"Just moving the function into the class and adding the self argument makes it terribly complex?   I don\u0027t think there is that much difference.\n\nLike I said, this way makes it a lot easier for me (and other operators) to have more complex / robust customization options.    If you feel strongly that you want this moved outside of the class, that is fine with me too - but I still need to keep some arguments with this class so I can access the request / user etc and have contextual information to be able to return the correct default dns server(s) for each situation.","commit_id":"b5611b14b20c29bd6881cb1648188a2fea676fed"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"38594d6326c9ffeb3fc042c8fd39155d6dfb95c0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # this returns the default dns servers to be used for new subnets"},{"line_number":64,"context_line":"        dns_default \u003d \"\\n\".join(getattr(settings, \u0027OPENSTACK_NEUTRON_NETWORK\u0027,"},{"line_number":65,"context_line":"                                        {}).get(\u0027default_dns_nameservers\u0027, \u0027\u0027))"},{"line_number":66,"context_line":"        return dns_default"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class CreateView(DefaultSubnetWorkflowMixin, workflows.WorkflowView):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_41040417","line":66,"in_reply_to":"fad55976_d6e84119","updated":"2016-07-26 11:37:25.000000000","message":"This still looks awfully complex for just adding a simple configuration option. A lot of classes and structure for a single line of code.","commit_id":"b5611b14b20c29bd6881cb1648188a2fea676fed"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"38594d6326c9ffeb3fc042c8fd39155d6dfb95c0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    workflow_class \u003d project_workflows.CreateNetwork"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_initial(self):"},{"line_number":73,"context_line":"        results \u003d workflows.WorkflowView.get_initial(self)"},{"line_number":74,"context_line":"        results[\u0027dns_nameservers\u0027] \u003d self.get_default_dns_servers()"},{"line_number":75,"context_line":"        return results"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_8119dc8a","line":73,"updated":"2016-07-26 11:37:25.000000000","message":"Please use super() to access the methods of the superclass.","commit_id":"b5611b14b20c29bd6881cb1648188a2fea676fed"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"f95812536bbd9e0b57d9609d48fc652b7636780f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    workflow_class \u003d project_workflows.CreateNetwork"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_initial(self):"},{"line_number":73,"context_line":"        results \u003d workflows.WorkflowView.get_initial(self)"},{"line_number":74,"context_line":"        results[\u0027dns_nameservers\u0027] \u003d self.get_default_dns_servers()"},{"line_number":75,"context_line":"        return results"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_04e96cb7","line":73,"in_reply_to":"dada55a8_8119dc8a","updated":"2016-07-26 15:26:18.000000000","message":"good catch, will do","commit_id":"b5611b14b20c29bd6881cb1648188a2fea676fed"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"c50674c28a2e4734aacd2f6d469092bc5b1bffc3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    workflow_class \u003d project_workflows.CreateNetwork"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_initial(self):"},{"line_number":73,"context_line":"        results \u003d workflows.WorkflowView.get_initial(self)"},{"line_number":74,"context_line":"        results[\u0027dns_nameservers\u0027] \u003d self.get_default_dns_servers()"},{"line_number":75,"context_line":"        return results"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_fc42ff3c","line":73,"updated":"2016-07-26 11:38:45.000000000","message":"Please use super() to call superclass methods, otherwise you are breaking inheritance.","commit_id":"a3efb977833c9a7e7fe3d5f08b918ddd3e167474"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"6b2e5be201f8cf1aa190382ca3c733e4f3f1a1af","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return networks"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class DefaultSubnetWorkflowMixin(workflows.WorkflowView):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def get_default_dns_servers(self):"},{"line_number":63,"context_line":"        # this returns the default dns servers to be used for new subnets"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_aab12be2","line":60,"updated":"2016-07-27 05:01:26.000000000","message":"Do we need to inherit WorkflowView?\nIn L69, CreateView is already inheriting WorkflowView.\nIf this class is for common methods in the case of subnetworkflow, I think it\u0027s enough to inherit Object.","commit_id":"f1255a35a777201928777ae38f04743ea6b3e1e3"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"f305cbeeb8ed46871b361370ca3e5a6517c592d0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return networks"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class DefaultSubnetWorkflowMixin(workflows.WorkflowView):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def get_default_dns_servers(self):"},{"line_number":63,"context_line":"        # this returns the default dns servers to be used for new subnets"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_2ccd4931","line":60,"in_reply_to":"bacf61ea_002bacec","updated":"2016-08-01 17:14:15.000000000","message":"Done","commit_id":"f1255a35a777201928777ae38f04743ea6b3e1e3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3dda3823cf85855b40d6c8395c899f03fafb203a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return networks"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class DefaultSubnetWorkflowMixin(workflows.WorkflowView):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def get_default_dns_servers(self):"},{"line_number":63,"context_line":"        # this returns the default dns servers to be used for new subnets"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_002bacec","line":60,"in_reply_to":"dada55a8_aab12be2","updated":"2016-07-27 19:39:46.000000000","message":"+1","commit_id":"f1255a35a777201928777ae38f04743ea6b3e1e3"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"f305cbeeb8ed46871b361370ca3e5a6517c592d0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return networks"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class DefaultSubnetWorkflowMixin(workflows.WorkflowView):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def get_default_dns_servers(self):"},{"line_number":63,"context_line":"        # this returns the default dns servers to be used for new subnets"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_4cca3d1c","line":60,"in_reply_to":"dada55a8_aab12be2","updated":"2016-08-01 17:14:15.000000000","message":"Done","commit_id":"f1255a35a777201928777ae38f04743ea6b3e1e3"}]}
