)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"9e7115c0f930f92183a71a69abff96a93eb07c22","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Server-side filtering networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements server-side filtering networks in:"},{"line_number":10,"context_line":"\t- Admin-\u003eSystem-\u003eNetworks"},{"line_number":11,"context_line":"\t- Project-\u003eNetwork-\u003eNetworks"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements blueprint: server-side-filtering"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_9a5f6040","line":10,"updated":"2016-06-14 03:10:04.000000000","message":"It is good to use not tab but space.","commit_id":"a03ebe12dd2c916b3771e18f491030e743bf8bd6"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"5fb76249d17dc145d5c7d815b70e4dceaf53bac6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Server-side filtering networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements server-side filtering networks in:"},{"line_number":10,"context_line":"\t- Admin-\u003eSystem-\u003eNetworks"},{"line_number":11,"context_line":"\t- Project-\u003eNetwork-\u003eNetworks"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements blueprint: server-side-filtering"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_b294918c","line":10,"in_reply_to":"7aa08908_9a5f6040","updated":"2016-06-15 20:42:13.000000000","message":"Done","commit_id":"a03ebe12dd2c916b3771e18f491030e743bf8bd6"}],"openstack_dashboard/api/neutron.py":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"b475ae92a2ce18783e75b287f41e7a1d5d5b354b","unresolved":false,"context_lines":[{"line_number":648,"context_line":"            networks \u003d network_list(request, tenant_id\u003dtenant_id, **params)"},{"line_number":649,"context_line":"    # In the current Neutron API, there is no way to retrieve"},{"line_number":650,"context_line":"    # both owner networks and public networks in a single API call."},{"line_number":651,"context_line":"    if \u0027shared\u0027 not in params:"},{"line_number":652,"context_line":"        networks +\u003d network_list(request, shared\u003dTrue, **params)"},{"line_number":653,"context_line":"    elif params[\u0027shared\u0027]:"},{"line_number":654,"context_line":"        networks +\u003d network_list(request, **params)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a9d85d2_1c1c7312","line":651,"updated":"2016-06-21 10:19:49.000000000","message":"Could you please explain why now we need to check it here? This is because of \"shared\" option fo filtering?","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"dd378f76cb0ef3203a0da11205de2a5a99062f85","unresolved":false,"context_lines":[{"line_number":648,"context_line":"            networks \u003d network_list(request, tenant_id\u003dtenant_id, **params)"},{"line_number":649,"context_line":"    # In the current Neutron API, there is no way to retrieve"},{"line_number":650,"context_line":"    # both owner networks and public networks in a single API call."},{"line_number":651,"context_line":"    if \u0027shared\u0027 not in params:"},{"line_number":652,"context_line":"        networks +\u003d network_list(request, shared\u003dTrue, **params)"},{"line_number":653,"context_line":"    elif params[\u0027shared\u0027]:"},{"line_number":654,"context_line":"        networks +\u003d network_list(request, **params)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_332287ba","line":651,"in_reply_to":"5a9d85d2_1c1c7312","updated":"2016-06-21 18:36:32.000000000","message":"if \u0027shared\u0027 not in params: is if shared is not the selected filter it will look for the shared networks with the other filter(s) in params, else if the filter is shared and any valid value it will bring the shared networks with any other possible parameter. For project table it is also filtered by tenant_id.  I don\u0027t know if this explains why I added that.","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"b676623a967ce7d6a6f32f40304eb2037384c19c","unresolved":false,"context_lines":[{"line_number":652,"context_line":"        networks +\u003d network_list(request, shared\u003dTrue, **params)"},{"line_number":653,"context_line":"    elif params[\u0027shared\u0027]:"},{"line_number":654,"context_line":"        networks +\u003d network_list(request, **params)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    include_external \u003d include_external or params.get(\u0027router:external\u0027)"},{"line_number":657,"context_line":"    if include_external:"},{"line_number":658,"context_line":"        params[\u0027router:external\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_579174f0","line":655,"updated":"2016-06-29 17:27:55.000000000","message":"The logic above seems kind of strange. Can we not merge these if statements to make it more readable? There are two separate boolean check for the same thing.","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"e9cb0ba8a61b257946f54bdb936c3b5e47b23caa","unresolved":false,"context_lines":[{"line_number":652,"context_line":"        networks +\u003d network_list(request, shared\u003dTrue, **params)"},{"line_number":653,"context_line":"    elif params[\u0027shared\u0027]:"},{"line_number":654,"context_line":"        networks +\u003d network_list(request, **params)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    include_external \u003d include_external or params.get(\u0027router:external\u0027)"},{"line_number":657,"context_line":"    if include_external:"},{"line_number":658,"context_line":"        params[\u0027router:external\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_c3ce462c","line":655,"in_reply_to":"3aaa91ec_579174f0","updated":"2016-06-29 18:36:13.000000000","message":"I\u0027ll upload a patch in a while","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8fc331ac1cb9a1117dad8cc00230e907c00e847b","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        # both owner networks and public networks in a single API call."},{"line_number":649,"context_line":"        networks +\u003d network_list(request, shared\u003dTrue, **params)"},{"line_number":650,"context_line":"    elif not params[\u0027shared\u0027]:"},{"line_number":651,"context_line":"            networks \u003d network_list(request, tenant_id\u003dtenant_id, **params)"},{"line_number":652,"context_line":"    elif params[\u0027shared\u0027]:"},{"line_number":653,"context_line":"        networks +\u003d network_list(request, **params)"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_e3e97fe7","line":651,"range":{"start_line":651,"start_character":8,"end_line":651,"end_character":12},"updated":"2016-06-30 20:59:33.000000000","message":"indent looks wrong...strange I don\u0027t see pep8 errors.","commit_id":"e0f92eb4b512f36739688e107483cebf2e92edff"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"87e7fe3716b42f5c3ad621934feb2cb6e14bddc4","unresolved":false,"context_lines":[{"line_number":650,"context_line":"    elif not params[\u0027shared\u0027]:"},{"line_number":651,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id, **params)"},{"line_number":652,"context_line":"    elif params[\u0027shared\u0027]:"},{"line_number":653,"context_line":"        networks +\u003d network_list(request, **params)"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    include_external \u003d include_external or params.get(\u0027router:external\u0027)"},{"line_number":656,"context_line":"    if include_external:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_907af6ef","line":653,"updated":"2016-07-05 13:23:51.000000000","message":"This way of doing tri-state logic is pretty bad, because then you have to jump through hoops when you sometimes want the \"shared\" parameter and sometimes not depending on some variable. I think it\u0027s much better to have two boolean parameters, one controlling whether the tennant_id is passed, second controlling whether shared networks are included.","commit_id":"6f1ae4fc6e8eaeead7fe45bde368144955d3e52e"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"0c7333b2d931af9812beec05a8a64647f77d9c30","unresolved":false,"context_lines":[{"line_number":650,"context_line":"    elif not params[\u0027shared\u0027]:"},{"line_number":651,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id, **params)"},{"line_number":652,"context_line":"    elif params[\u0027shared\u0027]:"},{"line_number":653,"context_line":"        networks +\u003d network_list(request, **params)"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    include_external \u003d include_external or params.get(\u0027router:external\u0027)"},{"line_number":656,"context_line":"    if include_external:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_f01843d5","line":653,"in_reply_to":"1aa78d24_17c34eee","updated":"2016-07-06 19:47:24.000000000","message":"Basically split this in two. Have one parameter that controls filtering by shared\u003dTrue/False, and another one that controls filtering by tenant. Then the code that calls this function has much more control, and doesn\u0027t have to have weird IFs like:\n\n    if shared is None:\n        network_list_for_tenant(request)\n    else:\n        network_list_for_tenant(request, shared\u003dshared)","commit_id":"6f1ae4fc6e8eaeead7fe45bde368144955d3e52e"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"ace3b815b29ed7b0327b7e175cfd6b4bf307abf2","unresolved":false,"context_lines":[{"line_number":650,"context_line":"    elif not params[\u0027shared\u0027]:"},{"line_number":651,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id, **params)"},{"line_number":652,"context_line":"    elif params[\u0027shared\u0027]:"},{"line_number":653,"context_line":"        networks +\u003d network_list(request, **params)"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    include_external \u003d include_external or params.get(\u0027router:external\u0027)"},{"line_number":656,"context_line":"    if include_external:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_17c34eee","line":653,"in_reply_to":"1aa78d24_907af6ef","updated":"2016-07-06 17:36:47.000000000","message":"The logic goes as the next:\n- If you are not filtering by \u0027shared\u0027 it returns the networks in the same tenant that shared \u003d false + all the networks shared. \n- If the filter is shared\u003dFalse, it returns the networks in the tenant with value shared\u003dFalse. \n- If the value is shared\u003dTrue, it returns all the networks with value shared\u003dTrue from all the tenants. \n\nI would really appreciate if you could explain me more about the way that you propose.","commit_id":"6f1ae4fc6e8eaeead7fe45bde368144955d3e52e"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"5817bc8b3b67ff1a072d4cbdbc90dd22b64d5d4b","unresolved":false,"context_lines":[{"line_number":650,"context_line":"    elif not params[\u0027shared\u0027]:"},{"line_number":651,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id, **params)"},{"line_number":652,"context_line":"    elif params[\u0027shared\u0027]:"},{"line_number":653,"context_line":"        networks +\u003d network_list(request, **params)"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    include_external \u003d include_external or params.get(\u0027router:external\u0027)"},{"line_number":656,"context_line":"    if include_external:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_966f32fb","line":653,"in_reply_to":"1aa78d24_f01843d5","updated":"2016-07-06 22:45:37.000000000","message":"I still dont get what you are saying, you mean adding another function like network_list_shared? and adding more ifs to networks views instead of here? Please if you have time contact me through irc, my nickname is jlopezgu and Im most of the time in #openstack-horizon","commit_id":"6f1ae4fc6e8eaeead7fe45bde368144955d3e52e"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"bbba37026c09409354d3767329e848a35405a4b8","unresolved":false,"context_lines":[{"line_number":651,"context_line":"    elif not params[\u0027shared\u0027]:"},{"line_number":652,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id, **params)"},{"line_number":653,"context_line":"    else:"},{"line_number":654,"context_line":"        networks \u003d network_list(request, **params)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    include_external \u003d include_external or params.get(\u0027router:external\u0027)"},{"line_number":657,"context_line":"    if include_external:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_1a01ae05","line":654,"updated":"2016-07-06 18:56:30.000000000","message":"My previous comment still applies. If you want to have three or more possible outcomes, use two bool parameters. Basing behavior on an existence of a parameter (not its value) is problematic for the caller.","commit_id":"a68fe993e3e372e6d1a7a1f3c1afba1b1a1dcca3"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"4cb83037683f5edefa06fa52ddad78c5fc262b5e","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    The list contains networks owned by the tenant and public networks."},{"line_number":664,"context_line":"    If requested_networks specified, it searches requested_networks only."},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":"    LOG.debug(\"network_list_for_tenant(): tenant_id\u003d%s, params\u003d%s\""},{"line_number":667,"context_line":"              % (tenant_id, params))"},{"line_number":668,"context_line":"    networks \u003d []"},{"line_number":669,"context_line":"    if shared:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_6aaf8194","line":666,"updated":"2016-07-19 21:14:31.000000000","message":"If adding a new function. Should probably add the equivalent api tests. openstack_dashboad/test/api_tests/neutron_tests","commit_id":"7a900a646ee4b23dfa95cc4d231eae8779540eb8"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"fca61dd134be3e48c605949ed926a40220392c32","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    The list contains networks owned by the tenant and public networks."},{"line_number":664,"context_line":"    If requested_networks specified, it searches requested_networks only."},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":"    LOG.debug(\"network_list_for_tenant(): tenant_id\u003d%s, params\u003d%s\""},{"line_number":667,"context_line":"              % (tenant_id, params))"},{"line_number":668,"context_line":"    networks \u003d []"},{"line_number":669,"context_line":"    if shared:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_82594791","line":666,"in_reply_to":"dada55a8_5778ce2b","updated":"2016-07-22 20:54:58.000000000","message":"Done","commit_id":"7a900a646ee4b23dfa95cc4d231eae8779540eb8"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"dfc0e9061178fe957a22c8d5319df658073706e3","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    The list contains networks owned by the tenant and public networks."},{"line_number":664,"context_line":"    If requested_networks specified, it searches requested_networks only."},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":"    LOG.debug(\"network_list_for_tenant(): tenant_id\u003d%s, params\u003d%s\""},{"line_number":667,"context_line":"              % (tenant_id, params))"},{"line_number":668,"context_line":"    networks \u003d []"},{"line_number":669,"context_line":"    if shared:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_f9156c9b","line":666,"in_reply_to":"dada55a8_5778ce2b","updated":"2016-07-22 15:15:57.000000000","message":"No sorry, jsut copied the function and modified a little, forgot to change that. Im doing it right now","commit_id":"7a900a646ee4b23dfa95cc4d231eae8779540eb8"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"fca61dd134be3e48c605949ed926a40220392c32","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    The list contains networks owned by the tenant and public networks."},{"line_number":664,"context_line":"    If requested_networks specified, it searches requested_networks only."},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":"    LOG.debug(\"network_list_for_tenant(): tenant_id\u003d%s, params\u003d%s\""},{"line_number":667,"context_line":"              % (tenant_id, params))"},{"line_number":668,"context_line":"    networks \u003d []"},{"line_number":669,"context_line":"    if shared:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_c26cdf38","line":666,"in_reply_to":"dada55a8_6aaf8194","updated":"2016-07-22 20:54:58.000000000","message":"Done","commit_id":"7a900a646ee4b23dfa95cc4d231eae8779540eb8"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"38b38265ccd43d4220e1fbddb02775097990ecea","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    The list contains networks owned by the tenant and public networks."},{"line_number":664,"context_line":"    If requested_networks specified, it searches requested_networks only."},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":"    LOG.debug(\"network_list_for_tenant(): tenant_id\u003d%s, params\u003d%s\""},{"line_number":667,"context_line":"              % (tenant_id, params))"},{"line_number":668,"context_line":"    networks \u003d []"},{"line_number":669,"context_line":"    if shared:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_5778ce2b","line":666,"in_reply_to":"dada55a8_6aaf8194","updated":"2016-07-22 12:02:51.000000000","message":"Here is `network_list_for_tenant()` but function named as ` network_list_filtered_by_shared`. Looks like they should be match?","commit_id":"7a900a646ee4b23dfa95cc4d231eae8779540eb8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"330bbcecbd65ad4dbeab3d30f20bc5348cea8378","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        networks \u003d network_list(request, shared\u003dTrue, **params)"},{"line_number":671,"context_line":"    else:"},{"line_number":672,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id,"},{"line_number":673,"context_line":"                                shared\u003dFalse, **params)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    if include_external:"},{"line_number":676,"context_line":"        fetched_net_ids \u003d [n.id for n in networks]"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_c0819491","line":673,"updated":"2016-07-27 20:22:51.000000000","message":"The logic of this function is very similar to network_list_for_tenant.\nHow about merging these two method?\n\n- shared\u003dNone: the current behavior of network_list_for_tenant\n- shared\u003dTrue : search networks with shared\u003dTrue\n- shared\u003dFalse : search networks with shared\u003dFalse","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"a889fb012e6f46cf2e3d7629072c0ea13126e348","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        networks \u003d network_list(request, shared\u003dTrue, **params)"},{"line_number":671,"context_line":"    else:"},{"line_number":672,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id,"},{"line_number":673,"context_line":"                                shared\u003dFalse, **params)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    if include_external:"},{"line_number":676,"context_line":"        fetched_net_ids \u003d [n.id for n in networks]"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_8ca92793","line":673,"in_reply_to":"bacf61ea_8adca7e5","updated":"2016-07-29 16:31:19.000000000","message":"I resume both functions were one, I just added the filtering stuff there, then @rdopiera suggested to split the functions to avoid a if-elseif-else and have the if filter \u003d\u003d \u0027shared\u0027 in view. You can watch the comments in patch 10. Some of the discussion was in IRC and I dont have the log. Please let me know what do u think.","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"5f4e562c166ff3dcdf00fccde4d64ba24651b9b3","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        networks \u003d network_list(request, shared\u003dTrue, **params)"},{"line_number":671,"context_line":"    else:"},{"line_number":672,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id,"},{"line_number":673,"context_line":"                                shared\u003dFalse, **params)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    if include_external:"},{"line_number":676,"context_line":"        fetched_net_ids \u003d [n.id for n in networks]"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_e9a003a8","line":673,"in_reply_to":"bacf61ea_c0819491","updated":"2016-07-27 20:48:05.000000000","message":"They were merged in previos patches and because the feedback I split them.","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6a77c1b8ca6c36c5a61a472ab6e48fea3448cfd6","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        networks \u003d network_list(request, shared\u003dTrue, **params)"},{"line_number":671,"context_line":"    else:"},{"line_number":672,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id,"},{"line_number":673,"context_line":"                                shared\u003dFalse, **params)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    if include_external:"},{"line_number":676,"context_line":"        fetched_net_ids \u003d [n.id for n in networks]"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_8adca7e5","line":673,"in_reply_to":"bacf61ea_e9a003a8","updated":"2016-07-28 16:02:45.000000000","message":"Although I haven\u0027t followed the full discussion, these two methods are too similar and I think other developers may have similar questions.","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"330bbcecbd65ad4dbeab3d30f20bc5348cea8378","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id,"},{"line_number":673,"context_line":"                                shared\u003dFalse, **params)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    if include_external:"},{"line_number":676,"context_line":"        fetched_net_ids \u003d [n.id for n in networks]"},{"line_number":677,"context_line":"        ext_nets \u003d network_list(request, **{\u0027router:external\u0027: True})"},{"line_number":678,"context_line":"        networks +\u003d [n for n in ext_nets if n.id not in fetched_net_ids]"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    return networks"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_0374569a","line":678,"range":{"start_line":675,"start_character":4,"end_line":678,"end_character":72},"updated":"2016-07-27 20:22:51.000000000","message":"I am not confident what is the expected behavior.\nIn the current logic, if include_external is True, both shared networks and external networks are listed. Is it intended?\nCould you define the expected behavior of the new function?\n\nExternal networks can be marked as shared\u003dTrue too.\nIf both shared and router:external are set to True, what is expected?","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"5f4e562c166ff3dcdf00fccde4d64ba24651b9b3","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id,"},{"line_number":673,"context_line":"                                shared\u003dFalse, **params)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    if include_external:"},{"line_number":676,"context_line":"        fetched_net_ids \u003d [n.id for n in networks]"},{"line_number":677,"context_line":"        ext_nets \u003d network_list(request, **{\u0027router:external\u0027: True})"},{"line_number":678,"context_line":"        networks +\u003d [n for n in ext_nets if n.id not in fetched_net_ids]"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    return networks"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_29ab3b8b","line":678,"range":{"start_line":675,"start_character":4,"end_line":678,"end_character":72},"in_reply_to":"bacf61ea_0374569a","updated":"2016-07-27 20:48:05.000000000","message":"In the method network_list_for_tenant that is the way that it works, if include_external is True, regarding to any filter it adds the router:external networks. For being honest I don\u0027t know which is the exact expected behavior I just used the current one.","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6a77c1b8ca6c36c5a61a472ab6e48fea3448cfd6","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id,"},{"line_number":673,"context_line":"                                shared\u003dFalse, **params)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    if include_external:"},{"line_number":676,"context_line":"        fetched_net_ids \u003d [n.id for n in networks]"},{"line_number":677,"context_line":"        ext_nets \u003d network_list(request, **{\u0027router:external\u0027: True})"},{"line_number":678,"context_line":"        networks +\u003d [n for n in ext_nets if n.id not in fetched_net_ids]"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    return networks"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_45a62011","line":678,"range":{"start_line":675,"start_character":4,"end_line":678,"end_character":72},"in_reply_to":"bacf61ea_29ab3b8b","updated":"2016-07-28 16:02:45.000000000","message":"Yeah, it is a tricky area :-(\n\nIf shared filter is specified and include_external is True, the situation is simple.\n\nA situation in question is a case where \u0027shared\u0027 is specified and include_external is True.\nIMHO, filter parameters like \u0027shared\u0027 have priority.\nIf \u0027shared\u003d\u003dTrue\u0027 is specified, only shared external networks should be listed. If \u0027shared\u003dFalse\u0027 is specified, external networks with shared\u003d\u003dFalse should be specified.\n\nIt is just my opinion, but I think it leads to a consistent behavior and we can merge network_list_for_tenant and this function.\n\nAnyway, more input from other reviewers would be appreciated.","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"3822006720abe1117069320053ff969b1b50df75","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id,"},{"line_number":673,"context_line":"                                shared\u003dFalse, **params)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    if include_external:"},{"line_number":676,"context_line":"        fetched_net_ids \u003d [n.id for n in networks]"},{"line_number":677,"context_line":"        ext_nets \u003d network_list(request, **{\u0027router:external\u0027: True})"},{"line_number":678,"context_line":"        networks +\u003d [n for n in ext_nets if n.id not in fetched_net_ids]"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    return networks"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_fc39a6a4","line":678,"range":{"start_line":675,"start_character":4,"end_line":678,"end_character":72},"in_reply_to":"bacf61ea_2cf0fbfd","updated":"2016-08-03 16:14:44.000000000","message":"Done","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"a889fb012e6f46cf2e3d7629072c0ea13126e348","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        networks \u003d network_list(request, tenant_id\u003dtenant_id,"},{"line_number":673,"context_line":"                                shared\u003dFalse, **params)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    if include_external:"},{"line_number":676,"context_line":"        fetched_net_ids \u003d [n.id for n in networks]"},{"line_number":677,"context_line":"        ext_nets \u003d network_list(request, **{\u0027router:external\u0027: True})"},{"line_number":678,"context_line":"        networks +\u003d [n for n in ext_nets if n.id not in fetched_net_ids]"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    return networks"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_2cf0fbfd","line":678,"range":{"start_line":675,"start_character":4,"end_line":678,"end_character":72},"in_reply_to":"bacf61ea_45a62011","updated":"2016-07-29 16:31:19.000000000","message":"Done, I\u0027m just correcting the unit tests. But yeah you\u0027re right shared parameter should have the priority.","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4f8454374b45fe598b58e65724cf679bd41321d3","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"def network_list_filtered_by_shared(request, tenant_id, include_external\u003dFalse,"},{"line_number":661,"context_line":"                                    shared\u003dNone, **params):"},{"line_number":662,"context_line":"    \"\"\"Return a network list available for the tenant filtered by shared field."},{"line_number":663,"context_line":"    \"\"\""},{"line_number":664,"context_line":"    LOG.debug(\"network_list_filtered_by_shared(): tenant_id\u003d%s, params\u003d%s, \""}],"source_content_type":"text/x-python","patch_set":16,"id":"bacf61ea_339a086f","line":661,"updated":"2016-08-04 18:12:09.000000000","message":"I see the comments in patch set 10 and the previous patch set, but I still feel these two methods are redundant.\n\nTri-state parameter is usual if a method supports filters. We take \u0027shared\u0027 as explicit and this takes tri-state (True/False/None). But the same thing can be said to a parameter specified in \u0027params\u0027 (e.g. router:external). Thus I don\u0027t think tri-state argument is the good reason to have redundant methods.\n\nIn addition, this kind of things should be hidden in the API layer. It should not be done in the presentation layer.\n\nReturning back to the behavior of the method, in my understanding, \u0027tenant_id\u0027 and \u0027include_external\u0027 parameters define a full set of networks, and other parameters (shared and params) specifies the filter. I believe this behavior is natural to users of the filters.\n\nRegardless of values of (tenant_id, include_external), we can apply filters to the full set of networks.\n\nIf we look at the logic of network_list_for_tenant(), we see some meaningless logic depending on what filters are specified of course.\nFor example, shared\u003dTrue or False is specified, one of network_list can be dropped. if-clause of \u0027include_external\u0027 is meaningless when  router:external\u003dFalse is passed.\n\nThought?","commit_id":"1f48b60ec55c6b7a1b80d1d00a6cae2e22454d68"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb013248d0a03c023d03c2afa361893f6d484484","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        del params[\u0027shared\u0027]"},{"line_number":644,"context_line":"    networks \u003d []"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    if not shared:"},{"line_number":647,"context_line":"        # If a user has admin role, network list returned by Neutron API"},{"line_number":648,"context_line":"        # contains networks that do not belong to that tenant."},{"line_number":649,"context_line":"        # So we need to specify tenant_id when calling network_list()."}],"source_content_type":"text/x-python","patch_set":18,"id":"9ad45d7e_befdd1b2","line":646,"range":{"start_line":646,"start_character":7,"end_line":646,"end_character":17},"updated":"2016-08-11 19:05:28.000000000","message":"IMHO it is better not to touch params argument.\nI think the following logic clarifies the logic:\n\n  if \u0027shared\u0027 not in params or not params[\u0027shared\u0027]:\n\nOr:\n\n  if params.get(\u0027shared\u0027) in (None, False):\n\nThis means \u0027shared\u0027 is not specified or shared\u003dFalse.","commit_id":"3577c5bcc61991b2075d86ade2164dec5f8e9824"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"60e8e04ea391005815138246344a3676efaf8ac4","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        del params[\u0027shared\u0027]"},{"line_number":644,"context_line":"    networks \u003d []"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    if not shared:"},{"line_number":647,"context_line":"        # If a user has admin role, network list returned by Neutron API"},{"line_number":648,"context_line":"        # contains networks that do not belong to that tenant."},{"line_number":649,"context_line":"        # So we need to specify tenant_id when calling network_list()."}],"source_content_type":"text/x-python","patch_set":18,"id":"9ad45d7e_1894bae6","line":646,"range":{"start_line":646,"start_character":7,"end_line":646,"end_character":17},"in_reply_to":"9ad45d7e_befdd1b2","updated":"2016-08-12 15:50:18.000000000","message":"Done! Completely agree, is better if we don\u0027t touch the params argument.","commit_id":"3577c5bcc61991b2075d86ade2164dec5f8e9824"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb013248d0a03c023d03c2afa361893f6d484484","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        # So we need to specify tenant_id when calling network_list()."},{"line_number":650,"context_line":"        networks +\u003d network_list(request, tenant_id\u003dtenant_id,"},{"line_number":651,"context_line":"                                 shared\u003dFalse, **params)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    if shared or shared is None:"},{"line_number":654,"context_line":"        # In the current Neutron API, there is no way to retrieve"},{"line_number":655,"context_line":"        # both owner networks and public networks in a single API call."},{"line_number":656,"context_line":"        networks +\u003d network_list(request, shared\u003dTrue, **params)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9ad45d7e_3e28c132","line":653,"range":{"start_line":652,"start_character":0,"end_line":653,"end_character":7},"updated":"2016-08-11 19:05:28.000000000","message":"Similar to L.646. How about\n\n  if \u0027shared\u0027 not in params or params[\u0027shared\u0027]:\n\nThis means \u0027shared\u0027 is not specified or shared\u003dTrue.","commit_id":"3577c5bcc61991b2075d86ade2164dec5f8e9824"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"60e8e04ea391005815138246344a3676efaf8ac4","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        # So we need to specify tenant_id when calling network_list()."},{"line_number":650,"context_line":"        networks +\u003d network_list(request, tenant_id\u003dtenant_id,"},{"line_number":651,"context_line":"                                 shared\u003dFalse, **params)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    if shared or shared is None:"},{"line_number":654,"context_line":"        # In the current Neutron API, there is no way to retrieve"},{"line_number":655,"context_line":"        # both owner networks and public networks in a single API call."},{"line_number":656,"context_line":"        networks +\u003d network_list(request, shared\u003dTrue, **params)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9ad45d7e_589e3208","line":653,"range":{"start_line":652,"start_character":0,"end_line":653,"end_character":7},"in_reply_to":"9ad45d7e_3e28c132","updated":"2016-08-12 15:50:18.000000000","message":"Done","commit_id":"3577c5bcc61991b2075d86ade2164dec5f8e9824"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb013248d0a03c023d03c2afa361893f6d484484","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    if include_external:"},{"line_number":659,"context_line":"        fetched_net_ids \u003d [n.id for n in networks]"},{"line_number":660,"context_line":"        params[\u0027router:external\u0027] \u003d True"},{"line_number":661,"context_line":"        if shared is not None:"},{"line_number":662,"context_line":"            params[\u0027shared\u0027] \u003d shared"},{"line_number":663,"context_line":"        ext_nets \u003d network_list(request, **params)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9ad45d7e_9e7a8dbb","line":660,"range":{"start_line":660,"start_character":7,"end_line":660,"end_character":40},"updated":"2016-08-11 19:05:28.000000000","message":"IMHO, even when include_external\u003dTrue is specified, the filtering should work as usual, i.e., if params[\u0027router:external\u0027]\u003dFalse is specified combined with include_external\u003dTrue, no networks are retrieved.\n\nThought?\n\nIf you agree with this, the logic will be:\n\n  if include_external:\n    # Retrieves external networks when router:external is not specified\n    # in (filtering) params or router:external\u003dTrue filter is specified.\n    # When router:external\u003dFalse is specified there is no need to query\n    # networking API because apparently nothing will match the filter.\n    if params.get(\u0027router:external\u0027, True):\n        ext_nets \u003d network_list(request, **params)\n        networks +\u003d [n for n in ext_nets if n.id not in fetched_net_ids]","commit_id":"3577c5bcc61991b2075d86ade2164dec5f8e9824"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"60e8e04ea391005815138246344a3676efaf8ac4","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    if include_external:"},{"line_number":659,"context_line":"        fetched_net_ids \u003d [n.id for n in networks]"},{"line_number":660,"context_line":"        params[\u0027router:external\u0027] \u003d True"},{"line_number":661,"context_line":"        if shared is not None:"},{"line_number":662,"context_line":"            params[\u0027shared\u0027] \u003d shared"},{"line_number":663,"context_line":"        ext_nets \u003d network_list(request, **params)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9ad45d7e_fb2f203c","line":660,"range":{"start_line":660,"start_character":7,"end_line":660,"end_character":40},"in_reply_to":"9ad45d7e_9e7a8dbb","updated":"2016-08-12 15:50:18.000000000","message":"I used the code that you gave me,  just have one question. If the **params \u003d None, it used to provide the router_external \u003d True, now it will bring all the networks, isn\u0027t it? Shouldn\u0027t we add something like:\next_nets \u003d []\nif not params:\n   ext_nets \u003d network_list(request, **{\u0027router:external\u0027: True})\nelse:\n   ext_nets \u003d network_list(request, **params)\nnetworks +\u003d [n for n in ext_nets if n.id not in fetched_net_ids]","commit_id":"3577c5bcc61991b2075d86ade2164dec5f8e9824"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e7bf848e1c98b813f4e809f53a528246f5308798","unresolved":false,"context_lines":[{"line_number":639,"context_line":"              % (tenant_id, params))"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"    networks \u003d []"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    if params.get(\u0027shared\u0027) in (None, False):"},{"line_number":644,"context_line":"        # If a user has admin role, network list returned by Neutron API"},{"line_number":645,"context_line":"        # contains networks that do not belong to that tenant."}],"source_content_type":"text/x-python","patch_set":20,"id":"7ac969e8_6655631c","line":642,"updated":"2016-08-13 04:14:54.000000000","message":"My previous suggestion was not correct.\n\nThis raises an error when params contains \u0027shared\u0027, so we need to manipulate params dict as you originally did.\n\n  shared_specified \u003d params.get(\u0027shared\u0027)\n\n  if shared_specified in (None, False):\n      params[\u0027shared\u0027] \u003d False\n      networks +\u003d network_list(...)\n  if shared_specified in (None, True):\n      params[\u0027shared\u0027] \u003d True\n      networks +\u003d network_list(...)\n\n  if shared_specifed is None:\n      del params[\u0027shared\u0027]","commit_id":"55af6899573c8f1a1032f0187dd83c348cbefd6e"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"c3550f6dbff3425f40cc971e603fa65e20374ccc","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        # in (filtering) params or router:external\u003dTrue filter is specified."},{"line_number":659,"context_line":"        # When router:external\u003dFalse is specified there is no need to query"},{"line_number":660,"context_line":"        # networking API because apparently nothing will match the filter."},{"line_number":661,"context_line":"        if params.get(\u0027router:external\u0027, True):"},{"line_number":662,"context_line":"            ext_nets \u003d network_list(request, **params)"},{"line_number":663,"context_line":"            networks +\u003d [n for n in ext_nets if"},{"line_number":664,"context_line":"                         n.id not in fetched_net_ids]"}],"source_content_type":"text/x-python","patch_set":20,"id":"9ad45d7e_7178712c","line":661,"updated":"2016-08-12 16:23:10.000000000","message":"I think this should be:\n    \n    params[\u0027router:external\u0027] \u003d params.get(\u0027router:external\u0027, True)\n    if params[\u0027router:external\u0027] AND include_external:\n        fetched_net_ids \u003d [n.id for n in networks]\n        ...\n\nbecause otherwise params[\u0027router:external\u0027] \u003d True is only passed if its included in the params originally.","commit_id":"55af6899573c8f1a1032f0187dd83c348cbefd6e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e7bf848e1c98b813f4e809f53a528246f5308798","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        # in (filtering) params or router:external\u003dTrue filter is specified."},{"line_number":659,"context_line":"        # When router:external\u003dFalse is specified there is no need to query"},{"line_number":660,"context_line":"        # networking API because apparently nothing will match the filter."},{"line_number":661,"context_line":"        if params.get(\u0027router:external\u0027, True):"},{"line_number":662,"context_line":"            ext_nets \u003d network_list(request, **params)"},{"line_number":663,"context_line":"            networks +\u003d [n for n in ext_nets if"},{"line_number":664,"context_line":"                         n.id not in fetched_net_ids]"}],"source_content_type":"text/x-python","patch_set":20,"id":"7ac969e8_662c43ac","line":661,"in_reply_to":"9ad45d7e_7178712c","updated":"2016-08-13 04:14:54.000000000","message":"Yes. we need to specify \u0027router:external\u003dTrue\u0027 when it is not specified.","commit_id":"55af6899573c8f1a1032f0187dd83c348cbefd6e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"168976be2d7b81a12ee2d8921d5024ed59db1241","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    if shared in (None, True):"},{"line_number":654,"context_line":"        # In the current Neutron API, there is no way to retrieve"},{"line_number":655,"context_line":"        # both owner networks and public networks in a single API call."},{"line_number":656,"context_line":"        networks +\u003d network_list(request, shared\u003dTrue, **params)"},{"line_number":657,"context_line":"    params[\u0027router:external\u0027] \u003d params.get(\u0027router:external\u0027, True)"},{"line_number":658,"context_line":"    if params[\u0027router:external\u0027] and include_external:"},{"line_number":659,"context_line":"        if shared is not None:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1ac06dbe_a69ac8c3","line":656,"updated":"2016-08-19 10:30:25.000000000","message":"nit: it is better to keep a blank line here.","commit_id":"16a876d77bfbddac64cc04369de457b3eed2f3df"}],"openstack_dashboard/dashboards/admin/networks/tables.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"9e7115c0f930f92183a71a69abff96a93eb07c22","unresolved":false,"context_lines":[{"line_number":92,"context_line":"class AdminNetworksFilterAction(tables.FilterAction):"},{"line_number":93,"context_line":"    name \u003d \"filter_admin_networks\""},{"line_number":94,"context_line":"    filter_type \u003d \"server\""},{"line_number":95,"context_line":"    filter_choices \u003d ((\u0027tenant_id\u0027, _(\"Tenant Id\u003d\"), True),"},{"line_number":96,"context_line":"                      (\u0027name\u0027, _(\"Name \u003d\"), True),"},{"line_number":97,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":98,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9a276011","line":95,"updated":"2016-06-14 03:10:04.000000000","message":"It prefers \u0027project\u0027 to \u0027tenant\u0027 when displaying the page.","commit_id":"a03ebe12dd2c916b3771e18f491030e743bf8bd6"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"5fb76249d17dc145d5c7d815b70e4dceaf53bac6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"class AdminNetworksFilterAction(tables.FilterAction):"},{"line_number":93,"context_line":"    name \u003d \"filter_admin_networks\""},{"line_number":94,"context_line":"    filter_type \u003d \"server\""},{"line_number":95,"context_line":"    filter_choices \u003d ((\u0027tenant_id\u0027, _(\"Tenant Id\u003d\"), True),"},{"line_number":96,"context_line":"                      (\u0027name\u0027, _(\"Name \u003d\"), True),"},{"line_number":97,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":98,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_f2b73938","line":95,"in_reply_to":"7aa08908_9a276011","updated":"2016-06-15 20:42:13.000000000","message":"Done","commit_id":"a03ebe12dd2c916b3771e18f491030e743bf8bd6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"9e7115c0f930f92183a71a69abff96a93eb07c22","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    name \u003d \"filter_admin_networks\""},{"line_number":94,"context_line":"    filter_type \u003d \"server\""},{"line_number":95,"context_line":"    filter_choices \u003d ((\u0027tenant_id\u0027, _(\"Tenant Id\u003d\"), True),"},{"line_number":96,"context_line":"                      (\u0027name\u0027, _(\"Name \u003d\"), True),"},{"line_number":97,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":98,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":99,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_daf9e84f","line":96,"updated":"2016-06-14 03:10:04.000000000","message":"I think it might be better to use \"Network Name\" because table column name is so.","commit_id":"a03ebe12dd2c916b3771e18f491030e743bf8bd6"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"5fb76249d17dc145d5c7d815b70e4dceaf53bac6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    name \u003d \"filter_admin_networks\""},{"line_number":94,"context_line":"    filter_type \u003d \"server\""},{"line_number":95,"context_line":"    filter_choices \u003d ((\u0027tenant_id\u0027, _(\"Tenant Id\u003d\"), True),"},{"line_number":96,"context_line":"                      (\u0027name\u0027, _(\"Name \u003d\"), True),"},{"line_number":97,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":98,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":99,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_d2b4bd36","line":96,"in_reply_to":"7aa08908_daf9e84f","updated":"2016-06-15 20:42:13.000000000","message":"Done","commit_id":"a03ebe12dd2c916b3771e18f491030e743bf8bd6"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"16c2d2f0012353e07c5116da671c80e42a8368b9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    filter_choices \u003d ((\u0027project\u0027, _(\"Project \u003d\"), True),"},{"line_number":91,"context_line":"                      (\u0027name\u0027, _(\"Network Name \u003d\"), True),"},{"line_number":92,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":93,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":94,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"},{"line_number":95,"context_line":"                      (\u0027admin_state_up\u0027, _(\"Admin State \u003d\"), True))"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_bada9115","line":93,"updated":"2016-06-16 10:06:35.000000000","message":"This class is very similar to ProjectNetworksFilterAction. What do you think about reducing of code duplication here? Maybe we can inherit from project\u0027s filter?","commit_id":"464fe53f5eea33e744639e5c294cc4a7505cd89d"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"555b39fd55ca17913bf4b577593a0a758395d426","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    filter_choices \u003d ((\u0027project\u0027, _(\"Project \u003d\"), True),"},{"line_number":91,"context_line":"                      (\u0027name\u0027, _(\"Network Name \u003d\"), True),"},{"line_number":92,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":93,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":94,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"},{"line_number":95,"context_line":"                      (\u0027admin_state_up\u0027, _(\"Admin State \u003d\"), True))"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_f4d089f9","line":93,"in_reply_to":"7aa08908_bada9115","updated":"2016-06-16 20:57:42.000000000","message":"Done","commit_id":"464fe53f5eea33e744639e5c294cc4a7505cd89d"}],"openstack_dashboard/dashboards/admin/networks/views.py":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"16c2d2f0012353e07c5116da671c80e42a8368b9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return networks"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def get_filters(self):"},{"line_number":108,"context_line":"        filters \u003d {}"},{"line_number":109,"context_line":"        filter_field \u003d self.table.get_filter_field()"},{"line_number":110,"context_line":"        filter_action \u003d self.table._meta._filter_action"},{"line_number":111,"context_line":"        if filter_action.is_api_filter(filter_field):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_1a37654e","line":108,"updated":"2016-06-16 10:06:35.000000000","message":"This code fully duplicates the same method from https://review.openstack.org/#/c/329184/5/openstack_dashboard/dashboards/project/networks/views.py.","commit_id":"464fe53f5eea33e744639e5c294cc4a7505cd89d"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"555b39fd55ca17913bf4b577593a0a758395d426","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return networks"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def get_filters(self):"},{"line_number":108,"context_line":"        filters \u003d {}"},{"line_number":109,"context_line":"        filter_field \u003d self.table.get_filter_field()"},{"line_number":110,"context_line":"        filter_action \u003d self.table._meta._filter_action"},{"line_number":111,"context_line":"        if filter_action.is_api_filter(filter_field):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_943dc5df","line":108,"in_reply_to":"7aa08908_1a37654e","updated":"2016-06-16 20:57:42.000000000","message":"Done","commit_id":"464fe53f5eea33e744639e5c294cc4a7505cd89d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"330bbcecbd65ad4dbeab3d30f20bc5348cea8378","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            networks \u003d []"},{"line_number":86,"context_line":"            if \u0027project\u0027 in search_opts:"},{"line_number":87,"context_line":"                tenants \u003d api.keystone.tenant_list(self.request)[0]"},{"line_number":88,"context_line":"                ten_filter_ids \u003d [t.id for t in tenants"},{"line_number":89,"context_line":"                                  if t.name \u003d\u003d search_opts[\u0027project\u0027]]"},{"line_number":90,"context_line":"                if not ten_filter_ids:"},{"line_number":91,"context_line":"                    return []"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_6e96d995","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":30},"updated":"2016-07-27 20:22:51.000000000","message":"\u0027ten\u0027 is not easy to understand. I prefer \u0027tenant_filter_ids\u0027.","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"3822006720abe1117069320053ff969b1b50df75","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            networks \u003d []"},{"line_number":86,"context_line":"            if \u0027project\u0027 in search_opts:"},{"line_number":87,"context_line":"                tenants \u003d api.keystone.tenant_list(self.request)[0]"},{"line_number":88,"context_line":"                ten_filter_ids \u003d [t.id for t in tenants"},{"line_number":89,"context_line":"                                  if t.name \u003d\u003d search_opts[\u0027project\u0027]]"},{"line_number":90,"context_line":"                if not ten_filter_ids:"},{"line_number":91,"context_line":"                    return []"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_3c121e0a","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":30},"in_reply_to":"bacf61ea_09875710","updated":"2016-08-03 16:14:44.000000000","message":"Done","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"5f4e562c166ff3dcdf00fccde4d64ba24651b9b3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            networks \u003d []"},{"line_number":86,"context_line":"            if \u0027project\u0027 in search_opts:"},{"line_number":87,"context_line":"                tenants \u003d api.keystone.tenant_list(self.request)[0]"},{"line_number":88,"context_line":"                ten_filter_ids \u003d [t.id for t in tenants"},{"line_number":89,"context_line":"                                  if t.name \u003d\u003d search_opts[\u0027project\u0027]]"},{"line_number":90,"context_line":"                if not ten_filter_ids:"},{"line_number":91,"context_line":"                    return []"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_09875710","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":30},"in_reply_to":"bacf61ea_6e96d995","updated":"2016-07-27 20:48:05.000000000","message":"ok, in progress","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"330bbcecbd65ad4dbeab3d30f20bc5348cea8378","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                if not ten_filter_ids:"},{"line_number":91,"context_line":"                    return []"},{"line_number":92,"context_line":"                del search_opts[\u0027project\u0027]"},{"line_number":93,"context_line":"                for tenant_id in ten_filter_ids:"},{"line_number":94,"context_line":"                    search_opts[\u0027tenant_id\u0027] \u003d tenant_id"},{"line_number":95,"context_line":"                    networks +\u003d api.neutron.network_list("},{"line_number":96,"context_line":"                        self.request, **search_opts)"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                networks \u003d api.neutron.network_list("},{"line_number":99,"context_line":"                    self.request, **search_opts)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_aef1f1cf","line":96,"range":{"start_line":93,"start_character":16,"end_line":96,"end_character":52},"updated":"2016-07-27 20:22:51.000000000","message":"There is no need to use a loop for tenant_id.\nNeutron API supports filtering with multiple values.\n\nIn the level of the neutronclient python binding,\n\n  nc \u003d client.Client(....)\n  nc.list_networks(tenant_id\u003d[\u0027tenant-A\u0027, \u0027tenant-B\u0027])\n\nwill returns networks of both tenant-A and tenant-B.\n\nIn this case, you can do:\n\n  search_opts[\u0027tenant_id\u0027] \u003d tenant_filter_ids\n  api.neutron.netwwork_list(self.request, **search_opts)","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6a77c1b8ca6c36c5a61a472ab6e48fea3448cfd6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                if not ten_filter_ids:"},{"line_number":91,"context_line":"                    return []"},{"line_number":92,"context_line":"                del search_opts[\u0027project\u0027]"},{"line_number":93,"context_line":"                for tenant_id in ten_filter_ids:"},{"line_number":94,"context_line":"                    search_opts[\u0027tenant_id\u0027] \u003d tenant_id"},{"line_number":95,"context_line":"                    networks +\u003d api.neutron.network_list("},{"line_number":96,"context_line":"                        self.request, **search_opts)"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                networks \u003d api.neutron.network_list("},{"line_number":99,"context_line":"                    self.request, **search_opts)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_c5bfb0f9","line":96,"range":{"start_line":93,"start_character":16,"end_line":96,"end_character":52},"in_reply_to":"bacf61ea_69f8937d","updated":"2016-07-28 16:02:45.000000000","message":"I am originally a networking guy. This kind of suggestion is my job :)","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"5f4e562c166ff3dcdf00fccde4d64ba24651b9b3","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                if not ten_filter_ids:"},{"line_number":91,"context_line":"                    return []"},{"line_number":92,"context_line":"                del search_opts[\u0027project\u0027]"},{"line_number":93,"context_line":"                for tenant_id in ten_filter_ids:"},{"line_number":94,"context_line":"                    search_opts[\u0027tenant_id\u0027] \u003d tenant_id"},{"line_number":95,"context_line":"                    networks +\u003d api.neutron.network_list("},{"line_number":96,"context_line":"                        self.request, **search_opts)"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                networks \u003d api.neutron.network_list("},{"line_number":99,"context_line":"                    self.request, **search_opts)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_69f8937d","line":96,"range":{"start_line":93,"start_character":16,"end_line":96,"end_character":52},"in_reply_to":"bacf61ea_aef1f1cf","updated":"2016-07-27 20:48:05.000000000","message":"Thanks I had no idea, I\u0027ll modify it.","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"3822006720abe1117069320053ff969b1b50df75","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                if not ten_filter_ids:"},{"line_number":91,"context_line":"                    return []"},{"line_number":92,"context_line":"                del search_opts[\u0027project\u0027]"},{"line_number":93,"context_line":"                for tenant_id in ten_filter_ids:"},{"line_number":94,"context_line":"                    search_opts[\u0027tenant_id\u0027] \u003d tenant_id"},{"line_number":95,"context_line":"                    networks +\u003d api.neutron.network_list("},{"line_number":96,"context_line":"                        self.request, **search_opts)"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                networks \u003d api.neutron.network_list("},{"line_number":99,"context_line":"                    self.request, **search_opts)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_1c059ac1","line":96,"range":{"start_line":93,"start_character":16,"end_line":96,"end_character":52},"in_reply_to":"bacf61ea_c5bfb0f9","updated":"2016-08-03 16:14:44.000000000","message":"Done","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"330bbcecbd65ad4dbeab3d30f20bc5348cea8378","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                    networks +\u003d api.neutron.network_list("},{"line_number":96,"context_line":"                        self.request, **search_opts)"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                networks \u003d api.neutron.network_list("},{"line_number":99,"context_line":"                    self.request, **search_opts)"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            networks \u003d []"},{"line_number":102,"context_line":"            msg \u003d _(\u0027Network list can not be retrieved.\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_8e9ced6a","line":99,"range":{"start_line":98,"start_character":16,"end_line":99,"end_character":48},"updated":"2016-07-27 20:22:51.000000000","message":"If you follow my comment on L.96, this can be merged into L.96.","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"3822006720abe1117069320053ff969b1b50df75","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                    networks +\u003d api.neutron.network_list("},{"line_number":96,"context_line":"                        self.request, **search_opts)"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                networks \u003d api.neutron.network_list("},{"line_number":99,"context_line":"                    self.request, **search_opts)"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            networks \u003d []"},{"line_number":102,"context_line":"            msg \u003d _(\u0027Network list can not be retrieved.\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_5c0f12e1","line":99,"range":{"start_line":98,"start_character":16,"end_line":99,"end_character":48},"in_reply_to":"bacf61ea_29fe9b6b","updated":"2016-08-03 16:14:44.000000000","message":"Done","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"5f4e562c166ff3dcdf00fccde4d64ba24651b9b3","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                    networks +\u003d api.neutron.network_list("},{"line_number":96,"context_line":"                        self.request, **search_opts)"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                networks \u003d api.neutron.network_list("},{"line_number":99,"context_line":"                    self.request, **search_opts)"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            networks \u003d []"},{"line_number":102,"context_line":"            msg \u003d _(\u0027Network list can not be retrieved.\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_29fe9b6b","line":99,"range":{"start_line":98,"start_character":16,"end_line":99,"end_character":48},"in_reply_to":"bacf61ea_8e9ced6a","updated":"2016-07-27 20:48:05.000000000","message":"Agree, working on it.","commit_id":"16eb230db7d4a14063dafee2742405688d27b9f3"},{"author":{"_account_id":22587,"name":"xujun","email":"xu.jun@99cloud.net","username":"majik"},"change_message_id":"ad8d9a6dcc734590820a736757a604a7148f8d71","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return data"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def get_data(self):"},{"line_number":83,"context_line":"        try:"},{"line_number":84,"context_line":"            search_opts \u003d self.get_filters(filters_map\u003dself.FILTERS_MAPPING)"},{"line_number":85,"context_line":"            networks \u003d []"},{"line_number":86,"context_line":"            if \u0027project\u0027 in search_opts:"},{"line_number":87,"context_line":"                tenants \u003d api.keystone.tenant_list(self.request)[0]"},{"line_number":88,"context_line":"                tenant_filter_ids \u003d [t.id for t in tenants"},{"line_number":89,"context_line":"                                     if t.name \u003d\u003d search_opts[\u0027project\u0027]]"},{"line_number":90,"context_line":"                if not tenant_filter_ids:"},{"line_number":91,"context_line":"                    return []"},{"line_number":92,"context_line":"                del search_opts[\u0027project\u0027]"},{"line_number":93,"context_line":"                search_opts[\u0027tenant_id\u0027] \u003d tenant_filter_ids"},{"line_number":94,"context_line":"            networks \u003d api.neutron.network_list(self.request, **search_opts)"},{"line_number":95,"context_line":"        except Exception:"},{"line_number":96,"context_line":"            networks \u003d []"},{"line_number":97,"context_line":"            msg \u003d _(\u0027Network list can not be retrieved.\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3ac371cc_2e6508e1","line":94,"range":{"start_line":83,"start_character":8,"end_line":94,"end_character":76},"updated":"2016-08-14 13:14:59.000000000","message":"This \u0027try\u0027 should contain less","commit_id":"55af6899573c8f1a1032f0187dd83c348cbefd6e"}],"openstack_dashboard/dashboards/project/networks/tables.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2b0ee91d787898cbf5c7eef021d6dd82363002bc","unresolved":false,"context_lines":[{"line_number":161,"context_line":"class ProjectNetworksFilterAction(tables.FilterAction):"},{"line_number":162,"context_line":"    name \u003d \"filter_project_networks\""},{"line_number":163,"context_line":"    filter_type \u003d \"server\""},{"line_number":164,"context_line":"    filter_choices \u003d ((\u0027name\u0027, _(\"Name \u003d\"), True),"},{"line_number":165,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":166,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":167,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_676fbefc","line":164,"updated":"2016-06-17 03:56:45.000000000","message":"It seems not to be addressed here. \u0027Network Name \u0027 is right ?","commit_id":"33493724d794eecf8d0c94e3acaca7afc00055c1"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"a45c2bd7013077f9065e6c4e34bcef7f0e89cdb3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"class ProjectNetworksFilterAction(tables.FilterAction):"},{"line_number":162,"context_line":"    name \u003d \"filter_project_networks\""},{"line_number":163,"context_line":"    filter_type \u003d \"server\""},{"line_number":164,"context_line":"    filter_choices \u003d ((\u0027name\u0027, _(\"Name \u003d\"), True),"},{"line_number":165,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":166,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":167,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_0121664d","line":164,"in_reply_to":"7aa08908_1b29d99b","updated":"2016-06-17 16:08:07.000000000","message":"Done","commit_id":"33493724d794eecf8d0c94e3acaca7afc00055c1"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"b57831d37d9aea13ed1419a0e568fad3a9f6824d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"class ProjectNetworksFilterAction(tables.FilterAction):"},{"line_number":162,"context_line":"    name \u003d \"filter_project_networks\""},{"line_number":163,"context_line":"    filter_type \u003d \"server\""},{"line_number":164,"context_line":"    filter_choices \u003d ((\u0027name\u0027, _(\"Name \u003d\"), True),"},{"line_number":165,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":166,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":167,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_1b29d99b","line":164,"in_reply_to":"7aa08908_676fbefc","updated":"2016-06-17 15:45:08.000000000","message":"In project-\u003e Network -\u003e Networks the name of the column is Name, should I add the filter Network Name instead?","commit_id":"33493724d794eecf8d0c94e3acaca7afc00055c1"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"b475ae92a2ce18783e75b287f41e7a1d5d5b354b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"class ProjectNetworksFilterAction(tables.FilterAction):"},{"line_number":162,"context_line":"    name \u003d \"filter_project_networks\""},{"line_number":163,"context_line":"    filter_type \u003d \"server\""},{"line_number":164,"context_line":"    filter_choices \u003d ((\u0027name\u0027, _(\"Network Name \u003d\"), True),"},{"line_number":165,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":166,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":167,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a9d85d2_19d765c0","line":164,"updated":"2016-06-21 10:19:49.000000000","message":"Not sure if it\u0027s a related change but anyway, it\u0027s ok for me.","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"1ac0c6ce79620c2a851e4219ada63a213a5fa965","unresolved":false,"context_lines":[{"line_number":161,"context_line":"class ProjectNetworksFilterAction(tables.FilterAction):"},{"line_number":162,"context_line":"    name \u003d \"filter_project_networks\""},{"line_number":163,"context_line":"    filter_type \u003d \"server\""},{"line_number":164,"context_line":"    filter_choices \u003d ((\u0027name\u0027, _(\"Network Name \u003d\"), True),"},{"line_number":165,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":166,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":167,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_2eb1ee47","line":164,"in_reply_to":"3aaa91ec_23b90a16","updated":"2016-06-29 19:50:48.000000000","message":"Oh, just use Name I think. Its really minor, so it doesnt matter much, but I\u0027d personally just be consistent with using Name for the current item.","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"dda7b31348971adea8483f750a647260b3d997f9","unresolved":false,"context_lines":[{"line_number":161,"context_line":"class ProjectNetworksFilterAction(tables.FilterAction):"},{"line_number":162,"context_line":"    name \u003d \"filter_project_networks\""},{"line_number":163,"context_line":"    filter_type \u003d \"server\""},{"line_number":164,"context_line":"    filter_choices \u003d ((\u0027name\u0027, _(\"Network Name \u003d\"), True),"},{"line_number":165,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":166,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":167,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_2f1d3373","line":164,"in_reply_to":"3aaa91ec_2eb1ee47","updated":"2016-06-30 18:47:18.000000000","message":"Done","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"e9cb0ba8a61b257946f54bdb936c3b5e47b23caa","unresolved":false,"context_lines":[{"line_number":161,"context_line":"class ProjectNetworksFilterAction(tables.FilterAction):"},{"line_number":162,"context_line":"    name \u003d \"filter_project_networks\""},{"line_number":163,"context_line":"    filter_type \u003d \"server\""},{"line_number":164,"context_line":"    filter_choices \u003d ((\u0027name\u0027, _(\"Network Name \u003d\"), True),"},{"line_number":165,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":166,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":167,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_23b90a16","line":164,"in_reply_to":"3aaa91ec_627af089","updated":"2016-06-29 18:36:13.000000000","message":"This change was because the AdminNetworkFilterAction uses almost the same code as in here, the way to reduce this was inheriting from this FilterAction but the name would be the same. In this table is named \u0027Name\u0027 and in the other one \u0027Network Name\u0027 so modifying this would change both names that make reference to Networks, the other approach would be just implement its own filter options to each one. What do you think Rob?","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"b676623a967ce7d6a6f32f40304eb2037384c19c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"class ProjectNetworksFilterAction(tables.FilterAction):"},{"line_number":162,"context_line":"    name \u003d \"filter_project_networks\""},{"line_number":163,"context_line":"    filter_type \u003d \"server\""},{"line_number":164,"context_line":"    filter_choices \u003d ((\u0027name\u0027, _(\"Network Name \u003d\"), True),"},{"line_number":165,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":166,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":167,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_627af089","line":164,"in_reply_to":"3aaa91ec_d64cd178","updated":"2016-06-29 17:27:55.000000000","message":"Random change. Lets just stick with Name for the current resource.","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"dd378f76cb0ef3203a0da11205de2a5a99062f85","unresolved":false,"context_lines":[{"line_number":161,"context_line":"class ProjectNetworksFilterAction(tables.FilterAction):"},{"line_number":162,"context_line":"    name \u003d \"filter_project_networks\""},{"line_number":163,"context_line":"    filter_type \u003d \"server\""},{"line_number":164,"context_line":"    filter_choices \u003d ((\u0027name\u0027, _(\"Network Name \u003d\"), True),"},{"line_number":165,"context_line":"                      (\u0027shared\u0027, _(\"Shared \u003d\"), True),"},{"line_number":166,"context_line":"                      (\u0027router:external\u0027, _(\"External \u003d\"), True),"},{"line_number":167,"context_line":"                      (\u0027status\u0027, _(\"Status \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_d64cd178","line":164,"in_reply_to":"5a9d85d2_19d765c0","updated":"2016-06-21 18:36:32.000000000","message":"The one who asked this change is Kenji Ishii, if it\u0027s fine by all we can leave it as that or change it back.","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"}],"openstack_dashboard/dashboards/project/networks/views.py":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"16c2d2f0012353e07c5116da671c80e42a8368b9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                    self.request, tenant_id, **search_opts)"},{"line_number":54,"context_line":"            else:"},{"line_number":55,"context_line":"                networks \u003d api.neutron.network_list_for_tenant("},{"line_number":56,"context_line":"                 self.request, tenant_id, include_external\u003dTrue, **search_opts)"},{"line_number":57,"context_line":"        except Exception:"},{"line_number":58,"context_line":"            networks \u003d []"},{"line_number":59,"context_line":"            msg \u003d _(\u0027Network list can not be retrieved.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_5ad56db5","line":56,"updated":"2016-06-16 10:06:35.000000000","message":"This line causes pep8 error: \"./openstack_dashboard/dashboards/project/networks/views.py:56:18: E121 continuation line under-indented for hanging indent\"","commit_id":"464fe53f5eea33e744639e5c294cc4a7505cd89d"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"555b39fd55ca17913bf4b577593a0a758395d426","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                    self.request, tenant_id, **search_opts)"},{"line_number":54,"context_line":"            else:"},{"line_number":55,"context_line":"                networks \u003d api.neutron.network_list_for_tenant("},{"line_number":56,"context_line":"                 self.request, tenant_id, include_external\u003dTrue, **search_opts)"},{"line_number":57,"context_line":"        except Exception:"},{"line_number":58,"context_line":"            networks \u003d []"},{"line_number":59,"context_line":"            msg \u003d _(\u0027Network list can not be retrieved.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_342fb1a2","line":56,"in_reply_to":"7aa08908_5ad56db5","updated":"2016-06-16 20:57:42.000000000","message":"Done","commit_id":"464fe53f5eea33e744639e5c294cc4a7505cd89d"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"b676623a967ce7d6a6f32f40304eb2037384c19c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            filter_string \u003d self.table.get_filter_string().strip()"},{"line_number":70,"context_line":"            if filter_field and filter_string:"},{"line_number":71,"context_line":"                if filter_field \u003d\u003d \u0027shared\u0027:"},{"line_number":72,"context_line":"                    if _(\"yes\") \u003d\u003d filter_string.lower():"},{"line_number":73,"context_line":"                        filters[\u0027shared\u0027] \u003d True"},{"line_number":74,"context_line":"                    elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":75,"context_line":"                        filters[\u0027shared\u0027] \u003d False"},{"line_number":76,"context_line":"                elif filter_field \u003d\u003d \u0027router:external\u0027:"},{"line_number":77,"context_line":"                    if _(\"yes\") \u003d\u003d filter_string.lower():"},{"line_number":78,"context_line":"                        filters[\u0027router:external\u0027] \u003d True"},{"line_number":79,"context_line":"                    elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":80,"context_line":"                        filters[\u0027router:external\u0027] \u003d False"},{"line_number":81,"context_line":"                elif filter_field \u003d\u003d \u0027admin_state_up\u0027:"},{"line_number":82,"context_line":"                    if _(\"up\") \u003d\u003d filter_string.lower():"},{"line_number":83,"context_line":"                        filters[\u0027admin_state_up\u0027] \u003d True"},{"line_number":84,"context_line":"                    elif _(\"down\") \u003d\u003d filter_string.lower():"},{"line_number":85,"context_line":"                        filters[\u0027admin_state_up\u0027] \u003d False"},{"line_number":86,"context_line":"                if filter_field not in filters:"},{"line_number":87,"context_line":"                    filters[filter_field] \u003d filter_string"},{"line_number":88,"context_line":"        return filters"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_e23d402c","line":85,"range":{"start_line":72,"start_character":0,"end_line":85,"end_character":57},"updated":"2016-06-29 17:27:55.000000000","message":"This could potentially be very unreliable, as it will depend on an exact translation being correct. For example, \"UP\" when referring to an admin state may be a different word than \"up\" when referring to a direction, and with the current translation infrastructure I don\u0027t think we can guarantee they will be the same (not sure how capitalisation factors in).\nThis means that the strings may not match, and so the filter will not work. On top of that, it means every filter will have a long list of if else if etc.\n\n\nIdeally for those choices where there is a fixed option (Yes/No, True/False, Up/Down) we need a dropdown to show this. That way we can restrict the choices, and have their values (which are hidden to the user anyway) as True/False, and avoid all the messy data conversions.","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"1ac0c6ce79620c2a851e4219ada63a213a5fa965","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            filter_string \u003d self.table.get_filter_string().strip()"},{"line_number":70,"context_line":"            if filter_field and filter_string:"},{"line_number":71,"context_line":"                if filter_field \u003d\u003d \u0027shared\u0027:"},{"line_number":72,"context_line":"                    if _(\"yes\") \u003d\u003d filter_string.lower():"},{"line_number":73,"context_line":"                        filters[\u0027shared\u0027] \u003d True"},{"line_number":74,"context_line":"                    elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":75,"context_line":"                        filters[\u0027shared\u0027] \u003d False"},{"line_number":76,"context_line":"                elif filter_field \u003d\u003d \u0027router:external\u0027:"},{"line_number":77,"context_line":"                    if _(\"yes\") \u003d\u003d filter_string.lower():"},{"line_number":78,"context_line":"                        filters[\u0027router:external\u0027] \u003d True"},{"line_number":79,"context_line":"                    elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":80,"context_line":"                        filters[\u0027router:external\u0027] \u003d False"},{"line_number":81,"context_line":"                elif filter_field \u003d\u003d \u0027admin_state_up\u0027:"},{"line_number":82,"context_line":"                    if _(\"up\") \u003d\u003d filter_string.lower():"},{"line_number":83,"context_line":"                        filters[\u0027admin_state_up\u0027] \u003d True"},{"line_number":84,"context_line":"                    elif _(\"down\") \u003d\u003d filter_string.lower():"},{"line_number":85,"context_line":"                        filters[\u0027admin_state_up\u0027] \u003d False"},{"line_number":86,"context_line":"                if filter_field not in filters:"},{"line_number":87,"context_line":"                    filters[filter_field] \u003d filter_string"},{"line_number":88,"context_line":"        return filters"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_ce594a37","line":85,"range":{"start_line":72,"start_character":0,"end_line":85,"end_character":57},"in_reply_to":"3aaa91ec_03d32e05","updated":"2016-06-29 19:50:48.000000000","message":"I think in the case that a filter option has a very strict list of items, it should just show a dropdown with the possible values.","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"dda7b31348971adea8483f750a647260b3d997f9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            filter_string \u003d self.table.get_filter_string().strip()"},{"line_number":70,"context_line":"            if filter_field and filter_string:"},{"line_number":71,"context_line":"                if filter_field \u003d\u003d \u0027shared\u0027:"},{"line_number":72,"context_line":"                    if _(\"yes\") \u003d\u003d filter_string.lower():"},{"line_number":73,"context_line":"                        filters[\u0027shared\u0027] \u003d True"},{"line_number":74,"context_line":"                    elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":75,"context_line":"                        filters[\u0027shared\u0027] \u003d False"},{"line_number":76,"context_line":"                elif filter_field \u003d\u003d \u0027router:external\u0027:"},{"line_number":77,"context_line":"                    if _(\"yes\") \u003d\u003d filter_string.lower():"},{"line_number":78,"context_line":"                        filters[\u0027router:external\u0027] \u003d True"},{"line_number":79,"context_line":"                    elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":80,"context_line":"                        filters[\u0027router:external\u0027] \u003d False"},{"line_number":81,"context_line":"                elif filter_field \u003d\u003d \u0027admin_state_up\u0027:"},{"line_number":82,"context_line":"                    if _(\"up\") \u003d\u003d filter_string.lower():"},{"line_number":83,"context_line":"                        filters[\u0027admin_state_up\u0027] \u003d True"},{"line_number":84,"context_line":"                    elif _(\"down\") \u003d\u003d filter_string.lower():"},{"line_number":85,"context_line":"                        filters[\u0027admin_state_up\u0027] \u003d False"},{"line_number":86,"context_line":"                if filter_field not in filters:"},{"line_number":87,"context_line":"                    filters[filter_field] \u003d filter_string"},{"line_number":88,"context_line":"        return filters"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_755548f8","line":85,"range":{"start_line":72,"start_character":0,"end_line":85,"end_character":57},"in_reply_to":"3aaa91ec_ce594a37","updated":"2016-06-30 18:47:18.000000000","message":"I added the options into the tooltip, but I find really hard to add a dropdown when an option with strict value is selected. I would appreciate any feedback.","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"e9cb0ba8a61b257946f54bdb936c3b5e47b23caa","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            filter_string \u003d self.table.get_filter_string().strip()"},{"line_number":70,"context_line":"            if filter_field and filter_string:"},{"line_number":71,"context_line":"                if filter_field \u003d\u003d \u0027shared\u0027:"},{"line_number":72,"context_line":"                    if _(\"yes\") \u003d\u003d filter_string.lower():"},{"line_number":73,"context_line":"                        filters[\u0027shared\u0027] \u003d True"},{"line_number":74,"context_line":"                    elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":75,"context_line":"                        filters[\u0027shared\u0027] \u003d False"},{"line_number":76,"context_line":"                elif filter_field \u003d\u003d \u0027router:external\u0027:"},{"line_number":77,"context_line":"                    if _(\"yes\") \u003d\u003d filter_string.lower():"},{"line_number":78,"context_line":"                        filters[\u0027router:external\u0027] \u003d True"},{"line_number":79,"context_line":"                    elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":80,"context_line":"                        filters[\u0027router:external\u0027] \u003d False"},{"line_number":81,"context_line":"                elif filter_field \u003d\u003d \u0027admin_state_up\u0027:"},{"line_number":82,"context_line":"                    if _(\"up\") \u003d\u003d filter_string.lower():"},{"line_number":83,"context_line":"                        filters[\u0027admin_state_up\u0027] \u003d True"},{"line_number":84,"context_line":"                    elif _(\"down\") \u003d\u003d filter_string.lower():"},{"line_number":85,"context_line":"                        filters[\u0027admin_state_up\u0027] \u003d False"},{"line_number":86,"context_line":"                if filter_field not in filters:"},{"line_number":87,"context_line":"                    filters[filter_field] \u003d filter_string"},{"line_number":88,"context_line":"        return filters"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_03d32e05","line":85,"range":{"start_line":72,"start_character":0,"end_line":85,"end_character":57},"in_reply_to":"3aaa91ec_e23d402c","updated":"2016-06-29 18:36:13.000000000","message":"The idea was to be able to use the same text as input as is shown in the table.  What it does to create the tables is convert True/False to the translation of \u0027No\u0027|\u0027Yes\", the idea was to do the opposite. Or do you think that in this cases it should hide the textbox and show a dropdown with the possibles values?","commit_id":"66e4cf944f02c84ea0370fb6f0b9f5a5cd24fc3b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8fc331ac1cb9a1117dad8cc00230e907c00e847b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if filter_action.is_api_filter(filter_field):"},{"line_number":69,"context_line":"            filter_string \u003d self.table.get_filter_string().strip()"},{"line_number":70,"context_line":"            if filter_field and filter_string:"},{"line_number":71,"context_line":"                if filter_field \u003d\u003d \u0027shared\u0027:"},{"line_number":72,"context_line":"                    if _(\"yes\") \u003d\u003d filter_string.lower():"},{"line_number":73,"context_line":"                        filters[\u0027shared\u0027] \u003d True"},{"line_number":74,"context_line":"                    elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":75,"context_line":"                        filters[\u0027shared\u0027] \u003d False"},{"line_number":76,"context_line":"                elif filter_field \u003d\u003d \u0027router:external\u0027:"},{"line_number":77,"context_line":"                    if _(\"yes\") \u003d\u003d filter_string.lower():"},{"line_number":78,"context_line":"                        filters[\u0027router:external\u0027] \u003d True"},{"line_number":79,"context_line":"                    elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":80,"context_line":"                        filters[\u0027router:external\u0027] \u003d False"},{"line_number":81,"context_line":"                elif filter_field \u003d\u003d \u0027admin_state_up\u0027:"},{"line_number":82,"context_line":"                    if _(\"up\") \u003d\u003d filter_string.lower():"},{"line_number":83,"context_line":"                        filters[\u0027admin_state_up\u0027] \u003d True"},{"line_number":84,"context_line":"                    elif _(\"down\") \u003d\u003d filter_string.lower():"},{"line_number":85,"context_line":"                        filters[\u0027admin_state_up\u0027] \u003d False"},{"line_number":86,"context_line":"                if filter_field not in filters:"},{"line_number":87,"context_line":"                    filters[filter_field] \u003d filter_string"},{"line_number":88,"context_line":"        return filters"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_a333f760","line":85,"range":{"start_line":71,"start_character":15,"end_line":85,"end_character":57},"updated":"2016-06-30 20:59:33.000000000","message":"so much logic...sort of begs for a simple mapping:\n[{\"shared\": {\"yes\": True, \"no\": False}}, ...]\nand a simple evaluation.\n\nI won\u0027t -1 over that.  But adds a lot of conditional codes, increases cyclomatic complexity.","commit_id":"e0f92eb4b512f36739688e107483cebf2e92edff"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"51770d8fafd6bff341287cfc425005e1c31b4102","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def get_filters(self):"},{"line_number":68,"context_line":"        import pdb"},{"line_number":69,"context_line":"        pdb.set_trace()"},{"line_number":70,"context_line":"        filters \u003d {}"},{"line_number":71,"context_line":"        filter_field \u003d self.table.get_filter_field()"},{"line_number":72,"context_line":"        filter_action \u003d self.table._meta._filter_action"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_0b373eb1","line":69,"updated":"2016-07-04 06:34:12.000000000","message":"Looks like this is for debug purposes, isn\u0027t it?","commit_id":"6f1ae4fc6e8eaeead7fe45bde368144955d3e52e"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"ace3b815b29ed7b0327b7e175cfd6b4bf307abf2","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def get_filters(self):"},{"line_number":68,"context_line":"        import pdb"},{"line_number":69,"context_line":"        pdb.set_trace()"},{"line_number":70,"context_line":"        filters \u003d {}"},{"line_number":71,"context_line":"        filter_field \u003d self.table.get_filter_field()"},{"line_number":72,"context_line":"        filter_action \u003d self.table._meta._filter_action"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_57015669","line":69,"in_reply_to":"1aa78d24_0b373eb1","updated":"2016-07-06 17:36:47.000000000","message":"Yes, I\u0027m sorry I forgot to delete it. Its deleted now.","commit_id":"6f1ae4fc6e8eaeead7fe45bde368144955d3e52e"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"51770d8fafd6bff341287cfc425005e1c31b4102","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            filter_string \u003d self.table.get_filter_string().strip()"},{"line_number":75,"context_line":"            if filter_field and filter_string:"},{"line_number":76,"context_line":"                if filter_field in self.FILTERS_MAPPING:"},{"line_number":77,"context_line":"                    filters[filter_field] \u003d self.FILTERS_MAPPING.get(filter_field).get(filter_string.lower())"},{"line_number":78,"context_line":"                if filter_field not in filters:"},{"line_number":79,"context_line":"                    filters[filter_field] \u003d filter_string"},{"line_number":80,"context_line":"        return filters"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_cbbed6fe","line":77,"updated":"2016-07-04 06:34:12.000000000","message":"I think it would be more clear if we break this line into two lines.","commit_id":"6f1ae4fc6e8eaeead7fe45bde368144955d3e52e"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"ace3b815b29ed7b0327b7e175cfd6b4bf307abf2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            filter_string \u003d self.table.get_filter_string().strip()"},{"line_number":75,"context_line":"            if filter_field and filter_string:"},{"line_number":76,"context_line":"                if filter_field in self.FILTERS_MAPPING:"},{"line_number":77,"context_line":"                    filters[filter_field] \u003d self.FILTERS_MAPPING.get(filter_field).get(filter_string.lower())"},{"line_number":78,"context_line":"                if filter_field not in filters:"},{"line_number":79,"context_line":"                    filters[filter_field] \u003d filter_string"},{"line_number":80,"context_line":"        return filters"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_17322e5f","line":77,"in_reply_to":"1aa78d24_cbbed6fe","updated":"2016-07-06 17:36:47.000000000","message":"Done","commit_id":"6f1ae4fc6e8eaeead7fe45bde368144955d3e52e"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"4cb83037683f5edefa06fa52ddad78c5fc262b5e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                networks \u003d api.neutron.network_list_for_tenant("},{"line_number":56,"context_line":"                    self.request, tenant_id, **search_opts)"},{"line_number":57,"context_line":"            elif \u0027shared\u0027 in search_opts:"},{"line_number":58,"context_line":"                networks \u003d api.neutron.network_list_filtered_by_shared("},{"line_number":59,"context_line":"                    self.request, tenant_id, shared\u003dsearch_opts[\u0027shared\u0027])"},{"line_number":60,"context_line":"            else:"},{"line_number":61,"context_line":"                networks \u003d api.neutron.network_list_for_tenant("}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_6a9dc158","line":58,"updated":"2016-07-19 21:14:31.000000000","message":"Is it possible for there to be \u0027router:external\u0027 and \u0027shared\u0027 in search_opts. In which case this conditional should be changed.","commit_id":"7a900a646ee4b23dfa95cc4d231eae8779540eb8"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"37477710901b5c912138d18af15866a2dfa39599","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                networks \u003d api.neutron.network_list_for_tenant("},{"line_number":56,"context_line":"                    self.request, tenant_id, **search_opts)"},{"line_number":57,"context_line":"            elif \u0027shared\u0027 in search_opts:"},{"line_number":58,"context_line":"                networks \u003d api.neutron.network_list_filtered_by_shared("},{"line_number":59,"context_line":"                    self.request, tenant_id, shared\u003dsearch_opts[\u0027shared\u0027])"},{"line_number":60,"context_line":"            else:"},{"line_number":61,"context_line":"                networks \u003d api.neutron.network_list_for_tenant("}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_ea4a51ab","line":58,"in_reply_to":"dada55a8_6a9dc158","updated":"2016-07-19 21:20:06.000000000","message":"Nope because in the filter can only be one selected by a combobox.","commit_id":"7a900a646ee4b23dfa95cc4d231eae8779540eb8"}],"openstack_dashboard/test/api_tests/neutron_tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c8bee53acab0ec8f1a7550fe64b4a669f156797c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def test_network_list_for_tenant_with_external(self):"},{"line_number":111,"context_line":"        # self._test_network_list_for_tenant(include_external\u003dTrue)"},{"line_number":112,"context_line":"        self._test_network_list_for_tenant("},{"line_number":113,"context_line":"            include_external\u003dFalse, filter_params\u003dNone,"},{"line_number":114,"context_line":"            should_called\u003d[\u0027non_shared\u0027, \u0027shared\u0027])"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_network_list_for_tenant_with_filters_shared_false_wo_incext(self):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1ac06dbe_aaf1d5cf","line":113,"range":{"start_line":113,"start_character":29,"end_line":113,"end_character":34},"updated":"2016-08-19 15:21:30.000000000","message":"Should be True","commit_id":"edf4634846691903b875b514b15904ebc73ee9e7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c1a663ae3a2249495395a7adbb11ebc28b86d4cf","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def test_network_list_for_tenant_with_external(self):"},{"line_number":111,"context_line":"        # self._test_network_list_for_tenant(include_external\u003dTrue)"},{"line_number":112,"context_line":"        self._test_network_list_for_tenant("},{"line_number":113,"context_line":"            include_external\u003dFalse, filter_params\u003dNone,"},{"line_number":114,"context_line":"            should_called\u003d[\u0027non_shared\u0027, \u0027shared\u0027])"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_network_list_for_tenant_with_filters_shared_false_wo_incext(self):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1ac06dbe_4aa02191","line":113,"range":{"start_line":113,"start_character":29,"end_line":113,"end_character":34},"in_reply_to":"1ac06dbe_aaf1d5cf","updated":"2016-08-19 15:22:12.000000000","message":"Done","commit_id":"edf4634846691903b875b514b15904ebc73ee9e7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2ab03ea0b762cc8808f4a00fb79860781d7e97ff","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def _test_network_list_for_tenant("},{"line_number":46,"context_line":"            self, include_external,"},{"line_number":47,"context_line":"            filter_params, should_called):"},{"line_number":48,"context_line":"        \"\"\"This test only checks what parameters are passed to API."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        This test does not check what is returned. Return values"},{"line_number":51,"context_line":"        are checked by _test_network_list_for_tenant above."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param filter_params: Filters passed to network_list_for_tenant"},{"line_number":54,"context_line":"        :param should_called: this argument specifies which methods"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_ad93f759","line":51,"range":{"start_line":48,"start_character":11,"end_line":51,"end_character":59},"updated":"2016-08-23 18:07:45.000000000","message":"This comment is no longer correct. I forgot to change the docstring when I merged two variants of _test_network_list_for_tenant methods.","commit_id":"2bb81e16c706dac2d327d129b4cb9a3e89c5eb26"}]}
