)]}'
{"openstack_dashboard/dashboards/project/images/images/forms.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a83837bd1d55b9d7afad89239916ff6738988141","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                                                     \"location must \""},{"line_number":265,"context_line":"                                                     \"be specified.\","},{"line_number":266,"context_line":"                                                     ]})"},{"line_number":267,"context_line":"        elif image_url and image_file:"},{"line_number":268,"context_line":"            if source_type \u003d\u003d \u0027file\u0027:"},{"line_number":269,"context_line":"                raise ValidationError({\u0027image_file\u0027: [\"Can not specify \""},{"line_number":270,"context_line":"                                                      \"both an image \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_9c60c3d0","line":267,"updated":"2016-06-14 22:58:29.000000000","message":"do we need this one? doesn\u0027t seem like we\u0027d ever reach this case...\n\nit\u0027ll always only show either the file picker or the external URL input box","commit_id":"59b69fb0d7725b3bd5e6649852a650fcec599c18"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"fb89fb6c3f5d25e907fa6b5f404ad046944640cf","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                                                     \"location must \""},{"line_number":265,"context_line":"                                                     \"be specified.\","},{"line_number":266,"context_line":"                                                     ]})"},{"line_number":267,"context_line":"        elif image_url and image_file:"},{"line_number":268,"context_line":"            if source_type \u003d\u003d \u0027file\u0027:"},{"line_number":269,"context_line":"                raise ValidationError({\u0027image_file\u0027: [\"Can not specify \""},{"line_number":270,"context_line":"                                                      \"both an image \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_604a4c57","line":267,"in_reply_to":"7aa08908_778c10d7","updated":"2016-06-15 22:47:38.000000000","message":"It seems to me that if we\u0027ve got source_type then we can just ignore the unwanted extra parameter, and remove it from data, can\u0027t we?","commit_id":"59b69fb0d7725b3bd5e6649852a650fcec599c18"},{"author":{"_account_id":15837,"name":"Val Wanjura","email":"val.wanjura@rackspace.com","username":"valw"},"change_message_id":"03b70428489d1f6bc8a01591fc7cdc6b1d411422","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                                                     \"location must \""},{"line_number":265,"context_line":"                                                     \"be specified.\","},{"line_number":266,"context_line":"                                                     ]})"},{"line_number":267,"context_line":"        elif image_url and image_file:"},{"line_number":268,"context_line":"            if source_type \u003d\u003d \u0027file\u0027:"},{"line_number":269,"context_line":"                raise ValidationError({\u0027image_file\u0027: [\"Can not specify \""},{"line_number":270,"context_line":"                                                      \"both an image \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_778c10d7","line":267,"in_reply_to":"7aa08908_9c60c3d0","updated":"2016-06-14 23:24:22.000000000","message":"I thought the same thing when I saw the original code but was able to replicate it. You are correct that it is unlikely as the user would have to enter both an image file and a URL (enter one and then change the file picker to the other and enter it - even though only one or the other displays), but it could happen.","commit_id":"59b69fb0d7725b3bd5e6649852a650fcec599c18"}]}
