)]}'
{"openstack_dashboard/dashboards/admin/instances/tables.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a965d0f7e290e389137595265d26cfdbcdac90ec","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        status\u003dTrue,"},{"line_number":154,"context_line":"        status_choices\u003dSTATUS_CHOICES,"},{"line_number":155,"context_line":"        display_choices\u003dproject_tables.STATUS_DISPLAY_CHOICES)"},{"line_number":156,"context_line":"    locked \u003d tables.Column(project_tables.render_locked, verbose_name\u003d_(\" \"))"},{"line_number":157,"context_line":"    task \u003d tables.Column(\"OS-EXT-STS:task_state\","},{"line_number":158,"context_line":"                         verbose_name\u003d_(\"Task\"),"},{"line_number":159,"context_line":"                         empty_value\u003dproject_tables.TASK_DISPLAY_NONE,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_0d01f2ae","line":156,"updated":"2016-06-21 00:58:29.000000000","message":"is this meant to be it\u0027s own column (missing name?) or some extension of status column?\n\nshould also explain it above as a comment and include:\n\n# only shown when nova version 2.9 enabled","commit_id":"8cd8d25d15d30567ea7d0325a5780904c5c28e27"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"8774d80a8bd55ec3038504af891446a37d0fecc5","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        status\u003dTrue,"},{"line_number":154,"context_line":"        status_choices\u003dSTATUS_CHOICES,"},{"line_number":155,"context_line":"        display_choices\u003dproject_tables.STATUS_DISPLAY_CHOICES)"},{"line_number":156,"context_line":"    locked \u003d tables.Column(project_tables.render_locked, verbose_name\u003d_(\" \"))"},{"line_number":157,"context_line":"    task \u003d tables.Column(\"OS-EXT-STS:task_state\","},{"line_number":158,"context_line":"                         verbose_name\u003d_(\"Task\"),"},{"line_number":159,"context_line":"                         empty_value\u003dproject_tables.TASK_DISPLAY_NONE,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_0c3777e4","line":156,"in_reply_to":"5a9d85d2_0d01f2ae","updated":"2016-06-21 16:20:22.000000000","message":"Yes, it will be its own column. It doesn\u0027t have a name since I think the icon is self-explanatory enough and it\u0027s right next to the status column. I added two screenshots in the defect comments on launchpad.","commit_id":"8cd8d25d15d30567ea7d0325a5780904c5c28e27"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"697303ec329c8e1e75efe58903aef199a7a34127","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        display_choices\u003dproject_tables.STATUS_DISPLAY_CHOICES)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    # only shown when using nova version 2.9 and above"},{"line_number":158,"context_line":"    locked \u003d tables.Column(project_tables.render_locked, verbose_name\u003d_(\" \"))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    task \u003d tables.Column(\"OS-EXT-STS:task_state\","},{"line_number":161,"context_line":"                         verbose_name\u003d_(\"Task\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f64574b3","line":158,"updated":"2016-06-27 21:59:54.000000000","message":"hide this column unless \u003e 2.9 (otherwise we have an empty column that still takes up room)\n\nexample: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/tables.py#L232","commit_id":"e99e7bcc990d6397dc37fa4ad708e0299c46a826"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"3cbaf09c869911c3f3bba7d71aa70c6ac41a9df0","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        display_choices\u003dproject_tables.STATUS_DISPLAY_CHOICES)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    # only shown when using nova version 2.9 and above"},{"line_number":158,"context_line":"    locked \u003d tables.Column(project_tables.render_locked, verbose_name\u003d_(\" \"))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    task \u003d tables.Column(\"OS-EXT-STS:task_state\","},{"line_number":161,"context_line":"                         verbose_name\u003d_(\"Task\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_a35552c7","line":158,"in_reply_to":"3aaa91ec_f64574b3","updated":"2016-07-08 22:13:03.000000000","message":"Done. Thanks.","commit_id":"e99e7bcc990d6397dc37fa4ad708e0299c46a826"},{"author":{"_account_id":11592,"name":"Julie Gravel","email":"julie.gravel@suse.com","username":"jgravel"},"change_message_id":"4f826ea6f43da451547b9de1a2c5ab9fa1fa144e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        status\u003dTrue,"},{"line_number":153,"context_line":"        status_choices\u003dSTATUS_CHOICES,"},{"line_number":154,"context_line":"        display_choices\u003dproject_tables.STATUS_DISPLAY_CHOICES)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    locked \u003d tables.Column(project_tables.render_locked,"},{"line_number":157,"context_line":"                           verbose_name\u003d_(\" \"),"},{"line_number":158,"context_line":"                           sortable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff0f0b1f_5a121c0b","line":155,"updated":"2017-05-19 16:56:00.000000000","message":"Any reason for this line and line 159? Other columns don\u0027t have spaces between them.","commit_id":"ee14ac7f2c751e701a6cba6dba09a0f7fec246c5"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"73a852ec8ad0769552b0b033946f3c4d23f8a69e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        status\u003dTrue,"},{"line_number":153,"context_line":"        status_choices\u003dSTATUS_CHOICES,"},{"line_number":154,"context_line":"        display_choices\u003dproject_tables.STATUS_DISPLAY_CHOICES)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    locked \u003d tables.Column(project_tables.render_locked,"},{"line_number":157,"context_line":"                           verbose_name\u003d_(\" \"),"},{"line_number":158,"context_line":"                           sortable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff0f0b1f_129da058","line":155,"in_reply_to":"ff0f0b1f_5a121c0b","updated":"2017-05-20 00:10:00.000000000","message":"Done","commit_id":"ee14ac7f2c751e701a6cba6dba09a0f7fec246c5"}],"openstack_dashboard/dashboards/project/instances/tables.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a965d0f7e290e389137595265d26cfdbcdac90ec","unresolved":false,"context_lines":[{"line_number":1165,"context_line":"        lock_icon \u003d \u0027\u003cspan data-toggle\u003d\"tooltip\" title\u003d\"This instance is \u0027\\"},{"line_number":1166,"context_line":"            \u0027currently locked. To enable actions on it, please unlock it \u0027\\"},{"line_number":1167,"context_line":"            \u0027by selecting Unlock from the actions menu.\" \u0027\\"},{"line_number":1168,"context_line":"            \u0027class\u003d\"glyphicon glyphicon-lock\"\u003e\u003c/span\u003e\u0027"},{"line_number":1169,"context_line":"    return mark_safe(lock_icon)"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_8d81624d","line":1168,"updated":"2016-06-21 00:58:29.000000000","message":"use font awesome icons instead:\n\nfa fa-lock","commit_id":"8cd8d25d15d30567ea7d0325a5780904c5c28e27"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"8774d80a8bd55ec3038504af891446a37d0fecc5","unresolved":false,"context_lines":[{"line_number":1165,"context_line":"        lock_icon \u003d \u0027\u003cspan data-toggle\u003d\"tooltip\" title\u003d\"This instance is \u0027\\"},{"line_number":1166,"context_line":"            \u0027currently locked. To enable actions on it, please unlock it \u0027\\"},{"line_number":1167,"context_line":"            \u0027by selecting Unlock from the actions menu.\" \u0027\\"},{"line_number":1168,"context_line":"            \u0027class\u003d\"glyphicon glyphicon-lock\"\u003e\u003c/span\u003e\u0027"},{"line_number":1169,"context_line":"    return mark_safe(lock_icon)"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_2c5eb345","line":1168,"in_reply_to":"5a9d85d2_8d81624d","updated":"2016-06-21 16:20:22.000000000","message":"Done","commit_id":"8cd8d25d15d30567ea7d0325a5780904c5c28e27"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a965d0f7e290e389137595265d26cfdbcdac90ec","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"                           display_choices\u003dSTATUS_DISPLAY_CHOICES)"},{"line_number":1203,"context_line":"    locked \u003d tables.Column(render_locked,"},{"line_number":1204,"context_line":"                           verbose_name\u003d\"\","},{"line_number":1205,"context_line":"                           sortable\u003dFalse)"},{"line_number":1206,"context_line":"    az \u003d tables.Column(\"availability_zone\","},{"line_number":1207,"context_line":"                       verbose_name\u003d_(\"Availability Zone\"))"},{"line_number":1208,"context_line":"    task \u003d tables.Column(\"OS-EXT-STS:task_state\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_adab7e88","line":1205,"updated":"2016-06-21 00:58:29.000000000","message":"add comment\n\n# only shown when nova version 2.0 enabled","commit_id":"8cd8d25d15d30567ea7d0325a5780904c5c28e27"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"8774d80a8bd55ec3038504af891446a37d0fecc5","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"                           display_choices\u003dSTATUS_DISPLAY_CHOICES)"},{"line_number":1203,"context_line":"    locked \u003d tables.Column(render_locked,"},{"line_number":1204,"context_line":"                           verbose_name\u003d\"\","},{"line_number":1205,"context_line":"                           sortable\u003dFalse)"},{"line_number":1206,"context_line":"    az \u003d tables.Column(\"availability_zone\","},{"line_number":1207,"context_line":"                       verbose_name\u003d_(\"Availability Zone\"))"},{"line_number":1208,"context_line":"    task \u003d tables.Column(\"OS-EXT-STS:task_state\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_2f41853a","line":1205,"in_reply_to":"5a9d85d2_adab7e88","updated":"2016-06-21 16:20:22.000000000","message":"Done","commit_id":"8cd8d25d15d30567ea7d0325a5780904c5c28e27"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"6f3c1c4bd6ea31f973522b20b8b69fbc20ab4860","unresolved":false,"context_lines":[{"line_number":1185,"context_line":"def render_locked(instance):"},{"line_number":1186,"context_line":"    lock_icon \u003d \u0027\u0027"},{"line_number":1187,"context_line":"    if instance and getattr(instance, \u0027locked\u0027, False):"},{"line_number":1188,"context_line":"        lock_icon \u003d \u0027\u003cspan data-toggle\u003d\"tooltip\" title\u003d\"This instance is \u0027\\"},{"line_number":1189,"context_line":"            \u0027currently locked. To enable actions on it, please unlock it \u0027\\"},{"line_number":1190,"context_line":"            \u0027by selecting Unlock from the actions menu.\" \u0027\\"},{"line_number":1191,"context_line":"            \u0027class\u003d\"fa fa-lock\"\u003e\u003c/span\u003e\u0027"},{"line_number":1192,"context_line":"    return mark_safe(lock_icon)"},{"line_number":1193,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_abaec5e3","line":1190,"range":{"start_line":1188,"start_character":55,"end_line":1190,"end_character":56},"updated":"2016-11-01 12:09:14.000000000","message":"This text needs to be translatable","commit_id":"b6043468d0425ea7fdb51e9402aeeea9dcf34bc7"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"fa9d404d70f7731da1022d6315b7a06e9a67197e","unresolved":false,"context_lines":[{"line_number":1185,"context_line":"def render_locked(instance):"},{"line_number":1186,"context_line":"    lock_icon \u003d \u0027\u0027"},{"line_number":1187,"context_line":"    if instance and getattr(instance, \u0027locked\u0027, False):"},{"line_number":1188,"context_line":"        lock_icon \u003d \u0027\u003cspan data-toggle\u003d\"tooltip\" title\u003d\"This instance is \u0027\\"},{"line_number":1189,"context_line":"            \u0027currently locked. To enable actions on it, please unlock it \u0027\\"},{"line_number":1190,"context_line":"            \u0027by selecting Unlock from the actions menu.\" \u0027\\"},{"line_number":1191,"context_line":"            \u0027class\u003d\"fa fa-lock\"\u003e\u003c/span\u003e\u0027"},{"line_number":1192,"context_line":"    return mark_safe(lock_icon)"},{"line_number":1193,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_5f9ffa02","line":1190,"range":{"start_line":1188,"start_character":55,"end_line":1190,"end_character":56},"in_reply_to":"ba5da102_abaec5e3","updated":"2016-11-08 02:25:06.000000000","message":"Done","commit_id":"b6043468d0425ea7fdb51e9402aeeea9dcf34bc7"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"c447ee755f818bda29d4e269a72b6e46dfa226b7","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"        help_tooltip_title \u003d _(\"This instance is currently locked. To enable \""},{"line_number":1203,"context_line":"                               \"more actions on it, please unlock it by \""},{"line_number":1204,"context_line":"                               \"selecting Unlock from the actions menu.\")"},{"line_number":1205,"context_line":"        lock_icon \u003d \u0027\u003cspan data-toggle\u003d\"tooltip\" title\u003d\\\u0027{}\\\u0027 \u0027 \\"},{"line_number":1206,"context_line":"                    \u0027class\u003d\"fa fa-lock\"\u003e\u003c/span\u003e\u0027.format(help_tooltip_title)"},{"line_number":1207,"context_line":"    return mark_safe(lock_icon)"},{"line_number":1208,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_57f41a86","line":1205,"range":{"start_line":1205,"start_character":49,"end_line":1205,"end_character":61},"updated":"2016-11-08 18:04:57.000000000","message":"why instead of escaping the \u0027 (single quote) change the code to use \" (double quotes)","commit_id":"baffab9fa44b7cb6f95c8f9a79857ff89f97be68"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"bd8a202a3f166f4869267932b33322adf02f2d93","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"        help_tooltip_title \u003d _(\"This instance is currently locked. To enable \""},{"line_number":1203,"context_line":"                               \"more actions on it, please unlock it by \""},{"line_number":1204,"context_line":"                               \"selecting Unlock from the actions menu.\")"},{"line_number":1205,"context_line":"        lock_icon \u003d \u0027\u003cspan data-toggle\u003d\"tooltip\" title\u003d\\\u0027{}\\\u0027 \u0027 \\"},{"line_number":1206,"context_line":"                    \u0027class\u003d\"fa fa-lock\"\u003e\u003c/span\u003e\u0027.format(help_tooltip_title)"},{"line_number":1207,"context_line":"    return mark_safe(lock_icon)"},{"line_number":1208,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_4691ca51","line":1205,"range":{"start_line":1205,"start_character":49,"end_line":1205,"end_character":61},"in_reply_to":"9a629dbe_57f41a86","updated":"2016-11-08 19:50:16.000000000","message":"Done","commit_id":"baffab9fa44b7cb6f95c8f9a79857ff89f97be68"},{"author":{"_account_id":11592,"name":"Julie Gravel","email":"julie.gravel@suse.com","username":"jgravel"},"change_message_id":"4f826ea6f43da451547b9de1a2c5ab9fa1fa144e","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"                           status\u003dTrue,"},{"line_number":1234,"context_line":"                           status_choices\u003dSTATUS_CHOICES,"},{"line_number":1235,"context_line":"                           display_choices\u003dSTATUS_DISPLAY_CHOICES)"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    locked \u003d tables.Column(render_locked,"},{"line_number":1238,"context_line":"                           verbose_name\u003d\"\","},{"line_number":1239,"context_line":"                           sortable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff0f0b1f_dac4ec61","line":1236,"updated":"2017-05-19 16:56:00.000000000","message":"Don\u0027t need this line and line 1240.","commit_id":"ee14ac7f2c751e701a6cba6dba09a0f7fec246c5"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"b7f751368d14499211622e6cfe289d16f71bacdb","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"                           status\u003dTrue,"},{"line_number":1234,"context_line":"                           status_choices\u003dSTATUS_CHOICES,"},{"line_number":1235,"context_line":"                           display_choices\u003dSTATUS_DISPLAY_CHOICES)"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    locked \u003d tables.Column(render_locked,"},{"line_number":1238,"context_line":"                           verbose_name\u003d\"\","},{"line_number":1239,"context_line":"                           sortable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff0f0b1f_1288001d","line":1236,"in_reply_to":"ff0f0b1f_dac4ec61","updated":"2017-05-20 00:08:39.000000000","message":"Done","commit_id":"ee14ac7f2c751e701a6cba6dba09a0f7fec246c5"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"b97c2035c586d3abb6a2c24abb7c2b808b81eee4","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                               \"selecting Unlock from the actions menu.\")"},{"line_number":1198,"context_line":"        lock_icon \u003d \u0027\u003cspan data-toggle\u003d\"tooltip\" title\u003d\"{}\" \u0027 \\"},{"line_number":1199,"context_line":"                    \u0027class\u003d\"fa fa-lock\"\u003e\u003c/span\u003e\u0027.format(help_tooltip_title)"},{"line_number":1200,"context_line":"    return mark_safe(lock_icon)"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":"class InstancesTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":18,"id":"df140735_0f4b4b2b","line":1200,"updated":"2017-05-31 12:01:37.000000000","message":"Cool, works for me. I\u0027d quite like it if we could use an unlocked icon too; so we should check for the correct microversion, and if so, display a locked or unlocked icon, like this: https://imgur.com/a/09Du4\n\nFor the classes, if you could use \"fa fa-fw fa-lock\" and \"fa fa-fw fa-unlock text-muted\", that seems to give a decent effect. The fa-fw makes the widths of the icons the same, which is useful if people use alternate ones.","commit_id":"fb16cfad734884bac6378fa3c74f79c21d5ab84b"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"54dd95255f18bcfb5c79bd932655fba68fc0077f","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                               \"selecting Unlock from the actions menu.\")"},{"line_number":1198,"context_line":"        lock_icon \u003d \u0027\u003cspan data-toggle\u003d\"tooltip\" title\u003d\"{}\" \u0027 \\"},{"line_number":1199,"context_line":"                    \u0027class\u003d\"fa fa-lock\"\u003e\u003c/span\u003e\u0027.format(help_tooltip_title)"},{"line_number":1200,"context_line":"    return mark_safe(lock_icon)"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":"class InstancesTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":18,"id":"df140735_b4812f4d","line":1200,"in_reply_to":"df140735_0f4b4b2b","updated":"2017-06-01 14:14:22.000000000","message":"Thanks for the suggestion. Updated in the new patch.","commit_id":"fb16cfad734884bac6378fa3c74f79c21d5ab84b"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"22908026d1fa3b1bbe42785ca29eaf8a228e49eb","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"def render_locked(instance):"},{"line_number":1191,"context_line":"    locked_status \u003d \u0027\u0027"},{"line_number":1192,"context_line":"    if hasattr(instance, \"request\") and api.nova.is_feature_available("},{"line_number":1193,"context_line":"            instance.request, \"locked_attribute\"):"},{"line_number":1194,"context_line":"        if getattr(instance, \u0027locked\u0027, False):"},{"line_number":1195,"context_line":"            icon_classes \u003d \"fa fa-fw fa-lock\""},{"line_number":1196,"context_line":"            help_tooltip \u003d _(\"This instance is currently locked. To enable \""}],"source_content_type":"text/x-python","patch_set":22,"id":"7f231b9d_ca654847","line":1193,"updated":"2017-06-13 09:14:12.000000000","message":"nit: I think it would be more readable to negate this condition, and simply return \"\" in the if body. Avoids indenting the whole function.\n\nI also wonder if it wouldn\u0027t be better to just check for the \"locked\" attribute here, and simply make sure it\u0027s always there when the feature is supported, just like you do in the overview.","commit_id":"5f9986f7e2616c1d969ad418ed84fb601396d984"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"5eb3478982ddc5cb65bd60f9b29b372a002d6e5e","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"def render_locked(instance):"},{"line_number":1191,"context_line":"    locked_status \u003d \u0027\u0027"},{"line_number":1192,"context_line":"    if hasattr(instance, \"request\") and api.nova.is_feature_available("},{"line_number":1193,"context_line":"            instance.request, \"locked_attribute\"):"},{"line_number":1194,"context_line":"        if getattr(instance, \u0027locked\u0027, False):"},{"line_number":1195,"context_line":"            icon_classes \u003d \"fa fa-fw fa-lock\""},{"line_number":1196,"context_line":"            help_tooltip \u003d _(\"This instance is currently locked. To enable \""}],"source_content_type":"text/x-python","patch_set":22,"id":"7f231b9d_dfdde542","line":1193,"in_reply_to":"7f231b9d_8ead048a","updated":"2017-06-14 07:28:37.000000000","message":"I was thinking about something like this:\n\n    def render_locked(instance):\n        if not hasattr(instance, \"locked\"):\n            return \"\"\n        if instance.locked:\n            icon_classes \u003d ...\n            help_tooltip \u003d ...\n        else:\n            icon_class \u003d ...\n            help_tooltop \u003d ...\n        return mark_safe(...)","commit_id":"5f9986f7e2616c1d969ad418ed84fb601396d984"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"41677d1d9200cdb6d9a48240dbd05da1b92235c3","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"def render_locked(instance):"},{"line_number":1191,"context_line":"    locked_status \u003d \u0027\u0027"},{"line_number":1192,"context_line":"    if hasattr(instance, \"request\") and api.nova.is_feature_available("},{"line_number":1193,"context_line":"            instance.request, \"locked_attribute\"):"},{"line_number":1194,"context_line":"        if getattr(instance, \u0027locked\u0027, False):"},{"line_number":1195,"context_line":"            icon_classes \u003d \"fa fa-fw fa-lock\""},{"line_number":1196,"context_line":"            help_tooltip \u003d _(\"This instance is currently locked. To enable \""}],"source_content_type":"text/x-python","patch_set":22,"id":"7f231b9d_8ead048a","line":1193,"in_reply_to":"7f231b9d_ca654847","updated":"2017-06-14 02:38:11.000000000","message":"Radomir,\nI don\u0027t think adding two \"not\" in the condition is more readable than the indentation.\n\nThe check here is different from the overview because there can be three possible returned values here: empty string, unlocked status, and locked status. On the overview, it\u0027s just showing the locked status or not so the check is simpler.","commit_id":"5f9986f7e2616c1d969ad418ed84fb601396d984"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"5994722896d2b421ea6773fe3504dc27f032b188","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"def render_locked(instance):"},{"line_number":1191,"context_line":"    locked_status \u003d \u0027\u0027"},{"line_number":1192,"context_line":"    if hasattr(instance, \"request\") and api.nova.is_feature_available("},{"line_number":1193,"context_line":"            instance.request, \"locked_attribute\"):"},{"line_number":1194,"context_line":"        if getattr(instance, \u0027locked\u0027, False):"},{"line_number":1195,"context_line":"            icon_classes \u003d \"fa fa-fw fa-lock\""},{"line_number":1196,"context_line":"            help_tooltip \u003d _(\"This instance is currently locked. To enable \""}],"source_content_type":"text/x-python","patch_set":22,"id":"7f231b9d_6e1f21b7","line":1193,"in_reply_to":"7f231b9d_dfdde542","updated":"2017-06-15 03:03:09.000000000","message":"Done","commit_id":"5f9986f7e2616c1d969ad418ed84fb601396d984"}]}
