)]}'
{"openstack_dashboard/api/rest/swift.py":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        :param container:"},{"line_number":161,"context_line":"        :param object_name:"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        If the object_name (ie. PUT path) ends in a \u0027/\u0027 then a folder is"},{"line_number":164,"context_line":"        created, rather than an object. Any file content passed along with"},{"line_number":165,"context_line":"        the request will be ignored in that case."},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_80f67a8e","line":163,"updated":"2016-07-14 18:09:00.000000000","message":"PUT -\u003e POST or change it to def put(self....).","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        :param container:"},{"line_number":161,"context_line":"        :param object_name:"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        If the object_name (ie. PUT path) ends in a \u0027/\u0027 then a folder is"},{"line_number":164,"context_line":"        created, rather than an object. Any file content passed along with"},{"line_number":165,"context_line":"        the request will be ignored in that case."},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_1468df86","line":163,"in_reply_to":"1aa78d24_80f67a8e","updated":"2016-07-14 19:27:42.000000000","message":"Done","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/edit-object-controller.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"(function () {"},{"line_number":17,"context_line":"  \u0027use strict\u0027;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.dashboard.project.containers\u0027)"},{"line_number":21,"context_line":"    .controller(\u0027EditObjectModalController\u0027, EditObjectModalController);"},{"line_number":22,"context_line":""}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_7d7a1527","line":19,"updated":"2016-07-14 18:09:00.000000000","message":"needs ngdoc... even though its pretty obvious what this controller is use for.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":16,"context_line":"(function () {"},{"line_number":17,"context_line":"  \u0027use strict\u0027;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.dashboard.project.containers\u0027)"},{"line_number":21,"context_line":"    .controller(\u0027EditObjectModalController\u0027, EditObjectModalController);"},{"line_number":22,"context_line":""}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_748de329","line":19,"in_reply_to":"1aa78d24_7d7a1527","updated":"2016-07-14 19:27:42.000000000","message":"This is a purely \"internal\" controller for this interface, so I don\u0027t believe API documentation is necessary.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  \u0027use strict\u0027;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.dashboard.project.containers\u0027)"},{"line_number":21,"context_line":"    .controller(\u0027EditObjectModalController\u0027, EditObjectModalController);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  EditObjectModalController.$inject \u003d ["}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_80383ad6","line":20,"updated":"2016-07-14 18:09:00.000000000","message":"should the controller name be horizon.dashboard.project.containers.editObjectModalController?","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  \u0027use strict\u0027;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.dashboard.project.containers\u0027)"},{"line_number":21,"context_line":"    .controller(\u0027EditObjectModalController\u0027, EditObjectModalController);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  EditObjectModalController.$inject \u003d ["}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_34acfb8b","line":20,"in_reply_to":"1aa78d24_80383ad6","updated":"2016-07-14 19:27:42.000000000","message":"Yep, to prevent possible collisions, and especially since this is an internal controller for this interface, the name should be fully-qualified.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    function changeFile(files) {"},{"line_number":42,"context_line":"      if (files.length) {"},{"line_number":43,"context_line":"        // update the upload file"},{"line_number":44,"context_line":"        ctrl.model.edit_file \u003d files[0];"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        // we\u0027re modifying the model value from a DOM event so we need to manually $digest"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_bd7f5daa","line":43,"updated":"2016-07-14 18:09:00.000000000","message":"this should be self explanatory","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    function changeFile(files) {"},{"line_number":42,"context_line":"      if (files.length) {"},{"line_number":43,"context_line":"        // update the upload file"},{"line_number":44,"context_line":"        ctrl.model.edit_file \u003d files[0];"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        // we\u0027re modifying the model value from a DOM event so we need to manually $digest"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_94e04ffc","line":43,"in_reply_to":"1aa78d24_bd7f5daa","updated":"2016-07-14 19:27:42.000000000","message":"I will make this comment clearer.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        ctrl.model.edit_file \u003d files[0];"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        // we\u0027re modifying the model value from a DOM event so we need to manually $digest"},{"line_number":47,"context_line":"        $scope.$digest();"},{"line_number":48,"context_line":"      }"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_e3eb0811","line":47,"updated":"2016-07-14 18:09:00.000000000","message":"doesnt seem like digest is needed here. tested it and seems to work ok.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        ctrl.model.edit_file \u003d files[0];"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        // we\u0027re modifying the model value from a DOM event so we need to manually $digest"},{"line_number":47,"context_line":"        $scope.$digest();"},{"line_number":48,"context_line":"      }"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_d41bf71a","line":47,"in_reply_to":"1aa78d24_e3eb0811","updated":"2016-07-14 19:27:42.000000000","message":"Yep, this was copy/paste leftover - this code doesn\u0027t modify the ngModel.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/edit-object-controller.spec.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      expect($scope.$digest).toHaveBeenCalled();"},{"line_number":57,"context_line":"    });"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    it(\u0027should respond to file changes correctly if no files are present\u0027, function test() {"},{"line_number":60,"context_line":"      var ctrl \u003d createController();"},{"line_number":61,"context_line":"      spyOn($scope, \u0027$digest\u0027);"},{"line_number":62,"context_line":""}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_2012260a","line":59,"updated":"2016-07-14 18:09:00.000000000","message":"rewording suggestion: should NOT respond to file changes if no files are present.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      expect($scope.$digest).toHaveBeenCalled();"},{"line_number":57,"context_line":"    });"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    it(\u0027should respond to file changes correctly if no files are present\u0027, function test() {"},{"line_number":60,"context_line":"      var ctrl \u003d createController();"},{"line_number":61,"context_line":"      spyOn($scope, \u0027$digest\u0027);"},{"line_number":62,"context_line":""}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_14e1ff9a","line":59,"in_reply_to":"1aa78d24_2012260a","updated":"2016-07-14 19:27:42.000000000","message":"Done","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/edit-object-modal.html":[{"author":{"_account_id":16628,"name":"Beth Elwell","email":"e.r.elwell@gmail.com","username":"bethelwell"},"change_message_id":"43442b7e18fb493dc4360759837b1e5f40434b22","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \u003cdiv class\u003d\"row\"\u003e"},{"line_number":13,"context_line":"      \u003cdiv class\u003d\"col-sm-6\"\u003e"},{"line_number":14,"context_line":"        \u003cfieldset\u003e"},{"line_number":15,"context_line":"          \u003cdiv class\u003d\"form-group \"\u003e"},{"line_number":16,"context_line":"            \u003clabel class\u003d\"control-label required\" for\u003d\"id_object_file\" translate\u003eNew File Contents\u003c/label\u003e"},{"line_number":17,"context_line":"            \u003cdiv\u003e"},{"line_number":18,"context_line":"              \u003cinput id\u003d\"id_object_file\" type\u003d\"file\" name\u003d\"file\" required"}],"source_content_type":"text/html","patch_set":6,"id":"1aa78d24_0da3e801","line":15,"updated":"2016-07-13 20:58:02.000000000","message":"nit: should there be a space after this class?","commit_id":"05340fa66bda48f5987ed71017a601ab1fa75986"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"964f36d2abec5de96b81ec27a3fa85b4b12fb2bb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \u003cdiv class\u003d\"row\"\u003e"},{"line_number":13,"context_line":"      \u003cdiv class\u003d\"col-sm-6\"\u003e"},{"line_number":14,"context_line":"        \u003cfieldset\u003e"},{"line_number":15,"context_line":"          \u003cdiv class\u003d\"form-group \"\u003e"},{"line_number":16,"context_line":"            \u003clabel class\u003d\"control-label required\" for\u003d\"id_object_file\" translate\u003eNew File Contents\u003c/label\u003e"},{"line_number":17,"context_line":"            \u003cdiv\u003e"},{"line_number":18,"context_line":"              \u003cinput id\u003d\"id_object_file\" type\u003d\"file\" name\u003d\"file\" required"}],"source_content_type":"text/html","patch_set":6,"id":"1aa78d24_88ece6f4","line":15,"in_reply_to":"1aa78d24_0da3e801","updated":"2016-07-13 21:36:29.000000000","message":"Done","commit_id":"05340fa66bda48f5987ed71017a601ab1fa75986"},{"author":{"_account_id":16628,"name":"Beth Elwell","email":"e.r.elwell@gmail.com","username":"bethelwell"},"change_message_id":"43442b7e18fb493dc4360759837b1e5f40434b22","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            \u003clabel class\u003d\"control-label required\" for\u003d\"id_object_file\" translate\u003eNew File Contents\u003c/label\u003e"},{"line_number":17,"context_line":"            \u003cdiv\u003e"},{"line_number":18,"context_line":"              \u003cinput id\u003d\"id_object_file\" type\u003d\"file\" name\u003d\"file\" required"},{"line_number":19,"context_line":"                     ng-model\u003d\"ctrl.model.view_file\" on-file-change\u003d\"ctrl.changeFile\"\u003e"},{"line_number":20,"context_line":"            \u003c/div\u003e"},{"line_number":21,"context_line":"          \u003c/div\u003e"},{"line_number":22,"context_line":"        \u003c/fieldset\u003e"}],"source_content_type":"text/html","patch_set":6,"id":"1aa78d24_0d7ac877","line":19,"updated":"2016-07-13 20:58:02.000000000","message":"nit: close input tag /","commit_id":"05340fa66bda48f5987ed71017a601ab1fa75986"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"964f36d2abec5de96b81ec27a3fa85b4b12fb2bb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            \u003clabel class\u003d\"control-label required\" for\u003d\"id_object_file\" translate\u003eNew File Contents\u003c/label\u003e"},{"line_number":17,"context_line":"            \u003cdiv\u003e"},{"line_number":18,"context_line":"              \u003cinput id\u003d\"id_object_file\" type\u003d\"file\" name\u003d\"file\" required"},{"line_number":19,"context_line":"                     ng-model\u003d\"ctrl.model.view_file\" on-file-change\u003d\"ctrl.changeFile\"\u003e"},{"line_number":20,"context_line":"            \u003c/div\u003e"},{"line_number":21,"context_line":"          \u003c/div\u003e"},{"line_number":22,"context_line":"        \u003c/fieldset\u003e"}],"source_content_type":"text/html","patch_set":6,"id":"1aa78d24_c8bc2ede","line":19,"in_reply_to":"1aa78d24_0d7ac877","updated":"2016-07-13 21:36:29.000000000","message":"Done","commit_id":"05340fa66bda48f5987ed71017a601ab1fa75986"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      \u003cdiv class\u003d\"col-sm-6\"\u003e"},{"line_number":14,"context_line":"        \u003cfieldset\u003e"},{"line_number":15,"context_line":"          \u003cdiv class\u003d\"form-group\"\u003e"},{"line_number":16,"context_line":"            \u003clabel class\u003d\"control-label required\" for\u003d\"id_object_file\" translate\u003eNew File Contents\u003c/label\u003e"},{"line_number":17,"context_line":"            \u003cdiv\u003e"},{"line_number":18,"context_line":"              \u003cinput id\u003d\"id_object_file\" type\u003d\"file\" name\u003d\"file\" required"},{"line_number":19,"context_line":"                     ng-model\u003d\"ctrl.model.view_file\" on-file-change\u003d\"ctrl.changeFile\" /\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"1aa78d24_59f76ed4","line":16,"updated":"2016-07-14 18:09:00.000000000","message":"styling suggestion, indent so its under 100 characters.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      \u003cdiv class\u003d\"col-sm-6\"\u003e"},{"line_number":14,"context_line":"        \u003cfieldset\u003e"},{"line_number":15,"context_line":"          \u003cdiv class\u003d\"form-group\"\u003e"},{"line_number":16,"context_line":"            \u003clabel class\u003d\"control-label required\" for\u003d\"id_object_file\" translate\u003eNew File Contents\u003c/label\u003e"},{"line_number":17,"context_line":"            \u003cdiv\u003e"},{"line_number":18,"context_line":"              \u003cinput id\u003d\"id_object_file\" type\u003d\"file\" name\u003d\"file\" required"},{"line_number":19,"context_line":"                     ng-model\u003d\"ctrl.model.view_file\" on-file-change\u003d\"ctrl.changeFile\" /\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"1aa78d24_d4fdb73c","line":16,"in_reply_to":"1aa78d24_59f76ed4","updated":"2016-07-14 19:27:42.000000000","message":"Done","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/file-change-directive.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"4a2f5616131c6bd27e6ae089e467a1a99f6c0f8c","unresolved":false,"context_lines":[{"line_number":7,"context_line":" *"},{"line_number":8,"context_line":" *    http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":" *"},{"line_number":10,"context_line":" * Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":" * distributed under the License is distributed on an \u0027AS IS\u0027 BASIS,"},{"line_number":12,"context_line":" * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":" * See the License for the specific language governing permissions and"}],"source_content_type":"text/javascript","patch_set":6,"id":"1aa78d24_05b5867d","line":10,"updated":"2016-07-07 23:54:47.000000000","message":"this directive name needs to be cleaned up\n\non-file-change.directive.js","commit_id":"05340fa66bda48f5987ed71017a601ab1fa75986"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"   *      ctrl.upload_file \u003d files[0];"},{"line_number":39,"context_line":"   *      ctrl.file_name \u003d files[0].name;"},{"line_number":40,"context_line":"   *      // we\u0027re modifying the model value from a DOM event so we need to manually $digest"},{"line_number":41,"context_line":"   *      $scope.$digest();"},{"line_number":42,"context_line":"   *    }"},{"line_number":43,"context_line":"   *  }"},{"line_number":44,"context_line":"   * ```"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_03029472","line":41,"updated":"2016-07-14 18:09:00.000000000","message":"remove this as well, see other comment.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":38,"context_line":"   *      ctrl.upload_file \u003d files[0];"},{"line_number":39,"context_line":"   *      ctrl.file_name \u003d files[0].name;"},{"line_number":40,"context_line":"   *      // we\u0027re modifying the model value from a DOM event so we need to manually $digest"},{"line_number":41,"context_line":"   *      $scope.$digest();"},{"line_number":42,"context_line":"   *    }"},{"line_number":43,"context_line":"   *  }"},{"line_number":44,"context_line":"   * ```"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_943e8fd8","line":41,"in_reply_to":"1aa78d24_03029472","updated":"2016-07-14 19:27:42.000000000","message":"Done","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/object-name-exists.directive.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"          }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"          var def \u003d $q.defer();"},{"line_number":65,"context_line":"          // reverse the sense here - successful lookup \u003d\u003d error"},{"line_number":66,"context_line":"          swiftAPI.getObjectDetails(model.container.name, model.fullPath(modelValue), true).then("},{"line_number":67,"context_line":"            def.reject, def.resolve"},{"line_number":68,"context_line":"          );"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_e6eb1611","line":65,"updated":"2016-07-14 18:09:00.000000000","message":"Styling nit, reads a bit better.\n\nswiftAPI\n  .getObjectDetails(model.container.name, model.fullPath(modelValue), true)\n  .then(def.reject, def.resolve);","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":62,"context_line":"          }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"          var def \u003d $q.defer();"},{"line_number":65,"context_line":"          // reverse the sense here - successful lookup \u003d\u003d error"},{"line_number":66,"context_line":"          swiftAPI.getObjectDetails(model.container.name, model.fullPath(modelValue), true).then("},{"line_number":67,"context_line":"            def.reject, def.resolve"},{"line_number":68,"context_line":"          );"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_34051b14","line":65,"in_reply_to":"1aa78d24_e6eb1611","updated":"2016-07-14 19:27:42.000000000","message":"Done","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"31425238ea3056fee7ab83ade6bf09649bf5cfa6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      restrict: \u0027A\u0027,"},{"line_number":56,"context_line":"      require: \u0027ngModel\u0027,"},{"line_number":57,"context_line":"      link: function(scope, element, attrs, ngModel) {"},{"line_number":58,"context_line":"        ngModel.$asyncValidators.exists \u003d function(modelValue) {"},{"line_number":59,"context_line":"          if (ngModel.$isEmpty(modelValue)) {"},{"line_number":60,"context_line":"            // consider empty model valid"},{"line_number":61,"context_line":"            return $q.when();"}],"source_content_type":"text/javascript","patch_set":11,"id":"9ad45d7e_f8a9d97c","line":58,"updated":"2016-08-12 19:28:09.000000000","message":"name this function","commit_id":"c7a78d092c8c2f2eaef1cfec00f080817df28d74"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f9859b2f6b52df7834eae5f687ce3c7041afb328","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      restrict: \u0027A\u0027,"},{"line_number":56,"context_line":"      require: \u0027ngModel\u0027,"},{"line_number":57,"context_line":"      link: function(scope, element, attrs, ngModel) {"},{"line_number":58,"context_line":"        ngModel.$asyncValidators.exists \u003d function(modelValue) {"},{"line_number":59,"context_line":"          if (ngModel.$isEmpty(modelValue)) {"},{"line_number":60,"context_line":"            // consider empty model valid"},{"line_number":61,"context_line":"            return $q.when();"}],"source_content_type":"text/javascript","patch_set":11,"id":"1ac06dbe_83564cd0","line":58,"in_reply_to":"9ad45d7e_f8a9d97c","updated":"2016-08-22 04:47:10.000000000","message":"Done","commit_id":"c7a78d092c8c2f2eaef1cfec00f080817df28d74"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/objects-row-actions.service.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"4a2f5616131c6bd27e6ae089e467a1a99f6c0f8c","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        modalWaitSpinnerService.hideModalSpinner();"},{"line_number":173,"context_line":"        toastService.add("},{"line_number":174,"context_line":"          \u0027success\u0027,"},{"line_number":175,"context_line":"          interpolate(gettext(\u0027File %(name)s uploaded.\u0027), uploadInfo, true)"},{"line_number":176,"context_line":"        );"},{"line_number":177,"context_line":"        model.updateContainer();"},{"line_number":178,"context_line":"        model.selectContainer("}],"source_content_type":"text/javascript","patch_set":6,"id":"1aa78d24_c52a5e2f","line":175,"updated":"2016-07-07 23:54:47.000000000","message":"name \u0027undefined\u0027","commit_id":"05340fa66bda48f5987ed71017a601ab1fa75986"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"964f36d2abec5de96b81ec27a3fa85b4b12fb2bb","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        modalWaitSpinnerService.hideModalSpinner();"},{"line_number":173,"context_line":"        toastService.add("},{"line_number":174,"context_line":"          \u0027success\u0027,"},{"line_number":175,"context_line":"          interpolate(gettext(\u0027File %(name)s uploaded.\u0027), uploadInfo, true)"},{"line_number":176,"context_line":"        );"},{"line_number":177,"context_line":"        model.updateContainer();"},{"line_number":178,"context_line":"        model.selectContainer("}],"source_content_type":"text/javascript","patch_set":6,"id":"1aa78d24_c82eee41","line":175,"in_reply_to":"1aa78d24_c52a5e2f","updated":"2016-07-13 21:36:29.000000000","message":"Done","commit_id":"05340fa66bda48f5987ed71017a601ab1fa75986"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \u0027horizon.dashboard.project.containers.containers-model\u0027,"},{"line_number":133,"context_line":"    \u0027horizon.framework.util.q.extensions\u0027,"},{"line_number":134,"context_line":"    \u0027horizon.framework.widgets.modal-wait-spinner.service\u0027,"},{"line_number":135,"context_line":"    \u0027horizon.framework.widgets.toast.service\u0027,"},{"line_number":136,"context_line":"    \u0027$modal\u0027"},{"line_number":137,"context_line":"  ];"},{"line_number":138,"context_line":""}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_d9ab301d","line":135,"updated":"2016-07-14 18:09:00.000000000","message":"this should really be sorted alphabetically. $modal comes first.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \u0027horizon.dashboard.project.containers.containers-model\u0027,"},{"line_number":133,"context_line":"    \u0027horizon.framework.util.q.extensions\u0027,"},{"line_number":134,"context_line":"    \u0027horizon.framework.widgets.modal-wait-spinner.service\u0027,"},{"line_number":135,"context_line":"    \u0027horizon.framework.widgets.toast.service\u0027,"},{"line_number":136,"context_line":"    \u0027$modal\u0027"},{"line_number":137,"context_line":"  ];"},{"line_number":138,"context_line":""}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_6f24eeb1","line":135,"in_reply_to":"1aa78d24_d9ab301d","updated":"2016-07-14 19:27:42.000000000","message":"just no.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  function editService(swiftAPI, basePath, model, $qExtensions, modalWaitSpinnerService,"},{"line_number":140,"context_line":"                         toastService, $modal) {"},{"line_number":141,"context_line":"    var service \u003d {"},{"line_number":142,"context_line":"      allowed: function allowed(file) {"},{"line_number":143,"context_line":"        return $qExtensions.booleanAsPromise(file.is_object);"},{"line_number":144,"context_line":"      },"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_b4074b17","line":141,"updated":"2016-07-14 18:09:00.000000000","message":"this breaks JP\u0027s guide line. method definition should be declared afterwards. Looks cleaner if you do something like:\n\n  var service \u003d {\n    allowed: allowed,\n    perform: perform,\n    editObjectCallback: editObjectCallback\n  };\n\n  return service;\n\n  function allowed(file){.....}\n  function perform(file){.....}\n  function editObjectCallback(uploadInfo){...}","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  function editService(swiftAPI, basePath, model, $qExtensions, modalWaitSpinnerService,"},{"line_number":140,"context_line":"                         toastService, $modal) {"},{"line_number":141,"context_line":"    var service \u003d {"},{"line_number":142,"context_line":"      allowed: function allowed(file) {"},{"line_number":143,"context_line":"        return $qExtensions.booleanAsPromise(file.is_object);"},{"line_number":144,"context_line":"      },"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_8f0cba3c","line":141,"in_reply_to":"1aa78d24_b4074b17","updated":"2016-07-14 19:27:42.000000000","message":"I hate this aspect of JP\u0027s style guide. Ugh.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":148,"context_line":"          controller: \u0027EditObjectModalController as ctrl\u0027,"},{"line_number":149,"context_line":"          templateUrl: basePath + \u0027edit-object-modal.html\u0027,"},{"line_number":150,"context_line":"          resolve: {"},{"line_number":151,"context_line":"            fileDetails: function () {"},{"line_number":152,"context_line":"              return {"},{"line_number":153,"context_line":"                path: file.path,"},{"line_number":154,"context_line":"                container: model.container.name"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_5429c788","line":151,"updated":"2016-07-14 18:09:00.000000000","message":"ok with anonymous function, but give it a name.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":148,"context_line":"          controller: \u0027EditObjectModalController as ctrl\u0027,"},{"line_number":149,"context_line":"          templateUrl: basePath + \u0027edit-object-modal.html\u0027,"},{"line_number":150,"context_line":"          resolve: {"},{"line_number":151,"context_line":"            fileDetails: function () {"},{"line_number":152,"context_line":"              return {"},{"line_number":153,"context_line":"                path: file.path,"},{"line_number":154,"context_line":"                container: model.container.name"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_af0d36ea","line":151,"in_reply_to":"1aa78d24_5429c788","updated":"2016-07-14 19:27:42.000000000","message":"Done","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        model.container.name,"},{"line_number":169,"context_line":"        uploadInfo.path,"},{"line_number":170,"context_line":"        uploadInfo.edit_file"},{"line_number":171,"context_line":"      ).then(function success() {"},{"line_number":172,"context_line":"        modalWaitSpinnerService.hideModalSpinner();"},{"line_number":173,"context_line":"        toastService.add("},{"line_number":174,"context_line":"          \u0027success\u0027,"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_d43c97c1","line":171,"updated":"2016-07-14 18:09:00.000000000","message":"Another styling nit, cleaner to read it as:\n\n  swiftAPI.uploadObject(...).then(success, error);\n  function success(){....}\n  function error(){...}","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        model.container.name,"},{"line_number":169,"context_line":"        uploadInfo.path,"},{"line_number":170,"context_line":"        uploadInfo.edit_file"},{"line_number":171,"context_line":"      ).then(function success() {"},{"line_number":172,"context_line":"        modalWaitSpinnerService.hideModalSpinner();"},{"line_number":173,"context_line":"        toastService.add("},{"line_number":174,"context_line":"          \u0027success\u0027,"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_2f194623","line":171,"in_reply_to":"1aa78d24_d43c97c1","updated":"2016-07-14 19:27:42.000000000","message":"Done","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"31425238ea3056fee7ab83ade6bf09649bf5cfa6","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"      return $modal.open(localSpec).result.then(function finished() {"},{"line_number":232,"context_line":"        return actionResultService.getActionResult().deleted("},{"line_number":233,"context_line":"          \u0027OS::Swift::Object\u0027, file.name"},{"line_number":234,"context_line":"        ).result;"},{"line_number":235,"context_line":"      });"},{"line_number":236,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":11,"id":"9ad45d7e_98fd3d71","line":233,"range":{"start_line":233,"start_character":10,"end_line":233,"end_character":29},"updated":"2016-08-12 19:28:09.000000000","message":"Should we use a constant from somewhere?","commit_id":"c7a78d092c8c2f2eaef1cfec00f080817df28d74"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f9859b2f6b52df7834eae5f687ce3c7041afb328","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"      return $modal.open(localSpec).result.then(function finished() {"},{"line_number":232,"context_line":"        return actionResultService.getActionResult().deleted("},{"line_number":233,"context_line":"          \u0027OS::Swift::Object\u0027, file.name"},{"line_number":234,"context_line":"        ).result;"},{"line_number":235,"context_line":"      });"},{"line_number":236,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":11,"id":"1ac06dbe_43fa94be","line":233,"in_reply_to":"9ad45d7e_98fd3d71","updated":"2016-08-22 04:47:10.000000000","message":"I actually disagree with the approach of putting this into a constant. I believe it unnecessarily obfuscates the code. Unnecessarily because it\u0027s clear what the token being used is, and using a variable in its place offers no clear benefit (certainly it doesn\u0027t protect against getting the name wrong - using the wrong variable name will just result in an undefined value).","commit_id":"c7a78d092c8c2f2eaef1cfec00f080817df28d74"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/objects.controller.spec.js":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"3ab6d7a19c4bbdd974414d7fbfa709e5644ae786","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    it(\u0027should handle empty action results\u0027, function test() {"},{"line_number":96,"context_line":"      var ctrl \u003d createController();"},{"line_number":97,"context_line":"      // there\u0027s nothing to assert here..."},{"line_number":98,"context_line":"      ctrl.actionResultHandler();"},{"line_number":99,"context_line":"    });"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    it(\u0027should handle action results\u0027, function test() {"}],"source_content_type":"text/javascript","patch_set":10,"id":"dada55a8_3d2b10ed","line":98,"updated":"2016-07-25 23:13:48.000000000","message":"You can just create the spys as below and use `expect(model.updateContainer).not.toHaveBeenCalled();` etc. A test without an assertion will always validate anyway.","commit_id":"516664a178262d3b555b4165258d88e62c70482d"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"73d843e8dbef933218684e08186cb0d19728700b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    it(\u0027should handle empty action results\u0027, function test() {"},{"line_number":96,"context_line":"      var ctrl \u003d createController();"},{"line_number":97,"context_line":"      // there\u0027s nothing to assert here..."},{"line_number":98,"context_line":"      ctrl.actionResultHandler();"},{"line_number":99,"context_line":"    });"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    it(\u0027should handle action results\u0027, function test() {"}],"source_content_type":"text/javascript","patch_set":10,"id":"dada55a8_98d84a81","line":98,"in_reply_to":"dada55a8_3d2b10ed","updated":"2016-07-25 23:34:38.000000000","message":"I thought about doing that, but the problem I have with that assertion is that there\u0027s other ways for that assertion to be true (ie. that the result is not undefined, but has an empty deleted array), which means the assertion is invalid in my mind.","commit_id":"516664a178262d3b555b4165258d88e62c70482d"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"48d301c4634222b8a27bb90a452cbf335d12d35f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    it(\u0027should handle empty action results\u0027, function test() {"},{"line_number":96,"context_line":"      var ctrl \u003d createController();"},{"line_number":97,"context_line":"      // there\u0027s nothing to assert here..."},{"line_number":98,"context_line":"      ctrl.actionResultHandler();"},{"line_number":99,"context_line":"    });"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    it(\u0027should handle action results\u0027, function test() {"}],"source_content_type":"text/javascript","patch_set":10,"id":"dada55a8_75e1fc29","line":98,"in_reply_to":"dada55a8_98d84a81","updated":"2016-07-26 13:52:14.000000000","message":"Couldn\u0027t you just write two tests then? One that handles result \u003d [] and one that handles result \u003d undefined? Since you\u0027re controlling the inputs it shouldnt affect your other tests, but does at least check your code paths are being executed correctly.\n\nOr even just delete this test. It\u0027ll always pass :)","commit_id":"516664a178262d3b555b4165258d88e62c70482d"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/upload-object-controller.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"(function () {"},{"line_number":17,"context_line":"  \u0027use strict\u0027;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.dashboard.project.containers\u0027)"},{"line_number":21,"context_line":"    .controller(\u0027UploadObjectModalController\u0027, UploadObjectModalController);"},{"line_number":22,"context_line":""}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_43581c8b","line":19,"updated":"2016-07-14 18:09:00.000000000","message":"missing ngdoc","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":16,"context_line":"(function () {"},{"line_number":17,"context_line":"  \u0027use strict\u0027;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.dashboard.project.containers\u0027)"},{"line_number":21,"context_line":"    .controller(\u0027UploadObjectModalController\u0027, UploadObjectModalController);"},{"line_number":22,"context_line":""}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_8fe03afc","line":19,"in_reply_to":"1aa78d24_43581c8b","updated":"2016-07-14 19:27:42.000000000","message":"As with the other file, this is internal, no API docs necessary.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    .controller(\u0027UploadObjectModalController\u0027, UploadObjectModalController);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  UploadObjectModalController.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.dashboard.project.containers.containers-model\u0027,"},{"line_number":25,"context_line":"    \u0027$scope\u0027"},{"line_number":26,"context_line":"  ];"},{"line_number":27,"context_line":""}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_23d4f0bb","line":24,"updated":"2016-07-14 18:09:00.000000000","message":"why is one using containers-model and the other using fileupload?","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    .controller(\u0027UploadObjectModalController\u0027, UploadObjectModalController);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  UploadObjectModalController.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.dashboard.project.containers.containers-model\u0027,"},{"line_number":25,"context_line":"    \u0027$scope\u0027"},{"line_number":26,"context_line":"  ];"},{"line_number":27,"context_line":""}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_e3c94827","line":24,"updated":"2016-07-14 18:09:00.000000000","message":"why is one using containers-model vs file-upload?","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    .controller(\u0027UploadObjectModalController\u0027, UploadObjectModalController);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  UploadObjectModalController.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.dashboard.project.containers.containers-model\u0027,"},{"line_number":25,"context_line":"    \u0027$scope\u0027"},{"line_number":26,"context_line":"  ];"},{"line_number":27,"context_line":""}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_a66ba084","line":24,"in_reply_to":"1aa78d24_e3c94827","updated":"2016-07-14 19:27:42.000000000","message":"They\u0027re different :-)","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027$scope\u0027"},{"line_number":26,"context_line":"  ];"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  function UploadObjectModalController(model, $scope) {"},{"line_number":29,"context_line":"    var ctrl \u003d this;"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    ctrl.model \u003d {"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_a34900ba","line":28,"updated":"2016-07-14 18:09:00.000000000","message":"NOTE: this seems like duplicated code of edit controller. can we combine?","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027$scope\u0027"},{"line_number":26,"context_line":"  ];"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  function UploadObjectModalController(model, $scope) {"},{"line_number":29,"context_line":"    var ctrl \u003d this;"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    ctrl.model \u003d {"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_afa9b692","line":28,"in_reply_to":"1aa78d24_a34900ba","updated":"2016-07-14 19:27:42.000000000","message":"They are similar, but you\u0027ll note subtle differences between the models and behaviours. Originally I had them combined but they were overly complex and messy as a result.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        ctrl.form.name.$setDirty();"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        // we\u0027re modifying the model value from a DOM event so we need to manually $digest"},{"line_number":52,"context_line":"        $scope.$digest();"},{"line_number":53,"context_line":"      }"},{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_863852d6","line":52,"updated":"2016-07-14 18:09:00.000000000","message":"as discussed, i also think this is not needed. my vote would be to remove since on-file-change triggers it via apply.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        ctrl.form.name.$setDirty();"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        // we\u0027re modifying the model value from a DOM event so we need to manually $digest"},{"line_number":52,"context_line":"        $scope.$digest();"},{"line_number":53,"context_line":"      }"},{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_af81b6c5","line":52,"in_reply_to":"1aa78d24_863852d6","updated":"2016-07-14 19:27:42.000000000","message":"Done","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"31425238ea3056fee7ab83ade6bf09649bf5cfa6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      folder: model.folder,"},{"line_number":37,"context_line":"      view_file: null,      // file object managed by angular form ngModel"},{"line_number":38,"context_line":"      upload_file: null,    // file object from the DOM element with the actual upload"},{"line_number":39,"context_line":"      DELIMETER: model.DELIMETER"},{"line_number":40,"context_line":"    };"},{"line_number":41,"context_line":"    ctrl.form \u003d null;       // set by the HTML"},{"line_number":42,"context_line":"    ctrl.changeFile \u003d changeFile;"}],"source_content_type":"text/javascript","patch_set":11,"id":"9ad45d7e_18778d03","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":32},"updated":"2016-08-12 19:28:09.000000000","message":"Someday we should correct this spelling: \u0027Delimiter\u0027","commit_id":"c7a78d092c8c2f2eaef1cfec00f080817df28d74"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f9859b2f6b52df7834eae5f687ce3c7041afb328","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      folder: model.folder,"},{"line_number":37,"context_line":"      view_file: null,      // file object managed by angular form ngModel"},{"line_number":38,"context_line":"      upload_file: null,    // file object from the DOM element with the actual upload"},{"line_number":39,"context_line":"      DELIMETER: model.DELIMETER"},{"line_number":40,"context_line":"    };"},{"line_number":41,"context_line":"    ctrl.form \u003d null;       // set by the HTML"},{"line_number":42,"context_line":"    ctrl.changeFile \u003d changeFile;"}],"source_content_type":"text/javascript","patch_set":11,"id":"1ac06dbe_c32cc44c","line":39,"in_reply_to":"9ad45d7e_18778d03","updated":"2016-08-22 04:47:10.000000000","message":"OMG how embarrassing I didn\u0027t even notice :/","commit_id":"c7a78d092c8c2f2eaef1cfec00f080817df28d74"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/upload-object-controller.spec.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1aa78d24_f949cc33","updated":"2016-07-14 18:09:00.000000000","message":"same comments from the other spec file","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1aa78d24_6fc50e09","in_reply_to":"1aa78d24_f949cc33","updated":"2016-07-14 19:27:42.000000000","message":"Done (I think).","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/upload-object-modal.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"4a2f5616131c6bd27e6ae089e467a1a99f6c0f8c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"              \u003cinput class\u003d\"form-control\" type\u003d\"text\" id\u003d\"id_name\" maxlength\u003d\"255\" name\u003d\"name\""},{"line_number":27,"context_line":"                     ng-model\u003d\"ctrl.model.name\" required object-name-exists\u003e"},{"line_number":28,"context_line":"              \u003cspan ng-show\u003d\"ctrl.form.name.$pending.exists\" translate\u003eChecking if this name is used...\u003c/span\u003e"},{"line_number":29,"context_line":"              \u003cspan ng-show\u003d\"ctrl.form.name.$error.exists\" translate\u003eThis name already exists!\u003c/span\u003e"},{"line_number":30,"context_line":"            \u003c/div\u003e"},{"line_number":31,"context_line":"          \u003c/div\u003e"},{"line_number":32,"context_line":"        \u003c/fieldset\u003e"}],"source_content_type":"text/html","patch_set":6,"id":"1aa78d24_055746cb","line":29,"range":{"start_line":29,"start_character":34,"end_line":29,"end_character":38},"updated":"2016-07-07 23:54:47.000000000","message":"include class help-block","commit_id":"05340fa66bda48f5987ed71017a601ab1fa75986"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"964f36d2abec5de96b81ec27a3fa85b4b12fb2bb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"              \u003cinput class\u003d\"form-control\" type\u003d\"text\" id\u003d\"id_name\" maxlength\u003d\"255\" name\u003d\"name\""},{"line_number":27,"context_line":"                     ng-model\u003d\"ctrl.model.name\" required object-name-exists\u003e"},{"line_number":28,"context_line":"              \u003cspan ng-show\u003d\"ctrl.form.name.$pending.exists\" translate\u003eChecking if this name is used...\u003c/span\u003e"},{"line_number":29,"context_line":"              \u003cspan ng-show\u003d\"ctrl.form.name.$error.exists\" translate\u003eThis name already exists!\u003c/span\u003e"},{"line_number":30,"context_line":"            \u003c/div\u003e"},{"line_number":31,"context_line":"          \u003c/div\u003e"},{"line_number":32,"context_line":"        \u003c/fieldset\u003e"}],"source_content_type":"text/html","patch_set":6,"id":"1aa78d24_231eb55f","line":29,"in_reply_to":"1aa78d24_055746cb","updated":"2016-07-13 21:36:29.000000000","message":"Added - also added text-info and text-danger.","commit_id":"05340fa66bda48f5987ed71017a601ab1fa75986"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                     ng-model\u003d\"ctrl.model.view_file\" on-file-change\u003d\"ctrl.changeFile\"\u003e"},{"line_number":21,"context_line":"            \u003c/div\u003e"},{"line_number":22,"context_line":"          \u003c/div\u003e"},{"line_number":23,"context_line":"          \u003cdiv class\u003d\"form-group required\" ng-class\u003d\"{\u0027has-error\u0027: ctrl.form.name.$dirty \u0026\u0026 ctrl.form.name.$invalid}\"\u003e"},{"line_number":24,"context_line":"            \u003clabel class\u003d\"control-label required\" for\u003d\"id_name\" translate\u003eFile Name\u003c/label\u003e"},{"line_number":25,"context_line":"            \u003cdiv\u003e"},{"line_number":26,"context_line":"              \u003cinput class\u003d\"form-control\" type\u003d\"text\" id\u003d\"id_name\" maxlength\u003d\"255\" name\u003d\"name\""}],"source_content_type":"text/html","patch_set":7,"id":"1aa78d24_4333fc62","line":23,"updated":"2016-07-14 18:09:00.000000000","message":"consider indenting so its under 100 character limit.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                     ng-model\u003d\"ctrl.model.view_file\" on-file-change\u003d\"ctrl.changeFile\"\u003e"},{"line_number":21,"context_line":"            \u003c/div\u003e"},{"line_number":22,"context_line":"          \u003c/div\u003e"},{"line_number":23,"context_line":"          \u003cdiv class\u003d\"form-group required\" ng-class\u003d\"{\u0027has-error\u0027: ctrl.form.name.$dirty \u0026\u0026 ctrl.form.name.$invalid}\"\u003e"},{"line_number":24,"context_line":"            \u003clabel class\u003d\"control-label required\" for\u003d\"id_name\" translate\u003eFile Name\u003c/label\u003e"},{"line_number":25,"context_line":"            \u003cdiv\u003e"},{"line_number":26,"context_line":"              \u003cinput class\u003d\"form-control\" type\u003d\"text\" id\u003d\"id_name\" maxlength\u003d\"255\" name\u003d\"name\""}],"source_content_type":"text/html","patch_set":7,"id":"1aa78d24_efd9fef5","line":23,"in_reply_to":"1aa78d24_4333fc62","updated":"2016-07-14 19:27:42.000000000","message":"Done","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"31425238ea3056fee7ab83ade6bf09649bf5cfa6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                Checking if this name is used..."},{"line_number":31,"context_line":"              \u003c/span\u003e"},{"line_number":32,"context_line":"              \u003cspan class\u003d\"help-block text-danger\" ng-show\u003d\"ctrl.form.name.$error.exists\" translate\u003e"},{"line_number":33,"context_line":"                This name already exists!"},{"line_number":34,"context_line":"              \u003c/span\u003e"},{"line_number":35,"context_line":"            \u003c/div\u003e"},{"line_number":36,"context_line":"          \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"9ad45d7e_b8fe4136","line":33,"range":{"start_line":33,"start_character":17,"end_line":33,"end_character":41},"updated":"2016-08-12 19:28:09.000000000","message":"Maybe: \u0027This name already exists.\u0027  The text-danger should be sufficient to scare users (our calling and profession).","commit_id":"c7a78d092c8c2f2eaef1cfec00f080817df28d74"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f9859b2f6b52df7834eae5f687ce3c7041afb328","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                Checking if this name is used..."},{"line_number":31,"context_line":"              \u003c/span\u003e"},{"line_number":32,"context_line":"              \u003cspan class\u003d\"help-block text-danger\" ng-show\u003d\"ctrl.form.name.$error.exists\" translate\u003e"},{"line_number":33,"context_line":"                This name already exists!"},{"line_number":34,"context_line":"              \u003c/span\u003e"},{"line_number":35,"context_line":"            \u003c/div\u003e"},{"line_number":36,"context_line":"          \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"1ac06dbe_a32f083d","line":33,"in_reply_to":"9ad45d7e_b8fe4136","updated":"2016-08-22 04:47:10.000000000","message":"Good point.","commit_id":"c7a78d092c8c2f2eaef1cfec00f080817df28d74"}],"openstack_dashboard/static/app/core/openstack-service-api/swift.service.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":270,"context_line":"      var promise \u003d apiService.get("},{"line_number":271,"context_line":"        service.getObjectURL(container, objectName, \u0027metadata\u0027)"},{"line_number":272,"context_line":"      );"},{"line_number":273,"context_line":"      if (ignoreError) {"},{"line_number":274,"context_line":"        return promise;"},{"line_number":275,"context_line":"      }"},{"line_number":276,"context_line":"      return promise.error(function () {"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_79506ad5","line":273,"updated":"2016-07-14 18:09:00.000000000","message":"I am seeing an error each time i upload a file in the console. Personally, I dont think this is right (from user or developer point of view). Since it is an intended behavior, should we be suppressing this one?","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":270,"context_line":"      var promise \u003d apiService.get("},{"line_number":271,"context_line":"        service.getObjectURL(container, objectName, \u0027metadata\u0027)"},{"line_number":272,"context_line":"      );"},{"line_number":273,"context_line":"      if (ignoreError) {"},{"line_number":274,"context_line":"        return promise;"},{"line_number":275,"context_line":"      }"},{"line_number":276,"context_line":"      return promise.error(function () {"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_8645c444","line":273,"in_reply_to":"1aa78d24_79506ad5","updated":"2016-07-14 19:27:42.000000000","message":"I have attempted a few methods of suppressing this - it\u0027s a low-level log event from inside the xhr http machinery - and have been unable to.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"}],"openstack_dashboard/static/app/core/openstack-service-api/swift.service.spec.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":177,"context_line":"      innerFunc(message, 409);"},{"line_number":178,"context_line":"      expect(toastService.add).toHaveBeenCalledWith(\u0027error\u0027, message);"},{"line_number":179,"context_line":"    });"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    it(\u0027returns a relevant error message when deleteContainer returns a 409 error\u0027,"},{"line_number":182,"context_line":"      function test() {"},{"line_number":183,"context_line":"        var promise \u003d {error: angular.noop};"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_f9cf0c55","line":180,"updated":"2016-07-14 18:09:00.000000000","message":"Need tests for getting the object details when name of the object is taken, and when name of object not available.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":177,"context_line":"      innerFunc(message, 409);"},{"line_number":178,"context_line":"      expect(toastService.add).toHaveBeenCalledWith(\u0027error\u0027, message);"},{"line_number":179,"context_line":"    });"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    it(\u0027returns a relevant error message when deleteContainer returns a 409 error\u0027,"},{"line_number":182,"context_line":"      function test() {"},{"line_number":183,"context_line":"        var promise \u003d {error: angular.noop};"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_46d75c4f","line":180,"in_reply_to":"1aa78d24_f9cf0c55","updated":"2016-07-14 19:27:42.000000000","message":"That\u0027s already tested for.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"}],"openstack_dashboard/test/api_tests/swift_tests.py":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7475e700095758c28746dda4ba4196ed2db150c4","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                                 container.name,"},{"line_number":199,"context_line":"                                                 folder.name)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_swift_upload_object(self):"},{"line_number":202,"context_line":"        container \u003d self.containers.first()"},{"line_number":203,"context_line":"        obj \u003d self.objects.first()"},{"line_number":204,"context_line":"        fake_name \u003d \u0027fake_object.jpg\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_b9cf4428","line":201,"updated":"2016-07-14 18:09:00.000000000","message":"Need a test that verifies that you can not use an existing name.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c660f8677205432a996fc3dbcfd68c284f2a9712","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                                 container.name,"},{"line_number":199,"context_line":"                                                 folder.name)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_swift_upload_object(self):"},{"line_number":202,"context_line":"        container \u003d self.containers.first()"},{"line_number":203,"context_line":"        obj \u003d self.objects.first()"},{"line_number":204,"context_line":"        fake_name \u003d \u0027fake_object.jpg\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_d46db79a","line":201,"in_reply_to":"1aa78d24_b9cf4428","updated":"2016-07-14 19:27:42.000000000","message":"But you *can* use an existing name. This patch is *removing* the check that blocked using an existing name.","commit_id":"5657d6606b9c38b4f915fd92553ff30c98b7b71e"}]}
