)]}'
{"horizon/static/framework/widgets/table/hz-cell.directive.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"4df39710002002e0d15d1affed6f123a9b363425","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   *     {id: \u0027c\u0027, title: \u0027Header C\u0027, priority: 1, sortDefault: true},"},{"line_number":56,"context_line":"   *     {id: \u0027d\u0027, title: \u0027Header D\u0027, priority: 2,"},{"line_number":57,"context_line":"   *       template: \u0027\u003cspan class\u003d\"fa fa-bolt\"\u003e{$ item.id $}\u003c/span\u003e\u0027,"},{"line_number":58,"context_line":"   *       filters: [someFilterFunction, \u0027uppercase\u0027]}"},{"line_number":59,"context_line":"   *   ]"},{"line_number":60,"context_line":"   * };"},{"line_number":61,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":1,"id":"3aaa91ec_05249dc2","line":58,"updated":"2016-06-24 20:27:46.000000000","message":"Need to document the \u0027values\u0027 option.","commit_id":"d74dfd8e32980bf11fc8d6dedb84961840ce365c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"4ed19602dfcf3eb19ca332b5570a725c091bd9c6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   *     {id: \u0027c\u0027, title: \u0027Header C\u0027, priority: 1, sortDefault: true},"},{"line_number":56,"context_line":"   *     {id: \u0027d\u0027, title: \u0027Header D\u0027, priority: 2,"},{"line_number":57,"context_line":"   *       template: \u0027\u003cspan class\u003d\"fa fa-bolt\"\u003e{$ item.id $}\u003c/span\u003e\u0027,"},{"line_number":58,"context_line":"   *       filters: [someFilterFunction, \u0027uppercase\u0027]}"},{"line_number":59,"context_line":"   *   ]"},{"line_number":60,"context_line":"   * };"},{"line_number":61,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":1,"id":"3aaa91ec_e1eaecab","line":58,"in_reply_to":"3aaa91ec_05249dc2","updated":"2016-06-27 13:50:56.000000000","message":"Done","commit_id":"d74dfd8e32980bf11fc8d6dedb84961840ce365c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f0cb09c0f2f842febf73accb7eb97cf56b2ac2a2","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if (column \u0026\u0026 column.values) {"},{"line_number":99,"context_line":"          html \u003d column.values[propValue];"},{"line_number":100,"context_line":"        }"},{"line_number":101,"context_line":"        html \u003d html || propValue;"},{"line_number":102,"context_line":"        if (column \u0026\u0026 column.filters) {"},{"line_number":103,"context_line":"          for (var i \u003d 0; i \u003c column.filters.length; i++) {"},{"line_number":104,"context_line":"            var filter \u003d column.filters[i];"}],"source_content_type":"text/javascript","patch_set":1,"id":"3aaa91ec_a002d707","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":33},"updated":"2016-06-24 20:28:32.000000000","message":"should do this as \u0027else\u0027 in case value returned is falsy.","commit_id":"d74dfd8e32980bf11fc8d6dedb84961840ce365c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"4ed19602dfcf3eb19ca332b5570a725c091bd9c6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if (column \u0026\u0026 column.values) {"},{"line_number":99,"context_line":"          html \u003d column.values[propValue];"},{"line_number":100,"context_line":"        }"},{"line_number":101,"context_line":"        html \u003d html || propValue;"},{"line_number":102,"context_line":"        if (column \u0026\u0026 column.filters) {"},{"line_number":103,"context_line":"          for (var i \u003d 0; i \u003c column.filters.length; i++) {"},{"line_number":104,"context_line":"            var filter \u003d column.filters[i];"}],"source_content_type":"text/javascript","patch_set":1,"id":"3aaa91ec_c1025072","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":33},"in_reply_to":"3aaa91ec_a002d707","updated":"2016-06-27 13:50:56.000000000","message":"Modified to place values translation after filters.","commit_id":"d74dfd8e32980bf11fc8d6dedb84961840ce365c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6038a3393756b66417da13f41ca0629ac1038f98","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   *"},{"line_number":45,"context_line":"   * It should ideally be used within the context of the `hz-dynamic-table` directive."},{"line_number":46,"context_line":"   * The params passed into `hz-dynamic-table` can be used in the custom template,"},{"line_number":47,"context_line":"   * including the \u0027table\u0027 scope. \u0027table\u0027 can be referenced if you want to pass in an"},{"line_number":48,"context_line":"   * outside scope."},{"line_number":49,"context_line":"   *"},{"line_number":50,"context_line":"   * The column configuration may transform the data in the item\u0027s property"},{"line_number":51,"context_line":"   * using either a set of single-argument filters or functions, specified by"}],"source_content_type":"text/javascript","patch_set":3,"id":"3aaa91ec_adc3ab37","line":48,"range":{"start_line":47,"start_character":34,"end_line":48,"end_character":17},"updated":"2016-06-27 17:20:27.000000000","message":"I don\u0027t think this is true any longer (isolate scope), and shouldn\u0027t be as it makes any config 100% reliant on the vagaries of context.  That is, we already have problems with the idea of templates embedded here, but assuming in a config that a certain named item is present on scope outside of column and item seems really suspicious.","commit_id":"9adf9275e617dd18dfee03286422fe38894d02d4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"25b79211b8de19ddc05b1b6c95fbbdc1e1407e2b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   *"},{"line_number":45,"context_line":"   * It should ideally be used within the context of the `hz-dynamic-table` directive."},{"line_number":46,"context_line":"   * The params passed into `hz-dynamic-table` can be used in the custom template,"},{"line_number":47,"context_line":"   * including the \u0027table\u0027 scope. \u0027table\u0027 can be referenced if you want to pass in an"},{"line_number":48,"context_line":"   * outside scope."},{"line_number":49,"context_line":"   *"},{"line_number":50,"context_line":"   * The column configuration may transform the data in the item\u0027s property"},{"line_number":51,"context_line":"   * using either a set of single-argument filters or functions, specified by"}],"source_content_type":"text/javascript","patch_set":3,"id":"3aaa91ec_cd66f728","line":48,"range":{"start_line":47,"start_character":34,"end_line":48,"end_character":17},"in_reply_to":"3aaa91ec_adc3ab37","updated":"2016-06-27 17:24:16.000000000","message":"If people are bent out of shape about this, I\u0027d suggest moving the output logic to a service to it can be used by other directives/controllers.","commit_id":"9adf9275e617dd18dfee03286422fe38894d02d4"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fcff66ad2e4bddd32d3e7ad3ca42675d0f1eb03b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   *"},{"line_number":45,"context_line":"   * It should ideally be used within the context of the `hz-dynamic-table` directive."},{"line_number":46,"context_line":"   * The params passed into `hz-dynamic-table` can be used in the custom template,"},{"line_number":47,"context_line":"   * including the \u0027table\u0027 scope. \u0027table\u0027 can be referenced if you want to pass in an"},{"line_number":48,"context_line":"   * outside scope."},{"line_number":49,"context_line":"   *"},{"line_number":50,"context_line":"   * The column configuration may transform the data in the item\u0027s property"},{"line_number":51,"context_line":"   * using either a set of single-argument filters or functions, specified by"}],"source_content_type":"text/javascript","patch_set":3,"id":"3aaa91ec_e85fe83e","line":48,"range":{"start_line":47,"start_character":34,"end_line":48,"end_character":17},"in_reply_to":"3aaa91ec_cd66f728","updated":"2016-06-29 16:03:24.000000000","message":"Changing the directive\u0027s scope to be an isolate one makes sense to, as I usually did the same in my own directives, but I\u0027m wondering if someone else\u0027s code would be broken by cutting off the upward scope? Would like to hear Cindy Lu opinion here who worked on this directive.","commit_id":"9adf9275e617dd18dfee03286422fe38894d02d4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"43d213fc559de638405fdd9fd80cdd9a83114f40","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   *"},{"line_number":45,"context_line":"   * It should ideally be used within the context of the `hz-dynamic-table` directive."},{"line_number":46,"context_line":"   * The params passed into `hz-dynamic-table` can be used in the custom template,"},{"line_number":47,"context_line":"   * including the \u0027table\u0027 scope. \u0027table\u0027 can be referenced if you want to pass in an"},{"line_number":48,"context_line":"   * outside scope."},{"line_number":49,"context_line":"   *"},{"line_number":50,"context_line":"   * The column configuration may transform the data in the item\u0027s property"},{"line_number":51,"context_line":"   * using either a set of single-argument filters or functions, specified by"}],"source_content_type":"text/javascript","patch_set":3,"id":"3aaa91ec_15408133","line":48,"range":{"start_line":47,"start_character":34,"end_line":48,"end_character":17},"in_reply_to":"3aaa91ec_e85fe83e","updated":"2016-06-29 18:44:32.000000000","message":"Yes, breaks the current Container\u0027s panel. Specifically:\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/containers/objects.controller.js#L89 \nOtherwise, isolating the scope sounds good to me.","commit_id":"9adf9275e617dd18dfee03286422fe38894d02d4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a976d735868de76703d787cba77edc6c7a0c884a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"   * You should define a template when you want to format data or show more"},{"line_number":34,"context_line":"   * complex content (e.g conditionally show different icons or a link)."},{"line_number":35,"context_line":"   * You should reference the cell\u0027s \u0027item\u0027 attribute in the template if"},{"line_number":36,"context_line":"   * you need access to the cell\u0027s data. The attributes \u0027column\u0027 and \u0027item\u0027"},{"line_number":37,"context_line":"   * should be defined outside of this directive. See example below."},{"line_number":38,"context_line":"   *"},{"line_number":39,"context_line":"   * It should ideally be used within the context of the `hz-dynamic-table` directive."},{"line_number":40,"context_line":"   * The params passed into `hz-dynamic-table` can be used in the custom template,"}],"source_content_type":"text/javascript","patch_set":5,"id":"3aaa91ec_4b442cb6","side":"PARENT","line":37,"range":{"start_line":36,"start_character":41,"end_line":37,"end_character":50},"updated":"2016-06-29 19:42:15.000000000","message":"put this back in","commit_id":"f16435b8254de706ae503d6c9946280c4438c25b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a6cd302d62e60f68ced90167b542a335d86aa266","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  /**"},{"line_number":26,"context_line":"   * @ngdoc directive"},{"line_number":27,"context_line":"   * @name horizon.framework.widgets.table.directive:hzCell"},{"line_number":28,"context_line":"   * @param column {Object} - The column definition object, described below"},{"line_number":29,"context_line":"   * @param item {Object} - The object containing the property from column.id"},{"line_number":30,"context_line":"   * @description"},{"line_number":31,"context_line":"   * The `hzCell` directive allows you to customize your cell content."},{"line_number":32,"context_line":"   * When specifying your table configuration object, you may pass in a"}],"source_content_type":"text/javascript","patch_set":5,"id":"3aaa91ec_04121157","line":29,"range":{"start_line":28,"start_character":4,"end_line":29,"end_character":77},"updated":"2016-06-29 21:07:23.000000000","message":"Take these out","commit_id":"4ed4890b2fe6837bf2aef3be0ca3dec867f5fce1"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3f6248d4ca6dc88fd523b82c22d71911b973c5ad","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  /**"},{"line_number":26,"context_line":"   * @ngdoc directive"},{"line_number":27,"context_line":"   * @name horizon.framework.widgets.table.directive:hzCell"},{"line_number":28,"context_line":"   * @param column {Object} - The column definition object, described below"},{"line_number":29,"context_line":"   * @param item {Object} - The object containing the property from column.id"},{"line_number":30,"context_line":"   * @description"}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_20f38074","line":27,"updated":"2016-06-30 19:19:34.000000000","message":"Add @param table","commit_id":"df66bb5a3da34197a4fc0e0db4e0d3a0e79e59dc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"606597728ce164d87a7eed431204e35fb683fdee","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  /**"},{"line_number":26,"context_line":"   * @ngdoc directive"},{"line_number":27,"context_line":"   * @name horizon.framework.widgets.table.directive:hzCell"},{"line_number":28,"context_line":"   * @param column {Object} - The column definition object, described below"},{"line_number":29,"context_line":"   * @param item {Object} - The object containing the property from column.id"},{"line_number":30,"context_line":"   * @description"}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_5b0afd20","line":27,"in_reply_to":"3aaa91ec_20f38074","updated":"2016-06-30 19:26:45.000000000","message":"Done","commit_id":"df66bb5a3da34197a4fc0e0db4e0d3a0e79e59dc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3f6248d4ca6dc88fd523b82c22d71911b973c5ad","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   * you need access to the cell\u0027s data. See example below."},{"line_number":42,"context_line":"   *"},{"line_number":43,"context_line":"   * It should ideally be used within the context of the `hz-dynamic-table` directive."},{"line_number":44,"context_line":"   * The params passed into `hz-dynamic-table` can be used in the custom template,"},{"line_number":45,"context_line":"   * including the \u0027table\u0027 scope. \u0027table\u0027 can be referenced if you want to pass in an"},{"line_number":46,"context_line":"   * outside scope."},{"line_number":47,"context_line":"   *"},{"line_number":48,"context_line":"   * @restrict E"}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_e0f5f850","line":45,"range":{"start_line":44,"start_character":5,"end_line":45,"end_character":34},"updated":"2016-06-30 19:19:34.000000000","message":"Remove.","commit_id":"df66bb5a3da34197a4fc0e0db4e0d3a0e79e59dc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"606597728ce164d87a7eed431204e35fb683fdee","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   * you need access to the cell\u0027s data. See example below."},{"line_number":42,"context_line":"   *"},{"line_number":43,"context_line":"   * It should ideally be used within the context of the `hz-dynamic-table` directive."},{"line_number":44,"context_line":"   * The params passed into `hz-dynamic-table` can be used in the custom template,"},{"line_number":45,"context_line":"   * including the \u0027table\u0027 scope. \u0027table\u0027 can be referenced if you want to pass in an"},{"line_number":46,"context_line":"   * outside scope."},{"line_number":47,"context_line":"   *"},{"line_number":48,"context_line":"   * @restrict E"}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_bb15e140","line":45,"range":{"start_line":44,"start_character":5,"end_line":45,"end_character":34},"in_reply_to":"3aaa91ec_e0f5f850","updated":"2016-06-30 19:26:45.000000000","message":"Done","commit_id":"df66bb5a3da34197a4fc0e0db4e0d3a0e79e59dc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3f6248d4ca6dc88fd523b82c22d71911b973c5ad","unresolved":false,"context_lines":[{"line_number":102,"context_line":"      if (column \u0026\u0026 column.template) {"},{"line_number":103,"context_line":"        // if template provided, render, and place into cell"},{"line_number":104,"context_line":"        html \u003d $compile(column.template)(scope);"},{"line_number":105,"context_line":"      } else {"},{"line_number":106,"context_line":"        html \u003d $compile(\u0027\u003chz-field column\u003d\"column\" item\u003d\"item\"\u003e\u003c/hz-field\u003e\u0027)(scope);"},{"line_number":107,"context_line":"      }"},{"line_number":108,"context_line":"      element.append(html);"}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_80423466","line":105,"updated":"2016-06-30 19:19:34.000000000","message":"Note that \u0027table\u0027 is not passed to field (intentionally).","commit_id":"df66bb5a3da34197a4fc0e0db4e0d3a0e79e59dc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"606597728ce164d87a7eed431204e35fb683fdee","unresolved":false,"context_lines":[{"line_number":102,"context_line":"      if (column \u0026\u0026 column.template) {"},{"line_number":103,"context_line":"        // if template provided, render, and place into cell"},{"line_number":104,"context_line":"        html \u003d $compile(column.template)(scope);"},{"line_number":105,"context_line":"      } else {"},{"line_number":106,"context_line":"        html \u003d $compile(\u0027\u003chz-field column\u003d\"column\" item\u003d\"item\"\u003e\u003c/hz-field\u003e\u0027)(scope);"},{"line_number":107,"context_line":"      }"},{"line_number":108,"context_line":"      element.append(html);"}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_3b4f316c","line":105,"in_reply_to":"3aaa91ec_80423466","updated":"2016-06-30 19:26:45.000000000","message":"Done","commit_id":"df66bb5a3da34197a4fc0e0db4e0d3a0e79e59dc"}],"horizon/static/framework/widgets/table/hz-field.directive.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3f6248d4ca6dc88fd523b82c22d71911b973c5ad","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   * map to keys first (e.g. upper-casing a string with a filter so it matches"},{"line_number":46,"context_line":"   * upper-case keys), and allows the values provided in the \u0027values\u0027 mapping"},{"line_number":47,"context_line":"   * to be the final value produced."},{"line_number":48,"context_line":"   *"},{"line_number":49,"context_line":"   * @restrict E"},{"line_number":50,"context_line":"   *"},{"line_number":51,"context_line":"   * @scope"}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_0092c4f5","line":48,"updated":"2016-06-30 19:19:34.000000000","message":"describe urlFunction","commit_id":"df66bb5a3da34197a4fc0e0db4e0d3a0e79e59dc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"606597728ce164d87a7eed431204e35fb683fdee","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   * map to keys first (e.g. upper-casing a string with a filter so it matches"},{"line_number":46,"context_line":"   * upper-case keys), and allows the values provided in the \u0027values\u0027 mapping"},{"line_number":47,"context_line":"   * to be the final value produced."},{"line_number":48,"context_line":"   *"},{"line_number":49,"context_line":"   * @restrict E"},{"line_number":50,"context_line":"   *"},{"line_number":51,"context_line":"   * @scope"}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_5b7ddd6b","line":48,"in_reply_to":"3aaa91ec_0092c4f5","updated":"2016-06-30 19:26:45.000000000","message":"Done","commit_id":"df66bb5a3da34197a4fc0e0db4e0d3a0e79e59dc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3f6248d4ca6dc88fd523b82c22d71911b973c5ad","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   *         \u0027a\u0027: \u0027apple\u0027,"},{"line_number":67,"context_line":"   *         \u0027j\u0027: \u0027jacks\u0027"},{"line_number":68,"context_line":"   *       }"},{"line_number":69,"context_line":"   *     }"},{"line_number":70,"context_line":"   *   ]"},{"line_number":71,"context_line":"   * };"},{"line_number":72,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_60a0e842","line":69,"updated":"2016-06-30 19:19:34.000000000","message":"Add in a urlFunction","commit_id":"df66bb5a3da34197a4fc0e0db4e0d3a0e79e59dc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"606597728ce164d87a7eed431204e35fb683fdee","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   *         \u0027a\u0027: \u0027apple\u0027,"},{"line_number":67,"context_line":"   *         \u0027j\u0027: \u0027jacks\u0027"},{"line_number":68,"context_line":"   *       }"},{"line_number":69,"context_line":"   *     }"},{"line_number":70,"context_line":"   *   ]"},{"line_number":71,"context_line":"   * };"},{"line_number":72,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_bb9841c1","line":69,"in_reply_to":"3aaa91ec_60a0e842","updated":"2016-06-30 19:26:45.000000000","message":"Done","commit_id":"df66bb5a3da34197a4fc0e0db4e0d3a0e79e59dc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"010cff8fa3aa05bad5fdcd0d626bef2cab61353d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    var directive \u003d {"},{"line_number":87,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":88,"context_line":"      scope: {"},{"line_number":89,"context_line":"        column: \"\u003d\","},{"line_number":90,"context_line":"        item: \"\u003d\""},{"line_number":91,"context_line":"      },"},{"line_number":92,"context_line":"      link: link"}],"source_content_type":"text/javascript","patch_set":8,"id":"1aa78d24_2b25f9c1","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":20},"updated":"2016-07-01 22:33:20.000000000","message":"I guess I\u0027m a little confused about why this requires a column input. This makes it still seem really coupled to the notion of a table.  Shouldn\u0027t it take filters and values as input?","commit_id":"ec5d7996c1a883414a580685f92fec0d142d87cb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"3ae2a43fc57fbd4cf23602a5e74b903b7e5e6d1d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    var directive \u003d {"},{"line_number":87,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":88,"context_line":"      scope: {"},{"line_number":89,"context_line":"        column: \"\u003d\","},{"line_number":90,"context_line":"        item: \"\u003d\""},{"line_number":91,"context_line":"      },"},{"line_number":92,"context_line":"      link: link"}],"source_content_type":"text/javascript","patch_set":8,"id":"1aa78d24_919ffcb3","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":20},"in_reply_to":"1aa78d24_2b25f9c1","updated":"2016-07-01 23:27:33.000000000","message":"If we are jumping through hoops coupling directives just re-use some code, then probably this code should be some kind of reusable service.","commit_id":"ec5d7996c1a883414a580685f92fec0d142d87cb"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"592667face90f6c7b8d3693159da1efcaec1d6a8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    var directive \u003d {"},{"line_number":87,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":88,"context_line":"      scope: {"},{"line_number":89,"context_line":"        column: \"\u003d\","},{"line_number":90,"context_line":"        item: \"\u003d\""},{"line_number":91,"context_line":"      },"},{"line_number":92,"context_line":"      link: link"}],"source_content_type":"text/javascript","patch_set":8,"id":"1aa78d24_6287add7","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":20},"in_reply_to":"1aa78d24_30ddfd0e","updated":"2016-07-05 19:23:59.000000000","message":"Changing this hzField to be in a \u0027property\u0027 widget directory, and renaming the \u0027column\u0027 property to \u0027config.\u0027","commit_id":"ec5d7996c1a883414a580685f92fec0d142d87cb"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"73aadd0c4ed398ae455c67be7b231a327a705c0a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    var directive \u003d {"},{"line_number":87,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":88,"context_line":"      scope: {"},{"line_number":89,"context_line":"        column: \"\u003d\","},{"line_number":90,"context_line":"        item: \"\u003d\""},{"line_number":91,"context_line":"      },"},{"line_number":92,"context_line":"      link: link"}],"source_content_type":"text/javascript","patch_set":8,"id":"1aa78d24_30ddfd0e","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":20},"in_reply_to":"1aa78d24_919ffcb3","updated":"2016-07-05 14:43:50.000000000","message":"Yeah, I\u0027ve considered the service too...either way...we could just rename this from \u0027column\u0027 to \u0027config\u0027 and it would be more correct.","commit_id":"ec5d7996c1a883414a580685f92fec0d142d87cb"}]}
