)]}'
{"horizon/static/framework/conf/resource-type-registry.service.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"eeec0d9eb81792301d1b3904f233cd04f52f27c9","unresolved":false,"context_lines":[{"line_number":199,"context_line":"      }"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"      // Returns a copy of the properties."},{"line_number":202,"context_line":"      function getProperties() {"},{"line_number":203,"context_line":"        return angular.copy(properties);"},{"line_number":204,"context_line":"      }"},{"line_number":205,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_a06137ab","line":202,"updated":"2016-06-24 20:39:00.000000000","message":"test","commit_id":"8adba97cfb20643cf01c47787217d4d3e99de269"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"eeec0d9eb81792301d1b3904f233cd04f52f27c9","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        function mapTableInfo(x) {"},{"line_number":256,"context_line":"          var tableInfo \u003d x;"},{"line_number":257,"context_line":"          tableInfo.title \u003d x.title || label(x.id);"},{"line_number":258,"context_line":"          // use \u0027values\u0027 or \u0027filters\u0027 from property definition if available."},{"line_number":259,"context_line":"          if (properties[x.id] \u0026\u0026 properties[x.id].values) {"},{"line_number":260,"context_line":"            tableInfo.values \u003d properties[x.id].values;"},{"line_number":261,"context_line":"          }"}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_8064fbb8","line":258,"updated":"2016-06-24 20:39:00.000000000","message":"test","commit_id":"8adba97cfb20643cf01c47787217d4d3e99de269"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5a77de347b634e2665ccd807032460e93db2ff1c","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        function mapTableInfo(x) {"},{"line_number":261,"context_line":"          var tableInfo \u003d x;"},{"line_number":262,"context_line":"          tableInfo.title \u003d x.title || label(x.id);"},{"line_number":263,"context_line":"          // use \u0027values\u0027 or \u0027filters\u0027 from property definition if available."},{"line_number":264,"context_line":"          if (properties[x.id] \u0026\u0026 properties[x.id].values) {"},{"line_number":265,"context_line":"            tableInfo.values \u003d properties[x.id].values;"},{"line_number":266,"context_line":"          }"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_aea0d7a6","line":263,"updated":"2016-07-01 23:06:40.000000000","message":"Values and filters mentioned here, but not in the properties documentation above. How does the values_function play into this?","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6c22729a4732bbb80821f8dbd04916e04c9ec785","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        function mapTableInfo(x) {"},{"line_number":261,"context_line":"          var tableInfo \u003d x;"},{"line_number":262,"context_line":"          tableInfo.title \u003d x.title || label(x.id);"},{"line_number":263,"context_line":"          // use \u0027values\u0027 or \u0027filters\u0027 from property definition if available."},{"line_number":264,"context_line":"          if (properties[x.id] \u0026\u0026 properties[x.id].values) {"},{"line_number":265,"context_line":"            tableInfo.values \u003d properties[x.id].values;"},{"line_number":266,"context_line":"          }"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_a236b5e4","line":263,"in_reply_to":"1aa78d24_aea0d7a6","updated":"2016-07-05 19:45:37.000000000","message":"aah...geez, I\u0027d forgotten about the code from above.  I\u0027m going to have to think about that.  I don\u0027t think we\u0027re using .format anywhere right now.  hz-field is pretty useful because it is responsive to databound changes.  I think I need to re-evaluate the .format function. :(","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f0cdab498caff946af414034628dca509843031b","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        function mapTableInfo(x) {"},{"line_number":261,"context_line":"          var tableInfo \u003d x;"},{"line_number":262,"context_line":"          tableInfo.title \u003d x.title || label(x.id);"},{"line_number":263,"context_line":"          // use \u0027values\u0027 or \u0027filters\u0027 from property definition if available."},{"line_number":264,"context_line":"          if (properties[x.id] \u0026\u0026 properties[x.id].values) {"},{"line_number":265,"context_line":"            tableInfo.values \u003d properties[x.id].values;"},{"line_number":266,"context_line":"          }"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_049eac62","line":263,"updated":"2016-07-06 00:06:48.000000000","message":"what to do about values functions?","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5d681200a3edc8ea65d3f0c5b643ada14ca94e51","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        function mapTableInfo(x) {"},{"line_number":261,"context_line":"          var tableInfo \u003d x;"},{"line_number":262,"context_line":"          tableInfo.title \u003d x.title || label(x.id);"},{"line_number":263,"context_line":"          // use \u0027values\u0027 or \u0027filters\u0027 from property definition if available."},{"line_number":264,"context_line":"          if (properties[x.id] \u0026\u0026 properties[x.id].values) {"},{"line_number":265,"context_line":"            tableInfo.values \u003d properties[x.id].values;"},{"line_number":266,"context_line":"          }"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_91ca336d","line":263,"in_reply_to":"1aa78d24_049eac62","updated":"2016-07-08 15:44:03.000000000","message":"I think I\u0027ll take the .format() function out as it seems to have been surpassed by the hz-field feature.  It wasn\u0027t used anywhere.  Much of its logic was redundant, like defaults, since in hz-field the same can be accomplished by a combo of functions/filters and a values mapping.","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"}],"horizon/static/framework/widgets/property/hz-resource-property-list.directive.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f0cdab498caff946af414034628dca509843031b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  /**"},{"line_number":28,"context_line":"   * @ngdoc directive"},{"line_number":29,"context_line":"   * @name hzResourcePropertyList"},{"line_number":30,"context_line":"   * @description"},{"line_number":31,"context_line":"   * This directive displays sets of properties registered for the given type,"},{"line_number":32,"context_line":"   * grouped into label/values."},{"line_number":33,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_448a741c","line":30,"updated":"2016-07-06 00:06:48.000000000","message":"I think also say \"This is intended to be used with the resource registry.\"I think give a reference to the resource registry.  Perhaps give link to images as example.","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5d681200a3edc8ea65d3f0c5b643ada14ca94e51","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  /**"},{"line_number":28,"context_line":"   * @ngdoc directive"},{"line_number":29,"context_line":"   * @name hzResourcePropertyList"},{"line_number":30,"context_line":"   * @description"},{"line_number":31,"context_line":"   * This directive displays sets of properties registered for the given type,"},{"line_number":32,"context_line":"   * grouped into label/values."},{"line_number":33,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_710b477e","line":30,"in_reply_to":"1aa78d24_448a741c","updated":"2016-07-08 15:44:03.000000000","message":"Done","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f0cdab498caff946af414034628dca509843031b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * grouped into label/values."},{"line_number":33,"context_line":"   *"},{"line_number":34,"context_line":"   * The directive displays the groups proportionately based on the number of"},{"line_number":35,"context_line":"   * property groups presented."},{"line_number":36,"context_line":"   *"},{"line_number":37,"context_line":"   * @example"},{"line_number":38,"context_line":"   * The following would produce three sets of property lists, each entry with"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_c4cca46c","line":35,"updated":"2016-07-06 00:06:48.000000000","message":"Mention max allowed.","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5d681200a3edc8ea65d3f0c5b643ada14ca94e51","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * grouped into label/values."},{"line_number":33,"context_line":"   *"},{"line_number":34,"context_line":"   * The directive displays the groups proportionately based on the number of"},{"line_number":35,"context_line":"   * property groups presented."},{"line_number":36,"context_line":"   *"},{"line_number":37,"context_line":"   * @example"},{"line_number":38,"context_line":"   * The following would produce three sets of property lists, each entry with"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_5110cba8","line":35,"in_reply_to":"1aa78d24_c4cca46c","updated":"2016-07-08 15:44:03.000000000","message":"Done","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d64a37f9363d4e302f022ca172cda95ecb5ca5ba","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    function link(scope) {"},{"line_number":72,"context_line":"      scope.getColumnCount \u003d getColumnCount;"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"      function getColumnCount(columns) {"},{"line_number":75,"context_line":"        return Math.floor(12 / columns.length);"},{"line_number":76,"context_line":"      }"},{"line_number":77,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_e708142b","line":74,"range":{"start_line":74,"start_character":15,"end_line":74,"end_character":29},"updated":"2016-07-08 16:43:24.000000000","message":"bleah, this should probably be called \u0027getColumnSpan.\u0027","commit_id":"7e7176840c8aa9dbb25fb0b09f4be660d7cbba22"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"34456d6ddc506a5824fc532914b10b24d75087e5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"     property-groups\u003d\"["},{"line_number":49,"context_line":"       [\u0027name\u0027, \u0027id\u0027],"},{"line_number":50,"context_line":"       [\u0027shared\u0027, \u0027router__external\u0027],"},{"line_number":51,"context_line":"       [\u0027status\u0027, \u0027admin_state_up\u0027]]\"\u003e"},{"line_number":52,"context_line":"   \u003c/hz-resource-property-list\u003e"},{"line_number":53,"context_line":"   ```"},{"line_number":54,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":14,"id":"1aa78d24_e8220fb8","line":51,"updated":"2016-07-12 20:11:30.000000000","message":"i think it should be mentioned somewhere what this will result in detail view looking like:\n\n------------------------------------------------\nname    shared                  status\nid          router__external   admin_state_up\n------------------------------------------------\n\nsince i read it left to right and might assume it would look the fields are passed in, unless I read the html\n\n-------------------------------\nname        id\nshared      router__external\nstatus       admin_state_up\n-------------------------------\n\nAlso, mention that there is no restriction on the number of rows (as there is for columns)","commit_id":"4492d3ff0e3e978abc2c73409c1f03da08dc5a53"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"acbd37b67139c1c182cd298a870f17885fded4d1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"     property-groups\u003d\"["},{"line_number":49,"context_line":"       [\u0027name\u0027, \u0027id\u0027],"},{"line_number":50,"context_line":"       [\u0027shared\u0027, \u0027router__external\u0027],"},{"line_number":51,"context_line":"       [\u0027status\u0027, \u0027admin_state_up\u0027]]\"\u003e"},{"line_number":52,"context_line":"   \u003c/hz-resource-property-list\u003e"},{"line_number":53,"context_line":"   ```"},{"line_number":54,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":14,"id":"1aa78d24_ce6f23fb","line":51,"in_reply_to":"1aa78d24_e8220fb8","updated":"2016-07-13 17:56:39.000000000","message":"Sounds good, will do","commit_id":"4492d3ff0e3e978abc2c73409c1f03da08dc5a53"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"34456d6ddc506a5824fc532914b10b24d75087e5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      scope: {"},{"line_number":61,"context_line":"        resourceTypeName: \"@\","},{"line_number":62,"context_line":"        propertyGroups: \"\u003d\","},{"line_number":63,"context_line":"        cls: \"@?\","},{"line_number":64,"context_line":"        item: \"\u003d\""},{"line_number":65,"context_line":"      },"},{"line_number":66,"context_line":"      link: link,"}],"source_content_type":"text/javascript","patch_set":14,"id":"1aa78d24_cd076516","line":63,"updated":"2016-07-12 20:11:30.000000000","message":"document cls","commit_id":"4492d3ff0e3e978abc2c73409c1f03da08dc5a53"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"acbd37b67139c1c182cd298a870f17885fded4d1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      scope: {"},{"line_number":61,"context_line":"        resourceTypeName: \"@\","},{"line_number":62,"context_line":"        propertyGroups: \"\u003d\","},{"line_number":63,"context_line":"        cls: \"@?\","},{"line_number":64,"context_line":"        item: \"\u003d\""},{"line_number":65,"context_line":"      },"},{"line_number":66,"context_line":"      link: link,"}],"source_content_type":"text/javascript","patch_set":14,"id":"1aa78d24_ee6adfec","line":63,"in_reply_to":"1aa78d24_cd076516","updated":"2016-07-13 17:56:39.000000000","message":"Will do","commit_id":"4492d3ff0e3e978abc2c73409c1f03da08dc5a53"}],"horizon/static/framework/widgets/property/hz-resource-property-list.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f0cdab498caff946af414034628dca509843031b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"row\"\u003e"},{"line_number":2,"context_line":"  \u003cdiv ng-repeat\u003d\"propNames in propertyGroups\"\u003e"},{"line_number":3,"context_line":"    \u003cdl class\u003d\"col-md-{$ 12/propertyGroups.length $} {$ cls $}\"\u003e"},{"line_number":4,"context_line":"      \u003cdiv ng-repeat\u003d\"propName in propNames\"\u003e"},{"line_number":5,"context_line":"        \u003chz-resource-property"},{"line_number":6,"context_line":"          resource-type-name\u003d\"{$ resourceTypeName $}\""}],"source_content_type":"text/html","patch_set":9,"id":"1aa78d24_248f682b","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":52},"updated":"2016-07-06 00:06:48.000000000","message":"Seems we need an absolute max property groups mentioned in the docs.","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5d681200a3edc8ea65d3f0c5b643ada14ca94e51","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"row\"\u003e"},{"line_number":2,"context_line":"  \u003cdiv ng-repeat\u003d\"propNames in propertyGroups\"\u003e"},{"line_number":3,"context_line":"    \u003cdl class\u003d\"col-md-{$ 12/propertyGroups.length $} {$ cls $}\"\u003e"},{"line_number":4,"context_line":"      \u003cdiv ng-repeat\u003d\"propName in propNames\"\u003e"},{"line_number":5,"context_line":"        \u003chz-resource-property"},{"line_number":6,"context_line":"          resource-type-name\u003d\"{$ resourceTypeName $}\""}],"source_content_type":"text/html","patch_set":9,"id":"1aa78d24_9108732f","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":52},"in_reply_to":"1aa78d24_248f682b","updated":"2016-07-08 15:44:03.000000000","message":"I\u0027m changing this to use Math.floor() and mention any column grouping between 1 and 12 is OK, which is true when we use Math.floor().","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"}],"horizon/static/framework/widgets/property/hz-resource-property.controller.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f0cdab498caff946af414034628dca509843031b","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    // \u0027Public\u0027 Controller members"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    // \u0027config\u0027 is the configuration for how to output the field, and \u0027column.id\u0027"},{"line_number":33,"context_line":"    // is the property name itself."},{"line_number":34,"context_line":"    ctrl.config \u003d registry.getResourceType(ctrl.resourceTypeName).getProperties()[ctrl.propName];"},{"line_number":35,"context_line":"    ctrl.config.id \u003d ctrl.propName;"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_e46720b5","line":32,"range":{"start_line":32,"start_character":71,"end_line":32,"end_character":77},"updated":"2016-07-06 00:06:48.000000000","message":"config.id","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5d681200a3edc8ea65d3f0c5b643ada14ca94e51","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    // \u0027Public\u0027 Controller members"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    // \u0027config\u0027 is the configuration for how to output the field, and \u0027column.id\u0027"},{"line_number":33,"context_line":"    // is the property name itself."},{"line_number":34,"context_line":"    ctrl.config \u003d registry.getResourceType(ctrl.resourceTypeName).getProperties()[ctrl.propName];"},{"line_number":35,"context_line":"    ctrl.config.id \u003d ctrl.propName;"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_4c25d2ac","line":32,"range":{"start_line":32,"start_character":71,"end_line":32,"end_character":77},"in_reply_to":"1aa78d24_e46720b5","updated":"2016-07-08 15:44:03.000000000","message":"Done","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"34456d6ddc506a5824fc532914b10b24d75087e5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    // \u0027config\u0027 is the configuration for how to output the field, and \u0027config.id\u0027"},{"line_number":33,"context_line":"    // is the property name itself."},{"line_number":34,"context_line":"    ctrl.config \u003d registry.getResourceType(ctrl.resourceTypeName).getProperties()[ctrl.propName];"},{"line_number":35,"context_line":"    ctrl.config.id \u003d ctrl.propName;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""}],"source_content_type":"text/javascript","patch_set":14,"id":"1aa78d24_e2ffd031","line":35,"updated":"2016-07-12 20:11:30.000000000","message":"do we use ctrl.config.id anywhere?","commit_id":"4492d3ff0e3e978abc2c73409c1f03da08dc5a53"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"acbd37b67139c1c182cd298a870f17885fded4d1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    // \u0027config\u0027 is the configuration for how to output the field, and \u0027config.id\u0027"},{"line_number":33,"context_line":"    // is the property name itself."},{"line_number":34,"context_line":"    ctrl.config \u003d registry.getResourceType(ctrl.resourceTypeName).getProperties()[ctrl.propName];"},{"line_number":35,"context_line":"    ctrl.config.id \u003d ctrl.propName;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""}],"source_content_type":"text/javascript","patch_set":14,"id":"1aa78d24_4e4973b7","line":35,"in_reply_to":"1aa78d24_e2ffd031","updated":"2016-07-13 17:56:39.000000000","message":"Yes, config.id is the way in which we can find the name of the property.  The \u0027id\u0027 member is referenced in hz-field.","commit_id":"4492d3ff0e3e978abc2c73409c1f03da08dc5a53"}],"horizon/static/framework/widgets/property/hz-resource-property.directive.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f0cdab498caff946af414034628dca509843031b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.framework.widgets.property\u0027)"},{"line_number":21,"context_line":"    .directive(\u0027hzResourceProperty\u0027, directive);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  directive.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.framework.widgets.basePath\u0027"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_84e57cdd","line":21,"range":{"start_line":21,"start_character":37,"end_line":21,"end_character":46},"updated":"2016-07-06 00:06:48.000000000","message":"typically we have named the directive the same as its name.  I don\u0027t care too much on this, but this might be john papa - i\u0027m too rushed to check right now.","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5d681200a3edc8ea65d3f0c5b643ada14ca94e51","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.framework.widgets.property\u0027)"},{"line_number":21,"context_line":"    .directive(\u0027hzResourceProperty\u0027, directive);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  directive.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.framework.widgets.basePath\u0027"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_acd9d685","line":21,"range":{"start_line":21,"start_character":37,"end_line":21,"end_character":46},"in_reply_to":"1aa78d24_84e57cdd","updated":"2016-07-08 15:44:03.000000000","message":"Done","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f0cdab498caff946af414034628dca509843031b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  /**"},{"line_number":28,"context_line":"   * @ngdoc directive"},{"line_number":29,"context_line":"   * @name hzProperty"},{"line_number":30,"context_line":"   * @description"},{"line_number":31,"context_line":"   * This directive produces a label/value output of a property. It uses the"},{"line_number":32,"context_line":"   * resource type registry to look up the resource type by name, then outputs"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_e4bf20a8","line":29,"range":{"start_line":29,"start_character":11,"end_line":29,"end_character":21},"updated":"2016-07-06 00:06:48.000000000","message":"Wrong name.  Also add reference to registry here.","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5d681200a3edc8ea65d3f0c5b643ada14ca94e51","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  /**"},{"line_number":28,"context_line":"   * @ngdoc directive"},{"line_number":29,"context_line":"   * @name hzProperty"},{"line_number":30,"context_line":"   * @description"},{"line_number":31,"context_line":"   * This directive produces a label/value output of a property. It uses the"},{"line_number":32,"context_line":"   * resource type registry to look up the resource type by name, then outputs"}],"source_content_type":"text/javascript","patch_set":9,"id":"1aa78d24_0ce74a41","line":29,"range":{"start_line":29,"start_character":11,"end_line":29,"end_character":21},"in_reply_to":"1aa78d24_e4bf20a8","updated":"2016-07-08 15:44:03.000000000","message":"Done with the first request, but not I have an explicit reference to the resource type registry below.","commit_id":"8d796e513822a44db873de672923b3cc3fee4c48"}],"horizon/static/framework/widgets/table/hz-property-list.directive.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5a77de347b634e2665ccd807032460e93db2ff1c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  \u0027use strict\u0027;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.framework.widgets.table\u0027)"},{"line_number":21,"context_line":"    .directive(\u0027hzPropertyList\u0027, directive);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  directive.$inject \u003d ["}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_6e9f0f60","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":44},"updated":"2016-07-01 23:06:40.000000000","message":"Why is this bound to a table?","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6c22729a4732bbb80821f8dbd04916e04c9ec785","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  \u0027use strict\u0027;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.framework.widgets.table\u0027)"},{"line_number":21,"context_line":"    .directive(\u0027hzPropertyList\u0027, directive);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  directive.$inject \u003d ["}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_62eccd8f","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":44},"in_reply_to":"1aa78d24_6e9f0f60","updated":"2016-07-05 19:45:37.000000000","message":"Done","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"4d181c348480bc09b2686d32519e5c0fa19871c0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.framework.widgets.table\u0027)"},{"line_number":21,"context_line":"    .directive(\u0027hzPropertyList\u0027, directive);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  directive.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.framework.widgets.basePath\u0027"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_5148f45b","line":21,"range":{"start_line":21,"start_character":16,"end_line":21,"end_character":30},"updated":"2016-07-01 23:25:49.000000000","message":"Seeing this here, I\u0027m realizing that this is specific to resource type and should be named like the hz-resource-table and hz-resource-panel.  It should be hz-resource-property-list.","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6c22729a4732bbb80821f8dbd04916e04c9ec785","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.framework.widgets.table\u0027)"},{"line_number":21,"context_line":"    .directive(\u0027hzPropertyList\u0027, directive);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  directive.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.framework.widgets.basePath\u0027"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_457a7bf2","line":21,"range":{"start_line":21,"start_character":16,"end_line":21,"end_character":30},"in_reply_to":"1aa78d24_5148f45b","updated":"2016-07-05 19:45:37.000000000","message":"Done","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"da9b0590621d4731f046d01206d099363cf7fad3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":58,"context_line":"      scope: {"},{"line_number":59,"context_line":"        resourceTypeName: \"@\","},{"line_number":60,"context_line":"        propertyGroups: \"\u003d\","},{"line_number":61,"context_line":"        item: \"\u003d\""},{"line_number":62,"context_line":"      },"},{"line_number":63,"context_line":"      templateUrl: basePath + \u0027table/hz-property-list.html\u0027"}],"source_content_type":"text/javascript","patch_set":7,"id":"3aaa91ec_ac60d8a5","line":60,"updated":"2016-07-01 16:26:40.000000000","message":"suggest \u0027cls\u0027 or some sort of class for the dl so we can specify \u0027dl-horizontal\u0027 if we like.","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6c22729a4732bbb80821f8dbd04916e04c9ec785","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":58,"context_line":"      scope: {"},{"line_number":59,"context_line":"        resourceTypeName: \"@\","},{"line_number":60,"context_line":"        propertyGroups: \"\u003d\","},{"line_number":61,"context_line":"        item: \"\u003d\""},{"line_number":62,"context_line":"      },"},{"line_number":63,"context_line":"      templateUrl: basePath + \u0027table/hz-property-list.html\u0027"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_257dafe7","line":60,"in_reply_to":"3aaa91ec_ac60d8a5","updated":"2016-07-05 19:45:37.000000000","message":"Done","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"}],"horizon/static/framework/widgets/table/hz-property-list.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5496a8caac547833a3f292652d5c037829076ae1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"row\"\u003e"},{"line_number":2,"context_line":"  \u003cdiv ng-repeat\u003d\"propNames in propertyGroups\"\u003e"},{"line_number":3,"context_line":"    \u003cdl class\u003d\"col-md-{$ 12/propertyGroups.length $}\"\u003e"},{"line_number":4,"context_line":"      \u003cdiv ng-repeat\u003d\"propName in propNames\"\u003e"},{"line_number":5,"context_line":"        \u003chz-property"},{"line_number":6,"context_line":"          resource-type-name\u003d\"{$ resourceTypeName $}\""}],"source_content_type":"text/html","patch_set":3,"id":"3aaa91ec_3691839b","line":3,"range":{"start_line":3,"start_character":28,"end_line":3,"end_character":49},"updated":"2016-06-28 18:51:21.000000000","message":"I know, 5 doesn\u0027t work :)  I\u0027ll add a floor() in there just to be safe.","commit_id":"a91b9a71bcce59db662fe4b29dda95ad71555aec"}],"horizon/static/framework/widgets/table/hz-property.controller.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"eeec0d9eb81792301d1b3904f233cd04f52f27c9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    var ctrl \u003d this;"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    // \u0027Public\u0027 Controller members"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    ctrl.column \u003d registry.getResourceType(ctrl.resourceTypeName).getProperties()[ctrl.propName];"},{"line_number":33,"context_line":"    ctrl.column.id \u003d ctrl.propName;"},{"line_number":34,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_e057bfc7","line":31,"updated":"2016-06-24 20:39:00.000000000","message":"in comments, explain why we need a \u0027column\u0027 and \u0027column.id\u0027","commit_id":"8adba97cfb20643cf01c47787217d4d3e99de269"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5a77de347b634e2665ccd807032460e93db2ff1c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  \u0027use strict\u0027;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.framework.widgets.table\u0027)"},{"line_number":21,"context_line":"    .controller(\u0027horizon.framework.widgets.table.hzPropertyController\u0027, controller);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  controller.$inject \u003d ["}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_2e7ce71f","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":44},"updated":"2016-07-01 23:06:40.000000000","message":"I feel like either this needs to become hz-table-property or this needs to be in its own module and not so tightly coupled with tables.","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6c22729a4732bbb80821f8dbd04916e04c9ec785","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  \u0027use strict\u0027;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.framework.widgets.table\u0027)"},{"line_number":21,"context_line":"    .controller(\u0027horizon.framework.widgets.table.hzPropertyController\u0027, controller);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  controller.$inject \u003d ["}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_6587b7d7","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":44},"in_reply_to":"1aa78d24_2e7ce71f","updated":"2016-07-05 19:45:37.000000000","message":"Done","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"}],"horizon/static/framework/widgets/table/hz-property.directive.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"eeec0d9eb81792301d1b3904f233cd04f52f27c9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  /**"},{"line_number":30,"context_line":"   * @ngdoc directive"},{"line_number":31,"context_line":"   * @name hzProperty"},{"line_number":32,"context_line":"   * @description"},{"line_number":33,"context_line":"   * @example"},{"line_number":34,"context_line":"   *"},{"line_number":35,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_4067b3b6","line":32,"updated":"2016-06-24 20:39:00.000000000","message":"description","commit_id":"8adba97cfb20643cf01c47787217d4d3e99de269"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"eeec0d9eb81792301d1b3904f233cd04f52f27c9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      },"},{"line_number":52,"context_line":"      bindToController: true,"},{"line_number":53,"context_line":"      controller: \u0027horizon.framework.widgets.table.hzPropertyController as ctrl\u0027,"},{"line_number":54,"context_line":"      template: \"\u003cdt\u003e{$ ctrl.column.label $}\u003c/dt\u003e\u003cdd\u003e\u003chz-cell column\u003d\u0027ctrl.column\u0027 item\u003d\u0027ctrl.item\u0027\u003e\u003c/hz-cell\u003e\u003c/dd\u003e\""},{"line_number":55,"context_line":"    };"},{"line_number":56,"context_line":"    return directiveConf;"},{"line_number":57,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_00712b76","line":54,"updated":"2016-06-24 20:39:00.000000000","message":"Make into a real template.","commit_id":"8adba97cfb20643cf01c47787217d4d3e99de269"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"4d181c348480bc09b2686d32519e5c0fa19871c0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.framework.widgets.table\u0027)"},{"line_number":21,"context_line":"    .directive(\u0027hzProperty\u0027, directive);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  directive.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.framework.widgets.basePath\u0027"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_b17318b4","line":21,"range":{"start_line":21,"start_character":16,"end_line":21,"end_character":26},"updated":"2016-07-01 23:25:49.000000000","message":"Seeing this here, I\u0027m realizing that this is specific to resource type and should be named like the hz-resource-table and hz-resource-panel.  It should be hz-resource-property.","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6c22729a4732bbb80821f8dbd04916e04c9ec785","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.framework.widgets.table\u0027)"},{"line_number":21,"context_line":"    .directive(\u0027hzProperty\u0027, directive);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  directive.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.framework.widgets.basePath\u0027"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_057993f6","line":21,"range":{"start_line":21,"start_character":16,"end_line":21,"end_character":26},"in_reply_to":"1aa78d24_b17318b4","updated":"2016-07-05 19:45:37.000000000","message":"Done","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"}],"horizon/static/framework/widgets/table/hz-property.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5a77de347b634e2665ccd807032460e93db2ff1c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdt\u003e{$ ctrl.column.label $}\u003c/dt\u003e"},{"line_number":2,"context_line":"\u003cdd\u003e"},{"line_number":3,"context_line":"  \u003chz-field column\u003d\u0027ctrl.column\u0027 item\u003d\u0027ctrl.item\u0027\u003e\u003c/hz-field\u003e"},{"line_number":4,"context_line":"\u003c/dd\u003e"},{"line_number":5,"context_line":""}],"source_content_type":"text/html","patch_set":7,"id":"1aa78d24_4eee93ed","line":3,"updated":"2016-07-01 23:06:40.000000000","message":"I feel like this is coupled to tables when it doesn\u0027t need to be.","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6c22729a4732bbb80821f8dbd04916e04c9ec785","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdt\u003e{$ ctrl.column.label $}\u003c/dt\u003e"},{"line_number":2,"context_line":"\u003cdd\u003e"},{"line_number":3,"context_line":"  \u003chz-field column\u003d\u0027ctrl.column\u0027 item\u003d\u0027ctrl.item\u0027\u003e\u003c/hz-field\u003e"},{"line_number":4,"context_line":"\u003c/dd\u003e"},{"line_number":5,"context_line":""}],"source_content_type":"text/html","patch_set":7,"id":"1aa78d24_4561db38","line":3,"in_reply_to":"1aa78d24_4eee93ed","updated":"2016-07-05 19:45:37.000000000","message":"Yep, updated.","commit_id":"efde8d1002316a4e2966fdbed2c1667f97c7baea"}]}