)]}'
{"openstack_dashboard/static/app/core/images/details/drawer.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"b46397a239e8b57a4bb023edf63b477fb11a69b5","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  \u003cdiv class\u003d\"row\"\u003e"},{"line_number":23,"context_line":"    \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":24,"context_line":"      \u003cdt translate\u003eMin. Disk\u003c/dt\u003e"},{"line_number":25,"context_line":"      \u003cdd\u003e{$ item.min_disk | gb | noValue $}\u003c/dd\u003e"},{"line_number":26,"context_line":"    \u003c/dl\u003e"},{"line_number":27,"context_line":"    \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":28,"context_line":"      \u003cdt translate\u003eMin. RAM\u003c/dt\u003e"},{"line_number":29,"context_line":"      \u003cdd\u003e{$ item.min_ram | mb | noValue $}\u003c/dd\u003e"},{"line_number":30,"context_line":"    \u003c/dl\u003e"},{"line_number":31,"context_line":"  \u003c/div\u003e"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  \u003cdiv class\u003d\"row\" ng-if\u003d\"drawerCtrl.metadataDefs \u0026\u0026 item.properties\"\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"3aaa91ec_c56f35fa","line":30,"range":{"start_line":24,"start_character":0,"end_line":30,"end_character":9},"updated":"2016-06-24 20:25:42.000000000","message":"Do these guys too!","commit_id":"0dab1075df8bd78ac7f5ac31fdfa6d21fd934b94"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"29d4a1f53b7b5be29f56b29db684ea2d79ce5929","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"horizon.app.core.images.DrawerController as drawerCtrl\"\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \u003chz-property-list"},{"line_number":4,"context_line":"    resource-type-name\u003d\"OS::Glance::Image\""},{"line_number":5,"context_line":"    item\u003d\"item\""},{"line_number":6,"context_line":"    property-groups\u003d\"["}],"source_content_type":"text/html","patch_set":6,"id":"1aa78d24_aebbb774","line":3,"updated":"2016-07-01 23:25:02.000000000","message":"Seeing this here, I\u0027m realizing that this is specific to resource type and should be named like the hz-resource-table and hz-resource-panel.  It should be hz-resource-property-list.","commit_id":"74357c0a2dd583cf025f1756dd21bfa707f3cc49"}],"openstack_dashboard/static/app/core/images/details/overview.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"77c80d71dccb358f8674d6f9bd045065f8d85d0d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        resource-type-name\u003d\"OS::Glance::Image\""},{"line_number":8,"context_line":"        cls\u003d\"dl-horizontal\""},{"line_number":9,"context_line":"        item\u003d\"ctrl.image\""},{"line_number":10,"context_line":"        property-groups\u003d\"[[\u0027type\u0027, \u0027status\u0027, \u0027size\u0027, \u0027min_disk\u0027, \u0027min_ram\u0027, \u0027disk_format\u0027, \u0027container_format\u0027]]\"\u003e\u003c/hz-resource-property-list\u003e"},{"line_number":11,"context_line":"      \u003c/dl\u003e"},{"line_number":12,"context_line":"    \u003c/div\u003e"},{"line_number":13,"context_line":"    \u003cdiv class\u003d\"col-md-6 detail\"\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"1aa78d24_04198c22","line":10,"range":{"start_line":10,"start_character":113,"end_line":10,"end_character":141},"updated":"2016-07-05 23:59:06.000000000","message":"nit: line wrap, plz","commit_id":"b08a9e57d7f3eea41367d14a8d558eb3ff03513a"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"2ec20944578e8d756127a59f66e56845af64ff13","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        resource-type-name\u003d\"OS::Glance::Image\""},{"line_number":8,"context_line":"        cls\u003d\"dl-horizontal\""},{"line_number":9,"context_line":"        item\u003d\"ctrl.image\""},{"line_number":10,"context_line":"        property-groups\u003d\"[[\u0027type\u0027, \u0027status\u0027, \u0027size\u0027, \u0027min_disk\u0027, \u0027min_ram\u0027, \u0027disk_format\u0027, \u0027container_format\u0027]]\"\u003e\u003c/hz-resource-property-list\u003e"},{"line_number":11,"context_line":"      \u003c/dl\u003e"},{"line_number":12,"context_line":"    \u003c/div\u003e"},{"line_number":13,"context_line":"    \u003cdiv class\u003d\"col-md-6 detail\"\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"1aa78d24_b2c66466","line":10,"updated":"2016-07-14 03:09:57.000000000","message":"\u003c/hz-resource-property-list\u003e  in another line will be more readable","commit_id":"81742c87ea574722af28693745e23135f053cdd8"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d4fbe7ea1aabe80e88f52e424a5ff2b7bd174d9e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        resource-type-name\u003d\"OS::Glance::Image\""},{"line_number":8,"context_line":"        cls\u003d\"dl-horizontal\""},{"line_number":9,"context_line":"        item\u003d\"ctrl.image\""},{"line_number":10,"context_line":"        property-groups\u003d\"[[\u0027type\u0027, \u0027status\u0027, \u0027size\u0027, \u0027min_disk\u0027, \u0027min_ram\u0027, \u0027disk_format\u0027, \u0027container_format\u0027]]\"\u003e\u003c/hz-resource-property-list\u003e"},{"line_number":11,"context_line":"      \u003c/dl\u003e"},{"line_number":12,"context_line":"    \u003c/div\u003e"},{"line_number":13,"context_line":"    \u003cdiv class\u003d\"col-md-6 detail\"\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"1aa78d24_8525b10b","line":10,"in_reply_to":"1aa78d24_b2c66466","updated":"2016-07-14 23:50:02.000000000","message":"Good point!","commit_id":"81742c87ea574722af28693745e23135f053cdd8"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"2ec20944578e8d756127a59f66e56845af64ff13","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        cls\u003d\"dl-horizontal\""},{"line_number":9,"context_line":"        item\u003d\"ctrl.image\""},{"line_number":10,"context_line":"        property-groups\u003d\"[[\u0027type\u0027, \u0027status\u0027, \u0027size\u0027, \u0027min_disk\u0027, \u0027min_ram\u0027, \u0027disk_format\u0027, \u0027container_format\u0027]]\"\u003e\u003c/hz-resource-property-list\u003e"},{"line_number":11,"context_line":"      \u003c/dl\u003e"},{"line_number":12,"context_line":"    \u003c/div\u003e"},{"line_number":13,"context_line":"    \u003cdiv class\u003d\"col-md-6 detail\"\u003e"},{"line_number":14,"context_line":"      \u003ch3\u003e{$ \u0027Security\u0027 | translate $}\u003c/h3\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"1aa78d24_32b27407","line":11,"updated":"2016-07-14 03:09:57.000000000","message":"remove this line","commit_id":"81742c87ea574722af28693745e23135f053cdd8"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d4fbe7ea1aabe80e88f52e424a5ff2b7bd174d9e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        cls\u003d\"dl-horizontal\""},{"line_number":9,"context_line":"        item\u003d\"ctrl.image\""},{"line_number":10,"context_line":"        property-groups\u003d\"[[\u0027type\u0027, \u0027status\u0027, \u0027size\u0027, \u0027min_disk\u0027, \u0027min_ram\u0027, \u0027disk_format\u0027, \u0027container_format\u0027]]\"\u003e\u003c/hz-resource-property-list\u003e"},{"line_number":11,"context_line":"      \u003c/dl\u003e"},{"line_number":12,"context_line":"    \u003c/div\u003e"},{"line_number":13,"context_line":"    \u003cdiv class\u003d\"col-md-6 detail\"\u003e"},{"line_number":14,"context_line":"      \u003ch3\u003e{$ \u0027Security\u0027 | translate $}\u003c/h3\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"1aa78d24_652085f9","line":11,"in_reply_to":"1aa78d24_32b27407","updated":"2016-07-14 23:50:02.000000000","message":"Thanks!  yes","commit_id":"81742c87ea574722af28693745e23135f053cdd8"}],"openstack_dashboard/static/app/core/images/images.module.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"29d4a1f53b7b5be29f56b29db684ea2d79ce5929","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      })"},{"line_number":73,"context_line":"      .setProperty(\u0027type\u0027, {"},{"line_number":74,"context_line":"        label: gettext(\u0027Type\u0027),"},{"line_number":75,"context_line":"        filters: [imageType]"},{"line_number":76,"context_line":"      })"},{"line_number":77,"context_line":"      .setProperty(\u0027members\u0027, {"},{"line_number":78,"context_line":"        label: gettext(\u0027Members\u0027)"}],"source_content_type":"text/javascript","patch_set":6,"id":"1aa78d24_6e770f03","line":75,"updated":"2016-07-01 23:25:02.000000000","message":"All my comments that follow are wishy-washy... just contemplating since this patch is still WIP.\n\nWhy get rid of the real filter and replace with a function only accessible here? Why can\u0027t it be used here?  I\u0027m on the fence about this. On the one hand, it will guide people to just use the registered type, on the other hand, now the filter is not usable via injection.","commit_id":"74357c0a2dd583cf025f1756dd21bfa707f3cc49"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"29d4a1f53b7b5be29f56b29db684ea2d79ce5929","unresolved":false,"context_lines":[{"line_number":105,"context_line":"          \u0027queued\u0027: gettext(\u0027Queued\u0027),"},{"line_number":106,"context_line":"          \u0027pending_delete\u0027: gettext(\u0027Pending Delete\u0027),"},{"line_number":107,"context_line":"          \u0027killed\u0027: gettext(\u0027Killed\u0027),"},{"line_number":108,"context_line":"          \u0027deleted\u0027: gettext(\u0027Deleted\u0027)"},{"line_number":109,"context_line":"        }"},{"line_number":110,"context_line":"      })"},{"line_number":111,"context_line":"      .setProperty(\u0027tags\u0027, {"}],"source_content_type":"text/javascript","patch_set":6,"id":"1aa78d24_91037c0d","line":108,"updated":"2016-07-01 23:25:02.000000000","message":"Didn\u0027t test, but does the usage of this fall through and return the input value if there isn\u0027t a match in the values? Or does this need to be a value function?","commit_id":"74357c0a2dd583cf025f1756dd21bfa707f3cc49"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"b80a70639b08cf0f32444ea16d1125bde2f53c8a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"          \u0027queued\u0027: gettext(\u0027Queued\u0027),"},{"line_number":107,"context_line":"          \u0027pending_delete\u0027: gettext(\u0027Pending Delete\u0027),"},{"line_number":108,"context_line":"          \u0027killed\u0027: gettext(\u0027Killed\u0027),"},{"line_number":109,"context_line":"          \u0027deleted\u0027: gettext(\u0027Deleted\u0027)"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"      })"},{"line_number":112,"context_line":"      .setProperty(\u0027tags\u0027, {"}],"source_content_type":"text/javascript","patch_set":14,"id":"dada55a8_d4ea6173","line":109,"updated":"2016-07-20 18:05:22.000000000","message":"can we add this to images.module.js as a constant?","commit_id":"4e95b1e31815413152e9ffa76231b7c0fc600b38"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"2034d9bfeb20130a6faf30386d32a1350343a2e7","unresolved":false,"context_lines":[{"line_number":106,"context_line":"          \u0027queued\u0027: gettext(\u0027Queued\u0027),"},{"line_number":107,"context_line":"          \u0027pending_delete\u0027: gettext(\u0027Pending Delete\u0027),"},{"line_number":108,"context_line":"          \u0027killed\u0027: gettext(\u0027Killed\u0027),"},{"line_number":109,"context_line":"          \u0027deleted\u0027: gettext(\u0027Deleted\u0027)"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"      })"},{"line_number":112,"context_line":"      .setProperty(\u0027tags\u0027, {"}],"source_content_type":"text/javascript","patch_set":14,"id":"dada55a8_ed7074a6","line":109,"in_reply_to":"dada55a8_d4ea6173","updated":"2016-07-20 19:02:39.000000000","message":"Sure!","commit_id":"4e95b1e31815413152e9ffa76231b7c0fc600b38"}],"openstack_dashboard/static/app/core/images/images.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ed65e367253b6a1810b29a9bcd77518217e57e69","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      urlFunction: urlFunction"},{"line_number":31,"context_line":"    };"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    function urlFunction(item) {"},{"line_number":34,"context_line":"      return \u0027project/ngdetails/OS::Glance::Image/\u0027 + item.id;"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""}],"source_content_type":"text/javascript","patch_set":13,"id":"dada55a8_32825f95","line":33,"updated":"2016-07-18 22:56:26.000000000","message":"(in the voice of new developer).  Why is there a \"urlFunction\"? Why does a function include the word function in its name?\n\nProbably should just get getUrl or url. \n\nAnd the input needs to be documented as being and an image object whose id is an image.","commit_id":"ee057ebb71f896a1c431b855bd6461138d828e5c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"0e3d0ae9b0e504c16a0e5b1a9ae6fd1891765058","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      urlFunction: urlFunction"},{"line_number":31,"context_line":"    };"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    function urlFunction(item) {"},{"line_number":34,"context_line":"      return \u0027project/ngdetails/OS::Glance::Image/\u0027 + item.id;"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""}],"source_content_type":"text/javascript","patch_set":13,"id":"dada55a8_d3276062","line":33,"in_reply_to":"dada55a8_305232de","updated":"2016-07-19 15:17:31.000000000","message":"Added docs and renamed to getDetailsPath.","commit_id":"ee057ebb71f896a1c431b855bd6461138d828e5c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"35d70a19f6a21cd38b1a7db54947e76394c63de5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      urlFunction: urlFunction"},{"line_number":31,"context_line":"    };"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    function urlFunction(item) {"},{"line_number":34,"context_line":"      return \u0027project/ngdetails/OS::Glance::Image/\u0027 + item.id;"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""}],"source_content_type":"text/javascript","patch_set":13,"id":"dada55a8_305232de","line":33,"in_reply_to":"dada55a8_32825f95","updated":"2016-07-19 14:55:50.000000000","message":"Sure!  I\u0027ll put in more docs for this whole new file.","commit_id":"ee057ebb71f896a1c431b855bd6461138d828e5c"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ed65e367253b6a1810b29a9bcd77518217e57e69","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      return \u0027project/ngdetails/OS::Glance::Image/\u0027 + item.id;"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    function imageType(input) {"},{"line_number":38,"context_line":"      if (null !\u003d\u003d input \u0026\u0026"},{"line_number":39,"context_line":"        angular.isDefined(input) \u0026\u0026"},{"line_number":40,"context_line":"        angular.isDefined(input.properties) \u0026\u0026"}],"source_content_type":"text/javascript","patch_set":13,"id":"dada55a8_72ee978c","line":37,"updated":"2016-07-18 22:56:26.000000000","message":"No docs. Please provide the docs from the code you deleted (or better).\n\nhttps://review.openstack.org/#/c/334083/13/openstack_dashboard/static/app/core/images/filters/image-type.filter.js","commit_id":"ee057ebb71f896a1c431b855bd6461138d828e5c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"0e3d0ae9b0e504c16a0e5b1a9ae6fd1891765058","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      return \u0027project/ngdetails/OS::Glance::Image/\u0027 + item.id;"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    function imageType(input) {"},{"line_number":38,"context_line":"      if (null !\u003d\u003d input \u0026\u0026"},{"line_number":39,"context_line":"        angular.isDefined(input) \u0026\u0026"},{"line_number":40,"context_line":"        angular.isDefined(input.properties) \u0026\u0026"}],"source_content_type":"text/javascript","patch_set":13,"id":"dada55a8_531c1012","line":37,"in_reply_to":"dada55a8_72ee978c","updated":"2016-07-19 15:17:31.000000000","message":"Added the documentation, using verbiage specific to this implementation.","commit_id":"ee057ebb71f896a1c431b855bd6461138d828e5c"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ed65e367253b6a1810b29a9bcd77518217e57e69","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return gettext(\u0027Image\u0027);"},{"line_number":45,"context_line":"      }"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    function listFunction(params) {"},{"line_number":49,"context_line":"      return glance.getImages(params).then(modifyResponse);"},{"line_number":50,"context_line":""}],"source_content_type":"text/javascript","patch_set":13,"id":"dada55a8_f25e0744","line":47,"updated":"2016-07-18 22:56:26.000000000","message":"This now can create some confusion about whether I should inject this images service or inject the api service. This needs some documentation explaining why and when to use it.  Also, why does a function include \"function\" in its name.","commit_id":"ee057ebb71f896a1c431b855bd6461138d828e5c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"0e3d0ae9b0e504c16a0e5b1a9ae6fd1891765058","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return gettext(\u0027Image\u0027);"},{"line_number":45,"context_line":"      }"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    function listFunction(params) {"},{"line_number":49,"context_line":"      return glance.getImages(params).then(modifyResponse);"},{"line_number":50,"context_line":""}],"source_content_type":"text/javascript","patch_set":13,"id":"dada55a8_b33f4cd5","line":47,"in_reply_to":"dada55a8_f25e0744","updated":"2016-07-19 15:17:31.000000000","message":"Added docs and renamed to getImagesPromise.","commit_id":"ee057ebb71f896a1c431b855bd6461138d828e5c"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"b80a70639b08cf0f32444ea16d1125bde2f53c8a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    return {"},{"line_number":38,"context_line":"      getImagesPromise: getImagesPromise,"},{"line_number":39,"context_line":"      imageType: imageType,"},{"line_number":40,"context_line":"      getDetailsPath: getDetailsPath"},{"line_number":41,"context_line":"    };"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    /*"}],"source_content_type":"text/javascript","patch_set":14,"id":"dada55a8_344dbd3e","line":40,"updated":"2016-07-20 18:05:22.000000000","message":"alphabetize here and below pls","commit_id":"4e95b1e31815413152e9ffa76231b7c0fc600b38"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"2034d9bfeb20130a6faf30386d32a1350343a2e7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    return {"},{"line_number":38,"context_line":"      getImagesPromise: getImagesPromise,"},{"line_number":39,"context_line":"      imageType: imageType,"},{"line_number":40,"context_line":"      getDetailsPath: getDetailsPath"},{"line_number":41,"context_line":"    };"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    /*"}],"source_content_type":"text/javascript","patch_set":14,"id":"dada55a8_cd9c90c2","line":40,"in_reply_to":"dada55a8_344dbd3e","updated":"2016-07-20 19:02:39.000000000","message":"OK","commit_id":"4e95b1e31815413152e9ffa76231b7c0fc600b38"}]}
