)]}'
{"openstack_dashboard/api/network.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"57e880c51bf6e6938056e086f4b162718ae04a7e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"different dashboard implementations."},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from horizon.utils.memoized import memoized  # noqa"},{"line_number":23,"context_line":"from openstack_dashboard.api import base"},{"line_number":24,"context_line":"from openstack_dashboard.api import neutron"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_21d8f078","line":22,"range":{"start_line":22,"start_character":43,"end_line":22,"end_character":51},"updated":"2017-05-24 03:06:09.000000000","message":"unnecessary now","commit_id":"746da5fbfa8fb22bef6127b587a50cede73b1f6b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"6e169296f82dbee72c3f028523ac09eb1fb55206","unresolved":false,"context_lines":[{"line_number":19,"context_line":"different dashboard implementations."},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from horizon.utils.memoized import memoized  # noqa"},{"line_number":23,"context_line":"from openstack_dashboard.api import base"},{"line_number":24,"context_line":"from openstack_dashboard.api import neutron"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_2d457e70","line":22,"range":{"start_line":22,"start_character":43,"end_line":22,"end_character":51},"in_reply_to":"ff0f0b1f_21d8f078","updated":"2017-05-24 08:28:53.000000000","message":"Done","commit_id":"746da5fbfa8fb22bef6127b587a50cede73b1f6b"}],"openstack_dashboard/api/neutron.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e6b1ba79f0be3db0b978b3df432225f5c1e20f9","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        # We consider only the filter condition from (filter_attr,"},{"line_number":607,"context_line":"        # filter_values) and do not consider other filter conditions"},{"line_number":608,"context_line":"        # which may be specified in **params."},{"line_number":609,"context_line":"        if not hasattr(filter_values, \u0027__iter__\u0027):"},{"line_number":610,"context_line":"            filter_values \u003d [filter_values]"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        # Length of each query filter is:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ff52f3f_598283ca","line":609,"updated":"2017-04-13 04:03:19.000000000","message":"Hmm... I think this check is too loose. list has __iter__, but \u0027set\u0027, \u0027tuple\u0027 and \u0027dict\u0027 have __iter__. dict is not expected here.\n\nCannot isinstance be used?","commit_id":"91086b061b7b30d7f94fa3f4fc5001e056877617"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e6b1ba79f0be3db0b978b3df432225f5c1e20f9","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"    try:"},{"line_number":1181,"context_line":"        ports \u003d list_resources_with_long_filters("},{"line_number":1182,"context_line":"            port_list, \u0027device_id\u0027,"},{"line_number":1183,"context_line":"            tuple([instance.id for instance in servers]),"},{"line_number":1184,"context_line":"            request\u003drequest)"},{"line_number":1185,"context_line":"        fips \u003d FloatingIpManager(request)"},{"line_number":1186,"context_line":"        if fips.is_supported():"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ff52f3f_19551b51","line":1183,"range":{"start_line":1183,"start_character":12,"end_line":1183,"end_character":17},"updated":"2017-04-13 04:03:19.000000000","message":"Could you describe why tuple is required? Is this required to make @memoized work?\n\nThe commit should describe why. This kind of background of the change should be documented so that developers can check the reason.","commit_id":"91086b061b7b30d7f94fa3f4fc5001e056877617"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e6b1ba79f0be3db0b978b3df432225f5c1e20f9","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"        else:"},{"line_number":1191,"context_line":"            floating_ips \u003d []"},{"line_number":1192,"context_line":"        networks \u003d list_resources_with_long_filters("},{"line_number":1193,"context_line":"            network_list, \u0027id\u0027, frozenset([port.network_id for port in ports]),"},{"line_number":1194,"context_line":"            request\u003drequest)"},{"line_number":1195,"context_line":"    except Exception:"},{"line_number":1196,"context_line":"        error_message \u003d _(\u0027Unable to connect to Neutron.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ff52f3f_b94bcfae","line":1193,"range":{"start_line":1193,"start_character":32,"end_line":1193,"end_character":41},"updated":"2017-04-13 04:03:19.000000000","message":"Same as above.\n\nTuple is used above and fronzenset is used here. Why?","commit_id":"91086b061b7b30d7f94fa3f4fc5001e056877617"}]}
