)]}'
{"horizon/tables/actions.py":[{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f4ac09c85744551a2d416086ce9c5d4f6b469784","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        for the template to render."},{"line_number":533,"context_line":"        \"\"\""},{"line_number":534,"context_line":"        if self.filter_choices:"},{"line_number":535,"context_line":"            return [x[:4] for x in self.filter_choices if x[2] is True]"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"class NameFilterAction(FilterAction):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_69d198cd","line":535,"updated":"2016-08-19 22:04:51.000000000","message":"I know this is not part of the new code but I would rename \u0027x\u0027 to something more meaningful like \u0027choice\u0027. Also can we add a comment before the return to explain what does the indexes mean?","commit_id":"1cc971dee61f8f19978555ad3f64159daa4a0323"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"29c4edff180cd33aab15bd2654a6c38b9a497304","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        return False"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    def get_select_options(self):"},{"line_number":531,"context_line":"        \"\"\"Provide the value, string, and help_text (if applicable)"},{"line_number":532,"context_line":"        for the template to render."},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        If choice[2] is false then this option is not shown to the user."}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_e89e2906","line":531,"updated":"2016-12-08 23:59:46.000000000","message":"can you add this 4th attribute here; just referencing the array makes it confusing for future developers as to what is going on here.\n\n\"\"\"Provide the value, string, boolean to toggle an option, and help_text (if applicable) for the template to render.","commit_id":"97e8837d0f0eca71b6536bd22f7177f848543e86"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"80c45594dd34b91c1c11c6f823c6a0c07f9c5604","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        return False"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    def get_select_options(self):"},{"line_number":531,"context_line":"        \"\"\"Provide the value, string, and help_text (if applicable)"},{"line_number":532,"context_line":"        for the template to render."},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        If choice[2] is false then this option is not shown to the user."}],"source_content_type":"text/x-python","patch_set":13,"id":"5ff73747_750d438f","line":531,"in_reply_to":"3a71b18c_e89e2906","updated":"2017-04-23 22:11:41.000000000","message":"Updated the class docstring to cover it.","commit_id":"97e8837d0f0eca71b6536bd22f7177f848543e86"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"29c4edff180cd33aab15bd2654a6c38b9a497304","unresolved":false,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        If choice[2] is false then this option is not shown to the user."},{"line_number":535,"context_line":"        The condition is needed in case you want to enable/disable certain"},{"line_number":536,"context_line":"        options depending on your settings options or needs."},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        if self.filter_choices:"},{"line_number":539,"context_line":"            return [choice[:4] for choice in self.filter_choices if choice[2]]"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_e8b5497e","line":536,"updated":"2016-12-08 23:59:46.000000000","message":"clarify that it doesn\u0027t need to be a setting, just any function that returns a boolean\n\nThe function that returns a boolean is needed in case you want to enable/disable certain options depending on your needs (for example, show the option when a certain setting is enabled).","commit_id":"97e8837d0f0eca71b6536bd22f7177f848543e86"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"80c45594dd34b91c1c11c6f823c6a0c07f9c5604","unresolved":false,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        If choice[2] is false then this option is not shown to the user."},{"line_number":535,"context_line":"        The condition is needed in case you want to enable/disable certain"},{"line_number":536,"context_line":"        options depending on your settings options or needs."},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        if self.filter_choices:"},{"line_number":539,"context_line":"            return [choice[:4] for choice in self.filter_choices if choice[2]]"}],"source_content_type":"text/x-python","patch_set":13,"id":"5ff73747_95bc4fbc","line":536,"in_reply_to":"3a71b18c_e8b5497e","updated":"2017-04-23 22:11:41.000000000","message":"IMHO there is no need to add L.533-536.\n\nDescription of the third value in the class docstring is updated too.","commit_id":"97e8837d0f0eca71b6536bd22f7177f848543e86"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"57a577dd45be3cbc0fffd24422ae5142105cc959","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        options depending on your settings options or needs."},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        if self.filter_choices:"},{"line_number":539,"context_line":"            return [choice[:4] for choice in self.filter_choices if choice[2]]"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"class NameFilterAction(FilterAction):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5ff73747_f575d3fb","line":539,"range":{"start_line":539,"start_character":68,"end_line":539,"end_character":77},"updated":"2017-04-23 22:37:31.000000000","message":"After checking the current code, choice[2] is used to determine the field  should be specified as query parameter if the filter type is \u0027server\u0027. I wonder this fix is correct or not..... needs more thought.","commit_id":"97e8837d0f0eca71b6536bd22f7177f848543e86"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"807bf6cabc7da6a697d0b5ce84c9a3d7bbcd5d5b","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        options depending on your settings options or needs."},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        if self.filter_choices:"},{"line_number":539,"context_line":"            return [choice[:4] for choice in self.filter_choices if choice[2]]"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"class NameFilterAction(FilterAction):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5ff73747_55eec788","line":539,"range":{"start_line":539,"start_character":68,"end_line":539,"end_character":77},"in_reply_to":"5ff73747_f575d3fb","updated":"2017-04-23 22:49:14.000000000","message":"The third parameter (choice[2]) has a different meaning. If a back-end service API does not support filtering by some field but we would like to support it in horizon, choice[2] does the role. In such field, choice[2] should be False but the filter choice still needs to be displayed. This is the original intention of the usage of choice[2]. This change breaks this usage. I think you need to add the fifth parameter (or generate a list dynamically).","commit_id":"97e8837d0f0eca71b6536bd22f7177f848543e86"}],"openstack_dashboard/dashboards/project/instances/tables.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"7cf2551f6508f1b912538fd27d4333a0d356feba","unresolved":false,"context_lines":[{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"def is_ipv6_enabled():"},{"line_number":1154,"context_line":"    return getattr(settings, \u0027OPENSTACK_NEUTRON_NETWORK\u0027, {})\\"},{"line_number":1155,"context_line":"        .get(\u0027enable_ipv6\u0027, False)"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"INSTANCE_FILTER_CHOICES \u003d ("},{"line_number":1158,"context_line":"    (\u0027uuid\u0027, _(\"Instance ID\"), True),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_d3bbf173","line":1155,"updated":"2016-06-28 18:48:22.000000000","message":"default is True in this case\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L267","commit_id":"e27b1f55641d8da7a91598346da9aa80ec228b81"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"80c45594dd34b91c1c11c6f823c6a0c07f9c5604","unresolved":false,"context_lines":[{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":""},{"line_number":1179,"context_line":"def is_ipv6_enabled():"},{"line_number":1180,"context_line":"    return getattr(settings, \u0027OPENSTACK_NEUTRON_NETWORK\u0027, {})\\"},{"line_number":1181,"context_line":"        .get(\u0027enable_ipv6\u0027, True)"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"INSTANCE_FILTER_CHOICES \u003d ("},{"line_number":1184,"context_line":"    (\u0027uuid\u0027, _(\"Instance ID \u003d\"), True),"}],"source_content_type":"text/x-python","patch_set":13,"id":"5ff73747_559da757","line":1181,"range":{"start_line":1180,"start_character":4,"end_line":1181,"end_character":33},"updated":"2017-04-23 22:11:41.000000000","message":"You can use the following as a shortcut.\n\n api.neutron.is_enabled_by_config(\u0027enable_ipv6\u0027)","commit_id":"97e8837d0f0eca71b6536bd22f7177f848543e86"}]}
