)]}'
{"openstack_dashboard/api/rest/nova.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2e4c3e65b9becc6a541b7483c664b0aa9f918c2d","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"@urls.register"},{"line_number":272,"context_line":"class ServerGroups(generic.View):"},{"line_number":273,"context_line":"    \"\"\"API for nova server groups."},{"line_number":274,"context_line":"    \"\"\""},{"line_number":275,"context_line":"    url_regex \u003d r\u0027nova/servergroups/$\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_a27b83bd","line":272,"updated":"2016-07-14 23:23:48.000000000","message":"Need to add similarly worthless test as the other tests in here:\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/test/api_tests/nova_rest_tests.py","commit_id":"4ed8e5dc7d02f59bf4703227509b8f92b1d4ff93"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"97c9e3291fb273b7d2c1080d5407eeca459a084f","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"@urls.register"},{"line_number":272,"context_line":"class ServerGroups(generic.View):"},{"line_number":273,"context_line":"    \"\"\"API for nova server groups."},{"line_number":274,"context_line":"    \"\"\""},{"line_number":275,"context_line":"    url_regex \u003d r\u0027nova/servergroups/$\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_c257af24","line":272,"in_reply_to":"1aa78d24_a27b83bd","updated":"2016-07-14 23:24:53.000000000","message":"e.g. https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/api_tests/nova_rest_tests.py#L214","commit_id":"4ed8e5dc7d02f59bf4703227509b8f92b1d4ff93"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-workflow.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8b5a559f46bc9e09a71655eac49ab460c6dab7f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          helpUrl: basePath + \u0027security-groups/security-groups.help.html\u0027,"},{"line_number":76,"context_line":"          formName: \u0027launchInstanceAccessAndSecurityForm\u0027"},{"line_number":77,"context_line":"        },"},{"line_number":78,"context_line":"        {"},{"line_number":79,"context_line":"          id: \u0027servergroups\u0027,"},{"line_number":80,"context_line":"          title: gettext(\u0027Server Groups\u0027),"},{"line_number":81,"context_line":"          templateUrl: basePath + \u0027server-groups/server-groups.html\u0027,"}],"source_content_type":"text/javascript","patch_set":11,"id":"dada55a8_8d2146fe","line":78,"updated":"2016-07-19 14:33:56.000000000","message":"I have one final nit. I should have given this to you before.  Server groups seem like a more advanced option than key pairs. We\u0027ve been pushing more advanced options towards the end (like configuration and metadata).  I would vote to move them down to just before or just after the configuration step.","commit_id":"48d5fe3e584eef0332ed4a29a5cd1aa807027e84"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"34df64768cafb1933c266f562b9c39fdee41e4dc","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          helpUrl: basePath + \u0027security-groups/security-groups.help.html\u0027,"},{"line_number":76,"context_line":"          formName: \u0027launchInstanceAccessAndSecurityForm\u0027"},{"line_number":77,"context_line":"        },"},{"line_number":78,"context_line":"        {"},{"line_number":79,"context_line":"          id: \u0027servergroups\u0027,"},{"line_number":80,"context_line":"          title: gettext(\u0027Server Groups\u0027),"},{"line_number":81,"context_line":"          templateUrl: basePath + \u0027server-groups/server-groups.html\u0027,"}],"source_content_type":"text/javascript","patch_set":11,"id":"dada55a8_c27144e2","line":78,"in_reply_to":"dada55a8_8d2146fe","updated":"2016-07-19 16:32:08.000000000","message":"Makes sense to me. I moved this down under configuration in the next PS.","commit_id":"48d5fe3e584eef0332ed4a29a5cd1aa807027e84"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/server-groups/server-group-details.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"af53ab0fcf1743a26c37d3dd6e28480d0f02d196","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \u003c/tr\u003e"},{"line_number":6,"context_line":"  \u003c/thead\u003e"},{"line_number":7,"context_line":"  \u003ctbody\u003e"},{"line_number":8,"context_line":"    \u003ctr ng-repeat\u003d\"d in row.policies\"\u003e"},{"line_number":9,"context_line":"      \u003ctd\u003e{$ d | noValue $}\u003c/td\u003e"},{"line_number":10,"context_line":"    \u003c/tr\u003e"},{"line_number":11,"context_line":"  \u003c/tbody\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"1aa78d24_bdf0c7ca","line":8,"range":{"start_line":8,"start_character":19,"end_line":8,"end_character":20},"updated":"2016-07-14 21:20:58.000000000","message":"better name than \u0027d\u0027?","commit_id":"9e9948864215d247d99587af65274c663f3173d5"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"f7bbb22b60cd5a0c22a6b9e1331a7fbc0cc7e955","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \u003c/tr\u003e"},{"line_number":6,"context_line":"  \u003c/thead\u003e"},{"line_number":7,"context_line":"  \u003ctbody\u003e"},{"line_number":8,"context_line":"    \u003ctr ng-repeat\u003d\"d in row.policies\"\u003e"},{"line_number":9,"context_line":"      \u003ctd\u003e{$ d | noValue $}\u003c/td\u003e"},{"line_number":10,"context_line":"    \u003c/tr\u003e"},{"line_number":11,"context_line":"  \u003c/tbody\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"1aa78d24_62f23b9d","line":8,"range":{"start_line":8,"start_character":19,"end_line":8,"end_character":20},"in_reply_to":"1aa78d24_bdf0c7ca","updated":"2016-07-14 23:12:24.000000000","message":"Done","commit_id":"9e9948864215d247d99587af65274c663f3173d5"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/server-groups/server-groups.controller.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"af53ab0fcf1743a26c37d3dd6e28480d0f02d196","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":3,"context_line":" * you may not use this file except in compliance with the License."},{"line_number":4,"context_line":" * You may obtain a copy of the License at"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_1ddf5b3b","line":1,"updated":"2016-07-14 21:20:58.000000000","message":"copyright","commit_id":"9e9948864215d247d99587af65274c663f3173d5"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"f7bbb22b60cd5a0c22a6b9e1331a7fbc0cc7e955","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":3,"context_line":" * you may not use this file except in compliance with the License."},{"line_number":4,"context_line":" * You may obtain a copy of the License at"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_c2f16f97","line":1,"in_reply_to":"1aa78d24_1ddf5b3b","updated":"2016-07-14 23:12:24.000000000","message":"Done","commit_id":"9e9948864215d247d99587af65274c663f3173d5"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/server-groups/server-groups.help.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2d142533c3a8f073447c745f76fe76b953f9c965","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003cp translate\u003eServer groups define collections of VM\u0027s so that the entire collection can be given specific properties. For example, the policy of a server group may specify that VM\u0027s in this group should not be placed on the same physical hardware due to availability requirements.\u003c/p\u003e"},{"line_number":3,"context_line":"  \u003cp translate\u003eServer groups are project-specific and cannot be shared across projects.\u003c/p\u003e"},{"line_number":4,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"1aa78d24_25addd9b","line":2,"updated":"2016-07-14 23:42:29.000000000","message":"can you line wrap this?","commit_id":"253ba8e3010cce70a4ff4f9aa758373117252036"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"606f37961ace3d6eb9dc28c3b37170014145e2c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003cp translate\u003eServer groups define collections of VM\u0027s so that the entire collection can be given specific properties. For example, the policy of a server group may specify that VM\u0027s in this group should not be placed on the same physical hardware due to availability requirements.\u003c/p\u003e"},{"line_number":3,"context_line":"  \u003cp translate\u003eServer groups are project-specific and cannot be shared across projects.\u003c/p\u003e"},{"line_number":4,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"fad55976_6486edba","line":2,"in_reply_to":"1aa78d24_25addd9b","updated":"2016-07-15 22:43:17.000000000","message":"Done","commit_id":"253ba8e3010cce70a4ff4f9aa758373117252036"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/server-groups/server-groups.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2d142533c3a8f073447c745f76fe76b953f9c965","unresolved":false,"context_lines":[{"line_number":6,"context_line":"                  limits\u003d\"ctrl.tableLimits\"\u003e"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    \u003c!-- Server Groups Allocated --\u003e"},{"line_number":9,"context_line":"    \u003callocated\u003e"},{"line_number":10,"context_line":"      \u003ctable st-table\u003d\"ctrl.tableData.displayedAllocated\""},{"line_number":11,"context_line":"             st-safe-src\u003d\"ctrl.tableData.allocated\" hz-table"},{"line_number":12,"context_line":"             class\u003d\"table table-striped table-rsp table-detail\"\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"1aa78d24_e5891527","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":15},"updated":"2016-07-14 23:42:29.000000000","message":"Transfer table has a \"clone\" feature [0]. Can this patch use that and not need to do some of the other things in this patch?\n\nhttps://review.openstack.org/#/c/211345/","commit_id":"253ba8e3010cce70a4ff4f9aa758373117252036"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"606f37961ace3d6eb9dc28c3b37170014145e2c0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"                  limits\u003d\"ctrl.tableLimits\"\u003e"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    \u003c!-- Server Groups Allocated --\u003e"},{"line_number":9,"context_line":"    \u003callocated\u003e"},{"line_number":10,"context_line":"      \u003ctable st-table\u003d\"ctrl.tableData.displayedAllocated\""},{"line_number":11,"context_line":"             st-safe-src\u003d\"ctrl.tableData.allocated\" hz-table"},{"line_number":12,"context_line":"             class\u003d\"table table-striped table-rsp table-detail\"\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"fad55976_c49359f9","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":15},"in_reply_to":"1aa78d24_e5891527","updated":"2016-07-15 22:43:17.000000000","message":"Done","commit_id":"253ba8e3010cce70a4ff4f9aa758373117252036"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2d142533c3a8f073447c745f76fe76b953f9c965","unresolved":false,"context_lines":[{"line_number":78,"context_line":"              \u003cspan class\u003d\"fa fa-chevron-right\" hz-expand-detail"},{"line_number":79,"context_line":"                    title\u003d\"{$ ::trCtrl.helpText.expandDetailsText $}\"\u003e\u003c/span\u003e"},{"line_number":80,"context_line":"          \u003c/td\u003e"},{"line_number":81,"context_line":"          \u003ctd class\u003d\"rsp-p1\"\u003e{$ row.name$}\u003c/td\u003e"},{"line_number":82,"context_line":"          \u003ctd class\u003d\"actions_column\"\u003e"},{"line_number":83,"context_line":"            \u003caction-list\u003e"},{"line_number":84,"context_line":"              \u003caction action-classes\u003d\"\u0027btn btn-default\u0027\""}],"source_content_type":"text/html","patch_set":9,"id":"1aa78d24_857bf128","line":81,"range":{"start_line":81,"start_character":39,"end_line":81,"end_character":40},"updated":"2016-07-14 23:42:29.000000000","message":"space","commit_id":"253ba8e3010cce70a4ff4f9aa758373117252036"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"606f37961ace3d6eb9dc28c3b37170014145e2c0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"              \u003cspan class\u003d\"fa fa-chevron-right\" hz-expand-detail"},{"line_number":79,"context_line":"                    title\u003d\"{$ ::trCtrl.helpText.expandDetailsText $}\"\u003e\u003c/span\u003e"},{"line_number":80,"context_line":"          \u003c/td\u003e"},{"line_number":81,"context_line":"          \u003ctd class\u003d\"rsp-p1\"\u003e{$ row.name$}\u003c/td\u003e"},{"line_number":82,"context_line":"          \u003ctd class\u003d\"actions_column\"\u003e"},{"line_number":83,"context_line":"            \u003caction-list\u003e"},{"line_number":84,"context_line":"              \u003caction action-classes\u003d\"\u0027btn btn-default\u0027\""}],"source_content_type":"text/html","patch_set":9,"id":"fad55976_e4c01de3","line":81,"range":{"start_line":81,"start_character":39,"end_line":81,"end_character":40},"in_reply_to":"1aa78d24_857bf128","updated":"2016-07-15 22:43:17.000000000","message":"Done","commit_id":"253ba8e3010cce70a4ff4f9aa758373117252036"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/server-groups/server-groups.spec.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"af53ab0fcf1743a26c37d3dd6e28480d0f02d196","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":3,"context_line":" * you may not use this file except in compliance with the License."},{"line_number":4,"context_line":" * You may obtain a copy of the License at"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_7dc93f5a","line":1,"updated":"2016-07-14 21:20:58.000000000","message":"copyright","commit_id":"9e9948864215d247d99587af65274c663f3173d5"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"f7bbb22b60cd5a0c22a6b9e1331a7fbc0cc7e955","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":3,"context_line":" * you may not use this file except in compliance with the License."},{"line_number":4,"context_line":" * You may obtain a copy of the License at"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_e22c6b03","line":1,"in_reply_to":"1aa78d24_7dc93f5a","updated":"2016-07-14 23:12:24.000000000","message":"Done","commit_id":"9e9948864215d247d99587af65274c663f3173d5"}]}
