)]}'
{"openstack_dashboard/dashboards/project/volumes/panel.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"af1c39037096e42a5586112cf4d47c478e40ab40","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        request \u003d context[\u0027request\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        get_all \u003d policy.check(((\"volume\", \"volume:get_all\"),), request)"},{"line_number":38,"context_line":"        create \u003d policy.check(((\"volume\", \"volume:create\"),), request)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        if not get_all and not create:"},{"line_number":41,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_92b8ac12","line":38,"updated":"2016-07-07 16:46:03.000000000","message":"we should not block on create, read only is a valid use case. Create has its own policy check later.","commit_id":"3195e4f4e795bd3ad98833160dc95ae01e6c94dc"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"168cc09be62bf5d2f97b0e952167816d95efc57a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        request \u003d context[\u0027request\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        get_all \u003d policy.check(((\"volume\", \"volume:get_all\"),), request)"},{"line_number":38,"context_line":"        create \u003d policy.check(((\"volume\", \"volume:create\"),), request)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        if not get_all and not create:"},{"line_number":41,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_a163cfaf","line":38,"in_reply_to":"1aa78d24_92b8ac12","updated":"2016-07-07 19:41:50.000000000","message":"Done","commit_id":"3195e4f4e795bd3ad98833160dc95ae01e6c94dc"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"13f8cfd7f014af6b2f38662117ceb171a6043ac4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        get_all \u003d policy.check(((\"volume\", \"volume:get_all\"),), request)"},{"line_number":34,"context_line":"        create \u003d policy.check(((\"volume\", \"volume:create\"),), request)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        if not get_all and not create:"},{"line_number":37,"context_line":"            return False"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        return super(Volumes, self).allowed(context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_8cfa90bb","line":36,"updated":"2016-07-26 21:55:50.000000000","message":"create should play no role in viewing the page. The list is enough, the create button is guarded by the action once on the page.","commit_id":"66a1a61ff67cac4a43734d58815c4553f541243c"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"e171ced7fbe9c56ea66c837080494046496f7eda","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        get_all \u003d policy.check(((\"volume\", \"volume:get_all\"),), request)"},{"line_number":34,"context_line":"        create \u003d policy.check(((\"volume\", \"volume:create\"),), request)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        if not get_all and not create:"},{"line_number":37,"context_line":"            return False"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        return super(Volumes, self).allowed(context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_59503a32","line":36,"in_reply_to":"dada55a8_8cfa90bb","updated":"2016-08-01 18:03:58.000000000","message":"ok, so then I should only check for this policy? \npolicy.check(((\"volume\", \"volume:get_all\"),), request)","commit_id":"66a1a61ff67cac4a43734d58815c4553f541243c"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"583524dcdd383585fea52e2101ffd8fcf4575d1f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        (\u0027openstack.services.volume\u0027, \u0027openstack.services.volumev2\u0027),"},{"line_number":28,"context_line":"    )"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def allowed(self, context):"},{"line_number":31,"context_line":"        request \u003d context[\u0027request\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        if not policy.check(((\"volume\", \"volume:get_all\"),), request):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_15210e4e","line":30,"updated":"2016-08-09 02:20:47.000000000","message":"We can write this just like below.\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/hypervisors/panel.py#L24","commit_id":"a1630ab5d8a348621bc8bde140b97bc5820b0415"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"7907b19f47bd737c249853cd41eb527747cf7f31","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        (\u0027openstack.services.volume\u0027, \u0027openstack.services.volumev2\u0027),"},{"line_number":28,"context_line":"    )"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def allowed(self, context):"},{"line_number":31,"context_line":"        request \u003d context[\u0027request\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        if not policy.check(((\"volume\", \"volume:get_all\"),), request):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_2a780d2b","line":30,"in_reply_to":"9ad45d7e_15210e4e","updated":"2016-08-09 15:02:15.000000000","message":"Done","commit_id":"a1630ab5d8a348621bc8bde140b97bc5820b0415"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"c6f6b6be210c438aff654ae499e68dab985e69a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a98d1f4_c01eb362","line":28,"updated":"2016-09-29 15:06:40.000000000","message":"should more policy checks be added here as well?  what if create or get is allowed, but get_all is not?","commit_id":"6b9dc6ac560ef68e702e405d3653ff204cb88740"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"4ea215db05fcad2985134513989d6b7e2345d7db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ba5da102_8eb98431","line":28,"in_reply_to":"3a98d1f4_c01eb362","updated":"2016-10-26 13:45:29.000000000","message":"fine for me","commit_id":"6b9dc6ac560ef68e702e405d3653ff204cb88740"}]}
