)]}'
{"doc/source/topics/settings.rst":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fab356d42042027c79b8475d4a90f169e4913475","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Default: ``legacy``"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"There are currently two panel types that may be specified: ``legacy`` and"},{"line_number":191,"context_line":"``angular``. ``legacy`` will display the Python-based (server-side) Images"},{"line_number":192,"context_line":"panel and ``angular`` will display the Angular-based (client-side) Images"},{"line_number":193,"context_line":"panel."}],"source_content_type":"text/x-rst","patch_set":28,"id":"bacf61ea_6977b0d4","line":190,"updated":"2016-08-03 20:37:00.000000000","message":"-1: I think this setting at the HORIZON_CONFIG level should be a container of \u0027panel_enablements\u0027. Within that container, panels that support multiple modes can be listed.  As this stands today, it makes it seem like images panel is a special snowflake, when in fact we expect most panels to eventually have this switch?","commit_id":"8368237eaff94096b0c1b8e11e56066f0ea90c80"}],"openstack_dashboard/dashboards/admin/images/urls.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8b88cb81f3b3de425718351b2f47e50076e4e058","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from openstack_dashboard.dashboards.admin.images import views"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if settings.HORIZON_CONFIG[\u0027glance_panel\u0027] \u003d\u003d \u0027angular\u0027:"},{"line_number":25,"context_line":"    # New angular images"},{"line_number":26,"context_line":"    urlpatterns \u003d ["},{"line_number":27,"context_line":"        url(r\u0027^$\u0027, views.AngularIndexView.as_view(), name\u003d\u0027index\u0027),"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_cdb650db","line":24,"range":{"start_line":24,"start_character":28,"end_line":24,"end_character":40},"updated":"2016-07-26 17:56:16.000000000","message":"Strictly speaking, \u0027glance\u0027 is a project which provides images feature in openstack, and the service type is \u0027image\u0027.","commit_id":"b24dada18ed8eca1297fc0ed831189e6d665216f"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e5945c6e7a86baaf117dfc46c84b08c7af9946fe","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from openstack_dashboard.dashboards.admin.images import views"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if settings.HORIZON_CONFIG[\u0027glance_panel\u0027] \u003d\u003d \u0027angular\u0027:"},{"line_number":25,"context_line":"    # New angular images"},{"line_number":26,"context_line":"    urlpatterns \u003d ["},{"line_number":27,"context_line":"        url(r\u0027^$\u0027, views.AngularIndexView.as_view(), name\u003d\u0027index\u0027),"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_067fa6e0","line":24,"range":{"start_line":24,"start_character":28,"end_line":24,"end_character":40},"in_reply_to":"dada55a8_cdb650db","updated":"2016-07-26 19:13:36.000000000","message":"Cindy, what do you think?  I\u0027m up for images_panel.","commit_id":"b24dada18ed8eca1297fc0ed831189e6d665216f"}],"openstack_dashboard/dashboards/admin/images/views.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"13f7d84aa9f6d9cd58e123ecb7c7fcf215887f5e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class IndexAngularView(generic.TemplateView):"},{"line_number":45,"context_line":"    template_name \u003d \u0027angular.html\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"dada55a8_9d72fce1","line":44,"updated":"2016-07-26 01:07:14.000000000","message":"do we want to keep it somewhat consistent with how the Swift UI is doing it?\n\nIt\u0027s called NgIndexView?","commit_id":"7786e3b366de795d49b8481bfb6eb4251b574cd2"}],"openstack_dashboard/dashboards/project/images/tests.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"44123afbfd2fa1b5fb97720cab3b24261f24d4de","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from openstack_dashboard.dashboards.project.images import utils"},{"line_number":36,"context_line":"from openstack_dashboard.test import helpers as test"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"import unittest"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"INDEX_URL \u003d reverse(\u0027horizon:project:images:index\u0027)"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_81153741","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":15},"updated":"2016-08-01 09:35:40.000000000","message":"Moving this line here from line 22 looks weird, but I don\u0027t think we should block on this. If you will be changing something else in this patch, could you please change the import placement, Matt?","commit_id":"23b71d03c8f7d3241a2588d886ecaefba819d692"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e59b05248f5a99cb97c53d785d78d2e15d8b6070","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from openstack_dashboard.dashboards.project.images import utils"},{"line_number":36,"context_line":"from openstack_dashboard.test import helpers as test"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"import unittest"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"INDEX_URL \u003d reverse(\u0027horizon:project:images:index\u0027)"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_a5a479b9","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":15},"in_reply_to":"bacf61ea_81153741","updated":"2016-08-02 14:26:38.000000000","message":"Done","commit_id":"23b71d03c8f7d3241a2588d886ecaefba819d692"}],"openstack_dashboard/enabled/_1050_project_images_panel.py":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e0c98dd21d2dc310503ebf49c4699688ce43d447","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2016 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_72570058","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":62},"updated":"2016-07-07 16:53:38.000000000","message":"(c) Copyright 2016 Hewlett Packard Enterprise Development Company LP","commit_id":"278e10a85e4fcbae2200719f09f1149cd04df49a"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"fb93d36207158fc2017adffc7a63832b26437c49","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# Python panel class of the PANEL to be added."},{"line_number":23,"context_line":"ADD_PANEL \u003d \u0027openstack_dashboard.dashboards.project.images.panel.Images\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"DISABLED \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Which implementation of the panel should we use? Valid options"},{"line_number":28,"context_line":"# here are \u0027angular\u0027 (new implementation) and \u0027legacy\u0027 (old"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_f29770e9","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":16},"updated":"2016-07-07 16:54:10.000000000","message":"may not be necessary","commit_id":"278e10a85e4fcbae2200719f09f1149cd04df49a"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"f1cc3a6ec72ef8d9143284ab97d2b824a1bc6e60","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# Python panel class of the PANEL to be added."},{"line_number":23,"context_line":"ADD_PANEL \u003d \u0027openstack_dashboard.dashboards.project.images.panel.Images\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"DISABLED \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Which implementation of the panel should we use? Valid options"},{"line_number":28,"context_line":"# here are \u0027angular\u0027 (new implementation) and \u0027legacy\u0027 (old"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_180e9be4","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":16},"in_reply_to":"1aa78d24_f29770e9","updated":"2016-07-07 17:29:06.000000000","message":"Agree that it\u0027s not necessary and better to be removed for simplicity.","commit_id":"278e10a85e4fcbae2200719f09f1149cd04df49a"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"a2bd701b9f13f83bcf1cdcc2b2a1a613d5fbf511","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# here are \u0027angular\u0027 (new implementation) and \u0027legacy\u0027 (old"},{"line_number":27,"context_line":"# implementation.)"},{"line_number":28,"context_line":"UPDATE_HORIZON_CONFIG \u003d {"},{"line_number":29,"context_line":"    \u0027glance_panel\u0027: \u0027legacy\u0027"},{"line_number":30,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_083f0cd7","line":29,"updated":"2016-07-19 12:41:35.000000000","message":"highly recommend use \"enable_angular_image_panel\": True, we needn\u0027t to check the word \u0027legacy\u0027 or angular","commit_id":"bea681b126bbddf37906def1a75a16fc41d630f0"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"54da028fd1afd932a67f882a49f1af8ab107c2e8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# here are \u0027angular\u0027 (new implementation) and \u0027legacy\u0027 (old"},{"line_number":27,"context_line":"# implementation.)"},{"line_number":28,"context_line":"UPDATE_HORIZON_CONFIG \u003d {"},{"line_number":29,"context_line":"    \u0027glance_panel\u0027: \u0027legacy\u0027"},{"line_number":30,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_303192ed","line":29,"in_reply_to":"dada55a8_083f0cd7","updated":"2016-07-19 14:49:28.000000000","message":"I think the plan was to accommodate n-number of panel alternatives, which True/False wouldn\u0027t accommodate.  We are following the Swift (containers) example in doing this.","commit_id":"bea681b126bbddf37906def1a75a16fc41d630f0"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"7c559dbc0c172f3f4c79a9d830877473d94c521a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# here are \u0027angular\u0027 (new implementation) and \u0027legacy\u0027 (old"},{"line_number":27,"context_line":"# implementation.)"},{"line_number":28,"context_line":"UPDATE_HORIZON_CONFIG \u003d {"},{"line_number":29,"context_line":"    \u0027glance_panel\u0027: \u0027legacy\u0027"},{"line_number":30,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_9c61753c","line":29,"in_reply_to":"dada55a8_303192ed","updated":"2016-07-19 15:54:40.000000000","message":"Its a good point though; we could have something like enable_angular_panels \u003d { \u0027glance\u0027 : true } if people are worried about misspellings or legacy implications","commit_id":"bea681b126bbddf37906def1a75a16fc41d630f0"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"138d240d4c7a3308907f0d7792fcfe93b6f80389","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# here are \u0027angular\u0027 (new implementation) and \u0027legacy\u0027 (old"},{"line_number":27,"context_line":"# implementation.)"},{"line_number":28,"context_line":"UPDATE_HORIZON_CONFIG \u003d {"},{"line_number":29,"context_line":"    \u0027glance_panel\u0027: \u0027legacy\u0027"},{"line_number":30,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_d88c8281","line":29,"in_reply_to":"dada55a8_65ba1dc2","updated":"2016-07-20 01:21:51.000000000","message":"I\u0027m not sure I see the need to deviate from the approach we used for the swift panel.","commit_id":"bea681b126bbddf37906def1a75a16fc41d630f0"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e5bfd31a6549e9a96b6ca7836bf8ff5f7780f993","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# here are \u0027angular\u0027 (new implementation) and \u0027legacy\u0027 (old"},{"line_number":27,"context_line":"# implementation.)"},{"line_number":28,"context_line":"UPDATE_HORIZON_CONFIG \u003d {"},{"line_number":29,"context_line":"    \u0027glance_panel\u0027: \u0027legacy\u0027"},{"line_number":30,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_65ba1dc2","line":29,"in_reply_to":"dada55a8_9c61753c","updated":"2016-07-19 18:23:27.000000000","message":"I\u0027m fine with whatever approach the community wants for the switch.  I was just following what we\u0027d seen in Swift.  Do others (Richard, Travis) who contributed to that originally have any additional thoughts?  The main thing I can think of in support of the current standard is if we have further alternates, like \u0027react\u0027 as opposed to a binary switch.","commit_id":"bea681b126bbddf37906def1a75a16fc41d630f0"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"333808af814b3eaa0d17c32c44871748431957bc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# here are \u0027angular\u0027 (new implementation) and \u0027legacy\u0027 (old"},{"line_number":27,"context_line":"# implementation.)"},{"line_number":28,"context_line":"UPDATE_HORIZON_CONFIG \u003d {"},{"line_number":29,"context_line":"    \u0027glance_panel\u0027: \u0027legacy\u0027"},{"line_number":30,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_04a84cda","line":29,"in_reply_to":"dada55a8_d88c8281","updated":"2016-07-20 16:21:31.000000000","message":"Yeah, I think this approach gives us more flexibility.  I don\u0027t mind the string comparisons.  I\u0027m going to continue with just using a string in the horizon config dict unless there are more serious objections.","commit_id":"bea681b126bbddf37906def1a75a16fc41d630f0"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"05098f0b1d4bfb8c75d6592f8b97f98d553c357d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# here are \u0027angular\u0027 (new implementation) and \u0027legacy\u0027 (old"},{"line_number":27,"context_line":"# implementation.)"},{"line_number":28,"context_line":"UPDATE_HORIZON_CONFIG \u003d {"},{"line_number":29,"context_line":"    \u0027glance_panel\u0027: \u0027legacy\u0027"},{"line_number":30,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_ee7669a2","line":29,"updated":"2016-07-21 21:05:16.000000000","message":"Do the same thing for the Admin panel.","commit_id":"cfa6ef08ca2eb523e6c7a87fa9200f8d0ee98acf"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"ef57c45cefe7dd7999c5d05785f3983a5747e61d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":28,"id":"bacf61ea_7ffe3eaf","line":1,"updated":"2016-08-03 20:04:04.000000000","message":"I had pep8 yell at me when I had put verbiage in here before (it\u0027s apparently required after a certain line count).  Doesn\u0027t hurt to have in here.","commit_id":"8368237eaff94096b0c1b8e11e56066f0ea90c80"}],"openstack_dashboard/settings.py":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fab356d42042027c79b8475d4a90f169e4913475","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    \u0027js_spec_files\u0027: [],"},{"line_number":80,"context_line":"    \u0027external_templates\u0027: [],"},{"line_number":81,"context_line":"    \u0027plugins\u0027: [],"},{"line_number":82,"context_line":"    \u0027images_panel\u0027: \u0027legacy\u0027,"},{"line_number":83,"context_line":"    \u0027integration_tests_support\u0027: INTEGRATION_TESTS_SUPPORT"},{"line_number":84,"context_line":"}"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"bacf61ea_9ff21299","line":82,"range":{"start_line":82,"start_character":5,"end_line":82,"end_character":17},"updated":"2016-08-03 20:37:00.000000000","message":"-1: I\u0027d like to see the same panel slug as is registered by the panel ,\"images\" in this case. I don\u0027t think it is good for a panel which is universally referred to by slug \u0027images\u0027 to have a different key here. It makes it harder to understand that this setting is related to a particular enablement file.\n\nEventually, there will one of these for every core panel. To avoid pollution of HORIZON_CONFIG, I\u0027d like to see panel enablements grouped into their own sub-object, perhaps HORIZON_CONFIG[\u0027panel_enablements\u0027][\u0027images\u0027] \u003d \u0027legacy.","commit_id":"8368237eaff94096b0c1b8e11e56066f0ea90c80"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fab356d42042027c79b8475d4a90f169e4913475","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    \u0027js_spec_files\u0027: [],"},{"line_number":80,"context_line":"    \u0027external_templates\u0027: [],"},{"line_number":81,"context_line":"    \u0027plugins\u0027: [],"},{"line_number":82,"context_line":"    \u0027images_panel\u0027: \u0027legacy\u0027,"},{"line_number":83,"context_line":"    \u0027integration_tests_support\u0027: INTEGRATION_TESTS_SUPPORT"},{"line_number":84,"context_line":"}"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"bacf61ea_2282ed00","line":82,"range":{"start_line":82,"start_character":5,"end_line":82,"end_character":17},"updated":"2016-08-03 20:37:00.000000000","message":"-1: This control seems like it has a fairly major potential to cause deployers to deliver unexpected code (and broken 3rd party integrations) which will cause head scratching because of an unexpected settings.py value that controls what traditionally would have been a modification to a panel\u0027s enabled file.\n\nPersonally, I first expected to find information about the panel \u0027mode\u0027 to be in the enabled file for the particular panel...but if settings.py is a better place then I\u0027d like to see it be more self documenting. Consider:\n\na) a comment in the relevent panel enabled file that the panel \u0027mode\u0027 is controlled by this value in settings.py\n\nb) isolating panel modes as their own object, which is then referenced by HORIZON_CONFIG. That object can then have a block comment that helps deployers understand why they aren\u0027t seeing the panel they were used to.","commit_id":"8368237eaff94096b0c1b8e11e56066f0ea90c80"}],"openstack_dashboard/static/app/core/images/images.module.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"751a43f840cb8303e00fdefe65a1908195e79f2b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  function run(registry, basePath, imagesService, statuses, imageResourceType) {"},{"line_number":59,"context_line":"    registry.getResourceType(imageResourceType)"},{"line_number":60,"context_line":"      .setNames(gettext(\u0027Image\u0027), gettext(\u0027Images\u0027))"},{"line_number":61,"context_line":"      .setSummaryTemplateUrl(basePath + \u0027summary.html\u0027)"},{"line_number":62,"context_line":"      .setProperty(\u0027checksum\u0027, {"},{"line_number":63,"context_line":"        label: gettext(\u0027Checksum\u0027)"},{"line_number":64,"context_line":"      })"}],"source_content_type":"text/javascript","patch_set":28,"id":"bacf61ea_dfd2ca33","line":61,"updated":"2016-08-03 20:04:59.000000000","message":"This was changed due to dischord with other features we saw coming down the pike and it was suggested to just change it here.","commit_id":"8368237eaff94096b0c1b8e11e56066f0ea90c80"}],"openstack_dashboard/test/integration_tests/tests/test_images.py":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"05098f0b1d4bfb8c75d6592f8b97f98d553c357d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    @unittest.skipIf(config.get_config().image.panel_type !\u003d \u0027angular\u0027,"},{"line_number":51,"context_line":"                     \"Angular Panels not tested\")"},{"line_number":52,"context_line":"    def test_images_header(self):"},{"line_number":53,"context_line":"        header_text \u003d self.driver.find_element_by_tag_name(\u0027h1\u0027).text"},{"line_number":54,"context_line":"        self.assertEqual(header_text, \u0027Images\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @unittest.skipIf(config.get_config().image.panel_type !\u003d \u0027angular\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_6e443949","line":53,"updated":"2016-07-21 21:05:16.000000000","message":"We need to locate to the Images panel for this to work.","commit_id":"cfa6ef08ca2eb523e6c7a87fa9200f8d0ee98acf"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8b88cb81f3b3de425718351b2f47e50076e4e058","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertFalse(images_page.find_message_and_dismiss(messages.ERROR))"},{"line_number":48,"context_line":"        self.assertFalse(images_page.is_image_present(self.IMAGE_NAME))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @unittest.skipIf(config.get_config().image.panel_type !\u003d \u0027angular\u0027,"},{"line_number":51,"context_line":"                     \"Angular Panels not tested\")"},{"line_number":52,"context_line":"    def test_images_header(self):"},{"line_number":53,"context_line":"        self.home_pg.go_to_compute_imagespage()"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_cd31300d","line":50,"range":{"start_line":50,"start_character":21,"end_line":50,"end_character":70},"updated":"2016-07-26 17:56:16.000000000","message":"Nice, didn\u0027t think it could be used this way :)!","commit_id":"b24dada18ed8eca1297fc0ed831189e6d665216f"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8b88cb81f3b3de425718351b2f47e50076e4e058","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @unittest.skipIf(config.get_config().image.panel_type !\u003d \u0027angular\u0027,"},{"line_number":51,"context_line":"                     \"Angular Panels not tested\")"},{"line_number":52,"context_line":"    def test_images_header(self):"},{"line_number":53,"context_line":"        self.home_pg.go_to_compute_imagespage()"},{"line_number":54,"context_line":"        images_page \u003d self.images_page"},{"line_number":55,"context_line":"        header_text \u003d images_page.driver.find_element_by_tag_name(\u0027h1\u0027).text"},{"line_number":56,"context_line":"        self.assertEqual(header_text, \u0027Images\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @unittest.skipIf(config.get_config().image.panel_type !\u003d \u0027angular\u0027,"},{"line_number":59,"context_line":"                     \"Angular Panels not tested\")"},{"line_number":60,"context_line":"    def test_images_module_exists(self):"},{"line_number":61,"context_line":"        js_cmd \u003d \"$(\u0027html\u0027).append(\u0027\u003cdiv id\u003d\\\"testonly\\\"\u003e\u0027\"\\"},{"line_number":62,"context_line":"            \" + angular.module(\u0027horizon.app.core.images\u0027).name\"\\"},{"line_number":63,"context_line":"            \" + \u0027\u003c/div\u003e\u0027);\""},{"line_number":64,"context_line":"        self.driver.execute_script(js_cmd)"},{"line_number":65,"context_line":"        value \u003d self.driver.find_element_by_id(\u0027testonly\u0027).text"},{"line_number":66,"context_line":"        self.assertEqual(value, \u0027horizon.app.core.images\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @unittest.skipIf(config.get_config().image.panel_type \u003d\u003d \u0027angular\u0027,"},{"line_number":69,"context_line":"                     \"Legacy Panels not tested\")"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_68fd92b0","line":66,"range":{"start_line":52,"start_character":0,"end_line":66,"end_character":58},"updated":"2016-07-26 17:56:16.000000000","message":"Honestly these 2 tests do not look like integration tests to me at all :). I mean, you could get the same results (if some specific tag or html element present) using unit tests.\n\nA better approach would be to use different page objects (angular-specific of django-specific) for Images panel based on the config setting, thus leaving top-level test logic the same for both implementations. However, since page objects for angular images (mostly Create Image and Create Volume forms) are not written yet, we could just disable existing tests for Images in case Angular panel is used - and re-enable them later, as soon the above approach is implemented.","commit_id":"b24dada18ed8eca1297fc0ed831189e6d665216f"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e5945c6e7a86baaf117dfc46c84b08c7af9946fe","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @unittest.skipIf(config.get_config().image.panel_type !\u003d \u0027angular\u0027,"},{"line_number":51,"context_line":"                     \"Angular Panels not tested\")"},{"line_number":52,"context_line":"    def test_images_header(self):"},{"line_number":53,"context_line":"        self.home_pg.go_to_compute_imagespage()"},{"line_number":54,"context_line":"        images_page \u003d self.images_page"},{"line_number":55,"context_line":"        header_text \u003d images_page.driver.find_element_by_tag_name(\u0027h1\u0027).text"},{"line_number":56,"context_line":"        self.assertEqual(header_text, \u0027Images\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @unittest.skipIf(config.get_config().image.panel_type !\u003d \u0027angular\u0027,"},{"line_number":59,"context_line":"                     \"Angular Panels not tested\")"},{"line_number":60,"context_line":"    def test_images_module_exists(self):"},{"line_number":61,"context_line":"        js_cmd \u003d \"$(\u0027html\u0027).append(\u0027\u003cdiv id\u003d\\\"testonly\\\"\u003e\u0027\"\\"},{"line_number":62,"context_line":"            \" + angular.module(\u0027horizon.app.core.images\u0027).name\"\\"},{"line_number":63,"context_line":"            \" + \u0027\u003c/div\u003e\u0027);\""},{"line_number":64,"context_line":"        self.driver.execute_script(js_cmd)"},{"line_number":65,"context_line":"        value \u003d self.driver.find_element_by_id(\u0027testonly\u0027).text"},{"line_number":66,"context_line":"        self.assertEqual(value, \u0027horizon.app.core.images\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @unittest.skipIf(config.get_config().image.panel_type \u003d\u003d \u0027angular\u0027,"},{"line_number":69,"context_line":"                     \"Legacy Panels not tested\")"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_e67ed2ad","line":66,"range":{"start_line":52,"start_character":0,"end_line":66,"end_character":58},"in_reply_to":"dada55a8_68fd92b0","updated":"2016-07-26 19:13:36.000000000","message":"I think we should keep these tests.  We established a baseline at the midcycle discussions to ensure that we a) verified that the modules loaded, which the second test does, and b) that the Angular was generally working, which is true here in the first because if it is not, the header will not interpolate properly.\n\nWe also said we didn\u0027t want *a lot* of integration tests as they take a while, but that we wanted the basic \"the feature is loaded.\"  Since this patch is here to demonstrate that the feature is enabled or disabled, I\u0027d recommend keeping this.  If there are additional tests people want to write, that\u0027s great, but I don\u0027t believe it should block this patch, as we agreed on the basic criteria already.","commit_id":"b24dada18ed8eca1297fc0ed831189e6d665216f"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"598bf22a36c2bf5a76674b28d6cc2db3bb663308","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \" + \u0027\u003c/div\u003e\u0027);\""},{"line_number":64,"context_line":"        self.driver.execute_script(js_cmd)"},{"line_number":65,"context_line":"        value \u003d self.driver.find_element_by_id(\u0027testonly\u0027).text"},{"line_number":66,"context_line":"        self.assertEqual(value, \u0027horizon.app.core.images\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @unittest.skipIf(config.get_config().image.panel_type \u003d\u003d \u0027angular\u0027,"},{"line_number":69,"context_line":"                     \"Legacy Panels not tested\")"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_69791382","line":66,"in_reply_to":"dada55a8_e67ed2ad","updated":"2016-07-26 19:20:53.000000000","message":"Matt, give me please one day and I\u0027ll come up with a solution for \u0027integration as smoke\u0027 tests for angular. These 2 tests break a Page Object pattern which is the cornerstone of integration tests and set a very bad example to follow (see testing.rst guide on integration tests).","commit_id":"b24dada18ed8eca1297fc0ed831189e6d665216f"}],"releasenotes/notes/image-panel-switch-38e9d3716451f9e3.yaml":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fab356d42042027c79b8475d4a90f169e4913475","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    The Image panel now may be configured to use"},{"line_number":4,"context_line":"    either the legacy or Angular code."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - HORIZON_CONFIG now allows for a key \u0027glance_panel\u0027 to be"},{"line_number":7,"context_line":"    specified as \u0027legacy\u0027 or \u0027angular\u0027 indicating the type of"},{"line_number":8,"context_line":"    panel to use."},{"line_number":9,"context_line":"  - Integration tests for Image features may also be toggled"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"bacf61ea_22caeda1","line":6,"range":{"start_line":6,"start_character":41,"end_line":6,"end_character":53},"updated":"2016-08-03 20:37:00.000000000","message":"-1: did you mean \u0027images_panel\u0027 ?","commit_id":"8368237eaff94096b0c1b8e11e56066f0ea90c80"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"48e33f5bf02104e6bb3bce1eda233cba82b9cc6f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    The Image panel now may be configured to use"},{"line_number":4,"context_line":"    either the legacy or Angular code."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - HORIZON_CONFIG now allows for a key \u0027glance_panel\u0027 to be"},{"line_number":7,"context_line":"    specified as \u0027legacy\u0027 or \u0027angular\u0027 indicating the type of"},{"line_number":8,"context_line":"    panel to use."},{"line_number":9,"context_line":"  - Integration tests for Image features may also be toggled"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"bacf61ea_aca18b96","line":6,"range":{"start_line":6,"start_character":41,"end_line":6,"end_character":53},"in_reply_to":"bacf61ea_22caeda1","updated":"2016-08-04 13:58:15.000000000","message":"yep, that\u0027s right, I can change that.","commit_id":"8368237eaff94096b0c1b8e11e56066f0ea90c80"}]}
