)]}'
{"horizon/static/framework/widgets/property/hz-field.directive.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8bba93bdfea3c3923ca09203ca27df24fd01967c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   * The filters property may contain an array of filters. Each filter may be a function or"},{"line_number":47,"context_line":"   * a name of a filter that will be looked up using $filter. If it is a function, the function"},{"line_number":48,"context_line":"   * must take an and return the output. This function may be a promise, but only if it is the"},{"line_number":49,"context_line":"   * only filter or the last filter in the array of filters."},{"line_number":50,"context_line":"   *"},{"line_number":51,"context_line":"   * Note that a combination of \u0027filters\u0027 and \u0027values\u0027 may be used; in this case"}],"source_content_type":"text/javascript","patch_set":29,"id":"bacf61ea_a1cb0271","line":48,"range":{"start_line":48,"start_character":10,"end_line":48,"end_character":39},"updated":"2016-08-05 20:54:13.000000000","message":"not sure quite is intended here.","commit_id":"0f73e6c0c203d1e0b91e7a8f62163a2d3f624cd6"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bceb221630cf7e7a1e8160170a9efabc1e312ea1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   * The filters property may contain an array of filters. Each filter may be a function or"},{"line_number":47,"context_line":"   * a name of a filter that will be looked up using $filter. If it is a function, the function"},{"line_number":48,"context_line":"   * must take an and return the output. This function may be a promise, but only if it is the"},{"line_number":49,"context_line":"   * only filter or the last filter in the array of filters."},{"line_number":50,"context_line":"   *"},{"line_number":51,"context_line":"   * Note that a combination of \u0027filters\u0027 and \u0027values\u0027 may be used; in this case"}],"source_content_type":"text/javascript","patch_set":29,"id":"bacf61ea_a1514264","line":48,"range":{"start_line":48,"start_character":10,"end_line":48,"end_character":39},"in_reply_to":"bacf61ea_a1cb0271","updated":"2016-08-05 21:00:32.000000000","message":"Done","commit_id":"0f73e6c0c203d1e0b91e7a8f62163a2d3f624cd6"}],"openstack_dashboard/static/app/core/images/images.module.js":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"c03e2936be9aaf3b53cad5256f21f2d542f3ab4c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"      .append({"},{"line_number":149,"context_line":"        id: \u0027owner\u0027,"},{"line_number":150,"context_line":"        priority: 1,"},{"line_number":151,"context_line":"        filters: [$memoize(keystone.getProjectName)],"},{"line_number":152,"context_line":"        policies: [{rules: [[\u0027identity\u0027, \u0027identity:get_project\u0027]]}]"},{"line_number":153,"context_line":"      })"},{"line_number":154,"context_line":"      .append({"}],"source_content_type":"text/javascript","patch_set":30,"id":"9ad45d7e_60fa21bf","line":151,"range":{"start_line":151,"start_character":18,"end_line":151,"end_character":51},"updated":"2016-08-09 16:41:44.000000000","message":"Well, it\u0027s possible to change the project name, what\u0027s our plan for dealing with names from a stale cache? This is going to become more serious when Horizon becomes a SPA.","commit_id":"40d6c0c3fed3cdd49e6228d198418c1d125e9e19"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"dbc55966a05e5fa28dff9146f1547c1dcf5bc253","unresolved":false,"context_lines":[{"line_number":148,"context_line":"      .append({"},{"line_number":149,"context_line":"        id: \u0027owner\u0027,"},{"line_number":150,"context_line":"        priority: 1,"},{"line_number":151,"context_line":"        filters: [$memoize(keystone.getProjectName)],"},{"line_number":152,"context_line":"        policies: [{rules: [[\u0027identity\u0027, \u0027identity:get_project\u0027]]}]"},{"line_number":153,"context_line":"      })"},{"line_number":154,"context_line":"      .append({"}],"source_content_type":"text/javascript","patch_set":30,"id":"9ad45d7e_fe0fce85","line":151,"range":{"start_line":151,"start_character":18,"end_line":151,"end_character":51},"in_reply_to":"9ad45d7e_60fa21bf","updated":"2016-08-09 17:19:43.000000000","message":"I don\u0027t think this is a serious problem right now.  The image name would only be shown in various specific resource panels.  Every time you change panels the memoization is cleared.  At least this is the behavior I see exhibited. For example, have you tried opening a new tab, changing the project name in the tab and observing the effects on your images tab?\n\nHere\u0027s what you\u0027ll see, the project name in the project selector is still the old name and name in the images table is still the old name. But the second you click images again, click the refresh button, or switch panels and come back, the name is correct.","commit_id":"40d6c0c3fed3cdd49e6228d198418c1d125e9e19"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"7f733542a5efa12ca4eda916c842f0f537b620b0","unresolved":false,"context_lines":[{"line_number":148,"context_line":"      .append({"},{"line_number":149,"context_line":"        id: \u0027owner\u0027,"},{"line_number":150,"context_line":"        priority: 1,"},{"line_number":151,"context_line":"        filters: [$memoize(keystone.getProjectName)],"},{"line_number":152,"context_line":"        policies: [{rules: [[\u0027identity\u0027, \u0027identity:get_project\u0027]]}]"},{"line_number":153,"context_line":"      })"},{"line_number":154,"context_line":"      .append({"}],"source_content_type":"text/javascript","patch_set":30,"id":"9ad45d7e_35fb097b","line":151,"range":{"start_line":151,"start_character":18,"end_line":151,"end_character":51},"in_reply_to":"9ad45d7e_fe0fce85","updated":"2016-08-10 16:36:16.000000000","message":"I agree with Travis on this one.  It seems that generally we can memoize without major problems.  A lingering project name change, which right now is not a likely event during the SPA lifetime, is low risk and not confusing.  If the user themselves changed the project name, the SPA would be reloaded for long into the foreseeable future.","commit_id":"40d6c0c3fed3cdd49e6228d198418c1d125e9e19"}]}
