)]}'
{"openstack_dashboard/dashboards/admin/flavors/workflows.py":[{"author":{"_account_id":19774,"name":"Vivek Agrawal","email":"vivek.agrawal@veritas.com","username":"viveksagrawal"},"change_message_id":"2ba8180f2a40031c9965e1b212d462ecf4172db2","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            msg \u003d _(\u0027Unable to get flavor list\u0027)"},{"line_number":255,"context_line":"            exceptions.check_message([\"Connection\", \"refused\"], msg)"},{"line_number":256,"context_line":"            raise"},{"line_number":257,"context_line":"        if name and name.isspace():"},{"line_number":258,"context_line":"            msg \u003d _(\u0027Flavor name cannot be empty.\u0027)"},{"line_number":259,"context_line":"            self._errors[\u0027name\u0027] \u003d self.error_class([msg])"},{"line_number":260,"context_line":"        # Check if there is no flavor with the same name"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_15772a3c","line":257,"updated":"2016-07-10 01:13:57.000000000","message":"Make this check before API call of flavor list. 2 advantages of doing this... one no unnecessary API call, quick turnaround time for reporting error","commit_id":"2ea443e2817e58da2a3aa5bed9b233bf5b97f23a"},{"author":{"_account_id":19774,"name":"Vivek Agrawal","email":"vivek.agrawal@veritas.com","username":"viveksagrawal"},"change_message_id":"88c874dae33fabaa59247346772e0a61c49ef026","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        flavor_id \u003d self.cleaned_data.get(\u0027flavor_id\u0027)"},{"line_number":250,"context_line":"        if name and name.isspace():"},{"line_number":251,"context_line":"            msg \u003d _(\u0027Flavor name cannot be empty.\u0027)"},{"line_number":252,"context_line":"            self._errors[\u0027name\u0027] \u003d self.error_class([msg])"},{"line_number":253,"context_line":"        try:"},{"line_number":254,"context_line":"            flavors \u003d api.nova.flavor_list(self.request, None)"},{"line_number":255,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_8a7f4316","line":252,"updated":"2016-07-11 18:55:09.000000000","message":"we should return self.cleaned_data from here. Otherwise we will still do the fetching and comparison unnecessarily.","commit_id":"b9090fad3f0979d272bbb744997452a64bc72127"}]}
