)]}'
{"horizon/tables/views.py":[{"author":{"_account_id":9155,"name":"Eddie Ramirez","email":"eddie.ramirez@intel.com","username":"ediardo"},"change_message_id":"2e462d0e32d346d01107ade8101e6fc39e4d5e32","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            if filter_action.is_api_filter(filter_field):"},{"line_number":300,"context_line":"                filter_string \u003d self.table.get_filter_string().strip()"},{"line_number":301,"context_line":"                if filter_field and filter_string:"},{"line_number":302,"context_line":"                    if filter_field in map:"},{"line_number":303,"context_line":"                        fil_map \u003d map.get(filter_field)"},{"line_number":304,"context_line":"                        filters[filter_field] \u003d fil_map.get("},{"line_number":305,"context_line":"                            filter_string.lower())"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_be911849","line":302,"range":{"start_line":302,"start_character":39,"end_line":302,"end_character":42},"updated":"2016-07-13 22:12:36.000000000","message":"map is a built-in function","commit_id":"7a2974a8dbcfebd103492b9f46e89c74ec993d9c"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"df5b694fb3e2297f985e1fecc279e19618a323ce","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            if filter_action.is_api_filter(filter_field):"},{"line_number":300,"context_line":"                filter_string \u003d self.table.get_filter_string().strip()"},{"line_number":301,"context_line":"                if filter_field and filter_string:"},{"line_number":302,"context_line":"                    if filter_field in map:"},{"line_number":303,"context_line":"                        fil_map \u003d map.get(filter_field)"},{"line_number":304,"context_line":"                        filters[filter_field] \u003d fil_map.get("},{"line_number":305,"context_line":"                            filter_string.lower())"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_9ee37ca4","line":302,"range":{"start_line":302,"start_character":39,"end_line":302,"end_character":42},"in_reply_to":"1aa78d24_be911849","updated":"2016-07-13 22:21:12.000000000","message":"Done","commit_id":"7a2974a8dbcfebd103492b9f46e89c74ec993d9c"},{"author":{"_account_id":9155,"name":"Eddie Ramirez","email":"eddie.ramirez@intel.com","username":"ediardo"},"change_message_id":"85fa707db761aa40be2b2df98cbfd56e4adeeb2a","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    def get_filters(self, filters\u003dNone, map_filters\u003dNone):"},{"line_number":290,"context_line":"        \"\"\"Converts a string given by the user into a valid api filter value."},{"line_number":291,"context_line":"        -filters: Default filter values."},{"line_number":292,"context_line":"        -map_filters: mapping between user input and valid api filter values."},{"line_number":293,"context_line":"        \"\"\""},{"line_number":294,"context_line":"        filters \u003d filters or {}"},{"line_number":295,"context_line":"        map_filters \u003d map_filters or {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_0a836599","line":292,"range":{"start_line":292,"start_character":9,"end_line":292,"end_character":76},"updated":"2016-07-19 21:26:00.000000000","message":"Hi Juan, an example of this parameter and the first one would be nice to have.","commit_id":"89e574fa432a52fa73f1b01b5c4bdaf8bd06453a"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"901456b3706bfbf01ef4761c33a5be6e880149ba","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    def get_filters(self, filters\u003dNone, map_filters\u003dNone):"},{"line_number":290,"context_line":"        \"\"\"Converts a string given by the user into a valid api filter value."},{"line_number":291,"context_line":"        -filters: Default filter values."},{"line_number":292,"context_line":"        -map_filters: mapping between user input and valid api filter values."},{"line_number":293,"context_line":"        \"\"\""},{"line_number":294,"context_line":"        filters \u003d filters or {}"},{"line_number":295,"context_line":"        map_filters \u003d map_filters or {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_905b0887","line":292,"range":{"start_line":292,"start_character":9,"end_line":292,"end_character":76},"in_reply_to":"dada55a8_0a836599","updated":"2016-07-19 22:24:20.000000000","message":"Done","commit_id":"89e574fa432a52fa73f1b01b5c4bdaf8bd06453a"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"1ef5833615336f13b9c65180828647558526e52e","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        filters \u003d filters or {}"},{"line_number":295,"context_line":"        map_filters \u003d map_filters or {}"},{"line_number":296,"context_line":"        filter_action \u003d self.table._meta._filter_action"},{"line_number":297,"context_line":"        if filter_action:"},{"line_number":298,"context_line":"            filter_field \u003d self.table.get_filter_field()"},{"line_number":299,"context_line":"            if filter_action.is_api_filter(filter_field):"},{"line_number":300,"context_line":"                filter_string \u003d self.table.get_filter_string().strip()"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_aaacd935","line":297,"updated":"2016-07-19 21:23:33.000000000","message":"Any way to make this more human readable, optimized? Else LGTM","commit_id":"89e574fa432a52fa73f1b01b5c4bdaf8bd06453a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"9cce8fefa4d560381aa171721dbe9298aff03884","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            return shortcuts.redirect(self.get_table().get_absolute_url())"},{"line_number":287,"context_line":"        return self.get(request, *args, **kwargs)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def get_filters(self, filters\u003dNone, filters_map\u003dNone):"},{"line_number":290,"context_line":"        \"\"\"Converts a string given by the user into a valid api filter value."},{"line_number":291,"context_line":"        -filters: Default filter values."},{"line_number":292,"context_line":"        e. g."}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_337093dc","line":289,"updated":"2016-07-25 05:40:09.000000000","message":"I\u0027m confused about where filters_map came from. I can\u0027t see any invocation of get_filters providing it. Dependent patch 329184 has a map_filters argument. Probably the same thing, but the names don\u0027t match up.","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"9fdb2c0aa5c072dac8750ffee74bec5d9b35b159","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            return shortcuts.redirect(self.get_table().get_absolute_url())"},{"line_number":287,"context_line":"        return self.get(request, *args, **kwargs)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def get_filters(self, filters\u003dNone, filters_map\u003dNone):"},{"line_number":290,"context_line":"        \"\"\"Converts a string given by the user into a valid api filter value."},{"line_number":291,"context_line":"        -filters: Default filter values."},{"line_number":292,"context_line":"        e. g."}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_c77f9664","line":289,"in_reply_to":"dada55a8_337093dc","updated":"2016-07-25 15:53:00.000000000","message":"I changed the name to make it look better but Havent done it yet in the patch 329184, but yes it\u0027s the same thing, the idea is to use it in patches other filters.","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"9e917720de3f496c3784a30e888a475120b9908d","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            return shortcuts.redirect(self.get_table().get_absolute_url())"},{"line_number":287,"context_line":"        return self.get(request, *args, **kwargs)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def get_filters(self, filters\u003dNone, filters_map\u003dNone):"},{"line_number":290,"context_line":"        \"\"\"Converts a string given by the user into a valid api filter value."},{"line_number":291,"context_line":"        -filters: Default filter values."},{"line_number":292,"context_line":"        e. g."}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_81cb1b72","line":289,"in_reply_to":"dada55a8_c77f9664","updated":"2016-07-27 21:54:05.000000000","message":"Done","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"84741dd699379471b4ca91d0c7352cc81e5943d0","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def get_filters(self, filters\u003dNone, filters_map\u003dNone):"},{"line_number":290,"context_line":"        \"\"\"Converts a string given by the user into a valid api filter value."},{"line_number":291,"context_line":"        -filters: Default filter values."},{"line_number":292,"context_line":"        e. g."},{"line_number":293,"context_line":"          {\u0027filter1\u0027: filter_value, \u0027filter2\u0027: filter_value}"},{"line_number":294,"context_line":"        -filters_map: mapping between user input and valid api filter values."}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_6351d262","line":291,"range":{"start_line":291,"start_character":8,"end_line":291,"end_character":40},"updated":"2016-07-27 20:12:31.000000000","message":"If we describe arguments of a method, it is better to follow Sphinx convention.\n\n :parameter filters: Default filter values.\n ...\n :parameter filters_map: ...","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"64561594478c0006d2105cd3b5503faae11ee38d","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def get_filters(self, filters\u003dNone, filters_map\u003dNone):"},{"line_number":290,"context_line":"        \"\"\"Converts a string given by the user into a valid api filter value."},{"line_number":291,"context_line":"        -filters: Default filter values."},{"line_number":292,"context_line":"        e. g."},{"line_number":293,"context_line":"          {\u0027filter1\u0027: filter_value, \u0027filter2\u0027: filter_value}"},{"line_number":294,"context_line":"        -filters_map: mapping between user input and valid api filter values."}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_a91d6b68","line":291,"range":{"start_line":291,"start_character":8,"end_line":291,"end_character":40},"in_reply_to":"bacf61ea_6351d262","updated":"2016-07-27 20:38:06.000000000","message":"Working on it.","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"9e917720de3f496c3784a30e888a475120b9908d","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def get_filters(self, filters\u003dNone, filters_map\u003dNone):"},{"line_number":290,"context_line":"        \"\"\"Converts a string given by the user into a valid api filter value."},{"line_number":291,"context_line":"        -filters: Default filter values."},{"line_number":292,"context_line":"        e. g."},{"line_number":293,"context_line":"          {\u0027filter1\u0027: filter_value, \u0027filter2\u0027: filter_value}"},{"line_number":294,"context_line":"        -filters_map: mapping between user input and valid api filter values."}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_01bf2bd1","line":291,"range":{"start_line":291,"start_character":8,"end_line":291,"end_character":40},"in_reply_to":"bacf61ea_a91d6b68","updated":"2016-07-27 21:54:05.000000000","message":"Done","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"84741dd699379471b4ca91d0c7352cc81e5943d0","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                    if filter_field in filters_map:"},{"line_number":307,"context_line":"                        filter_map \u003d filters_map.get(filter_field)"},{"line_number":308,"context_line":"                        filters[filter_field] \u003d filter_map.get("},{"line_number":309,"context_line":"                            filter_string.lower())"},{"line_number":310,"context_line":"                    else:"},{"line_number":311,"context_line":"                        filters[filter_field] \u003d filter_string"},{"line_number":312,"context_line":"        return filters"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_2e09812d","line":309,"range":{"start_line":309,"start_character":42,"end_line":309,"end_character":49},"updated":"2016-07-27 20:12:31.000000000","message":"why do we need lower()?\n\nIf there is a reasonable reason, the comment should be added.","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"64561594478c0006d2105cd3b5503faae11ee38d","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                    if filter_field in filters_map:"},{"line_number":307,"context_line":"                        filter_map \u003d filters_map.get(filter_field)"},{"line_number":308,"context_line":"                        filters[filter_field] \u003d filter_map.get("},{"line_number":309,"context_line":"                            filter_string.lower())"},{"line_number":310,"context_line":"                    else:"},{"line_number":311,"context_line":"                        filters[filter_field] \u003d filter_string"},{"line_number":312,"context_line":"        return filters"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_2e9fc104","line":309,"range":{"start_line":309,"start_character":42,"end_line":309,"end_character":49},"in_reply_to":"bacf61ea_2e09812d","updated":"2016-07-27 20:38:06.000000000","message":"The filter string is the input of the user so in the mapping filter \u0027shared\u0027 can have value \u0027yes\u0027 for true and \u0027no\u0027 for false as an example. I use lower to only use in mappings _(\u0027yes\u0027) for true values if not we should add a map for each (yes, Yes, YES, yEs, ...) or maybe just the common probably inputs (yes, Yes, YES) but it would add a lot of lines of Mappings.","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"9e917720de3f496c3784a30e888a475120b9908d","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                    if filter_field in filters_map:"},{"line_number":307,"context_line":"                        filter_map \u003d filters_map.get(filter_field)"},{"line_number":308,"context_line":"                        filters[filter_field] \u003d filter_map.get("},{"line_number":309,"context_line":"                            filter_string.lower())"},{"line_number":310,"context_line":"                    else:"},{"line_number":311,"context_line":"                        filters[filter_field] \u003d filter_string"},{"line_number":312,"context_line":"        return filters"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_c1c5135c","line":309,"range":{"start_line":309,"start_character":42,"end_line":309,"end_character":49},"in_reply_to":"bacf61ea_2e9fc104","updated":"2016-07-27 21:54:05.000000000","message":"Done","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"639e442d32114f821647b8243c8aa1311688f76b","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                    if filter_field in filters_map:"},{"line_number":307,"context_line":"                        filter_map \u003d filters_map.get(filter_field)"},{"line_number":308,"context_line":"                        filters[filter_field] \u003d filter_map.get("},{"line_number":309,"context_line":"                            filter_string.lower())"},{"line_number":310,"context_line":"                    else:"},{"line_number":311,"context_line":"                        filters[filter_field] \u003d filter_string"},{"line_number":312,"context_line":"        return filters"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_6a917352","line":309,"range":{"start_line":309,"start_character":42,"end_line":309,"end_character":49},"in_reply_to":"bacf61ea_2e9fc104","updated":"2016-07-28 15:51:47.000000000","message":"Thanks for clarification. This kind of normalization sounds good.","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"84741dd699379471b4ca91d0c7352cc81e5943d0","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                        filters[filter_field] \u003d filter_map.get("},{"line_number":309,"context_line":"                            filter_string.lower())"},{"line_number":310,"context_line":"                    else:"},{"line_number":311,"context_line":"                        filters[filter_field] \u003d filter_string"},{"line_number":312,"context_line":"        return filters"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_8e1a2d6d","line":311,"updated":"2016-07-27 20:12:31.000000000","message":"The logic in L.306-311 can be:\n\n  filter_map \u003d filters_map.get(filter_field, {})\n  filters[filter_filed] \u003d filter_map.get(filter_string, filter_string)\n\nThis simplifies the logic if lower() is not needed.","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"64561594478c0006d2105cd3b5503faae11ee38d","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                        filters[filter_field] \u003d filter_map.get("},{"line_number":309,"context_line":"                            filter_string.lower())"},{"line_number":310,"context_line":"                    else:"},{"line_number":311,"context_line":"                        filters[filter_field] \u003d filter_string"},{"line_number":312,"context_line":"        return filters"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_ce99c521","line":311,"in_reply_to":"bacf61ea_8e1a2d6d","updated":"2016-07-27 20:38:06.000000000","message":"In the current case it returns None if the filter is in the Mapping but there is no valid value for true or false, in your case it returns the input of the user. I guess that in both cases its an invalid parameter to the API call so it wont return any value so I think I can change that.","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"9e917720de3f496c3784a30e888a475120b9908d","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                        filters[filter_field] \u003d filter_map.get("},{"line_number":309,"context_line":"                            filter_string.lower())"},{"line_number":310,"context_line":"                    else:"},{"line_number":311,"context_line":"                        filters[filter_field] \u003d filter_string"},{"line_number":312,"context_line":"        return filters"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_61ab878a","line":311,"in_reply_to":"bacf61ea_ce99c521","updated":"2016-07-27 21:54:05.000000000","message":"Done","commit_id":"e97de26f7546e9f1a2c705b4edb79b45c4ab7778"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"75e9de3a5cdf4603a817e3c57894457aa7f9b329","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            if filter_action.is_api_filter(filter_field):"},{"line_number":302,"context_line":"                filter_string \u003d self.table.get_filter_string().strip()"},{"line_number":303,"context_line":"                if filter_field and filter_string:"},{"line_number":304,"context_line":"                    if filter_field in filters_map:"},{"line_number":305,"context_line":"                        filter_map \u003d filters_map.get(filter_field, {})"},{"line_number":306,"context_line":"                        # We use the filter_string given by the user and"},{"line_number":307,"context_line":"                        # look for valid values in the filter_map that\u0027s why"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_4a274f64","line":304,"range":{"start_line":304,"start_character":20,"end_line":304,"end_character":51},"updated":"2016-07-28 15:53:30.000000000","message":"I think this if-clause is unnecessary.\nWe would like to set filters[filter_field] regardless of whether filter_field is contained in filters_map.","commit_id":"3e146ec6d06ec3d5496801d8e947923e4824c40b"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"efdf2240a4abac288054879ae7667ad76172e3f9","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            if filter_action.is_api_filter(filter_field):"},{"line_number":302,"context_line":"                filter_string \u003d self.table.get_filter_string().strip()"},{"line_number":303,"context_line":"                if filter_field and filter_string:"},{"line_number":304,"context_line":"                    if filter_field in filters_map:"},{"line_number":305,"context_line":"                        filter_map \u003d filters_map.get(filter_field, {})"},{"line_number":306,"context_line":"                        # We use the filter_string given by the user and"},{"line_number":307,"context_line":"                        # look for valid values in the filter_map that\u0027s why"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_622e7744","line":304,"range":{"start_line":304,"start_character":20,"end_line":304,"end_character":51},"in_reply_to":"bacf61ea_4a274f64","updated":"2016-07-29 18:30:22.000000000","message":"Right, I just noticed that with this change I broke all other dependent patches, now is fixed.","commit_id":"3e146ec6d06ec3d5496801d8e947923e4824c40b"}]}
