)]}'
{"horizon/static/horizon/js/horizon.instances.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1c5453090a55c253125d9e6765cc15010413a7c0","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    });"},{"line_number":134,"context_line":"    if ($(\"#networkListId \u003e div.form-group.error\").length \u003e 0) {"},{"line_number":135,"context_line":"      var errortext \u003d $(\"#networkListId \u003e div.form-group.error span.help-block\").text();"},{"line_number":136,"context_line":"      $(\"#selected_network_label\").before($(\u0027\u003cdiv class\u003d\"dynamic-error\"\u003e\u0027).html(errortext));"},{"line_number":137,"context_line":"    }"},{"line_number":138,"context_line":"    $(\".networklist\").sortable({"},{"line_number":139,"context_line":"      connectWith: \"ul.networklist\","}],"source_content_type":"text/javascript","patch_set":10,"id":"ba5da102_093baeec","side":"PARENT","line":136,"updated":"2016-10-26 14:45:30.000000000","message":"this is now changed to \"#selected_network_h4\"\n\nI think we need to update _update_networks.html too\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/templates/instances/_update_networks.html#L6","commit_id":"dd66682da7818471f34400c2e08e0e5b6b779a71"},{"author":{"_account_id":20752,"name":"Ernest Millan","email":"millan@gmail.com","username":"millan"},"change_message_id":"5306fdee2b2321b614ab9e34c0c8a6b4f58611e7","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    });"},{"line_number":134,"context_line":"    if ($(\"#networkListId \u003e div.form-group.error\").length \u003e 0) {"},{"line_number":135,"context_line":"      var errortext \u003d $(\"#networkListId \u003e div.form-group.error span.help-block\").text();"},{"line_number":136,"context_line":"      $(\"#selected_network_label\").before($(\u0027\u003cdiv class\u003d\"dynamic-error\"\u003e\u0027).html(errortext));"},{"line_number":137,"context_line":"    }"},{"line_number":138,"context_line":"    $(\".networklist\").sortable({"},{"line_number":139,"context_line":"      connectWith: \"ul.networklist\","}],"source_content_type":"text/javascript","patch_set":10,"id":"9a629dbe_d87897fb","side":"PARENT","line":136,"in_reply_to":"ba5da102_093baeec","updated":"2016-11-07 15:54:59.000000000","message":"Thanks Cindy. Updated.","commit_id":"dd66682da7818471f34400c2e08e0e5b6b779a71"}],"horizon/static/horizon/js/horizon.lists.js":[{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"039fb2484cdea2ad4d11bb129a38dc46d0503c2e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"   **/"},{"line_number":7,"context_line":"  generate_element: function (name, value, type) {"},{"line_number":8,"context_line":"    var $li \u003d $(\u0027\u003cli\u003e\u0027);"},{"line_number":9,"context_line":"    $li.attr(\u0027name\u0027, value).html(name + \u0027\u003cem class\u003d\"\u0027+type+\u0027_id\"\u003e(\u0027 + value + \u0027)\u003c/em\u003e\u003ca href\u003d\"#\" class\u003d\"btn btn-primary\"\u003e\u003c/a\u003e\u0027);"},{"line_number":10,"context_line":"    return $li;"},{"line_number":11,"context_line":"  },"},{"line_number":12,"context_line":""}],"source_content_type":"text/javascript","patch_set":6,"id":"9ad45d7e_ad1f37b6","line":9,"updated":"2016-08-12 14:19:21.000000000","message":"is there any way to wrap this line for readability? no longer than 100 characters","commit_id":"1d1c462f8e8d94ad35f84f2ed1a36fdfdbe140ba"},{"author":{"_account_id":20752,"name":"Ernest Millan","email":"millan@gmail.com","username":"millan"},"change_message_id":"ca0a6a24dbeaff6596a317c442c58f798cd6f32d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"   **/"},{"line_number":7,"context_line":"  generate_element: function (name, value, type) {"},{"line_number":8,"context_line":"    var $li \u003d $(\u0027\u003cli\u003e\u0027);"},{"line_number":9,"context_line":"    $li.attr(\u0027name\u0027, value).html(name + \u0027\u003cem class\u003d\"\u0027+type+\u0027_id\"\u003e(\u0027 + value + \u0027)\u003c/em\u003e\u003ca href\u003d\"#\" class\u003d\"btn btn-primary\"\u003e\u003c/a\u003e\u0027);"},{"line_number":10,"context_line":"    return $li;"},{"line_number":11,"context_line":"  },"},{"line_number":12,"context_line":""}],"source_content_type":"text/javascript","patch_set":6,"id":"3ac371cc_7c32b211","line":9,"in_reply_to":"9ad45d7e_ad1f37b6","updated":"2016-08-16 16:38:59.000000000","message":"Thanks. Updated.","commit_id":"1d1c462f8e8d94ad35f84f2ed1a36fdfdbe140ba"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"039fb2484cdea2ad4d11bb129a38dc46d0503c2e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    var append_new_elements \u003d function (type, state) {"},{"line_number":41,"context_line":"      $(\"#\"+state+\"_\"+type).empty();"},{"line_number":42,"context_line":"      $.each(self[type+\"s_\"+state], function (index, value) {"},{"line_number":43,"context_line":"        $(\"#\"+state+\"_\"+self.feature_type).append(self.generate_element(value.name, value.value, self.feature_type));"},{"line_number":44,"context_line":"      });"},{"line_number":45,"context_line":"    };"},{"line_number":46,"context_line":""}],"source_content_type":"text/javascript","patch_set":6,"id":"9ad45d7e_cd7c2bee","line":43,"updated":"2016-08-12 14:19:21.000000000","message":"ditto","commit_id":"1d1c462f8e8d94ad35f84f2ed1a36fdfdbe140ba"},{"author":{"_account_id":20752,"name":"Ernest Millan","email":"millan@gmail.com","username":"millan"},"change_message_id":"ca0a6a24dbeaff6596a317c442c58f798cd6f32d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    var append_new_elements \u003d function (type, state) {"},{"line_number":41,"context_line":"      $(\"#\"+state+\"_\"+type).empty();"},{"line_number":42,"context_line":"      $.each(self[type+\"s_\"+state], function (index, value) {"},{"line_number":43,"context_line":"        $(\"#\"+state+\"_\"+self.feature_type).append(self.generate_element(value.name, value.value, self.feature_type));"},{"line_number":44,"context_line":"      });"},{"line_number":45,"context_line":"    };"},{"line_number":46,"context_line":""}],"source_content_type":"text/javascript","patch_set":6,"id":"3ac371cc_fc26a2cc","line":43,"in_reply_to":"9ad45d7e_cd7c2bee","updated":"2016-08-16 16:38:59.000000000","message":"Updated too. Thanks.","commit_id":"1d1c462f8e8d94ad35f84f2ed1a36fdfdbe140ba"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"959db3b55f523de1acd72b7cf412cd93460eb1a6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    var $li \u003d $(\u0027\u003cli\u003e\u0027);"},{"line_number":9,"context_line":"    $li.attr(\u0027name\u0027, value).html("},{"line_number":10,"context_line":"      name + \u0027\u003cem class\u003d\"\u0027 + type + \u0027_id\"\u003e(\u0027 + value + \u0027)\u003c/em\u003e\u0027"},{"line_number":11,"context_line":"      + \u0027\u003ca href\u003d\"#\" class\u003d\"btn btn-primary\"\u003e\u003c/a\u003e\u0027"},{"line_number":12,"context_line":"    );"},{"line_number":13,"context_line":"    return $li;"},{"line_number":14,"context_line":"  },"}],"source_content_type":"text/javascript","patch_set":7,"id":"3ac371cc_acacf235","line":11,"updated":"2016-08-16 20:30:41.000000000","message":"\u0027+\u0027 should be placed at the end of the line  operator-linebreak","commit_id":"23daf525d7fd4034238fd079e9d4efb39436b4c7"},{"author":{"_account_id":20752,"name":"Ernest Millan","email":"millan@gmail.com","username":"millan"},"change_message_id":"13fc5338f07808be57dd5bf4641abcd4eeb18e71","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    var $li \u003d $(\u0027\u003cli\u003e\u0027);"},{"line_number":9,"context_line":"    $li.attr(\u0027name\u0027, value).html("},{"line_number":10,"context_line":"      name + \u0027\u003cem class\u003d\"\u0027 + type + \u0027_id\"\u003e(\u0027 + value + \u0027)\u003c/em\u003e\u0027"},{"line_number":11,"context_line":"      + \u0027\u003ca href\u003d\"#\" class\u003d\"btn btn-primary\"\u003e\u003c/a\u003e\u0027"},{"line_number":12,"context_line":"    );"},{"line_number":13,"context_line":"    return $li;"},{"line_number":14,"context_line":"  },"}],"source_content_type":"text/javascript","patch_set":7,"id":"3ac371cc_df8c6e81","line":11,"in_reply_to":"3ac371cc_acacf235","updated":"2016-08-16 20:35:40.000000000","message":"Thanks for the heads-up. Updated now.","commit_id":"23daf525d7fd4034238fd079e9d4efb39436b4c7"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"ea68814b4c58139cf27d5f11bed65e592a01f7d2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      error: function () {"},{"line_number":106,"context_line":"        if(via_user_submit) {"},{"line_number":107,"context_line":"          horizon.clearErrorMessages();"},{"line_number":108,"context_line":"          horizon.alert(\u0027error\u0027, gettext(error_txt));"},{"line_number":109,"context_line":"        }"},{"line_number":110,"context_line":"      }"},{"line_number":111,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":9,"id":"3a98d1f4_a7b6acf6","line":108,"updated":"2016-10-03 04:53:57.000000000","message":"This won\u0027t be translated  - gettext() must wrap the actual string to be translated. Just move the gettext() from here up to where error_txt is defined.","commit_id":"09df8285eae912a276ced1b3ee87efb63e914389"},{"author":{"_account_id":20752,"name":"Ernest Millan","email":"millan@gmail.com","username":"millan"},"change_message_id":"ecf128463eb1bf83ad3fe081769dec74b7801820","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      error: function () {"},{"line_number":106,"context_line":"        if(via_user_submit) {"},{"line_number":107,"context_line":"          horizon.clearErrorMessages();"},{"line_number":108,"context_line":"          horizon.alert(\u0027error\u0027, gettext(error_txt));"},{"line_number":109,"context_line":"        }"},{"line_number":110,"context_line":"      }"},{"line_number":111,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":9,"id":"fa6399be_16639442","line":108,"in_reply_to":"3a98d1f4_a7b6acf6","updated":"2016-10-18 22:05:24.000000000","message":"Thanks for catching these. Fixes applied.","commit_id":"09df8285eae912a276ced1b3ee87efb63e914389"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"ea68814b4c58139cf27d5f11bed65e592a01f7d2","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    self[type+\"s_available\"] \u003d [];"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    $(horizon.lists.get_element(\"\", type)).each(function () {"},{"line_number":130,"context_line":"      var $this \u003d $(this).parent();"},{"line_number":131,"context_line":"      var $input \u003d $this.children(\"input\");"},{"line_number":132,"context_line":"      var name \u003d horizon.string.escapeHtml($this.text().replace(/^\\s+/, \"\"));"},{"line_number":133,"context_line":"      var network_property \u003d {"}],"source_content_type":"text/javascript","patch_set":9,"id":"3a98d1f4_e77a7423","line":130,"updated":"2016-10-03 04:53:57.000000000","message":"This is confusing - why is it assigning $this to $(this).parent()? Why not call it $parent?","commit_id":"09df8285eae912a276ced1b3ee87efb63e914389"},{"author":{"_account_id":20752,"name":"Ernest Millan","email":"millan@gmail.com","username":"millan"},"change_message_id":"ecf128463eb1bf83ad3fe081769dec74b7801820","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    self[type+\"s_available\"] \u003d [];"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    $(horizon.lists.get_element(\"\", type)).each(function () {"},{"line_number":130,"context_line":"      var $this \u003d $(this).parent();"},{"line_number":131,"context_line":"      var $input \u003d $this.children(\"input\");"},{"line_number":132,"context_line":"      var name \u003d horizon.string.escapeHtml($this.text().replace(/^\\s+/, \"\"));"},{"line_number":133,"context_line":"      var network_property \u003d {"}],"source_content_type":"text/javascript","patch_set":9,"id":"fa6399be_365a5884","line":130,"in_reply_to":"3a98d1f4_e77a7423","updated":"2016-10-18 22:05:24.000000000","message":"Thanks again. Fix applied.","commit_id":"09df8285eae912a276ced1b3ee87efb63e914389"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"ea68814b4c58139cf27d5f11bed65e592a01f7d2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"      var $this \u003d $(this).parent();"},{"line_number":131,"context_line":"      var $input \u003d $this.children(\"input\");"},{"line_number":132,"context_line":"      var name \u003d horizon.string.escapeHtml($this.text().replace(/^\\s+/, \"\"));"},{"line_number":133,"context_line":"      var network_property \u003d {"},{"line_number":134,"context_line":"        \"name\": name,"},{"line_number":135,"context_line":"        \"id\": $input.attr(\"id\"),"},{"line_number":136,"context_line":"        \"value\": $input.attr(\"value\")"}],"source_content_type":"text/javascript","patch_set":9,"id":"3a98d1f4_8781b0fd","line":133,"updated":"2016-10-03 04:53:57.000000000","message":"\"network_property\" here is a holdover from one of the specific uses, should just be \"properties\".","commit_id":"09df8285eae912a276ced1b3ee87efb63e914389"},{"author":{"_account_id":20752,"name":"Ernest Millan","email":"millan@gmail.com","username":"millan"},"change_message_id":"ecf128463eb1bf83ad3fe081769dec74b7801820","unresolved":false,"context_lines":[{"line_number":130,"context_line":"      var $this \u003d $(this).parent();"},{"line_number":131,"context_line":"      var $input \u003d $this.children(\"input\");"},{"line_number":132,"context_line":"      var name \u003d horizon.string.escapeHtml($this.text().replace(/^\\s+/, \"\"));"},{"line_number":133,"context_line":"      var network_property \u003d {"},{"line_number":134,"context_line":"        \"name\": name,"},{"line_number":135,"context_line":"        \"id\": $input.attr(\"id\"),"},{"line_number":136,"context_line":"        \"value\": $input.attr(\"value\")"}],"source_content_type":"text/javascript","patch_set":9,"id":"fa6399be_565d0c78","line":133,"in_reply_to":"3a98d1f4_8781b0fd","updated":"2016-10-18 22:05:24.000000000","message":"Thanks again. Fix applied.","commit_id":"09df8285eae912a276ced1b3ee87efb63e914389"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1c5453090a55c253125d9e6765cc15010413a7c0","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    if ($(\"#\"+type+\"ListId \u003e div.form-group.error\").length \u003e 0) {"},{"line_number":72,"context_line":"      var errortext \u003d $(\"#\"+type+\"ListId \u003e div.form-group.error\").find(\"span.help-block\").text();"},{"line_number":73,"context_line":"      $(\"#selected_\"+type+\"_h4\").before($(\u0027\u003cdiv class\u003d\"dynamic-error\"\u003e\u0027).html(errortext));"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    $(\".\"+type+\"list\").sortable({"}],"source_content_type":"text/javascript","patch_set":10,"id":"ba5da102_29bb1274","line":73,"updated":"2016-10-26 14:45:30.000000000","message":"\"_h4_\u0027 --\u003e \u0027_label\u0027?\n\n(See other comment. I think we should keep as \"_label\" but then one of the HTML files needs to change.","commit_id":"3c55fb482c9ea74e34b88e42a19482be207a8838"},{"author":{"_account_id":20752,"name":"Ernest Millan","email":"millan@gmail.com","username":"millan"},"change_message_id":"5306fdee2b2321b614ab9e34c0c8a6b4f58611e7","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    if ($(\"#\"+type+\"ListId \u003e div.form-group.error\").length \u003e 0) {"},{"line_number":72,"context_line":"      var errortext \u003d $(\"#\"+type+\"ListId \u003e div.form-group.error\").find(\"span.help-block\").text();"},{"line_number":73,"context_line":"      $(\"#selected_\"+type+\"_h4\").before($(\u0027\u003cdiv class\u003d\"dynamic-error\"\u003e\u0027).html(errortext));"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    $(\".\"+type+\"list\").sortable({"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a629dbe_786a2b1c","line":73,"in_reply_to":"ba5da102_29bb1274","updated":"2016-11-07 15:54:59.000000000","message":"Good catch. Thanks Cindy. Updated.","commit_id":"3c55fb482c9ea74e34b88e42a19482be207a8838"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1c5453090a55c253125d9e6765cc15010413a7c0","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      error: function () {"},{"line_number":106,"context_line":"        if(via_user_submit) {"},{"line_number":107,"context_line":"          horizon.clearErrorMessages();"},{"line_number":108,"context_line":"          horizon.alert(\u0027error\u0027, error_txt);"},{"line_number":109,"context_line":"        }"},{"line_number":110,"context_line":"      }"},{"line_number":111,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":10,"id":"ba5da102_0912ce62","line":108,"updated":"2016-10-26 14:45:30.000000000","message":"please use new angular toast service\n\nhorizon.toast.add(\u0027error\u0027, error_txt);","commit_id":"3c55fb482c9ea74e34b88e42a19482be207a8838"},{"author":{"_account_id":20752,"name":"Ernest Millan","email":"millan@gmail.com","username":"millan"},"change_message_id":"5306fdee2b2321b614ab9e34c0c8a6b4f58611e7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      error: function () {"},{"line_number":106,"context_line":"        if(via_user_submit) {"},{"line_number":107,"context_line":"          horizon.clearErrorMessages();"},{"line_number":108,"context_line":"          horizon.alert(\u0027error\u0027, error_txt);"},{"line_number":109,"context_line":"        }"},{"line_number":110,"context_line":"      }"},{"line_number":111,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a629dbe_d85fb773","line":108,"in_reply_to":"ba5da102_0912ce62","updated":"2016-11-07 15:54:59.000000000","message":"Updated. Thanks.","commit_id":"3c55fb482c9ea74e34b88e42a19482be207a8838"}]}