)]}'
{"openstack_dashboard/usage/quotas.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"0bf9d7e37a554694254d41b81cb7bf1a00d3039a","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"def _get_tenant_compute_usages(request, usages, disabled_quotas, tenant_id):"},{"line_number":276,"context_line":"    # Can\u0027t check for the presence of \u0027instances\u0027 in disabled_quotas since"},{"line_number":277,"context_line":"    # there\u0027s an expectation introduced in"},{"line_number":278,"context_line":"    # https://review.openstack.org/#/c/215277 that nova usage information be"},{"line_number":279,"context_line":"    # presented even if quotas are disabled. Instead, check if nova\u0027s present"},{"line_number":280,"context_line":"    if not base.is_service_enabled(request, \u0027compute\u0027):"},{"line_number":281,"context_line":"        return"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_f642203d","line":279,"range":{"start_line":276,"start_character":4,"end_line":279,"end_character":77},"updated":"2016-07-26 11:08:13.000000000","message":"I\u0027m failing to see why that is true, because disabled_quotas doesn\u0027t contain info about quota usages, it\u0027s just a list (or set) of disabled quotas. Could you please elaborate?","commit_id":"f49620229188138c2dff272763ea37af0ec8eec9"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"838649652fcaf465870101d834d06957ae35ba20","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"def _get_tenant_compute_usages(request, usages, disabled_quotas, tenant_id):"},{"line_number":276,"context_line":"    # Can\u0027t check for the presence of \u0027instances\u0027 in disabled_quotas since"},{"line_number":277,"context_line":"    # there\u0027s an expectation introduced in"},{"line_number":278,"context_line":"    # https://review.openstack.org/#/c/215277 that nova usage information be"},{"line_number":279,"context_line":"    # presented even if quotas are disabled. Instead, check if nova\u0027s present"},{"line_number":280,"context_line":"    if not base.is_service_enabled(request, \u0027compute\u0027):"},{"line_number":281,"context_line":"        return"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_58218d4c","line":279,"range":{"start_line":276,"start_character":4,"end_line":279,"end_character":77},"in_reply_to":"dada55a8_f642203d","updated":"2016-07-26 14:41:11.000000000","message":"This comment\u0027s not very clear, but what I meant was that disabled_quotas \u0026 \u0027instances\u0027 is overloaded with this patch and the \u0027nova has quota\u0027 change; it can either mean \"nova is present but has no quota support\" or \"nova does not exist\". In the first instance we want usage info; in the second we don\u0027t. Because this check\u0027s different from other services i added a comment which confused everyone :)\n\nI\u0027ll reword it","commit_id":"f49620229188138c2dff272763ea37af0ec8eec9"}],"releasenotes/notes/horizon-without-nova-3cd0a84109ed2187.yaml":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"0bf9d7e37a554694254d41b81cb7bf1a00d3039a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  it will run as long as keystone is present (for instance,"},{"line_number":5,"context_line":"  swift-only deployments)."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  Nova and Glance are no longer required in order to run "},{"line_number":8,"context_line":"  Horizon. As long as keystone is present, Horizon will"},{"line_number":9,"context_line":"  run correctly."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dada55a8_9bb66df7","line":7,"range":{"start_line":7,"start_character":56,"end_line":7,"end_character":57},"updated":"2016-07-26 11:08:13.000000000","message":"trailing whitespace","commit_id":"f49620229188138c2dff272763ea37af0ec8eec9"}]}
