)]}'
{"horizon/themes.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"d0aeb05a4f0da1079ac3f2a28477bad4bd587fbf","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Get the themes from settings"},{"line_number":42,"context_line":"def get_themes():"},{"line_number":43,"context_line":"    return getattr(settings, \u0027AVAILABLE_THEMES\u0027, [get_default_theme()])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Get the themes dir from settings"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_401e5e0c","line":43,"range":{"start_line":43,"start_character":50,"end_line":43,"end_character":69},"updated":"2016-07-22 00:45:57.000000000","message":"That\u0027s not is expected as a single theme value - a tuple of (name, label, path) is expected as an item of AVAILABLE_THEMES list. See http://logs.openstack.org/28/345628/2/check/gate-sahara-dashboard-python27/d01fa95/console.html#_2016-07-21_20_41_20_427575 which is based on this patch - still failing.\n\nHaving that said, a unit test for themes machinery still working in the absence of AVAILABLE_THEMES would be nice.","commit_id":"f28d65b68d22efc23f3b32c8c5b4acff04737f4e"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"51610226a4e04fc00df6a2f46798c6c4d1c77f15","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Get the themes from settings"},{"line_number":42,"context_line":"def get_themes():"},{"line_number":43,"context_line":"    return getattr(settings, \u0027AVAILABLE_THEMES\u0027, [get_default_theme()])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Get the themes dir from settings"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_ef7ad576","line":43,"range":{"start_line":43,"start_character":50,"end_line":43,"end_character":69},"in_reply_to":"dada55a8_401e5e0c","updated":"2016-07-22 07:35:50.000000000","message":"Welp, you\u0027re correct. I rushed this patch it seems.","commit_id":"f28d65b68d22efc23f3b32c8c5b4acff04737f4e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2994dd648be443d338ae2c161d5d752431b1b619","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# Get the themes from settings"},{"line_number":42,"context_line":"def get_themes():"},{"line_number":43,"context_line":"    return getattr(settings, \u0027AVAILABLE_THEMES\u0027,"},{"line_number":44,"context_line":"                   [\u0027default\u0027, \u0027Default\u0027, \u0027themes/default\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Get the themes dir from settings"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8917c7ec","line":44,"range":{"start_line":44,"start_character":21,"end_line":44,"end_character":28},"updated":"2016-07-27 20:44:59.000000000","message":"get_default_theme() ?","commit_id":"66669d6b64d37e1164e795fa73dd0d4d60a96ad3"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2994dd648be443d338ae2c161d5d752431b1b619","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# Get the themes from settings"},{"line_number":42,"context_line":"def get_themes():"},{"line_number":43,"context_line":"    return getattr(settings, \u0027AVAILABLE_THEMES\u0027,"},{"line_number":44,"context_line":"                   [\u0027default\u0027, \u0027Default\u0027, \u0027themes/default\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Get the themes dir from settings"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_69e7f312","line":44,"range":{"start_line":44,"start_character":43,"end_line":44,"end_character":57},"updated":"2016-07-27 20:44:59.000000000","message":"os.path.join(get_theme_dir(), get_default_theme()) ?","commit_id":"66669d6b64d37e1164e795fa73dd0d4d60a96ad3"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"8936c581d77d4c0488831bc5c91d290160298d90","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# Get the themes from settings"},{"line_number":42,"context_line":"def get_themes():"},{"line_number":43,"context_line":"    return getattr(settings, \u0027AVAILABLE_THEMES\u0027,"},{"line_number":44,"context_line":"                   [\u0027default\u0027, \u0027Default\u0027, \u0027themes/default\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Get the themes dir from settings"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1fb74287","line":44,"range":{"start_line":44,"start_character":21,"end_line":44,"end_character":28},"in_reply_to":"bacf61ea_8917c7ec","updated":"2016-07-28 22:56:38.000000000","message":"Timur\u0027s right, this should be --\u003e [(get_default_theme(), get_default_theme(), os.path.join(get_theme_dir(), get_default_theme()))]","commit_id":"66669d6b64d37e1164e795fa73dd0d4d60a96ad3"}]}
