)]}'
{"openstack_dashboard/api/swift.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c7992a111c6c4683c5633a6d46c015d3ee4d9c66","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                                         auth_version\u003d\"2.0\")"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def swift_head_account(request, tenant_id\u003dNone):"},{"line_number":138,"context_line":"    headers \u003d swift_api(request, for_tenant_id\u003dtenant_id).head_account()"},{"line_number":139,"context_line":"    account_info \u003d {"},{"line_number":140,"context_line":"        \u0027objects\u0027: headers[\u0027x-account-object-count\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_e692ba4a","line":137,"updated":"2016-08-16 02:16:19.000000000","message":"Please add test code to this change:\nopenstack_dashboard\\test\\api_tests\\swift_tests.py","commit_id":"bf414a96ebed083dc9a4e58485f0f80999f66616"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c7992a111c6c4683c5633a6d46c015d3ee4d9c66","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        return {}"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"def tenant_quota_get(request, tenant_id):"},{"line_number":403,"context_line":"    \"\"\"Get quota limits for a tenant (account)\"\"\""},{"line_number":404,"context_line":"    account \u003d swift_head_account(request, tenant_id)"},{"line_number":405,"context_line":"    return base.QuotaSet({"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_669fea50","line":402,"updated":"2016-08-16 02:16:19.000000000","message":"ditto","commit_id":"bf414a96ebed083dc9a4e58485f0f80999f66616"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c7992a111c6c4683c5633a6d46c015d3ee4d9c66","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        \u0027object_count\u0027: account[\u0027metadata\u0027].get(\u0027meta_quota_count\u0027)})"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"def tenant_quota_update(request, tenant_id,"},{"line_number":411,"context_line":"                        object_bytes\u003dNone, object_count\u003dNone):"},{"line_number":412,"context_line":"    headers \u003d {}"},{"line_number":413,"context_line":"    if object_bytes:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_06b716d9","line":410,"updated":"2016-08-16 02:16:19.000000000","message":"ditto","commit_id":"bf414a96ebed083dc9a4e58485f0f80999f66616"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c7992a111c6c4683c5633a6d46c015d3ee4d9c66","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    return []"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"def can_set_quotas(request):"},{"line_number":426,"context_line":"    swift_admin_role \u003d getattr(settings, \u0027SWIFT_ADMIN_ROLE\u0027, \u0027ResellerAdmin\u0027)"},{"line_number":427,"context_line":"    return bool(list(filter(lambda r: r[\u0027name\u0027] \u003d\u003d swift_admin_role,"},{"line_number":428,"context_line":"                            request.user.roles)))"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_26b4d2cf","line":425,"updated":"2016-08-16 02:16:19.000000000","message":"ditto","commit_id":"bf414a96ebed083dc9a4e58485f0f80999f66616"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c7992a111c6c4683c5633a6d46c015d3ee4d9c66","unresolved":false,"context_lines":[{"line_number":425,"context_line":"def can_set_quotas(request):"},{"line_number":426,"context_line":"    swift_admin_role \u003d getattr(settings, \u0027SWIFT_ADMIN_ROLE\u0027, \u0027ResellerAdmin\u0027)"},{"line_number":427,"context_line":"    return bool(list(filter(lambda r: r[\u0027name\u0027] \u003d\u003d swift_admin_role,"},{"line_number":428,"context_line":"                            request.user.roles)))"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_261052a8","line":428,"updated":"2016-08-16 02:16:19.000000000","message":"What about ?\nreturn swift_admin_role in [r[\u0027name\u0027] for r in request.user.roles]","commit_id":"bf414a96ebed083dc9a4e58485f0f80999f66616"}],"openstack_dashboard/dashboards/identity/projects/tests.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c7992a111c6c4683c5633a6d46c015d3ee4d9c66","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                              set(quotas.NOVA_QUOTA_FIELDS) - disabled_quotas}"},{"line_number":377,"context_line":"        quotas.get_disabled_quotas(IsA(http.HttpRequest)) \\"},{"line_number":378,"context_line":"            .AndReturn(disabled_quotas)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        api.nova.tenant_quota_update(IsA(http.HttpRequest),"},{"line_number":381,"context_line":"                                     project.id,"},{"line_number":382,"context_line":"                                     **nova_updated_quota)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_66c6ca4a","line":379,"updated":"2016-08-16 02:16:19.000000000","message":"not needed","commit_id":"bf414a96ebed083dc9a4e58485f0f80999f66616"}],"openstack_dashboard/dashboards/identity/projects/workflows.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"70760da16da3f516d4a02f9e2ce605a6079438e6","unresolved":false,"context_lines":[{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        if cinder.is_volume_service_enabled(request):"},{"line_number":406,"context_line":"            cinder_data \u003d {key: data[key] for key in"},{"line_number":407,"context_line":"                           quotas.CINDER_QUOTA_FIELDS}"},{"line_number":408,"context_line":"            cinder.tenant_quota_update(request,"},{"line_number":409,"context_line":"                                       project_id,"},{"line_number":410,"context_line":"                                       **cinder_data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_4555764e","line":407,"updated":"2016-07-28 19:22:56.000000000","message":"seems like a separate change here","commit_id":"2ec0445f14c61f4b106dcb84f43aeb84c55c9633"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"624b3d80467f2954cad6bef0fb2e86173300d747","unresolved":false,"context_lines":[{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        if cinder.is_volume_service_enabled(request):"},{"line_number":406,"context_line":"            cinder_data \u003d {key: data[key] for key in"},{"line_number":407,"context_line":"                           quotas.CINDER_QUOTA_FIELDS}"},{"line_number":408,"context_line":"            cinder.tenant_quota_update(request,"},{"line_number":409,"context_line":"                                       project_id,"},{"line_number":410,"context_line":"                                       **cinder_data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_450d763d","line":407,"in_reply_to":"bacf61ea_4555764e","updated":"2016-07-28 19:30:10.000000000","message":"Yeah, think i got carried away, will revert","commit_id":"2ec0445f14c61f4b106dcb84f43aeb84c55c9633"}],"openstack_dashboard/local/local_settings.d/_20_integration_tests_scaffolds.py.example":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"70760da16da3f516d4a02f9e2ce605a6079438e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Enable both Launch Instance wizards for the sake of testing"},{"line_number":2,"context_line":"LAUNCH_INSTANCE_LEGACY_ENABLED \u003d True"},{"line_number":3,"context_line":"LAUNCH_INSTANCE_NG_ENABLED \u003d True"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bacf61ea_854acec3","side":"PARENT","line":1,"updated":"2016-07-28 19:22:56.000000000","message":"why is this going away ?","commit_id":"591fddf99c088a1303f1d09aaae8b8ddf7eb9093"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"624b3d80467f2954cad6bef0fb2e86173300d747","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Enable both Launch Instance wizards for the sake of testing"},{"line_number":2,"context_line":"LAUNCH_INSTANCE_LEGACY_ENABLED \u003d True"},{"line_number":3,"context_line":"LAUNCH_INSTANCE_NG_ENABLED \u003d True"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bacf61ea_683051e9","side":"PARENT","line":1,"in_reply_to":"bacf61ea_854acec3","updated":"2016-07-28 19:30:10.000000000","message":"Because i\u0027m blind and the documentation played a jape on me","commit_id":"591fddf99c088a1303f1d09aaae8b8ddf7eb9093"}],"openstack_dashboard/test/integration_tests/horizon.conf":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"70760da16da3f516d4a02f9e2ce605a6079438e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[dashboard]"},{"line_number":6,"context_line":"# Where the dashboard can be found (string value)"},{"line_number":7,"context_line":"dashboard_url\u003dhttp://localhost:8000/"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Dashboard help page url (string value)"},{"line_number":10,"context_line":"help_url\u003dhttp://docs.openstack.org/"}],"source_content_type":"text/plain","patch_set":4,"id":"bacf61ea_05fffe67","line":7,"updated":"2016-07-28 19:22:56.000000000","message":"the changes in this file don\u0027t seem to be required / related, from what I can see","commit_id":"2ec0445f14c61f4b106dcb84f43aeb84c55c9633"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"624b3d80467f2954cad6bef0fb2e86173300d747","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[dashboard]"},{"line_number":6,"context_line":"# Where the dashboard can be found (string value)"},{"line_number":7,"context_line":"dashboard_url\u003dhttp://localhost:8000/"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Dashboard help page url (string value)"},{"line_number":10,"context_line":"help_url\u003dhttp://docs.openstack.org/"}],"source_content_type":"text/plain","patch_set":4,"id":"bacf61ea_4842ad3f","line":7,"in_reply_to":"bacf61ea_05fffe67","updated":"2016-07-28 19:30:10.000000000","message":"Indeed, reverting","commit_id":"2ec0445f14c61f4b106dcb84f43aeb84c55c9633"}],"openstack_dashboard/test/integration_tests/regions/menus.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c7992a111c6c4683c5633a6d46c015d3ee4d9c66","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                classes \u003d dropdown.get_attribute(\u0027class\u0027).split()"},{"line_number":210,"context_line":"                return self._active_cls in classes"},{"line_number":211,"context_line":"            self._wait_until(predicate)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            dropdown.click()"},{"line_number":214,"context_line":"            self._wait_till_element_visible(self._menu_container_locator)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_06d4361e","side":"PARENT","line":212,"updated":"2016-08-16 02:16:19.000000000","message":"No needed change.","commit_id":"591fddf99c088a1303f1d09aaae8b8ddf7eb9093"}],"openstack_dashboard/test/tests/quotas.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c7992a111c6c4683c5633a6d46c015d3ee4d9c66","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    \u0027cores\u0027: {\u0027available\u0027: inf, \u0027used\u0027: 2, \u0027quota\u0027: inf}"},{"line_number":62,"context_line":"                })"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # (sjmc7) When neither neutron nor nova allow quotas for floating ips"},{"line_number":65,"context_line":"        # or security groups, an infinite (-1) quota is added in"},{"line_number":66,"context_line":"        # get_tenant_quota_data and seems to be relied upon elsewhere"},{"line_number":67,"context_line":"        if \u0027floating_ips\u0027 not in usages:"},{"line_number":68,"context_line":"            usages[\u0027floating_ips\u0027] \u003d {\u0027available\u0027: inf,"},{"line_number":69,"context_line":"                                      \u0027used\u0027: 0, \u0027quota\u0027: inf}"},{"line_number":70,"context_line":"        if \u0027security_groups\u0027 not in usages:"},{"line_number":71,"context_line":"            usages[\u0027security_groups\u0027] \u003d {\u0027available\u0027: inf,"},{"line_number":72,"context_line":"                                         \u0027used\u0027: 0, \u0027quota\u0027: inf}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if with_volume:"},{"line_number":75,"context_line":"            usages.update({\u0027volumes\u0027: {\u0027available\u0027: 0, \u0027used\u0027: 4, \u0027quota\u0027: 1},"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_a668c288","line":72,"range":{"start_line":64,"start_character":0,"end_line":72,"end_character":65},"updated":"2016-08-16 02:16:19.000000000","message":"This change is not related to this bug, upload a separated patch instead.","commit_id":"bf414a96ebed083dc9a4e58485f0f80999f66616"}],"openstack_dashboard/usage/quotas.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c7992a111c6c4683c5633a6d46c015d3ee4d9c66","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    _get_tenant_compute_usages(request, usages, disabled_quotas, tenant_id)"},{"line_number":447,"context_line":"    _get_tenant_network_usages(request, usages, disabled_quotas, tenant_id)"},{"line_number":448,"context_line":"    _get_tenant_volume_usages(request, usages, disabled_quotas, tenant_id)"},{"line_number":449,"context_line":"    _get_tenant_object_store_usages(request, usages,"},{"line_number":450,"context_line":"                                    disabled_quotas, tenant_id)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    return usages"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_c6f33e9d","line":449,"updated":"2016-08-16 02:16:19.000000000","message":"Please make sure test code cover this change.\nhorizon\\openstack_dashboard\\test\\tests\\quotas.py","commit_id":"bf414a96ebed083dc9a4e58485f0f80999f66616"}],"releasenotes/notes/add-swift-quotas-4224442b97cf42dd.yaml":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c7992a111c6c4683c5633a6d46c015d3ee4d9c66","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - Adds support for swift quotas at the tenant level"},{"line_number":7,"context_line":"    (for object count and total bytes). This requires"},{"line_number":8,"context_line":"    that the admin user have the ResellerAdmin role"},{"line_number":9,"context_line":"    granted to it."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3ac371cc_062d5646","line":9,"updated":"2016-08-16 02:16:19.000000000","message":"It\u0027s better to add the bug link here.","commit_id":"bf414a96ebed083dc9a4e58485f0f80999f66616"}]}
