)]}'
{"horizon/static/framework/conf/resource-type-registry.service.js":[{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"3d537f6f970988950168fa2751a161a5880f89ef","unresolved":false,"context_lines":[{"line_number":147,"context_line":"       *"},{"line_number":148,"context_line":"       * If an action does not have an initAction() function, it is ignored."},{"line_number":149,"context_line":"       */"},{"line_number":150,"context_line":"      function initActions() {"},{"line_number":151,"context_line":"        angular.forEach(self.itemActions, setActionScope);"},{"line_number":152,"context_line":"        angular.forEach(self.batchActions, setActionScope);"},{"line_number":153,"context_line":"        angular.forEach(self.globalActions, setActionScope);"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a629dbe_b3272f63","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":30},"updated":"2016-11-09 09:00:55.000000000","message":"Can we keep \"initScope\" for backword compatibility as Rob said?","commit_id":"bd9996e3400f3d6de4ba3caa185c7c7579244b7e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"89a8b6e86c3cc44bca4ddaf64c4141c4aaa8b9c7","unresolved":false,"context_lines":[{"line_number":147,"context_line":"       *"},{"line_number":148,"context_line":"       * If an action does not have an initAction() function, it is ignored."},{"line_number":149,"context_line":"       */"},{"line_number":150,"context_line":"      function initActions() {"},{"line_number":151,"context_line":"        angular.forEach(self.itemActions, setActionScope);"},{"line_number":152,"context_line":"        angular.forEach(self.batchActions, setActionScope);"},{"line_number":153,"context_line":"        angular.forEach(self.globalActions, setActionScope);"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a629dbe_b0af2093","line":150,"in_reply_to":"9a629dbe_b3272f63","updated":"2016-11-09 10:27:18.000000000","message":"I guess the problem is that initScope is passed a scope, which is the basic problem being addressed here. I wouldn\u0027t want to continue invoking it with a scope, which changes its signature, and if I\u0027m going to do that, then why not change its name?","commit_id":"bd9996e3400f3d6de4ba3caa185c7c7579244b7e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"907ec874d2c1f54c7b28b1b3b5b16469ef6ed2f3","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            // of the services, and should be stopped. State should be held on"},{"line_number":159,"context_line":"            // controllers instead; scope is now passed into allow() and perform()"},{"line_number":160,"context_line":"            // methods."},{"line_number":161,"context_line":"            $log.warn(\u0027The initScope() method is deprecated. \u0027 +"},{"line_number":162,"context_line":"              \u0027Invocation of it will stop in Queens.\u0027);"},{"line_number":163,"context_line":"            action.service.initScope(scope.$new());"},{"line_number":164,"context_line":"          }"},{"line_number":165,"context_line":"          if (action.service.initAction) {"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a629dbe_4094fb41","line":162,"range":{"start_line":161,"start_character":12,"end_line":162,"end_character":55},"updated":"2016-11-10 12:47:56.000000000","message":"Ha, after searching where this line could also be prepended to initScope I\u0027ve realized that it\u0027s the main and only caller of initScope. And OOP started to make sense to me (i.e., the same goal could be achieved with decorating the base initScope method - and it would be easier to track, but we don\u0027t it have due to the nature of JS objects).","commit_id":"992ced3de285d5ec9197f029cdb9717a295a1d4d"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"31e3dfcdb9d18138a15d49d0dc59000a965a65b6","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        angular.forEach(self.batchActions, setActionScope);"},{"line_number":153,"context_line":"        angular.forEach(self.globalActions, setActionScope);"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        function setActionScope(action) {"},{"line_number":156,"context_line":"          if (action.service.initScope) {"},{"line_number":157,"context_line":"            // The use of scope in action services breaks the singleton nature"},{"line_number":158,"context_line":"            // of the services, and should be stopped. State should be held on"}],"source_content_type":"text/javascript","patch_set":11,"id":"7a77a97e_277dc06e","line":155,"updated":"2016-11-16 01:34:47.000000000","message":"Detection for initAction should probably come first. And it should probably be \u0027else if\u0027 since we only want one to load.\n\nif (action.service.initAction) { ... }\nelse if (action.service.init) { ... }","commit_id":"7466bae27ad797638ce4f62de86a6d1f3778baee"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"d30eac95e91f7e76f2ea8f184a7ce6bb85ca4197","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        angular.forEach(self.batchActions, setActionScope);"},{"line_number":153,"context_line":"        angular.forEach(self.globalActions, setActionScope);"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        function setActionScope(action) {"},{"line_number":156,"context_line":"          if (action.service.initScope) {"},{"line_number":157,"context_line":"            // The use of scope in action services breaks the singleton nature"},{"line_number":158,"context_line":"            // of the services, and should be stopped. State should be held on"}],"source_content_type":"text/javascript","patch_set":11,"id":"7a77a97e_5b453415","line":155,"in_reply_to":"7a77a97e_277dc06e","updated":"2016-11-16 05:11:27.000000000","message":"Agree with the else if call, nonplussed about the other, so I\u0027ll switch \u0027em :-)","commit_id":"7466bae27ad797638ce4f62de86a6d1f3778baee"}],"horizon/static/framework/widgets/action-list/actions.controller.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"31e3dfcdb9d18138a15d49d0dc59000a965a65b6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"   * functions and variables within this controller."},{"line_number":31,"context_line":"   *"},{"line_number":32,"context_line":"   */"},{"line_number":33,"context_line":"  function ActionsController($q, $scope) {"},{"line_number":34,"context_line":"    var ctrl \u003d this;"},{"line_number":35,"context_line":"    ctrl.disabled \u003d false;"},{"line_number":36,"context_line":"    ctrl.passThroughCallbacks \u003d {};"}],"source_content_type":"text/javascript","patch_set":11,"id":"7a77a97e_320d0091","line":33,"updated":"2016-11-16 01:34:47.000000000","message":"What happens for batch actions? the $scope is not necessary at the item level.","commit_id":"7466bae27ad797638ce4f62de86a6d1f3778baee"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"d30eac95e91f7e76f2ea8f184a7ce6bb85ca4197","unresolved":false,"context_lines":[{"line_number":30,"context_line":"   * functions and variables within this controller."},{"line_number":31,"context_line":"   *"},{"line_number":32,"context_line":"   */"},{"line_number":33,"context_line":"  function ActionsController($q, $scope) {"},{"line_number":34,"context_line":"    var ctrl \u003d this;"},{"line_number":35,"context_line":"    ctrl.disabled \u003d false;"},{"line_number":36,"context_line":"    ctrl.passThroughCallbacks \u003d {};"}],"source_content_type":"text/javascript","patch_set":11,"id":"7a77a97e_c577a138","line":33,"in_reply_to":"7a77a97e_320d0091","updated":"2016-11-16 05:11:27.000000000","message":"Batch actions are handled through this code (there\u0027s only one action controller for all, since all it does is manage the callback).\n\nFor some Swift UI item actions the context (scope) of the item is useful. At the moment I\u0027m copying the container and folder info into all of the row items whereas I could just be accessing them through the scope.","commit_id":"7466bae27ad797638ce4f62de86a6d1f3778baee"}],"horizon/static/framework/widgets/action-list/actions.directive.js":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"907ec874d2c1f54c7b28b1b3b5b16469ef6ed2f3","unresolved":false,"context_lines":[{"line_number":150,"context_line":"   * is executed."},{"line_number":151,"context_line":"   *"},{"line_number":152,"context_line":"   * var createService \u003d {"},{"line_number":153,"context_line":"   *   allowed: function() {"},{"line_number":154,"context_line":"   *     return imageServiceEnabledPromise;"},{"line_number":155,"context_line":"   *   },"},{"line_number":156,"context_line":"   *   perform: function(ignored, scope) {"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a629dbe_206f072c","line":153,"range":{"start_line":153,"start_character":24,"end_line":153,"end_character":26},"updated":"2016-11-10 12:47:56.000000000","message":"What\u0027s about showing `item` and `scope` arguments here (since lines 98-100 told they are passed into allowed() )? On the other hand, this may require changing the example at lines 136-145 as well, so perhaps it\u0027s not worth it...","commit_id":"992ced3de285d5ec9197f029cdb9717a295a1d4d"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"19696cd11c3756b3d43a531befd014df19e976e7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"   * is executed."},{"line_number":151,"context_line":"   *"},{"line_number":152,"context_line":"   * var createService \u003d {"},{"line_number":153,"context_line":"   *   allowed: function() {"},{"line_number":154,"context_line":"   *     return imageServiceEnabledPromise;"},{"line_number":155,"context_line":"   *   },"},{"line_number":156,"context_line":"   *   perform: function(ignored, scope) {"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a629dbe_22244bc3","line":153,"in_reply_to":"9a629dbe_206f072c","updated":"2016-11-11 04:06:00.000000000","message":"Nah, I think it\u0027s ok to just change this one to show that there\u0027s wide flexibility in how these functions may be implemented based on their requirements.","commit_id":"992ced3de285d5ec9197f029cdb9717a295a1d4d"}],"horizon/static/framework/widgets/modal/wizard-modal.service.js":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"9b726a71f2ee52e248c51894301d364939e55ac5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        };"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        // backwards compatibility"},{"line_number":84,"context_line":"        if (angular.isDefined(params.scope)) {"},{"line_number":85,"context_line":"          options.scope \u003d params.scope;"},{"line_number":86,"context_line":"        }"},{"line_number":87,"context_line":""}],"source_content_type":"text/javascript","patch_set":6,"id":"ba5da102_30dc4e46","line":84,"updated":"2016-11-04 14:57:13.000000000","message":"Can we throw a console warning in here? It\u0027d be nice to flag to devs that this shouldn\u0027t be used.","commit_id":"de8ecebbf634e057ba6012c95775a6b18c53aae4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"9cb09820b6e27394010b23ae709121108fb106e9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        };"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        // backwards compatibility"},{"line_number":84,"context_line":"        if (angular.isDefined(params.scope)) {"},{"line_number":85,"context_line":"          options.scope \u003d params.scope;"},{"line_number":86,"context_line":"        }"},{"line_number":87,"context_line":""}],"source_content_type":"text/javascript","patch_set":6,"id":"9a629dbe_4521e8fa","line":84,"in_reply_to":"ba5da102_30dc4e46","updated":"2016-11-08 07:28:27.000000000","message":"Done","commit_id":"de8ecebbf634e057ba6012c95775a6b18c53aae4"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"907ec874d2c1f54c7b28b1b3b5b16469ef6ed2f3","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        // backwards compatibility"},{"line_number":85,"context_line":"        if (angular.isDefined(params.scope)) {"},{"line_number":86,"context_line":"          $log.warn(\u0027The \"scope\" param to modal() is deprecated.\u0027);"},{"line_number":87,"context_line":"          options.scope \u003d params.scope;"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":""}],"source_content_type":"text/javascript","patch_set":10,"id":"9a629dbe_40015b37","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":65},"updated":"2016-11-10 12:47:56.000000000","message":"Should the \u0027removal in Queens\u0027 part be mentioned?","commit_id":"992ced3de285d5ec9197f029cdb9717a295a1d4d"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"19696cd11c3756b3d43a531befd014df19e976e7","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        // backwards compatibility"},{"line_number":85,"context_line":"        if (angular.isDefined(params.scope)) {"},{"line_number":86,"context_line":"          $log.warn(\u0027The \"scope\" param to modal() is deprecated.\u0027);"},{"line_number":87,"context_line":"          options.scope \u003d params.scope;"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":""}],"source_content_type":"text/javascript","patch_set":10,"id":"9a629dbe_7dec222a","line":86,"in_reply_to":"9a629dbe_40015b37","updated":"2016-11-11 04:06:00.000000000","message":"Done","commit_id":"992ced3de285d5ec9197f029cdb9717a295a1d4d"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"31e3dfcdb9d18138a15d49d0dc59000a965a65b6","unresolved":false,"context_lines":[{"line_number":76,"context_line":"              return params.submit;"},{"line_number":77,"context_line":"            },"},{"line_number":78,"context_line":"            data: function() {"},{"line_number":79,"context_line":"              return params.data;"},{"line_number":80,"context_line":"            }"},{"line_number":81,"context_line":"          }"},{"line_number":82,"context_line":"        };"}],"source_content_type":"text/javascript","patch_set":11,"id":"7a77a97e_f274689d","line":79,"updated":"2016-11-16 01:34:47.000000000","message":"what happens if data is null or undefined? this is likely the case for most actions that have not been migrated to use this new model.","commit_id":"7466bae27ad797638ce4f62de86a6d1f3778baee"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"d30eac95e91f7e76f2ea8f184a7ce6bb85ca4197","unresolved":false,"context_lines":[{"line_number":76,"context_line":"              return params.submit;"},{"line_number":77,"context_line":"            },"},{"line_number":78,"context_line":"            data: function() {"},{"line_number":79,"context_line":"              return params.data;"},{"line_number":80,"context_line":"            }"},{"line_number":81,"context_line":"          }"},{"line_number":82,"context_line":"        };"}],"source_content_type":"text/javascript","patch_set":11,"id":"7a77a97e_a8d7dcbd","line":79,"in_reply_to":"7a77a97e_f274689d","updated":"2016-11-16 05:11:27.000000000","message":"That\u0027s fine - it only has to be an actual value if the underlying controller needs the data.","commit_id":"7466bae27ad797638ce4f62de86a6d1f3778baee"}],"horizon/static/framework/widgets/modal/wizard.controller.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"31e3dfcdb9d18138a15d49d0dc59000a965a65b6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    $scope.workflow \u003d workflow;"},{"line_number":49,"context_line":"    // copy over the data (we copy directly for backwards compatibility of access"},{"line_number":50,"context_line":"    // since these properties used to be assigned directly on the scope)"},{"line_number":51,"context_line":"    angular.forEach(data, function copy(value, key) {"},{"line_number":52,"context_line":"      $scope[key] \u003d value;"},{"line_number":53,"context_line":"    });"},{"line_number":54,"context_line":"    /* eslint-enable angular/controller-as */"}],"source_content_type":"text/javascript","patch_set":11,"id":"7a77a97e_449d5a58","line":51,"updated":"2016-11-16 01:34:47.000000000","message":"what happens if key is \u0027close\u0027, \u0027cancel\u0027, \u0027submit\u0027 or \u0027workflow\u0027? it would override the intended behavior above. why not just $scope.data \u003d data?","commit_id":"7466bae27ad797638ce4f62de86a6d1f3778baee"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"d30eac95e91f7e76f2ea8f184a7ce6bb85ca4197","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    $scope.workflow \u003d workflow;"},{"line_number":49,"context_line":"    // copy over the data (we copy directly for backwards compatibility of access"},{"line_number":50,"context_line":"    // since these properties used to be assigned directly on the scope)"},{"line_number":51,"context_line":"    angular.forEach(data, function copy(value, key) {"},{"line_number":52,"context_line":"      $scope[key] \u003d value;"},{"line_number":53,"context_line":"    });"},{"line_number":54,"context_line":"    /* eslint-enable angular/controller-as */"}],"source_content_type":"text/javascript","patch_set":11,"id":"7a77a97e_48a00844","line":51,"in_reply_to":"7a77a97e_449d5a58","updated":"2016-11-16 05:11:27.000000000","message":"Yeah, good point. Calling it \"data\" might be more obvious as to its source as well.","commit_id":"7466bae27ad797638ce4f62de86a6d1f3778baee"}],"openstack_dashboard/static/app/core/images/actions/create-volume.service.js":[{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"3d537f6f970988950168fa2751a161a5880f89ef","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    return service;"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    function initScope() {"},{"line_number":74,"context_line":"      createVolumePromise \u003d policy.ifAllowed({rules: [[\u0027volume\u0027, \u0027volume:create\u0027]]});"},{"line_number":75,"context_line":"      volumeServiceEnabledPromise \u003d serviceCatalog.ifTypeEnabled(\u0027volume\u0027);"},{"line_number":76,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a629dbe_984ec894","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":22},"updated":"2016-11-09 09:00:55.000000000","message":"initAction","commit_id":"bd9996e3400f3d6de4ba3caa185c7c7579244b7e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"31e3dfcdb9d18138a15d49d0dc59000a965a65b6","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    return service;"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    function initScope() {"},{"line_number":74,"context_line":"      createVolumePromise \u003d policy.ifAllowed({rules: [[\u0027volume\u0027, \u0027volume:create\u0027]]});"},{"line_number":75,"context_line":"      volumeServiceEnabledPromise \u003d serviceCatalog.ifTypeEnabled(\u0027volume\u0027);"},{"line_number":76,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":11,"id":"7a77a97e_24e85eb4","line":73,"updated":"2016-11-16 01:34:47.000000000","message":"initAction?","commit_id":"7466bae27ad797638ce4f62de86a6d1f3778baee"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"d30eac95e91f7e76f2ea8f184a7ce6bb85ca4197","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    return service;"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    function initScope() {"},{"line_number":74,"context_line":"      createVolumePromise \u003d policy.ifAllowed({rules: [[\u0027volume\u0027, \u0027volume:create\u0027]]});"},{"line_number":75,"context_line":"      volumeServiceEnabledPromise \u003d serviceCatalog.ifTypeEnabled(\u0027volume\u0027);"},{"line_number":76,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":11,"id":"7a77a97e_e88f14ca","line":73,"in_reply_to":"7a77a97e_24e85eb4","updated":"2016-11-16 05:11:27.000000000","message":"Hah, nice catch!","commit_id":"7466bae27ad797638ce4f62de86a6d1f3778baee"}],"openstack_dashboard/static/app/core/images/actions/create-volume.service.spec.js":[{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"3d537f6f970988950168fa2751a161a5880f89ef","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        spyOn(wizardModalService, \u0027modal\u0027).and.callThrough();"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        var image \u003d {id: \u002712\u0027};"},{"line_number":83,"context_line":"        service.initScope();"},{"line_number":84,"context_line":"        service.perform(image);"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        expect(wizardModalService.modal).toHaveBeenCalled();"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a629dbe_185b9855","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":25},"updated":"2016-11-09 09:00:55.000000000","message":"initAction","commit_id":"bd9996e3400f3d6de4ba3caa185c7c7579244b7e"}]}
