)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"ce976d495eac17655f064eb2c68844c8950f9ec4","unresolved":false,"context_lines":[{"line_number":10,"context_line":" - http://specs.openstack.org/openstack/keystone-specs/specs/backlog/implied-roles.html"},{"line_number":11,"context_line":"This patch will support it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implementation for angular is after being the patch below merged."},{"line_number":14,"context_line":"https://review.openstack.org/#/c/222825/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I96bf361dde273a35bd6f4878a691c676c2439f73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_05b09edc","line":13,"updated":"2016-08-03 16:51:34.000000000","message":"(nit) Suggest changing this sentence to \"Implementation for angular can proceed after this patch merges:\"","commit_id":"7677991e83f7800103fe8575a51a57ad2826d44c"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1098e3beb0671b62a50ef0a038e2409b52ae7203","unresolved":false,"context_lines":[{"line_number":10,"context_line":" - http://specs.openstack.org/openstack/keystone-specs/specs/backlog/implied-roles.html"},{"line_number":11,"context_line":"This patch will support it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implementation for angular is after being the patch below merged."},{"line_number":14,"context_line":"https://review.openstack.org/#/c/222825/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I96bf361dde273a35bd6f4878a691c676c2439f73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_cfe8557f","line":13,"in_reply_to":"bacf61ea_05b09edc","updated":"2016-08-05 10:02:43.000000000","message":"Done","commit_id":"7677991e83f7800103fe8575a51a57ad2826d44c"}],"openstack_dashboard/dashboards/identity/roles/forms.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"603fe7cd9e70a4e6d697b9868a7a71d5093da897","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # set true as a initial value"},{"line_number":75,"context_line":"        ir_list \u003d []"},{"line_number":76,"context_line":"        for i in api.keystone.list_role_inferences(self.request):"},{"line_number":77,"context_line":"            if role_id \u003d\u003d i.prior_role[\u0027id\u0027]:"},{"line_number":78,"context_line":"                ir_list \u003d i.implies"},{"line_number":79,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_b378262d","line":76,"updated":"2016-08-03 00:27:47.000000000","message":"Do we need to more thoroughly check the version of the Keystone server we\u0027re talking to before making this call? Since role inferences were added in Mitaka, we could be talking to a Keystone v3 server that doesn\u0027t have the new feature.","commit_id":"7677991e83f7800103fe8575a51a57ad2826d44c"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"51aef607f85f7033ec758150690f6351287a597a","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # set true as a initial value"},{"line_number":75,"context_line":"        ir_list \u003d []"},{"line_number":76,"context_line":"        for i in api.keystone.list_role_inferences(self.request):"},{"line_number":77,"context_line":"            if role_id \u003d\u003d i.prior_role[\u0027id\u0027]:"},{"line_number":78,"context_line":"                ir_list \u003d i.implies"},{"line_number":79,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_d3767ad7","line":76,"in_reply_to":"bacf61ea_b378262d","updated":"2016-08-03 00:52:19.000000000","message":"I agree with you. But at the moment, as far as I know, there is no way to check except for the check at Line49 and the policy.check at Line57.\n\nAnd, Keystone seems to be working for microversion(https://blueprints.launchpad.net/keystone/+spec/microversions). I think after being completed this feature, we could check whether Keystone supports a feature or not.","commit_id":"7677991e83f7800103fe8575a51a57ad2826d44c"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"ce976d495eac17655f064eb2c68844c8950f9ec4","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # set true as a initial value"},{"line_number":75,"context_line":"        ir_list \u003d []"},{"line_number":76,"context_line":"        for i in api.keystone.list_role_inferences(self.request):"},{"line_number":77,"context_line":"            if role_id \u003d\u003d i.prior_role[\u0027id\u0027]:"},{"line_number":78,"context_line":"                ir_list \u003d i.implies"},{"line_number":79,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_e57e2a69","line":76,"in_reply_to":"bacf61ea_d3767ad7","updated":"2016-08-03 16:51:34.000000000","message":"That\u0027s unfortunate Keystone doesn\u0027t currently support discoverability of features. I tested this patch out against a Keystone server that doesn\u0027t have the feature and, as expected, got some error popups in Horizon due to 404 codes coming back from Keystone. When I turned off the feature in Horizon by setting the following in keystone_policy.json, the errors went away:\n\n\"identity:list_role_inference_rules\": \"!\"\n\nSo it\u0027s good an admin can at least turn the feature off using the policy file. Could you add release notes using reno to explain what this feature does and how to turn it off when needed?","commit_id":"7677991e83f7800103fe8575a51a57ad2826d44c"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1098e3beb0671b62a50ef0a038e2409b52ae7203","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # set true as a initial value"},{"line_number":75,"context_line":"        ir_list \u003d []"},{"line_number":76,"context_line":"        for i in api.keystone.list_role_inferences(self.request):"},{"line_number":77,"context_line":"            if role_id \u003d\u003d i.prior_role[\u0027id\u0027]:"},{"line_number":78,"context_line":"                ir_list \u003d i.implies"},{"line_number":79,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2f839f57","line":76,"in_reply_to":"bacf61ea_e57e2a69","updated":"2016-08-05 10:02:43.000000000","message":"Done\nThanks for feedback! I totally agree with you, I added a release note :)","commit_id":"7677991e83f7800103fe8575a51a57ad2826d44c"}]}
