)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"de343a35f726daa6b93d9d5a482bdf16fe25fbc8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"The new-ish registry-based hz-resource-table wasn\u0027t making either of"},{"line_number":16,"context_line":"those visual changes.  But now it is!  Hurray for fewer regressions!"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ic84b1eabc2c32e7ba48bf9ce2279f69a4e9a95e0"},{"line_number":19,"context_line":"Co-Authored-By: Tyr Johanson tyr@hpe.com"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_91507b60","line":18,"updated":"2016-07-22 19:37:52.000000000","message":"You need either a blueprint or bug to be referenced here, by Closes-Bug: or Partially-Implements:","commit_id":"3d28db8cf278a4d66847deb64cf846ef4c179b12"}],"horizon/static/framework/conf/resource-type-registry.service.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"de343a35f726daa6b93d9d5a482bdf16fe25fbc8","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        return false;"},{"line_number":252,"context_line":"      }"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"      function setIsInTransition(func) {"},{"line_number":255,"context_line":"        self.isInTransition \u003d func;"},{"line_number":256,"context_line":"        return self;"},{"line_number":257,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":1,"id":"dada55a8_11092bde","line":254,"range":{"start_line":254,"start_character":15,"end_line":254,"end_character":32},"updated":"2016-07-22 19:37:52.000000000","message":"Might as well document, even if briefly.  Mention the chaining.\n\nAlso, write a test for this.","commit_id":"3d28db8cf278a4d66847deb64cf846ef4c179b12"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e67640ed40e0defcddd26ec0e6b89b1557662be8","unresolved":false,"context_lines":[{"line_number":261,"context_line":"       * @returns {boolean}"},{"line_number":262,"context_line":"       */"},{"line_number":263,"context_line":"      function defaultIsInTransition() {"},{"line_number":264,"context_line":"        return false;"},{"line_number":265,"context_line":"      }"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"      /**"}],"source_content_type":"text/javascript","patch_set":10,"id":"bacf61ea_e44825cf","line":264,"updated":"2016-08-02 18:31:00.000000000","message":"Question (not necessarily blocking): would it make sense to actually have this handle default setTransitionStatusFields function that takes a map of fields and statuses and then make the default function check that?\n\nRight now, the images implementation is defining a dictionary of status fields in the module, that are injected into the images service which has a function with what will likely be very common code, but requiring 4 tests, which is then injected back into the resource type registration in the module where it is then registered on the resource type.\n\nWith the below,  you\u0027d simply create the constant in the module and register it within the module. The ability to override with custom function still could be done, but the rest of it seems like it will be a bunch of redundant boiler plate with most resource types.\n\nE.g. setTransitionStatusFields(input) would be something like this (using mix of glance and instance fields)\n   {\n      \u0027status\u0027: [\u0027queued\u0027, \u0027pending\u0027],\n      \u0027task_state\u0027: [\u0027volume_mapping\u0027]\n    }\n\nand function would be something like this (just writing in gerrit, so not sure if totally correct):\n\n    function defaultInTransition(item) {\n      for (var key in self.transitionStatusFields) {\n        if (item.hasOwnProperty(key) \u0026\u0026 self.transitionStatusFields.indexOf(item[key]) \u003e\u003d 0) {\n          return true;\n        }\n        return false;\n      }\n    }","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9cfe5f43b3b5e3f8ca1142bcd306af0074116608","unresolved":false,"context_lines":[{"line_number":261,"context_line":"       * @returns {boolean}"},{"line_number":262,"context_line":"       */"},{"line_number":263,"context_line":"      function defaultIsInTransition() {"},{"line_number":264,"context_line":"        return false;"},{"line_number":265,"context_line":"      }"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"      /**"}],"source_content_type":"text/javascript","patch_set":10,"id":"bacf61ea_d8178052","line":264,"in_reply_to":"bacf61ea_e44825cf","updated":"2016-08-03 22:40:46.000000000","message":"Very good idea Travis. Matt and I were aiming for a very simple API, but you are probably right about being able to eliminate some boilerplate. I\u0027ll do some experiments.","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"31c0f9f3780c87018dce9a73566e0a7ef15bf0d4","unresolved":false,"context_lines":[{"line_number":261,"context_line":"       * @returns {boolean}"},{"line_number":262,"context_line":"       */"},{"line_number":263,"context_line":"      function defaultIsInTransition() {"},{"line_number":264,"context_line":"        return false;"},{"line_number":265,"context_line":"      }"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"      /**"}],"source_content_type":"text/javascript","patch_set":10,"id":"bacf61ea_c4736114","line":264,"in_reply_to":"bacf61ea_e44825cf","updated":"2016-08-02 18:33:07.000000000","message":"just looked at this... the false would be one } lower and you\u0027d need to set the self.transitionStatusFields to default of {}","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e67640ed40e0defcddd26ec0e6b89b1557662be8","unresolved":false,"context_lines":[{"line_number":268,"context_line":"       * @ngdoc function"},{"line_number":269,"context_line":"       * @param func - The callback-function to be used for determining if this"},{"line_number":270,"context_line":"       * resource is in a transitional state.  This callback-function should"},{"line_number":271,"context_line":"       * return a boolean."},{"line_number":272,"context_line":"       * @returns {ResourceType} - returning self to facilitate call-chaining."},{"line_number":273,"context_line":"       */"},{"line_number":274,"context_line":"      function setIsInTransition(func) {"}],"source_content_type":"text/javascript","patch_set":10,"id":"bacf61ea_efe76344","line":271,"updated":"2016-08-02 18:31:00.000000000","message":"This really should state that the function takes an instance of this type of resource for input.  When you say \"this\" resource, this actually is mostly closely associated with ResourceType, since \"isInTransition\" is a function of ResourceType.","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9cfe5f43b3b5e3f8ca1142bcd306af0074116608","unresolved":false,"context_lines":[{"line_number":268,"context_line":"       * @ngdoc function"},{"line_number":269,"context_line":"       * @param func - The callback-function to be used for determining if this"},{"line_number":270,"context_line":"       * resource is in a transitional state.  This callback-function should"},{"line_number":271,"context_line":"       * return a boolean."},{"line_number":272,"context_line":"       * @returns {ResourceType} - returning self to facilitate call-chaining."},{"line_number":273,"context_line":"       */"},{"line_number":274,"context_line":"      function setIsInTransition(func) {"}],"source_content_type":"text/javascript","patch_set":10,"id":"bacf61ea_1812b862","line":271,"in_reply_to":"bacf61ea_efe76344","updated":"2016-08-03 22:40:46.000000000","message":"Done","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"}],"horizon/static/framework/conf/resource-type-registry.service.spec.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e67640ed40e0defcddd26ec0e6b89b1557662be8","unresolved":false,"context_lines":[{"line_number":196,"context_line":"      });"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"      it(\"has a default isInTransition function that returns false\", function() {"},{"line_number":199,"context_line":"        expect(type.isInTransition()).toBe(false);"},{"line_number":200,"context_line":"      });"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"      it(\"allows setting an isInTransition function\", function() {"}],"source_content_type":"text/javascript","patch_set":10,"id":"bacf61ea_0f459716","line":199,"range":{"start_line":199,"start_character":15,"end_line":199,"end_character":36},"updated":"2016-08-02 18:31:00.000000000","message":"And here the example in test code make it seem like it is asking if the resourceType is in transition.","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9cfe5f43b3b5e3f8ca1142bcd306af0074116608","unresolved":false,"context_lines":[{"line_number":196,"context_line":"      });"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"      it(\"has a default isInTransition function that returns false\", function() {"},{"line_number":199,"context_line":"        expect(type.isInTransition()).toBe(false);"},{"line_number":200,"context_line":"      });"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"      it(\"allows setting an isInTransition function\", function() {"}],"source_content_type":"text/javascript","patch_set":10,"id":"bacf61ea_9306891e","line":199,"range":{"start_line":199,"start_character":15,"end_line":199,"end_character":36},"in_reply_to":"bacf61ea_0f459716","updated":"2016-08-03 22:40:46.000000000","message":"Done","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"}],"horizon/static/framework/widgets/table/hz-cell.directive.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e67640ed40e0defcddd26ec0e6b89b1557662be8","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        // not cognizant of a \u0027table\u0027 context as hz-cell is."},{"line_number":108,"context_line":"        if (column.isInTransitionFunc \u0026\u0026 column.isInTransitionFunc(scope.item)) {"},{"line_number":109,"context_line":"          // NOTE(woodnt): It\u0027d be nice to split this out into a template file,"},{"line_number":110,"context_line":"          //               but since we\u0027re inside a link function, that\u0027s complicated."},{"line_number":111,"context_line":"          progressBarHtml \u003d \u0027\u003cdiv class\u003d\"progress-text horizon-loading-bar\"\u003e\u0027 +"},{"line_number":112,"context_line":"                              \u0027\u003cdiv class\u003d\"progress progress-striped active\"\u003e\u0027 +"},{"line_number":113,"context_line":"                                \u0027\u003cdiv class\u003d\"progress-bar\"\u003e\u003c/div\u003e\u0027 +"}],"source_content_type":"text/javascript","patch_set":10,"id":"bacf61ea_8fed07f2","line":110,"updated":"2016-08-02 18:31:00.000000000","message":"nit (I don\u0027t really care): the progressBarHTML could be its own variable outside of the function at least.","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"}],"horizon/static/framework/widgets/table/hz-dynamic-table.directive.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"2f2466e902a12bf79ea17635f8e3ce90509dedc2","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        itemActions: \u0027\u003d?\u0027,"},{"line_number":102,"context_line":"        filterFacets: \u0027\u003d?\u0027,"},{"line_number":103,"context_line":"        resultHandler: \u0027\u003d?\u0027,"},{"line_number":104,"context_line":"        rowInTransitionHandler: \u0027\u003d?\u0027"},{"line_number":105,"context_line":"      },"},{"line_number":106,"context_line":"      templateUrl: basePath + \u0027table/hz-dynamic-table.html\u0027,"},{"line_number":107,"context_line":"      link: link"}],"source_content_type":"text/javascript","patch_set":1,"id":"dada55a8_e76bf583","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":30},"updated":"2016-07-22 20:15:09.000000000","message":"-1: doc above please to help understand how this is used","commit_id":"3d28db8cf278a4d66847deb64cf846ef4c179b12"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e67640ed40e0defcddd26ec0e6b89b1557662be8","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        itemActions: \u0027\u003d?\u0027,"},{"line_number":104,"context_line":"        filterFacets: \u0027\u003d?\u0027,"},{"line_number":105,"context_line":"        resultHandler: \u0027\u003d?\u0027,"},{"line_number":106,"context_line":"        rowInTransitionHandler: \u0027\u003d?\u0027"},{"line_number":107,"context_line":"      },"},{"line_number":108,"context_line":"      templateUrl: basePath + \u0027table/hz-dynamic-table.html\u0027,"},{"line_number":109,"context_line":"      link: {"}],"source_content_type":"text/javascript","patch_set":10,"id":"bacf61ea_0f863713","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":30},"updated":"2016-08-02 18:31:00.000000000","message":"The doc up around line 40 needs to be updated. Probably with same doc that you add to resource type.\n\nYou know, we have items, item actions, and use item throughout.  Does this really \"Handle\" a row in transition? Or does it really tell you if an item is in transition?  I mean the wording makes me thing that I would be passing in a function that actually modifies the rows directly. This doesn\u0027t it only returns a boolean true / false if a particular item is in transition.\n\nHere are a few other names to consider:\n\nitem-transitioning\nitem-transition\nitem-transition-detector\nitem-transition-sentry\nfunction-that-determines-if-item-is-in-a-freaking-transition\nis-item-transitioning\nis-item-transitioning-func","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9cfe5f43b3b5e3f8ca1142bcd306af0074116608","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        itemActions: \u0027\u003d?\u0027,"},{"line_number":104,"context_line":"        filterFacets: \u0027\u003d?\u0027,"},{"line_number":105,"context_line":"        resultHandler: \u0027\u003d?\u0027,"},{"line_number":106,"context_line":"        rowInTransitionHandler: \u0027\u003d?\u0027"},{"line_number":107,"context_line":"      },"},{"line_number":108,"context_line":"      templateUrl: basePath + \u0027table/hz-dynamic-table.html\u0027,"},{"line_number":109,"context_line":"      link: {"}],"source_content_type":"text/javascript","patch_set":10,"id":"bacf61ea_d373e1b2","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":30},"in_reply_to":"bacf61ea_0f863713","updated":"2016-08-03 22:40:46.000000000","message":"Good point. I\u0027ll update.","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"}],"horizon/static/framework/widgets/table/hz-dynamic-table.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"de343a35f726daa6b93d9d5a482bdf16fe25fbc8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        --\u003e"},{"line_number":53,"context_line":"        \u003ctr ng-repeat-start\u003d\"item in items track by item[config.trackId]\""},{"line_number":54,"context_line":"            ng-class\u003d\"{\u0027st-selected\u0027: checked[item[config.trackId]],"},{"line_number":55,"context_line":"                       \u0027status_unknown\u0027: rowInTransitionHandler(item)}\"\u003e"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"          \u003ctd ng-show\u003d\"config.selectAll\" class\u003d\"multi_select_column\"\u003e"},{"line_number":58,"context_line":"            \u003cdiv class\u003d\"themable-checkbox\"\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"dada55a8_7143476d","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":38},"updated":"2016-07-22 19:37:52.000000000","message":"\u0027unknown\u0027?  Seems to be more status-in-transition.","commit_id":"3d28db8cf278a4d66847deb64cf846ef4c179b12"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"2f2466e902a12bf79ea17635f8e3ce90509dedc2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        --\u003e"},{"line_number":53,"context_line":"        \u003ctr ng-repeat-start\u003d\"item in items track by item[config.trackId]\""},{"line_number":54,"context_line":"            ng-class\u003d\"{\u0027st-selected\u0027: checked[item[config.trackId]],"},{"line_number":55,"context_line":"                       \u0027status_unknown\u0027: rowInTransitionHandler(item)}\"\u003e"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"          \u003ctd ng-show\u003d\"config.selectAll\" class\u003d\"multi_select_column\"\u003e"},{"line_number":58,"context_line":"            \u003cdiv class\u003d\"themable-checkbox\"\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"dada55a8_87f5d9cc","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":38},"in_reply_to":"dada55a8_7143476d","updated":"2016-07-22 20:15:09.000000000","message":"this is the class used by the existing horizon tables","commit_id":"3d28db8cf278a4d66847deb64cf846ef4c179b12"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e67640ed40e0defcddd26ec0e6b89b1557662be8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        --\u003e"},{"line_number":53,"context_line":"        \u003ctr ng-repeat-start\u003d\"item in items track by item[config.trackId]\""},{"line_number":54,"context_line":"            ng-class\u003d\"{\u0027st-selected\u0027: checked[item[config.trackId]],"},{"line_number":55,"context_line":"                       \u0027status_unknown\u0027: rowInTransitionHandler(item)}\"\u003e"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"          \u003ctd ng-show\u003d\"config.selectAll\" class\u003d\"multi_select_column\"\u003e"},{"line_number":58,"context_line":"            \u003cdiv class\u003d\"themable-checkbox\"\u003e"}],"source_content_type":"text/html","patch_set":10,"id":"bacf61ea_efdbe31f","line":55,"updated":"2016-08-02 18:31:00.000000000","message":"aligning the class name with the \"transition\" naming used everywhere else may be better. An unknown status is different to me than in-transition status.  In transition makes sense that I\u0027d see a progress bar. Unknown would make me think that maybe I\u0027d see an icon or something else indicating \"i dunno\". Also, i believe we are supposed to be using dashes instead of underscores for class names.","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9cfe5f43b3b5e3f8ca1142bcd306af0074116608","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        --\u003e"},{"line_number":53,"context_line":"        \u003ctr ng-repeat-start\u003d\"item in items track by item[config.trackId]\""},{"line_number":54,"context_line":"            ng-class\u003d\"{\u0027st-selected\u0027: checked[item[config.trackId]],"},{"line_number":55,"context_line":"                       \u0027status_unknown\u0027: rowInTransitionHandler(item)}\"\u003e"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"          \u003ctd ng-show\u003d\"config.selectAll\" class\u003d\"multi_select_column\"\u003e"},{"line_number":58,"context_line":"            \u003cdiv class\u003d\"themable-checkbox\"\u003e"}],"source_content_type":"text/html","patch_set":10,"id":"bacf61ea_336d1d9a","line":55,"in_reply_to":"bacf61ea_efdbe31f","updated":"2016-08-03 22:40:46.000000000","message":"status_unknown is the class used by existing horizon for this same purpose. I think your suggestions are spot-on, but I\u0027m hesitant to have two classes that do the same thing in Horizon, unless you think it is a deal breaker?","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"}],"horizon/static/framework/widgets/table/table.scss":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"de343a35f726daa6b93d9d5a482bdf16fe25fbc8","unresolved":false,"context_lines":[{"line_number":157,"context_line":"              background-color: $table-bg-accent;"},{"line_number":158,"context_line":"            }"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"            \u0026.status_unknown td {"},{"line_number":161,"context_line":"              background-color: lighten($brand-warning, 10%);"},{"line_number":162,"context_line":"            }"},{"line_number":163,"context_line":"          }"}],"source_content_type":"text/x-scss","patch_set":1,"id":"dada55a8_111c8b76","line":160,"range":{"start_line":160,"start_character":14,"end_line":160,"end_character":28},"updated":"2016-07-22 19:37:52.000000000","message":"change from unknown?","commit_id":"3d28db8cf278a4d66847deb64cf846ef4c179b12"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"de343a35f726daa6b93d9d5a482bdf16fe25fbc8","unresolved":false,"context_lines":[{"line_number":173,"context_line":"              background-color: transparent;"},{"line_number":174,"context_line":"            }"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"            \u0026.status_unknown td {"},{"line_number":177,"context_line":"              background-color: lighten($brand-warning, 6%);"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            }"}],"source_content_type":"text/x-scss","patch_set":1,"id":"dada55a8_b10bff2a","line":176,"range":{"start_line":176,"start_character":14,"end_line":176,"end_character":28},"updated":"2016-07-22 19:37:52.000000000","message":"change from unknown?","commit_id":"3d28db8cf278a4d66847deb64cf846ef4c179b12"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"473bb7f08259e32e0eb172713b818a95aefbc0f5","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    \u0026:not(.st-sort-ascent):hover:after,"},{"line_number":91,"context_line":"    \u0026:not(.st-sort-descent):hover:after {"},{"line_number":92,"context_line":"      opacity: 1;"},{"line_number":93,"context_line":"    }"},{"line_number":94,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":7,"id":"dada55a8_299c490d","line":91,"updated":"2016-07-26 15:14:32.000000000","message":"Can we make this so it repeats itself a little bit less?\n\nLike:\n\n\u0026:not(.st-sort-ascent),\n\u0026:not(.st-sort-descent) {\n  \u0026:hover:after {\n  }\n}","commit_id":"0bcb1a3325e5d0fdcf5dc0b6f42d97dbd812749d"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"b94695b43dc8d5e3d855040a1d086536e0b260de","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    \u0026:not(.st-sort-ascent):hover:after,"},{"line_number":91,"context_line":"    \u0026:not(.st-sort-descent):hover:after {"},{"line_number":92,"context_line":"      opacity: 1;"},{"line_number":93,"context_line":"    }"},{"line_number":94,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":7,"id":"dada55a8_23ef3c88","line":91,"in_reply_to":"dada55a8_299c490d","updated":"2016-07-26 18:52:38.000000000","message":"Done","commit_id":"0bcb1a3325e5d0fdcf5dc0b6f42d97dbd812749d"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e67640ed40e0defcddd26ec0e6b89b1557662be8","unresolved":false,"context_lines":[{"line_number":159,"context_line":"              background-color: $table-bg-accent;"},{"line_number":160,"context_line":"            }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            \u0026.status_unknown td {"},{"line_number":163,"context_line":"              background-color: lighten($brand-warning, 10%);"},{"line_number":164,"context_line":"            }"},{"line_number":165,"context_line":"          }"}],"source_content_type":"text/x-scss","patch_set":10,"id":"bacf61ea_e175b732","line":162,"range":{"start_line":162,"start_character":14,"end_line":162,"end_character":28},"updated":"2016-08-02 18:31:00.000000000","message":"see comments in other file about class naming.","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9cfe5f43b3b5e3f8ca1142bcd306af0074116608","unresolved":false,"context_lines":[{"line_number":159,"context_line":"              background-color: $table-bg-accent;"},{"line_number":160,"context_line":"            }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            \u0026.status_unknown td {"},{"line_number":163,"context_line":"              background-color: lighten($brand-warning, 10%);"},{"line_number":164,"context_line":"            }"},{"line_number":165,"context_line":"          }"}],"source_content_type":"text/x-scss","patch_set":10,"id":"bacf61ea_7353153a","line":162,"range":{"start_line":162,"start_character":14,"end_line":162,"end_character":28},"in_reply_to":"bacf61ea_e175b732","updated":"2016-08-03 22:40:46.000000000","message":"this class is used by existing horizon. We decided to keep it to avoid creating a new class in horizon with the same semantic.","commit_id":"1d53f19255b7c5ea4972e9e5eda653f2279c3e6b"}]}
