)]}'
{"horizon/static/framework/conf/permissions.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9d8ee09593b10161bccf8530ee8fafb3adfec6d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":3,"context_line":" * you may not use this file except in compliance with the License."},{"line_number":4,"context_line":" * You may obtain a copy of the License at"}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_6a558f4e","line":1,"updated":"2016-07-26 16:05:45.000000000","message":"Need HP copyright.","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d1a387ba4d7266722f0d182df3af385b5e026dbd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":3,"context_line":" * you may not use this file except in compliance with the License."},{"line_number":4,"context_line":" * You may obtain a copy of the License at"}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_9e300858","line":1,"in_reply_to":"dada55a8_6a558f4e","updated":"2016-07-26 16:29:28.000000000","message":"Done","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"451071ecd34eb41b60fb7a4b6d75e58c0bacf895","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  angular"},{"line_number":18,"context_line":"    .module(\u0027horizon.framework.conf\u0027)"},{"line_number":19,"context_line":"    .service(\u0027horizon.framework.conf.permissions\u0027, Permissions);"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  Permissions.$inject \u003d [\u0027$q\u0027];"},{"line_number":22,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_db1297b3","line":19,"updated":"2016-07-26 15:17:07.000000000","message":"horizon.framework.conf.permissions.service?","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d1a387ba4d7266722f0d182df3af385b5e026dbd","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  angular"},{"line_number":18,"context_line":"    .module(\u0027horizon.framework.conf\u0027)"},{"line_number":19,"context_line":"    .service(\u0027horizon.framework.conf.permissions\u0027, Permissions);"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  Permissions.$inject \u003d [\u0027$q\u0027];"},{"line_number":22,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_de0d6090","line":19,"in_reply_to":"dada55a8_8aec43bc","updated":"2016-07-26 16:29:28.000000000","message":"Done","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9d8ee09593b10161bccf8530ee8fafb3adfec6d0","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  angular"},{"line_number":18,"context_line":"    .module(\u0027horizon.framework.conf\u0027)"},{"line_number":19,"context_line":"    .service(\u0027horizon.framework.conf.permissions\u0027, Permissions);"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  Permissions.$inject \u003d [\u0027$q\u0027];"},{"line_number":22,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_8aec43bc","line":19,"in_reply_to":"dada55a8_db1297b3","updated":"2016-07-26 16:05:45.000000000","message":"yeah, good catch.","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9d8ee09593b10161bccf8530ee8fafb3adfec6d0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    var service \u003d {"},{"line_number":30,"context_line":"      checkAllowed: checkAllowed,"},{"line_number":31,"context_line":"      checkAll: checkAll,"},{"line_number":32,"context_line":"      extendedPermissions: extendedPermissions"},{"line_number":33,"context_line":"    };"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    return service;"}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_9e63e8b0","line":32,"updated":"2016-07-26 16:05:45.000000000","message":"Maybe add function \"hasPermissions(configItem)\"  will return true or false if there are permissions to check.  This would allow users to optimize setting whether or not to use permissions without registering unnecessary promise callbacks.","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d1a387ba4d7266722f0d182df3af385b5e026dbd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    var service \u003d {"},{"line_number":30,"context_line":"      checkAllowed: checkAllowed,"},{"line_number":31,"context_line":"      checkAll: checkAll,"},{"line_number":32,"context_line":"      extendedPermissions: extendedPermissions"},{"line_number":33,"context_line":"    };"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    return service;"}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_b4ffedff","line":32,"in_reply_to":"dada55a8_9e63e8b0","updated":"2016-07-26 16:29:28.000000000","message":"Not sure about the specific advantage of this...maybe need to verify if that\u0027s a valuable use case.","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9d8ee09593b10161bccf8530ee8fafb3adfec6d0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"     * Openstack Dashboard may set permissions for required policies, services, or settings"},{"line_number":88,"context_line":"     * (amongst other items). To do this, the service would be decorated like the following:"},{"line_number":89,"context_line":"     function permissionsDecorator($provide) {"},{"line_number":90,"context_line":"     $provide.decorator(\u0027horizon.framework.conf.permissions\u0027,"},{"line_number":91,"context_line":"     [\u0027$delegate\u0027,"},{"line_number":92,"context_line":"     \u0027horizon.app.core.openstack-service-api.policy\u0027,"},{"line_number":93,"context_line":"     \u0027horizon.app.core.openstack-service-api.serviceCatalog\u0027,"},{"line_number":94,"context_line":"     \u0027horizon.app.core.openstack-service-api.settings\u0027,"},{"line_number":95,"context_line":"     decorator]);"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"     function decorator($delegate, policy, serviceCatalog, settings) {"},{"line_number":98,"context_line":"     var permissionsService \u003d $delegate;"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"     permissionsService.extendedPermissions \u003d extendedPermissions;"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"     function extendedPermissions() {"},{"line_number":103,"context_line":"     return {"},{"line_number":104,"context_line":"     policies: policy.ifAllowed,"},{"line_number":105,"context_line":"     services: serviceCatalog.ifTypeEnabled,"},{"line_number":106,"context_line":"     settings: settings.ifEnabled"},{"line_number":107,"context_line":"     };"},{"line_number":108,"context_line":"     }"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"     return $delegate;"},{"line_number":111,"context_line":"     }"},{"line_number":112,"context_line":"     }"},{"line_number":113,"context_line":"     */"},{"line_number":114,"context_line":"    function extendedPermissions() {"},{"line_number":115,"context_line":"      return {};"}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_ea797ffd","line":112,"range":{"start_line":90,"start_character":0,"end_line":112,"end_character":6},"updated":"2016-07-26 16:05:45.000000000","message":"TODO: needs better formatting.  Or possibly just show lines 102 - 108.","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d1a387ba4d7266722f0d182df3af385b5e026dbd","unresolved":false,"context_lines":[{"line_number":87,"context_line":"     * Openstack Dashboard may set permissions for required policies, services, or settings"},{"line_number":88,"context_line":"     * (amongst other items). To do this, the service would be decorated like the following:"},{"line_number":89,"context_line":"     function permissionsDecorator($provide) {"},{"line_number":90,"context_line":"     $provide.decorator(\u0027horizon.framework.conf.permissions\u0027,"},{"line_number":91,"context_line":"     [\u0027$delegate\u0027,"},{"line_number":92,"context_line":"     \u0027horizon.app.core.openstack-service-api.policy\u0027,"},{"line_number":93,"context_line":"     \u0027horizon.app.core.openstack-service-api.serviceCatalog\u0027,"},{"line_number":94,"context_line":"     \u0027horizon.app.core.openstack-service-api.settings\u0027,"},{"line_number":95,"context_line":"     decorator]);"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"     function decorator($delegate, policy, serviceCatalog, settings) {"},{"line_number":98,"context_line":"     var permissionsService \u003d $delegate;"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"     permissionsService.extendedPermissions \u003d extendedPermissions;"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"     function extendedPermissions() {"},{"line_number":103,"context_line":"     return {"},{"line_number":104,"context_line":"     policies: policy.ifAllowed,"},{"line_number":105,"context_line":"     services: serviceCatalog.ifTypeEnabled,"},{"line_number":106,"context_line":"     settings: settings.ifEnabled"},{"line_number":107,"context_line":"     };"},{"line_number":108,"context_line":"     }"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"     return $delegate;"},{"line_number":111,"context_line":"     }"},{"line_number":112,"context_line":"     }"},{"line_number":113,"context_line":"     */"},{"line_number":114,"context_line":"    function extendedPermissions() {"},{"line_number":115,"context_line":"      return {};"}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_9e364801","line":112,"range":{"start_line":90,"start_character":0,"end_line":112,"end_character":6},"in_reply_to":"dada55a8_ea797ffd","updated":"2016-07-26 16:29:28.000000000","message":"Done","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"b52ba629bb5cfca10cfae2ff8e23709212192d58","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      return {};"},{"line_number":119,"context_line":"    }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    function handleMultipleInputs(configItem) {"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"      var promises \u003d [];"},{"line_number":124,"context_line":""}],"source_content_type":"text/javascript","patch_set":6,"id":"dada55a8_45ad0b83","line":121,"updated":"2016-07-26 23:38:21.000000000","message":"the world input makes me think of form inputs. can we rename?","commit_id":"886c9e22b85c4342edc28ed623821b2afe124ab4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"1411265361284323bcda8fc86ee7158069d6ef11","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      return {};"},{"line_number":119,"context_line":"    }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    function handleMultipleInputs(configItem) {"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"      var promises \u003d [];"},{"line_number":124,"context_line":""}],"source_content_type":"text/javascript","patch_set":6,"id":"bacf61ea_053bc5ec","line":121,"in_reply_to":"dada55a8_45ad0b83","updated":"2016-07-27 16:54:39.000000000","message":"This really gets promises based on a configuration, so I called it getConfigurationPromises().","commit_id":"886c9e22b85c4342edc28ed623821b2afe124ab4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8c412808079f5af7f9b8ec9b4d9ab8aedbf67fd9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  /**"},{"line_number":26,"context_line":"   * @ngdoc service"},{"line_number":27,"context_line":"   * @name horizon.framework.conf.permissions"},{"line_number":28,"context_line":"   * @module horizon.framework.conf"},{"line_number":29,"context_line":"   */"},{"line_number":30,"context_line":"  function Permissions($q) {"},{"line_number":31,"context_line":"    var service \u003d {"}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_ed3121ee","line":28,"updated":"2016-07-28 04:25:22.000000000","message":"What is this service and how is it intended to be used?\n\nI think it\u0027d be helpful to say something like \"This code checks the allowed() function (if it exists) on items passed in and returns the boolean result. An example of an item passed in might be a hz-dynamic-table column spec. See that code for an example of permissionService in use.\"\n\nThe split of horizon/openstack_dashboard really makes comprehension of this code far more difficult than it needs to be. While I think that the code example I\u0027ve noted below is not necessary in full, I think there should be a comment up here like \"In the openstack dashboard additional checks beyond the simple allowed() function are added to this service in the app.core.conf permissionsDecorator, including policies, services and settings.\"","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bdff0b41d240197ee6f0d7916fc9f0d4f2486bac","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  /**"},{"line_number":26,"context_line":"   * @ngdoc service"},{"line_number":27,"context_line":"   * @name horizon.framework.conf.permissions"},{"line_number":28,"context_line":"   * @module horizon.framework.conf"},{"line_number":29,"context_line":"   */"},{"line_number":30,"context_line":"  function Permissions($q) {"},{"line_number":31,"context_line":"    var service \u003d {"}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_18b75887","line":28,"in_reply_to":"bacf61ea_ed3121ee","updated":"2016-07-29 01:05:51.000000000","message":"Great suggestion. Took this and added more.","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8c412808079f5af7f9b8ec9b4d9ab8aedbf67fd9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"     * each input element."},{"line_number":60,"context_line":"     */"},{"line_number":61,"context_line":"    function checkAll(configItem) {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      // This allows users of this directive to dynamically add"},{"line_number":64,"context_line":"      // on additional declarative requirements for viewing the column."},{"line_number":65,"context_line":"      // For example, openstack dashboard may add policies, settings,"}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_6d7371b2","line":62,"updated":"2016-07-28 04:25:22.000000000","message":"nit: unnecessary blank line","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bdff0b41d240197ee6f0d7916fc9f0d4f2486bac","unresolved":false,"context_lines":[{"line_number":59,"context_line":"     * each input element."},{"line_number":60,"context_line":"     */"},{"line_number":61,"context_line":"    function checkAll(configItem) {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      // This allows users of this directive to dynamically add"},{"line_number":64,"context_line":"      // on additional declarative requirements for viewing the column."},{"line_number":65,"context_line":"      // For example, openstack dashboard may add policies, settings,"}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_d84ae082","line":62,"in_reply_to":"bacf61ea_6d7371b2","updated":"2016-07-29 01:05:51.000000000","message":"Done","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8c412808079f5af7f9b8ec9b4d9ab8aedbf67fd9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"     * @example"},{"line_number":88,"context_line":"     *"},{"line_number":89,"context_line":"     * Openstack Dashboard may set permissions for required policies, services, or settings"},{"line_number":90,"context_line":"     * (amongst other items). To do this, the service would be decorated like the following:"},{"line_number":91,"context_line":"     function permissionsDecorator($provide) {"},{"line_number":92,"context_line":"       $provide.decorator(\u0027horizon.framework.conf.permissions\u0027, ["},{"line_number":93,"context_line":"         \u0027$delegate\u0027,"}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_ad3729e2","line":90,"updated":"2016-07-28 04:25:22.000000000","message":"I don\u0027t think we need an entire copy of the code here - just a reference to the module would be enough. A shorter, contrived example would probably be ok here.","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bdff0b41d240197ee6f0d7916fc9f0d4f2486bac","unresolved":false,"context_lines":[{"line_number":87,"context_line":"     * @example"},{"line_number":88,"context_line":"     *"},{"line_number":89,"context_line":"     * Openstack Dashboard may set permissions for required policies, services, or settings"},{"line_number":90,"context_line":"     * (amongst other items). To do this, the service would be decorated like the following:"},{"line_number":91,"context_line":"     function permissionsDecorator($provide) {"},{"line_number":92,"context_line":"       $provide.decorator(\u0027horizon.framework.conf.permissions\u0027, ["},{"line_number":93,"context_line":"         \u0027$delegate\u0027,"}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_580d503d","line":90,"in_reply_to":"bacf61ea_ad3729e2","updated":"2016-07-29 01:05:51.000000000","message":"Done","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"}],"horizon/static/framework/widgets/table/hz-dynamic-table.directive.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9d8ee09593b10161bccf8530ee8fafb3adfec6d0","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  hzDynamicTable.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.framework.widgets.basePath\u0027,"},{"line_number":25,"context_line":"    \u0027horizon.framework.conf.permissions\u0027"},{"line_number":26,"context_line":"  ];"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  /**"}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_8adf23d5","line":25,"range":{"start_line":25,"start_character":27,"end_line":25,"end_character":40},"updated":"2016-07-26 16:05:45.000000000","message":"permissions.service","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"451071ecd34eb41b60fb7a4b6d75e58c0bacf895","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    function link(scope) {"},{"line_number":128,"context_line":"      //Isolate config changes we do here from propagating out."},{"line_number":129,"context_line":"      scope.config \u003d angular.copy(scope.config);"},{"line_number":130,"context_line":"      scope.items \u003d [];"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"      // if selectAll and expand are not set in the config, default set to true"}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_7bb8cb11","line":129,"range":{"start_line":129,"start_character":6,"end_line":129,"end_character":48},"updated":"2016-07-26 15:17:07.000000000","message":"I tested this pretty deeply and I think this is a good thing to do here.  I can see that deep objects in the copied config can be done so without affecting the original, and yet functions and their closures are maintained appropriately.","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"}],"openstack_dashboard/static/app/core/conf/conf.module.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9d8ee09593b10161bccf8530ee8fafb3adfec6d0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   * @name permissionsDecorator"},{"line_number":38,"context_line":"   * @param {Object} $provide"},{"line_number":39,"context_line":"   * @description"},{"line_number":40,"context_line":"   * The decorates the horizon.framework.conf.permissions service to"},{"line_number":41,"context_line":"   * support additional declarative level permissions. This adds the following"},{"line_number":42,"context_line":"   * declarative permissions:"},{"line_number":43,"context_line":"   *     \u0027services\u0027 (OpenStack services that must be enabled in the current region),"}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_eabcdf6d","line":40,"range":{"start_line":40,"start_character":5,"end_line":40,"end_character":8},"updated":"2016-07-26 16:05:45.000000000","message":"This","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d1a387ba4d7266722f0d182df3af385b5e026dbd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   * @name permissionsDecorator"},{"line_number":38,"context_line":"   * @param {Object} $provide"},{"line_number":39,"context_line":"   * @description"},{"line_number":40,"context_line":"   * The decorates the horizon.framework.conf.permissions service to"},{"line_number":41,"context_line":"   * support additional declarative level permissions. This adds the following"},{"line_number":42,"context_line":"   * declarative permissions:"},{"line_number":43,"context_line":"   *     \u0027services\u0027 (OpenStack services that must be enabled in the current region),"}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_be186c85","line":40,"range":{"start_line":40,"start_character":5,"end_line":40,"end_character":8},"in_reply_to":"dada55a8_eabcdf6d","updated":"2016-07-26 16:29:28.000000000","message":"Done","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9d8ee09593b10161bccf8530ee8fafb3adfec6d0","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \u0027horizon.app.core.openstack-service-api.policy\u0027,"},{"line_number":102,"context_line":"        \u0027horizon.app.core.openstack-service-api.serviceCatalog\u0027,"},{"line_number":103,"context_line":"        \u0027horizon.app.core.openstack-service-api.settings\u0027,"},{"line_number":104,"context_line":"        decorator]);"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    function decorator($delegate, policy, serviceCatalog, settings) {"},{"line_number":107,"context_line":"      var permissionsService \u003d $delegate;"}],"source_content_type":"text/javascript","patch_set":4,"id":"dada55a8_5e17b044","line":104,"updated":"2016-07-26 16:05:45.000000000","message":"As a note to the future, we should provide a \"dashboard\" setting or user context setting. This would inject a service that would allow a user to say \u0027dashboard\u003d\"admin\"\u0027 or \"dahsboard\u003d\"project\"\u0027 and would only resolve to true if that is the current dashboard that the user is working in.  This is essentially a user context. The user is saying \"I may be logged in as admin but I am working in the \"admin\" or \"currently scoped project\" context.","commit_id":"753662bb075b9b6279fd1f9bb845e6a5066d1273"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"b52ba629bb5cfca10cfae2ff8e23709212192d58","unresolved":false,"context_lines":[{"line_number":23,"context_line":"   *"},{"line_number":24,"context_line":"   * @description"},{"line_number":25,"context_line":"   * Provides all of the services and widgets required"},{"line_number":26,"context_line":"   * to support and display images related content."},{"line_number":27,"context_line":"   */"},{"line_number":28,"context_line":"  angular"},{"line_number":29,"context_line":"    .module(\u0027horizon.app.core.conf\u0027, [\u0027horizon.framework.conf\u0027])"}],"source_content_type":"text/javascript","patch_set":6,"id":"dada55a8_acb83412","line":26,"updated":"2016-07-26 23:38:21.000000000","message":"fix ngDocs","commit_id":"886c9e22b85c4342edc28ed623821b2afe124ab4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"1411265361284323bcda8fc86ee7158069d6ef11","unresolved":false,"context_lines":[{"line_number":23,"context_line":"   *"},{"line_number":24,"context_line":"   * @description"},{"line_number":25,"context_line":"   * Provides all of the services and widgets required"},{"line_number":26,"context_line":"   * to support and display images related content."},{"line_number":27,"context_line":"   */"},{"line_number":28,"context_line":"  angular"},{"line_number":29,"context_line":"    .module(\u0027horizon.app.core.conf\u0027, [\u0027horizon.framework.conf\u0027])"}],"source_content_type":"text/javascript","patch_set":6,"id":"bacf61ea_65e281a1","line":26,"in_reply_to":"dada55a8_acb83412","updated":"2016-07-27 16:54:39.000000000","message":"Done","commit_id":"886c9e22b85c4342edc28ed623821b2afe124ab4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"b52ba629bb5cfca10cfae2ff8e23709212192d58","unresolved":false,"context_lines":[{"line_number":83,"context_line":"   *"},{"line_number":84,"context_line":"   * The desired setting must be listed in one of the two following locations"},{"line_number":85,"context_line":"   * in settings.py or local_settings.py in order for it to be available"},{"line_number":86,"context_line":"   * to the client side for evaluation. If it is not, it will always evalute"},{"line_number":87,"context_line":"   * to false."},{"line_number":88,"context_line":"   *"},{"line_number":89,"context_line":"   * REST_API_REQUIRED_SETTINGS"}],"source_content_type":"text/javascript","patch_set":6,"id":"dada55a8_cc69288e","line":86,"updated":"2016-07-26 23:38:21.000000000","message":"evaluate*","commit_id":"886c9e22b85c4342edc28ed623821b2afe124ab4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"1411265361284323bcda8fc86ee7158069d6ef11","unresolved":false,"context_lines":[{"line_number":83,"context_line":"   *"},{"line_number":84,"context_line":"   * The desired setting must be listed in one of the two following locations"},{"line_number":85,"context_line":"   * in settings.py or local_settings.py in order for it to be available"},{"line_number":86,"context_line":"   * to the client side for evaluation. If it is not, it will always evalute"},{"line_number":87,"context_line":"   * to false."},{"line_number":88,"context_line":"   *"},{"line_number":89,"context_line":"   * REST_API_REQUIRED_SETTINGS"}],"source_content_type":"text/javascript","patch_set":6,"id":"bacf61ea_a5f2b96d","line":86,"in_reply_to":"dada55a8_cc69288e","updated":"2016-07-27 16:54:39.000000000","message":"Done","commit_id":"886c9e22b85c4342edc28ed623821b2afe124ab4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8c412808079f5af7f9b8ec9b4d9ab8aedbf67fd9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   * @param {Object} $provide"},{"line_number":38,"context_line":"   * @description"},{"line_number":39,"context_line":"   * This decorates the horizon.framework.conf.permissions service to"},{"line_number":40,"context_line":"   * support additional declarative level permissions. This adds the following"},{"line_number":41,"context_line":"   * declarative permissions:"},{"line_number":42,"context_line":"   *     \u0027services\u0027 (OpenStack services that must be enabled in the current region),"},{"line_number":43,"context_line":"   *     \u0027settings\u0027 (horizon settings that must be enabled)"}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_2accbf34","line":40,"updated":"2016-07-28 04:25:22.000000000","message":"\"... declarative level permissions based on openstack_dashboard requirements.\" just to make it clearer for the newcomer.","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bdff0b41d240197ee6f0d7916fc9f0d4f2486bac","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   * @param {Object} $provide"},{"line_number":38,"context_line":"   * @description"},{"line_number":39,"context_line":"   * This decorates the horizon.framework.conf.permissions service to"},{"line_number":40,"context_line":"   * support additional declarative level permissions. This adds the following"},{"line_number":41,"context_line":"   * declarative permissions:"},{"line_number":42,"context_line":"   *     \u0027services\u0027 (OpenStack services that must be enabled in the current region),"},{"line_number":43,"context_line":"   *     \u0027settings\u0027 (horizon settings that must be enabled)"}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_73195579","line":40,"in_reply_to":"bacf61ea_2accbf34","updated":"2016-07-29 01:05:51.000000000","message":"Done","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8c412808079f5af7f9b8ec9b4d9ab8aedbf67fd9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   * support additional declarative level permissions. This adds the following"},{"line_number":41,"context_line":"   * declarative permissions:"},{"line_number":42,"context_line":"   *     \u0027services\u0027 (OpenStack services that must be enabled in the current region),"},{"line_number":43,"context_line":"   *     \u0027settings\u0027 (horizon settings that must be enabled)"},{"line_number":44,"context_line":"   *     \u0027policies\u0027 (policy rules that must be allowed)"},{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   * \u0027policies\u0027 may be set to a single object or an array of rules objects."}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_8ae84b7e","line":43,"updated":"2016-07-28 04:25:22.000000000","message":"nit: \"Horizon\" (capitalize)\n\n\n(sarcasm, ignore) \"horizon\" settings, being configured from openstack_dashboard, because that\u0027s where the settings are, as opposed to \"horizon\" ... grrr","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bdff0b41d240197ee6f0d7916fc9f0d4f2486bac","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   * support additional declarative level permissions. This adds the following"},{"line_number":41,"context_line":"   * declarative permissions:"},{"line_number":42,"context_line":"   *     \u0027services\u0027 (OpenStack services that must be enabled in the current region),"},{"line_number":43,"context_line":"   *     \u0027settings\u0027 (horizon settings that must be enabled)"},{"line_number":44,"context_line":"   *     \u0027policies\u0027 (policy rules that must be allowed)"},{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   * \u0027policies\u0027 may be set to a single object or an array of rules objects."}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_533b71d1","line":43,"in_reply_to":"bacf61ea_8ae84b7e","updated":"2016-07-29 01:05:51.000000000","message":"serious grrr from me as well.","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8c412808079f5af7f9b8ec9b4d9ab8aedbf67fd9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"   *     \u0027services\u0027 (OpenStack services that must be enabled in the current region),"},{"line_number":43,"context_line":"   *     \u0027settings\u0027 (horizon settings that must be enabled)"},{"line_number":44,"context_line":"   *     \u0027policies\u0027 (policy rules that must be allowed)"},{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   * \u0027policies\u0027 may be set to a single object or an array of rules objects."},{"line_number":47,"context_line":"   *"},{"line_number":48,"context_line":"   * All of the following are examples:"}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_edb6413c","line":45,"updated":"2016-07-28 04:25:22.000000000","message":"I am at a complete loss as to how or in what context these are actually set/used. An example would be really good here.","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bdff0b41d240197ee6f0d7916fc9f0d4f2486bac","unresolved":false,"context_lines":[{"line_number":42,"context_line":"   *     \u0027services\u0027 (OpenStack services that must be enabled in the current region),"},{"line_number":43,"context_line":"   *     \u0027settings\u0027 (horizon settings that must be enabled)"},{"line_number":44,"context_line":"   *     \u0027policies\u0027 (policy rules that must be allowed)"},{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   * \u0027policies\u0027 may be set to a single object or an array of rules objects."},{"line_number":47,"context_line":"   *"},{"line_number":48,"context_line":"   * All of the following are examples:"}],"source_content_type":"text/javascript","patch_set":8,"id":"bacf61ea_33ab5dd8","line":45,"in_reply_to":"bacf61ea_edb6413c","updated":"2016-07-29 01:05:51.000000000","message":"Originally I only needed policies, but cindy asked to bring in some others from:\n\nhttps://github.com/openstack/horizon/tree/master/openstack_dashboard/static/app/core/cloud-services\n\nSo, I did and I think that\u0027s okay. My reference for images is in the next patch, but I went ahead and made a contrived example for instances.","commit_id":"f32d54a08eefe377231087a88dec2cd504e98890"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"9ebd1ef0e2eac9626bd60a45e3510e9641f15cd8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"   *     \u0027settings\u0027 (OpenStack Dashboard settings that must be enabled)"},{"line_number":44,"context_line":"   *     \u0027policies\u0027 (policy rules that must be allowed)"},{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   * For example, these may all be used with the regisry service and table column registrations."},{"line_number":47,"context_line":"   * They are passed through to hz-dynamic-table which asks the permissions service to check"},{"line_number":48,"context_line":"   * the column\u0027s permissions before displaying each column. Below is a pseudo example where you"},{"line_number":49,"context_line":"   * want to show the instance compute host only if the user is an admin. So you\u0027d create a policy"}],"source_content_type":"text/javascript","patch_set":11,"id":"bacf61ea_64df9f0d","line":46,"updated":"2016-07-29 21:19:54.000000000","message":"nit \"registry\"","commit_id":"a249d7179e45565046f41b7b493467b9b28f3064"}]}
