)]}'
{"openstack_dashboard/api/nova.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"418bb7066ee48a5f86c428f2544a7f9dfafc41b0","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        # be removed once novaclient supports this call."},{"line_number":312,"context_line":"        security_groups \u003d []"},{"line_number":313,"context_line":"        nclient \u003d self.client"},{"line_number":314,"context_line":"        resp, body \u003d nclient.client.get(\u0027/servers/%s/os-security-groups\u0027"},{"line_number":315,"context_line":"                                        % instance_id)"},{"line_number":316,"context_line":"        if body:"},{"line_number":317,"context_line":"            # Wrap data in SG objects as novaclient would."}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_6a1c98c1","side":"PARENT","line":314,"updated":"2016-09-07 09:27:42.000000000","message":"Hmm, I wonder if the idea behind this TODO was that gabriel wanted to avoid fetching of information about an instance and go directly for the list of security groups instead.","commit_id":"92e4f9d225fb4e7c62d45dc452382253a38ce2e5"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"1b4d2f57542fc55daa9eaf74127e295044e96a70","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    Wraps its rules in SecurityGroupRule objects and allows access to them."},{"line_number":216,"context_line":"    \"\"\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    _attrs \u003d [\u0027id\u0027, \u0027name\u0027, \u0027description\u0027, \u0027tenant_id\u0027]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @cached_property"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_5b89f1c9","side":"PARENT","line":217,"updated":"2016-09-14 03:56:40.000000000","message":"unrelated line","commit_id":"7419a6f36506416ac56c9637d068d9c78bbaaec2"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"4e6702655674c15ccd8e47e476473ab8ae720aa3","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                nclient.security_groups, sg, loaded\u003dTrue)"},{"line_number":315,"context_line":"            sg_objs.append(sg_obj)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        security_groups \u003d [SecurityGroup(sg) for sg in sg_objs]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        return security_groups"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_a0ad9cea","line":317,"updated":"2016-11-11 16:28:21.000000000","message":"Why two separate loops? Can\u0027t you wrap it twice in a single loop?\nAlso, please leave the comment explaining why double wrapping is necessary.","commit_id":"ed6b3a710e2862659c2535d8322ebfe578c8b881"}],"openstack_dashboard/test/api_tests/network_tests.py":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"1b4d2f57542fc55daa9eaf74127e295044e96a70","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        rm_secgroup \u003d all_secgroups[0]"},{"line_number":95,"context_line":"        cur_secgroups \u003d []"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        for sg in all_secgroups[0:2]:"},{"line_number":98,"context_line":"            sg_obj \u003d SecurityGroup(None)"},{"line_number":99,"context_line":"            sg_obj.id \u003d sg.id"},{"line_number":100,"context_line":"            sg_obj.name \u003d sg.name"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_3b17c552","line":97,"updated":"2016-09-14 03:56:40.000000000","message":"sg is SecurityGroup object, why not use it directly?","commit_id":"ed6b3a710e2862659c2535d8322ebfe578c8b881"}]}
