)]}'
{"openstack_dashboard/local/local_settings.d/_2010_integration_tests_deprecated.py.example":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"746254dd6c40b6185916ec4bf1f2a3d610f9c96c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This file is to be included for configuring integration tests when"},{"line_number":2,"context_line":"# wanting to only test legacy panels.  Since \u0027local\u0027 modules are evaluated"},{"line_number":3,"context_line":"# after core modules, these configurations will override the panel settings."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"HORIZON_CONFIG.update({\"images_panel\": \"legacy\"})"},{"line_number":6,"context_line":"HORIZON_CONFIG.update({\"flavors_panel\": \"legacy\"})"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"bacf61ea_210ac48a","line":3,"range":{"start_line":2,"start_character":39,"end_line":3,"end_character":76},"updated":"2016-08-04 13:41:03.000000000","message":"This comment is wrong...should say that it overrides settings.py.","commit_id":"16a37b546710db4b13b30c8fd5ad544716a2c226"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b883a3c70d63535a146a3a7a0e376adfbeb3ab47","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This file is to be included for configuring integration tests when"},{"line_number":2,"context_line":"# wanting to only test legacy panels.  Since \u0027local\u0027 modules are evaluated"},{"line_number":3,"context_line":"# after core modules, these configurations will override the panel settings."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"HORIZON_CONFIG.update({\"images_panel\": \"legacy\"})"},{"line_number":6,"context_line":"HORIZON_CONFIG.update({\"flavors_panel\": \"legacy\"})"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"bacf61ea_c9b47183","line":3,"range":{"start_line":2,"start_character":39,"end_line":3,"end_character":76},"in_reply_to":"bacf61ea_210ac48a","updated":"2016-08-05 14:48:17.000000000","message":"If it is wrong, why not fix it?","commit_id":"16a37b546710db4b13b30c8fd5ad544716a2c226"}],"openstack_dashboard/local/local_settings.d/_30_integration_tests_deprecated.py.example":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3d0ecbbf79c4d7d7770be8e52fb155d405602578","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This file is to be included for configuring integration tests when"},{"line_number":2,"context_line":"# wanting to only test legacy panels.  Since \u0027local\u0027 modules are evaluated"},{"line_number":3,"context_line":"# after core modules, these configurations will override the panel settings."},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bacf61ea_21856b06","line":1,"updated":"2016-08-01 09:52:02.000000000","message":"Let\u0027s use the same _20 prefix for this file to indicate it also belongs to integration tests, e.g. _2010_integration_tests_deprecated.py","commit_id":"431f990342983b6b0db3dffc84dd804fbc8420ec"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5cade7ce5042e08b336e2f6d74875da08943d923","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This file is to be included for configuring integration tests when"},{"line_number":2,"context_line":"# wanting to only test legacy panels.  Since \u0027local\u0027 modules are evaluated"},{"line_number":3,"context_line":"# after core modules, these configurations will override the panel settings."},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bacf61ea_27c8d1a5","line":1,"in_reply_to":"bacf61ea_21856b06","updated":"2016-08-01 13:23:02.000000000","message":"Fine with me, as long as it works! :)","commit_id":"431f990342983b6b0db3dffc84dd804fbc8420ec"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"35bd562cb353dab591d66f1c95754470f6edc42b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This file is to be included for configuring integration tests when"},{"line_number":2,"context_line":"# wanting to only test legacy panels.  Since \u0027local\u0027 modules are evaluated"},{"line_number":3,"context_line":"# after core modules, these configurations will override the panel settings."},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bacf61ea_2ad538e7","line":1,"in_reply_to":"bacf61ea_27c8d1a5","updated":"2016-08-01 13:46:12.000000000","message":"Done","commit_id":"431f990342983b6b0db3dffc84dd804fbc8420ec"}],"tools/gate/integration/pre_test_hook.sh":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3d0ecbbf79c4d7d7770be8e52fb155d405602578","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if [ \"${HORIZON_TEST_DEPRECATED}\" ] ; then"},{"line_number":13,"context_line":"  mv _30_integration_tests_deprecated.py.example _30_integration_tests_deprecated.py"},{"line_number":14,"context_line":"  # not sure if this is actually going to be run from this directory"},{"line_number":15,"context_line":"  sed -i \u0027s/angular/legacy/g\u0027 ${HORIZON_CODE_DIR}/openstack_dashboard/test/integration_tests/horizon.conf"},{"line_number":16,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"bacf61ea_419dff08","line":15,"range":{"start_line":15,"start_character":2,"end_line":15,"end_character":105},"updated":"2016-08-01 09:52:02.000000000","message":"Using sed is not very elegant, it could made unwanted replacements in unexpected places, especially when word boundaries are not considered.\n\nI suggest to use the mechanism of overriding horizon.conf with local-horizon.conf file which [mechanism] is defined here: https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/config.py#L148-L151\n\nYou need to place local-horizon.conf file alongside with original horizon.conf and define only the sections/settings that need to be overridden. See for example the file contents I use for local test runs: http://paste2.org/fHA6yj0a","commit_id":"431f990342983b6b0db3dffc84dd804fbc8420ec"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5cade7ce5042e08b336e2f6d74875da08943d923","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if [ \"${HORIZON_TEST_DEPRECATED}\" ] ; then"},{"line_number":13,"context_line":"  mv _30_integration_tests_deprecated.py.example _30_integration_tests_deprecated.py"},{"line_number":14,"context_line":"  # not sure if this is actually going to be run from this directory"},{"line_number":15,"context_line":"  sed -i \u0027s/angular/legacy/g\u0027 ${HORIZON_CODE_DIR}/openstack_dashboard/test/integration_tests/horizon.conf"},{"line_number":16,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"bacf61ea_e7f23905","line":15,"range":{"start_line":15,"start_character":2,"end_line":15,"end_character":105},"in_reply_to":"bacf61ea_419dff08","updated":"2016-08-01 13:23:02.000000000","message":"Excellent!  Thanks for letting me know about this.","commit_id":"431f990342983b6b0db3dffc84dd804fbc8420ec"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"35bd562cb353dab591d66f1c95754470f6edc42b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if [ \"${HORIZON_TEST_DEPRECATED}\" ] ; then"},{"line_number":13,"context_line":"  mv _30_integration_tests_deprecated.py.example _30_integration_tests_deprecated.py"},{"line_number":14,"context_line":"  # not sure if this is actually going to be run from this directory"},{"line_number":15,"context_line":"  sed -i \u0027s/angular/legacy/g\u0027 ${HORIZON_CODE_DIR}/openstack_dashboard/test/integration_tests/horizon.conf"},{"line_number":16,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"bacf61ea_9d50ec0c","line":15,"range":{"start_line":15,"start_character":2,"end_line":15,"end_character":105},"in_reply_to":"bacf61ea_e7f23905","updated":"2016-08-01 13:46:12.000000000","message":"Done","commit_id":"431f990342983b6b0db3dffc84dd804fbc8420ec"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"c9010289d864cc31d7d67cacb24b4c3be87fb03f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mv _20_integration_tests_scaffolds.py.example _20_integration_tests_scaffolds.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ \"$1\" \u003d\u003d \"dep\" ] ; then"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"mv _2010_integration_tests_deprecated.py.example _2010_integration_tests_deprecated.py"},{"line_number":15,"context_line":"cat \u003e ${HORIZON_CODE_DIR}/openstack_dashboard/test/integration_tests/local-horizon.conf \u003c\u003cEOF"},{"line_number":16,"context_line":"[image]"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bacf61ea_54c6024a","line":13,"updated":"2016-08-02 17:27:19.000000000","message":"Indenting this will make it a bit easier to parse visually.","commit_id":"99c6fb3b2d906517bd67ef9bde7dfe1ed8899790"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9d1c4cf179a41f32a36aa927a3eb9efd349d8b68","unresolved":false,"context_lines":[{"line_number":9,"context_line":"cd ${HORIZON_CODE_DIR}/openstack_dashboard/local/local_settings.d"},{"line_number":10,"context_line":"mv _20_integration_tests_scaffolds.py.example _20_integration_tests_scaffolds.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ \"$1\" \u003d\u003d \"deprecated\" ] ; then"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"mv _2010_integration_tests_deprecated.py.example _2010_integration_tests_deprecated.py"},{"line_number":15,"context_line":"cat \u003e ${HORIZON_CODE_DIR}/openstack_dashboard/test/integration_tests/local-horizon.conf \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bacf61ea_3f2b5435","line":12,"updated":"2016-08-03 05:42:42.000000000","message":"Since most of if block contents is a here documents, which needs tabs for proper indentation (see http://unix.stackexchange.com/questions/76481/cant-indent-heredoc-to-match-nestings-indent), I think we could skip the indentattion to not mess with tabs.","commit_id":"4462acd6f72ded4a38de0b0c62505c6784e8e45c"}]}
