)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"95174146a25d7ab704c5e34e0b6c029aded830ef","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add the admin_filter_first feature to networks admin/project views."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements blueprint: admin-views-filter-first"},{"line_number":12,"context_line":"Depends-On: Ie05f58a77b62b12dbf087395fbaf4ff0dc1f8562"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I934240040dec3094e0271c14a85a1081cbe878f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad45d7e_a1d496eb","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":53},"updated":"2016-08-11 19:27:04.000000000","message":"There is no need to use Depends-On.\nYour patch already has the above change-ID as a parent commit.","commit_id":"820f0553c3d6e343cb5827e74fd6a25c034ab653"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1b6c462160dd3476385c8e79ea08dc5416dc05ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements admin_filter_first in networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the admin_filter_first feature to networks admin/project views."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements blueprint: admin-views-filter-first"},{"line_number":12,"context_line":"Change-Id: I934240040dec3094e0271c14a85a1081cbe878f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3ac371cc_a07615d6","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":66},"updated":"2016-08-19 02:47:54.000000000","message":"It\u0027s only admin view, right?","commit_id":"175d122e70b503277d40a8fc77ee3844c92a2fb5"}],"openstack_dashboard/dashboards/admin/networks/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"95174146a25d7ab704c5e34e0b6c029aded830ef","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            search_opts \u003d self.get_filters(filters_map\u003dself.FILTERS_MAPPING)"},{"line_number":88,"context_line":"            networks \u003d []"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"            \"\"\"If admin_filter_first is set and if there are not other filters"},{"line_number":91,"context_line":"            selected, then search criteria must be provided and return an empty"},{"line_number":92,"context_line":"            list\"\"\""},{"line_number":93,"context_line":"            if self.admin_filter_first and not search_opts:"},{"line_number":94,"context_line":"                self._needs_filter_first \u003d True"},{"line_number":95,"context_line":"                return []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_01880270","line":92,"range":{"start_line":90,"start_character":11,"end_line":92,"end_character":19},"updated":"2016-08-11 19:27:04.000000000","message":"Use # for a usual comment. We use triple quotes only for docstring.","commit_id":"820f0553c3d6e343cb5827e74fd6a25c034ab653"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"95174146a25d7ab704c5e34e0b6c029aded830ef","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            \"\"\"If admin_filter_first is set and if there are not other filters"},{"line_number":91,"context_line":"            selected, then search criteria must be provided and return an empty"},{"line_number":92,"context_line":"            list\"\"\""},{"line_number":93,"context_line":"            if self.admin_filter_first and not search_opts:"},{"line_number":94,"context_line":"                self._needs_filter_first \u003d True"},{"line_number":95,"context_line":"                return []"},{"line_number":96,"context_line":"            self._needs_filter_first \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_6111fe5c","line":93,"range":{"start_line":93,"start_character":15,"end_line":93,"end_character":38},"updated":"2016-08-11 19:27:04.000000000","message":"(This is not a question only for the author.)\n\nI am really surprised horizon.tables.views.MultiTableMixin defines admin_filter_first attribute. In the design policy of horizon, \u0027horizon\u0027 module provides a django part and should not be aware of OpenStack specific feature. \u0027openstack_dashboard\u0027 should provide OpenStack specific features. \u0027admin\u0027 is a concept of OpenStack, so \u0027horizon.tables.views.MultiTableMixin\u0027 should not be aware of OpenStack \u0027admin\u0027. Are we squashing \u0027horizon\u0027 and \u0027openstack_dashboard\u0027?\nWhat is the motivation to add OpenStack-specific concept to \u0027horizon\u0027 module?","commit_id":"820f0553c3d6e343cb5827e74fd6a25c034ab653"}]}