)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"24a3ce0cc05a5bfa931716d84b2c7eb161906f0a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"I haven\u0027t moved the \u0027swift_panel\u0027 setting, as that panel will be removed"},{"line_number":14,"context_line":"in the O cycle anway, so it seems pointless to move a setting causing"},{"line_number":15,"context_line":"potential issues for a single cycle."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ia5702ff523355ae895e14cc3d49c895128478944"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3ac371cc_866946c1","line":16,"updated":"2016-08-16 01:56:25.000000000","message":"Forgot the LP tracing line?\nThere are 4 patches set as same topic: \u0027angular-features-setting\u0027.\nTwo of them marked as `Partially-Implements: blueprint ng-flavors`,\nand one of them marked as `Partially-Implements: blueprint angularize-images-table`.\nWhat about this patch ?","commit_id":"1050755d052eea728e98089ca3ef855d899d6f69"}],"doc/source/topics/settings.rst":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"eb9d5d81868abc061c0a1db9d9387b855d4f6096","unresolved":false,"context_lines":[{"line_number":436,"context_line":"  }"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"A dictionary of currently available AngularJS features. This allows simple"},{"line_number":439,"context_line":"toggling of legacy or rewritten featues, such as new panels, workflows etc."},{"line_number":440,"context_line":""},{"line_number":441,"context_line":""},{"line_number":442,"context_line":".. _available_themes:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ac371cc_2f5317e3","line":439,"updated":"2016-08-15 18:30:36.000000000","message":"features*","commit_id":"e663df2c8f16639fe3a9b302f17f87920bc78c86"}],"openstack_dashboard/dashboards/admin/images/urls.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"43a98c04445c98efa1b6f5a99090d89aaa761f3d","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from openstack_dashboard.dashboards.admin.images import views"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if settings.ANGULAR_FEATURES[\u0027images_panel\u0027]:"},{"line_number":25,"context_line":"    # New angular images"},{"line_number":26,"context_line":"    urlpatterns \u003d ["},{"line_number":27,"context_line":"        url(r\u0027^$\u0027, views.AngularIndexView.as_view(), name\u003d\u0027index\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_4e630b1b","line":24,"range":{"start_line":24,"start_character":3,"end_line":24,"end_character":44},"updated":"2016-08-15 13:05:29.000000000","message":"Not providing a default value for a missing ANGULAR_FEATURES setting is another nail in the coffin of plugins which still use their own (copy-pasted from openstack_dashboard) settings ;). On the other hand, I don\u0027t think it is possible since the times of overridable angular templates commit, so it doesn\u0027t matter anymore.","commit_id":"e663df2c8f16639fe3a9b302f17f87920bc78c86"}],"openstack_dashboard/local/local_settings.d/_2010_integration_tests_deprecated.py.example":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d1a0dd2bc9b2e195a3c1ea0ee28300597bc6c5fb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# wanting to only test legacy panels.  Since \u0027local\u0027 modules are evaluated"},{"line_number":3,"context_line":"# after settings.py, these configurations will override the default settings."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ANGULAR_FEATURES.update({\"images_panel\": \"legacy\"})"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9ad45d7e_a5f8ebc5","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":48},"updated":"2016-08-12 15:20:53.000000000","message":"Needs to be False.","commit_id":"f0db1605fb549e58ce2c2d94136269bc0142388a"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"fbd9a67187e1fb975352c5d62c6f0487ca36e0f3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# wanting to only test legacy panels.  Since \u0027local\u0027 modules are evaluated"},{"line_number":3,"context_line":"# after settings.py, these configurations will override the default settings."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ANGULAR_FEATURES.update({\"images_panel\": False})"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9ad45d7e_d84d02c6","line":5,"updated":"2016-08-12 15:41:21.000000000","message":"Interesting, when I try to do this in local_settings.py it doesn\u0027t work; there I have to explicitly set ANGULAR_FEATURES.","commit_id":"e663df2c8f16639fe3a9b302f17f87920bc78c86"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"43a98c04445c98efa1b6f5a99090d89aaa761f3d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# wanting to only test legacy panels.  Since \u0027local\u0027 modules are evaluated"},{"line_number":3,"context_line":"# after settings.py, these configurations will override the default settings."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ANGULAR_FEATURES.update({\"images_panel\": False})"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3ac371cc_6eb527cc","line":5,"in_reply_to":"9ad45d7e_d84d02c6","updated":"2016-08-15 13:05:29.000000000","message":"That\u0027s quite understandable: local_settings.py is being imported (and knows nothing about the importing module globals), while code snippets from local_settings.d/ are being executed in the same globals() environment of the openstack_dashboard.settings module.","commit_id":"e663df2c8f16639fe3a9b302f17f87920bc78c86"}]}
