)]}'
{"horizon/templates/horizon/common/_data_table_action.html":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"6390afb907c4fec2d1d01119f79a7a899bc32167","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      class\u003d\"btn data-table-action {% if is_single %}btn-default {% endif %}{% if is_small %}btn-sm {% endif %}{{ action.get_final_css|safe }}\""},{"line_number":36,"context_line":"      {% if is_table_action %}"},{"line_number":37,"context_line":"        href\u003d\"{{ action.get_link_url }}\""},{"line_number":38,"context_line":"        title\u003d\"{{ action.verbose_name }}\"\u003e"},{"line_number":39,"context_line":"        {% if action.icon !\u003d None %}"},{"line_number":40,"context_line":"          \u003cspan class\u003d\"fa fa-{{ action.icon }}\"\u003e\u003c/span\u003e"},{"line_number":41,"context_line":"        {% endif %}"}],"source_content_type":"text/html","patch_set":3,"id":"1ac06dbe_7194b6e1","line":38,"updated":"2016-08-22 06:44:26.000000000","message":"Do you have any reason why this patch is addressing only the row_action case? In table_action case, verbose_name is used as a title value, but it\u0027s meaningless. So IMO, It\u0027s better to be able to set in both cases. Thank you.","commit_id":"dda7b1ba052a7006d45a8193e392da9b06170e65"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"b22f3483a55e20d7a7172a177f25c6e85da53a26","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      class\u003d\"btn data-table-action {% if is_single %}btn-default {% endif %}{% if is_small %}btn-sm {% endif %}{{ action.get_final_css|safe }}\""},{"line_number":36,"context_line":"      {% if is_table_action %}"},{"line_number":37,"context_line":"        href\u003d\"{{ action.get_link_url }}\""},{"line_number":38,"context_line":"        title\u003d\"{{ action.verbose_name }}\"\u003e"},{"line_number":39,"context_line":"        {% if action.icon !\u003d None %}"},{"line_number":40,"context_line":"          \u003cspan class\u003d\"fa fa-{{ action.icon }}\"\u003e\u003c/span\u003e"},{"line_number":41,"context_line":"        {% endif %}"}],"source_content_type":"text/html","patch_set":3,"id":"1ac06dbe_b0c0c87d","line":38,"in_reply_to":"1ac06dbe_0cd39205","updated":"2016-08-22 15:19:55.000000000","message":"+1","commit_id":"dda7b1ba052a7006d45a8193e392da9b06170e65"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"83ea00187c38d3846b5f8bcd93461e4de7580d63","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      class\u003d\"btn data-table-action {% if is_single %}btn-default {% endif %}{% if is_small %}btn-sm {% endif %}{{ action.get_final_css|safe }}\""},{"line_number":36,"context_line":"      {% if is_table_action %}"},{"line_number":37,"context_line":"        href\u003d\"{{ action.get_link_url }}\""},{"line_number":38,"context_line":"        title\u003d\"{{ action.verbose_name }}\"\u003e"},{"line_number":39,"context_line":"        {% if action.icon !\u003d None %}"},{"line_number":40,"context_line":"          \u003cspan class\u003d\"fa fa-{{ action.icon }}\"\u003e\u003c/span\u003e"},{"line_number":41,"context_line":"        {% endif %}"}],"source_content_type":"text/html","patch_set":3,"id":"1ac06dbe_aa9fb44e","line":38,"in_reply_to":"1ac06dbe_0cd39205","updated":"2016-08-22 16:11:59.000000000","message":"Why not define `help_text` attribute for `Action` class instead of `LinkAction`?","commit_id":"dda7b1ba052a7006d45a8193e392da9b06170e65"},{"author":{"_account_id":20364,"name":"Konstantin Snihyr","email":"konstantin.lex@gmail.com","username":"ksnihyr"},"change_message_id":"cd4b215b291ef8aba5e858b9b8beb6710713b459","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      class\u003d\"btn data-table-action {% if is_single %}btn-default {% endif %}{% if is_small %}btn-sm {% endif %}{{ action.get_final_css|safe }}\""},{"line_number":36,"context_line":"      {% if is_table_action %}"},{"line_number":37,"context_line":"        href\u003d\"{{ action.get_link_url }}\""},{"line_number":38,"context_line":"        title\u003d\"{{ action.verbose_name }}\"\u003e"},{"line_number":39,"context_line":"        {% if action.icon !\u003d None %}"},{"line_number":40,"context_line":"          \u003cspan class\u003d\"fa fa-{{ action.icon }}\"\u003e\u003c/span\u003e"},{"line_number":41,"context_line":"        {% endif %}"}],"source_content_type":"text/html","patch_set":3,"id":"1ac06dbe_0cd39205","line":38,"in_reply_to":"1ac06dbe_7194b6e1","updated":"2016-08-22 13:20:56.000000000","message":"Hi, Kenji ! Thank you for attention. In table_action case verbose_name used according to documentation. This patch only introduce new feature. If you want to change existing behaviour, we can discuss it in feature request on launchpad.\nCurrently not all actions have \u0027.help_text\u0027 field, this is not part of parent interface.","commit_id":"dda7b1ba052a7006d45a8193e392da9b06170e65"},{"author":{"_account_id":20364,"name":"Konstantin Snihyr","email":"konstantin.lex@gmail.com","username":"ksnihyr"},"change_message_id":"08696f26c96f2cdbfa9123954fbabe46c2127436","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      class\u003d\"btn data-table-action {% if is_single %}btn-default {% endif %}{% if is_small %}btn-sm {% endif %}{{ action.get_final_css|safe }}\""},{"line_number":36,"context_line":"      {% if is_table_action %}"},{"line_number":37,"context_line":"        href\u003d\"{{ action.get_link_url }}\""},{"line_number":38,"context_line":"        title\u003d\"{{ action.verbose_name }}\"\u003e"},{"line_number":39,"context_line":"        {% if action.icon !\u003d None %}"},{"line_number":40,"context_line":"          \u003cspan class\u003d\"fa fa-{{ action.icon }}\"\u003e\u003c/span\u003e"},{"line_number":41,"context_line":"        {% endif %}"}],"source_content_type":"text/html","patch_set":3,"id":"9a89bdaa_f86c6c9e","line":38,"in_reply_to":"1ac06dbe_aa9fb44e","updated":"2016-09-05 09:59:49.000000000","message":"I\u0027m not sure about it. Don\u0027t know how to define help_text description for DeleteAction or FilterAction","commit_id":"dda7b1ba052a7006d45a8193e392da9b06170e65"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"83ea00187c38d3846b5f8bcd93461e4de7580d63","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        {% endif %}"},{"line_number":42,"context_line":"      {% else %}"},{"line_number":43,"context_line":"        {% if action.help_text %}"},{"line_number":44,"context_line":"          data-toggle\u003d\"tooltip\" data-placement\u003d\"top\" title\u003d\"{{ action.help_text }}\""},{"line_number":45,"context_line":"        {% endif %}"},{"line_number":46,"context_line":"        href\u003d\"{{ action.bound_url }}\"\u003e"},{"line_number":47,"context_line":"      {% endif %}"}],"source_content_type":"text/html","patch_set":3,"id":"1ac06dbe_ad36aee4","line":44,"range":{"start_line":44,"start_character":48,"end_line":44,"end_character":51},"updated":"2016-08-22 16:11:59.000000000","message":"I\u0027m a bit hesitant about placing it on top of element... In a row-action dropdown where a lot of actions have help_text attribute this may create clutter which will prevent from seeing other dropdown elements.\n\nI would be happy to hear other cores\u0027 opinions though.","commit_id":"dda7b1ba052a7006d45a8193e392da9b06170e65"}]}