)]}'
{"openstack_dashboard/static/app/core/images/details/drawer.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2bf4a25e305da4e210f82ca6cfd2b9e7fb3cd335","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    item\u003d\"item\""},{"line_number":6,"context_line":"    property-groups\u003d\"["},{"line_number":7,"context_line":"      [\u0027name\u0027, \u0027id\u0027],"},{"line_number":8,"context_line":"      [\u0027visibility\u0027, \u0027is_public\u0027, \u0027protected\u0027],"},{"line_number":9,"context_line":"      [\u0027disk_format\u0027, \u0027size\u0027],"},{"line_number":10,"context_line":"      [\u0027min_disk\u0027, \u0027min_ram\u0027]]\"\u003e"},{"line_number":11,"context_line":"  \u003c/hz-resource-property-list\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"1ac06dbe_f5f27799","line":8,"range":{"start_line":8,"start_character":21,"end_line":8,"end_character":32},"updated":"2016-08-19 23:51:19.000000000","message":"visibility replaces is_public.  This shouldn\u0027t be here.","commit_id":"7bb0bd51f8a44e6279624040049bfc2e04eb4424"}],"openstack_dashboard/static/app/core/images/images.module.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c5ad86f028eb7d5ad95f52139b7797963f0d027e","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        label: gettext(\u0027Virtual Size\u0027)"},{"line_number":130,"context_line":"      })"},{"line_number":131,"context_line":"      .setProperty(\u0027visibility\u0027, {"},{"line_number":132,"context_line":"        label: gettext(\u0027Visibility\u0027)"},{"line_number":133,"context_line":"      })"},{"line_number":134,"context_line":"      .setProperty(\u0027description\u0027, {"},{"line_number":135,"context_line":"        label: gettext(\u0027Description\u0027)"}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_dca1d595","line":132,"updated":"2016-08-17 21:35:58.000000000","message":"This needs the visibility filter applied I think:\n\nI guess this is okay and be updated with the glance v2 patch.  But really, we need to first get the glance version and then if v1 do this and if v2 use the visibility field.\n\nOr we could just add synthetic visibility in the get images call that always populates visibility using logic similar to this:\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/filters/image-visibility.filter.js","commit_id":"c2ebb34333ecd201e77bb69b1d1c0a4a43eed75b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f602a29c67ef68de2d10f9c7cd0d7c27f173e22f","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        label: gettext(\u0027Virtual Size\u0027)"},{"line_number":130,"context_line":"      })"},{"line_number":131,"context_line":"      .setProperty(\u0027visibility\u0027, {"},{"line_number":132,"context_line":"        label: gettext(\u0027Visibility\u0027)"},{"line_number":133,"context_line":"      })"},{"line_number":134,"context_line":"      .setProperty(\u0027description\u0027, {"},{"line_number":135,"context_line":"        label: gettext(\u0027Description\u0027)"}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_717a5b25","line":132,"in_reply_to":"3ac371cc_dca1d595","updated":"2016-08-18 13:31:28.000000000","message":"Filters are only applied per property, not per object, so we should synthesize the field however we want.","commit_id":"c2ebb34333ecd201e77bb69b1d1c0a4a43eed75b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c5ad86f028eb7d5ad95f52139b7797963f0d027e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"          {label: gettext(\u0027Deleted\u0027), key: \u0027deleted\u0027}"},{"line_number":197,"context_line":"        ]"},{"line_number":198,"context_line":"      })"},{"line_number":199,"context_line":"      .append({"},{"line_number":200,"context_line":"        label: gettext(\u0027Is Public\u0027),"},{"line_number":201,"context_line":"        name: \u0027is_public\u0027,"},{"line_number":202,"context_line":"        isServer: true,"}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_bc0e99e2","line":199,"updated":"2016-08-17 21:35:58.000000000","message":"I guess this is okay and be updated with the glance v2 patch.  But really, we need to first get the glance version and then if v1 do this and if v2 use the visibility field.\n\nOr we could just add synthetic visibility in the get images call that always populates visibility using logic similar to this:\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/filters/image-visibility.filter.js","commit_id":"c2ebb34333ecd201e77bb69b1d1c0a4a43eed75b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f602a29c67ef68de2d10f9c7cd0d7c27f173e22f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"          {label: gettext(\u0027Deleted\u0027), key: \u0027deleted\u0027}"},{"line_number":197,"context_line":"        ]"},{"line_number":198,"context_line":"      })"},{"line_number":199,"context_line":"      .append({"},{"line_number":200,"context_line":"        label: gettext(\u0027Is Public\u0027),"},{"line_number":201,"context_line":"        name: \u0027is_public\u0027,"},{"line_number":202,"context_line":"        isServer: true,"}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_11bde7d7","line":199,"in_reply_to":"3ac371cc_3f58db55","updated":"2016-08-18 13:31:28.000000000","message":"Since we process the incoming data (see getImagesPromise in images.service.js), we can synthesize any field we want.  I suggest we synthesize the a field and add a facet.","commit_id":"c2ebb34333ecd201e77bb69b1d1c0a4a43eed75b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c28866daa4bfab17ff6c346214bd6c21208ec904","unresolved":false,"context_lines":[{"line_number":196,"context_line":"          {label: gettext(\u0027Deleted\u0027), key: \u0027deleted\u0027}"},{"line_number":197,"context_line":"        ]"},{"line_number":198,"context_line":"      })"},{"line_number":199,"context_line":"      .append({"},{"line_number":200,"context_line":"        label: gettext(\u0027Is Public\u0027),"},{"line_number":201,"context_line":"        name: \u0027is_public\u0027,"},{"line_number":202,"context_line":"        isServer: true,"}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_dfcc278b","line":199,"in_reply_to":"3ac371cc_bc0e99e2","updated":"2016-08-17 21:49:26.000000000","message":"The synthetic thing would only work for client side searches... since this is server side search, I don\u0027t think that\u0027d work in this case.  The current UI supports Public, Project, Shared with me.  It is a tragedy how this works in v1. And v2 it works a certain way until Newton and changes with community image sharing... \n\n[0] http://specs.openstack.org/openstack/glance-specs/specs/newton/approved/glance/community_visibility.html \n\nBecause of the disaster that v2 didn\u0027t just make visibility work properly from day 1, I think that should be a separate patch for v2 / v2 + community support.","commit_id":"c2ebb34333ecd201e77bb69b1d1c0a4a43eed75b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"3cd0de30652af51e782ba444a589b75d7f37581f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"          {label: gettext(\u0027Deleted\u0027), key: \u0027deleted\u0027}"},{"line_number":197,"context_line":"        ]"},{"line_number":198,"context_line":"      })"},{"line_number":199,"context_line":"      .append({"},{"line_number":200,"context_line":"        label: gettext(\u0027Is Public\u0027),"},{"line_number":201,"context_line":"        name: \u0027is_public\u0027,"},{"line_number":202,"context_line":"        isServer: true,"}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_3f58db55","line":199,"in_reply_to":"3ac371cc_dfcc278b","updated":"2016-08-17 21:56:32.000000000","message":"Okay, I\u0027ve thought about it even more...  \n\nThe following may be as good as the current django features  Add visibility as a synthetic field on the data using the visibility filter above\n\n Then either make the facet be client side (not server side) with these options.\n Or\n Keep it as a search facet for server side public or not and add it as a table column so that it can at least be sorted on.","commit_id":"c2ebb34333ecd201e77bb69b1d1c0a4a43eed75b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2bf4a25e305da4e210f82ca6cfd2b9e7fb3cd335","unresolved":false,"context_lines":[{"line_number":226,"context_line":"          {label: gettext(\u0027Unknown\u0027), key: \u0027unknown\u0027}"},{"line_number":227,"context_line":"        ]"},{"line_number":228,"context_line":"      })"},{"line_number":229,"context_line":"      .append({"},{"line_number":230,"context_line":"        label: gettext(\u0027Is Public\u0027),"},{"line_number":231,"context_line":"        name: \u0027is_public\u0027,"},{"line_number":232,"context_line":"        isServer: false,"},{"line_number":233,"context_line":"        singleton: true,"},{"line_number":234,"context_line":"        options: ["},{"line_number":235,"context_line":"          {label: gettext(\u0027Yes\u0027), key: \u0027true\u0027}, // this must be a string"},{"line_number":236,"context_line":"          {label: gettext(\u0027No\u0027), key: false}"},{"line_number":237,"context_line":"        ]"},{"line_number":238,"context_line":"      })"},{"line_number":239,"context_line":"      .append({"},{"line_number":240,"context_line":"        label: gettext(\u0027Protected\u0027),"}],"source_content_type":"text/javascript","patch_set":4,"id":"1ac06dbe_5511cbab","line":237,"range":{"start_line":229,"start_character":0,"end_line":237,"end_character":9},"updated":"2016-08-19 23:51:19.000000000","message":"Visibility should replace is public","commit_id":"7bb0bd51f8a44e6279624040049bfc2e04eb4424"}],"openstack_dashboard/static/app/core/images/steps/create-volume/create-volume.help.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c5ad86f028eb7d5ad95f52139b7797963f0d027e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003ch3 translate\u003eDescription\u003c/h3\u003e"},{"line_number":3,"context_line":"  \u003cp translate\u003eThis page allows you to create a volume based off of the image.\u003c/p\u003e"},{"line_number":4,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"3ac371cc_fc05b145","line":3,"updated":"2016-08-17 21:35:58.000000000","message":"Cindy had a patch that removed this info because it didn\u0027t add value. How about adding this (or something like it) to make it more useful:\n\nVolumes, unlike images, may hold persistent instance data on the boot device.","commit_id":"c2ebb34333ecd201e77bb69b1d1c0a4a43eed75b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"0833df3572b1afddca2a18355397ffe0323636e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003ch3 translate\u003eDescription\u003c/h3\u003e"},{"line_number":3,"context_line":"  \u003cp translate\u003eThis page allows you to create a volume based off of the image.\u003c/p\u003e"},{"line_number":4,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"3ac371cc_77db8f1b","line":3,"in_reply_to":"3ac371cc_fc05b145","updated":"2016-08-18 03:20:48.000000000","message":"Or just get rid of it again, because this is going to merge:\n\nhttps://review.openstack.org/#/c/351945/","commit_id":"c2ebb34333ecd201e77bb69b1d1c0a4a43eed75b"}]}