)]}'
{"openstack_dashboard/api/base.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"581213850ada3214fc4bb49ce847dd26699c3ef4","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        return self._apidict"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class UsageUnknown(Exception):"},{"line_number":174,"context_line":"    def __init__(self, quota_name, *args, **kwargs):"},{"line_number":175,"context_line":"        super(UsageUnknown, self).__init__(*args, **kwargs)"},{"line_number":176,"context_line":"        self.quota_name \u003d quota_name"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_954a4482","line":173,"updated":"2016-08-26 14:35:04.000000000","message":"the changes in this file - I would like to split out into another patch","commit_id":"865db06b255c3d633abf96cdb6b6da6845644f2e"}],"openstack_dashboard/api/cinder.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"581213850ada3214fc4bb49ce847dd26699c3ef4","unresolved":false,"context_lines":[{"line_number":659,"context_line":"    return cinderclient(request).volumes.unmanage(volume\u003dvolume_id)"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"def tenant_quota_get(request, tenant_id, usage\u003dTrue):"},{"line_number":663,"context_line":"    c_client \u003d cinderclient(request)"},{"line_number":664,"context_line":"    if c_client is None:"},{"line_number":665,"context_line":"        return base.QuotaSet()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_9531640e","line":662,"updated":"2016-08-26 14:35:04.000000000","message":"keep this change, but the default value for Usage should be False - to match the existing behavior.","commit_id":"865db06b255c3d633abf96cdb6b6da6845644f2e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"bb9802c589cf1580c5ce385c0dc809a7b84970c3","unresolved":false,"context_lines":[{"line_number":659,"context_line":"    return cinderclient(request).volumes.unmanage(volume\u003dvolume_id)"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"def tenant_quota_get(request, tenant_id, usage\u003dTrue):"},{"line_number":663,"context_line":"    c_client \u003d cinderclient(request)"},{"line_number":664,"context_line":"    if c_client is None:"},{"line_number":665,"context_line":"        return base.QuotaSet()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_12b99115","line":662,"in_reply_to":"fa7ab95a_9531640e","updated":"2016-09-01 19:57:48.000000000","message":"Done","commit_id":"865db06b255c3d633abf96cdb6b6da6845644f2e"}],"openstack_dashboard/api/nova.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"581213850ada3214fc4bb49ce847dd26699c3ef4","unresolved":false,"context_lines":[{"line_number":806,"context_line":"    novaclient(request).servers.delete_meta(instance_id, keys)"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"def tenant_quota_get(request, tenant_id, usage\u003dTrue):"},{"line_number":810,"context_line":"    return base.QuotaSet(novaclient(request).quotas.get("},{"line_number":811,"context_line":"        tenant_id, detail\u003dusage))"},{"line_number":812,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_95188486","line":809,"updated":"2016-08-26 14:35:04.000000000","message":"keep this, but the default value should be False, to not change the behavior for existing callers.   (the nova default is false)","commit_id":"865db06b255c3d633abf96cdb6b6da6845644f2e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"bb9802c589cf1580c5ce385c0dc809a7b84970c3","unresolved":false,"context_lines":[{"line_number":806,"context_line":"    novaclient(request).servers.delete_meta(instance_id, keys)"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"def tenant_quota_get(request, tenant_id, usage\u003dTrue):"},{"line_number":810,"context_line":"    return base.QuotaSet(novaclient(request).quotas.get("},{"line_number":811,"context_line":"        tenant_id, detail\u003dusage))"},{"line_number":812,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_52bcf9ba","line":809,"in_reply_to":"fa7ab95a_0f959131","updated":"2016-09-01 19:57:48.000000000","message":"Yes, the necessity of being an admin to do that is rather unfortunate :(. Will talk to nova guys to see if something can be done here.","commit_id":"865db06b255c3d633abf96cdb6b6da6845644f2e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"bb9802c589cf1580c5ce385c0dc809a7b84970c3","unresolved":false,"context_lines":[{"line_number":806,"context_line":"    novaclient(request).servers.delete_meta(instance_id, keys)"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"def tenant_quota_get(request, tenant_id, usage\u003dTrue):"},{"line_number":810,"context_line":"    return base.QuotaSet(novaclient(request).quotas.get("},{"line_number":811,"context_line":"        tenant_id, detail\u003dusage))"},{"line_number":812,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_92b201e4","line":809,"in_reply_to":"fa7ab95a_95188486","updated":"2016-09-01 19:57:48.000000000","message":"Done","commit_id":"865db06b255c3d633abf96cdb6b6da6845644f2e"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"4a77e3cbab354c34b6250a7082afc412d6d6c39a","unresolved":false,"context_lines":[{"line_number":806,"context_line":"    novaclient(request).servers.delete_meta(instance_id, keys)"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"def tenant_quota_get(request, tenant_id, usage\u003dTrue):"},{"line_number":810,"context_line":"    return base.QuotaSet(novaclient(request).quotas.get("},{"line_number":811,"context_line":"        tenant_id, detail\u003dusage))"},{"line_number":812,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_0f959131","line":809,"in_reply_to":"fa7ab95a_95188486","updated":"2016-08-30 15:05:45.000000000","message":"also of note - asking for usage requires admin type privileges.","commit_id":"865db06b255c3d633abf96cdb6b6da6845644f2e"}],"openstack_dashboard/dashboards/project/networks/tables.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"581213850ada3214fc4bb49ce847dd26699c3ef4","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # when Settings.OPENSTACK_NEUTRON_NETWORK[\u0027enable_quotas\u0027] \u003d False"},{"line_number":96,"context_line":"        # usages[\"networks\"] is empty"},{"line_number":97,"context_line":"        if usages.get(\u0027networks\u0027).available \u003c\u003d 0:"},{"line_number":98,"context_line":"            if \"disabled\" not in self.classes:"},{"line_number":99,"context_line":"                self.classes \u003d [c for c in self.classes] + [\"disabled\"]"},{"line_number":100,"context_line":"                self.verbose_name \u003d _(\"Create Network (Quota exceeded)\")"},{"line_number":101,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_c009682e","line":98,"updated":"2016-08-26 14:35:04.000000000","message":"the changes in this file are safe to keep too","commit_id":"865db06b255c3d633abf96cdb6b6da6845644f2e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"bb9802c589cf1580c5ce385c0dc809a7b84970c3","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # when Settings.OPENSTACK_NEUTRON_NETWORK[\u0027enable_quotas\u0027] \u003d False"},{"line_number":96,"context_line":"        # usages[\"networks\"] is empty"},{"line_number":97,"context_line":"        if usages.get(\u0027networks\u0027).available \u003c\u003d 0:"},{"line_number":98,"context_line":"            if \"disabled\" not in self.classes:"},{"line_number":99,"context_line":"                self.classes \u003d [c for c in self.classes] + [\"disabled\"]"},{"line_number":100,"context_line":"                self.verbose_name \u003d _(\"Create Network (Quota exceeded)\")"},{"line_number":101,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f2d8ad20","line":98,"in_reply_to":"fa7ab95a_c009682e","updated":"2016-09-01 19:57:48.000000000","message":"actually, to work they require changes in usage/base.py to be present","commit_id":"865db06b255c3d633abf96cdb6b6da6845644f2e"}],"openstack_dashboard/usage/quotas.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"581213850ada3214fc4bb49ce847dd26699c3ef4","unresolved":false,"context_lines":[{"line_number":400,"context_line":"    # Get our usages."},{"line_number":401,"context_line":"    _get_tenant_compute_usages(request, usages, disabled_quotas, tenant_id)"},{"line_number":402,"context_line":"    _get_tenant_network_usages(request, usages, disabled_quotas, tenant_id)"},{"line_number":403,"context_line":"    _get_tenant_volume_usages(request, usages, disabled_quotas, tenant_id)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    return usages"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_e0b90ceb","side":"PARENT","line":403,"updated":"2016-08-26 14:35:04.000000000","message":"why is the cinder stuff here removed?   and network stuff is not?   I think this part of the change should be split out and is likely broken","commit_id":"450baeed4fe74736d0f0825256f758fc4ab099c6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"bb9802c589cf1580c5ce385c0dc809a7b84970c3","unresolved":false,"context_lines":[{"line_number":400,"context_line":"    # Get our usages."},{"line_number":401,"context_line":"    _get_tenant_compute_usages(request, usages, disabled_quotas, tenant_id)"},{"line_number":402,"context_line":"    _get_tenant_network_usages(request, usages, disabled_quotas, tenant_id)"},{"line_number":403,"context_line":"    _get_tenant_volume_usages(request, usages, disabled_quotas, tenant_id)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    return usages"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_121b51cb","side":"PARENT","line":403,"in_reply_to":"fa7ab95a_e0b90ceb","updated":"2016-09-01 19:57:48.000000000","message":"The reason is that we have special calls to get nova and cinder quotas - and they were used earlier within `get_tenant_quota_data`, but no such calls for neutron.\n\nBut now that you mentioned that one has to be an admin to request usage data from nova, maybe I need to reconsider it...","commit_id":"450baeed4fe74736d0f0825256f758fc4ab099c6"}]}
