)]}'
{"openstack_dashboard/contrib/developer/dashboard.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9897215a39da21ecceceb76998386e2adcfed523","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    default_panel \u003d \"theme_preview\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"if getattr(settings, \u0027DEBUG\u0027, False):"},{"line_number":28,"context_line":"    horizon.register(Developer)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_1f8655b9","line":27,"range":{"start_line":27,"start_character":3,"end_line":27,"end_character":36},"updated":"2016-09-20 09:19:01.000000000","message":"I recall there was an intent to be less \u0027defensive\u0027 when accessing settings variables which exist for sure, like settings.DEBUG. Is that approach no longer pursued?","commit_id":"b261c6a04920ae74f6deaa5b13279e7f742d3ca7"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"dc0e3b560df1c803c4231b2cb8be3ef433c19889","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    default_panel \u003d \"theme_preview\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"if getattr(settings, \u0027DEBUG\u0027, False):"},{"line_number":28,"context_line":"    horizon.register(Developer)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_0ace1183","line":27,"range":{"start_line":27,"start_character":3,"end_line":27,"end_character":36},"in_reply_to":"7a8ec9b2_1f8655b9","updated":"2016-09-20 09:22:03.000000000","message":"AFAIK, we have not made a decision on this, so I just used the same logic as before","commit_id":"b261c6a04920ae74f6deaa5b13279e7f742d3ca7"}],"openstack_dashboard/contrib/developer/enabled/_9001_developer.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9897215a39da21ecceceb76998386e2adcfed523","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a8ec9b2_ffda89e8","side":"PARENT","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":1},"updated":"2016-09-20 09:19:01.000000000","message":"Will the top-level sass still be included after this change?","commit_id":"aaa3ad4a13ffcee49e40b619a19a3a73ca5ce467"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"148e9d8c53508d0680ea23909ac085a544c27574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a8ec9b2_56a2714c","side":"PARENT","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":1},"in_reply_to":"7a8ec9b2_052522c1","updated":"2016-09-20 14:00:57.000000000","message":"Hmm, what SCSS are you using? I would rather remove the import until it is actually used, otherwise its just an empty statement. If you require it for your patch, you can simply add it back in. I haven\u0027t reviewed that yet, though.","commit_id":"aaa3ad4a13ffcee49e40b619a19a3a73ca5ce467"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"a1b13a791adf97ab2a14e24dcfa801aaad1cc13d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a8ec9b2_052522c1","side":"PARENT","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":1},"in_reply_to":"7a8ec9b2_0a72917c","updated":"2016-09-20 09:45:26.000000000","message":"Do I understand correct that dashboard sass is always imported? Because \"it\u0027s not needed\" \u003d \"we don\u0027t actually use css rules defined in theme-preview sass, thus we don\u0027t need the umbrella sass as well\" won\u0027t work for Profiler panel which also adds its sass into developer sass.","commit_id":"aaa3ad4a13ffcee49e40b619a19a3a73ca5ce467"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"dc0e3b560df1c803c4231b2cb8be3ef433c19889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a8ec9b2_0a72917c","side":"PARENT","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":1},"in_reply_to":"7a8ec9b2_ffda89e8","updated":"2016-09-20 09:22:03.000000000","message":"It is not needed :)","commit_id":"aaa3ad4a13ffcee49e40b619a19a3a73ca5ce467"}],"openstack_dashboard/test/settings.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9897215a39da21ecceceb76998386e2adcfed523","unresolved":false,"context_lines":[{"line_number":105,"context_line":")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Load the pluggable dashboard settings"},{"line_number":108,"context_line":"import openstack_dashboard.contrib.developer.enabled"},{"line_number":109,"context_line":"import openstack_dashboard.enabled"},{"line_number":110,"context_line":"import openstack_dashboard.local.enabled"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_8a25c1af","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":52},"updated":"2016-09-20 09:19:01.000000000","message":"Not sure I fully get the point here: why include contrib.enabled in openstack_dashboard.test.settings and not include them in openstack_dashboard.settings?","commit_id":"b261c6a04920ae74f6deaa5b13279e7f742d3ca7"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"a1b13a791adf97ab2a14e24dcfa801aaad1cc13d","unresolved":false,"context_lines":[{"line_number":105,"context_line":")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Load the pluggable dashboard settings"},{"line_number":108,"context_line":"import openstack_dashboard.contrib.developer.enabled"},{"line_number":109,"context_line":"import openstack_dashboard.enabled"},{"line_number":110,"context_line":"import openstack_dashboard.local.enabled"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_575281de","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":52},"in_reply_to":"7a8ec9b2_0a20d148","updated":"2016-09-20 09:45:26.000000000","message":"That\u0027s true. Yet the general question about developer panels removed by default still persists.","commit_id":"b261c6a04920ae74f6deaa5b13279e7f742d3ca7"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"148e9d8c53508d0680ea23909ac085a544c27574","unresolved":false,"context_lines":[{"line_number":105,"context_line":")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Load the pluggable dashboard settings"},{"line_number":108,"context_line":"import openstack_dashboard.contrib.developer.enabled"},{"line_number":109,"context_line":"import openstack_dashboard.enabled"},{"line_number":110,"context_line":"import openstack_dashboard.local.enabled"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_9659595e","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":52},"in_reply_to":"7a8ec9b2_575281de","updated":"2016-09-20 14:00:57.000000000","message":"So, if you run your dashboard now you get a warning for every single panel, which is just noise. It seems more sensible to carry them in contrib.","commit_id":"b261c6a04920ae74f6deaa5b13279e7f742d3ca7"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"dc0e3b560df1c803c4231b2cb8be3ef433c19889","unresolved":false,"context_lines":[{"line_number":105,"context_line":")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Load the pluggable dashboard settings"},{"line_number":108,"context_line":"import openstack_dashboard.contrib.developer.enabled"},{"line_number":109,"context_line":"import openstack_dashboard.enabled"},{"line_number":110,"context_line":"import openstack_dashboard.local.enabled"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_0a20d148","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":52},"in_reply_to":"7a8ec9b2_8a25c1af","updated":"2016-09-20 09:22:03.000000000","message":"Because this way they can still be tested :)","commit_id":"b261c6a04920ae74f6deaa5b13279e7f742d3ca7"}]}
