)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d59c0b3cb68089d3ada53d83319be8f294b03fa0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add test for host aggregate create fail due to duplicated name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. extend \"_test_generic_create_aggregate\" method to accept existed_aggregates array argument as mock data"},{"line_number":10,"context_line":"2. add \"test_create_aggregate_fails_duplicated_name\" to test if the error message is shown when name conflict happens"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I638a79defa6bc97a72feac26a314ae584d88bd10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_0a30ed55","line":10,"updated":"2016-08-26 07:40:32.000000000","message":"Please split the lines to make them fit into 72 characters restriction: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"2380ee820b365005acd80c4cc5a66555b788c8fc"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d59c0b3cb68089d3ada53d83319be8f294b03fa0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1. extend \"_test_generic_create_aggregate\" method to accept existed_aggregates array argument as mock data"},{"line_number":10,"context_line":"2. add \"test_create_aggregate_fails_duplicated_name\" to test if the error message is shown when name conflict happens"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I638a79defa6bc97a72feac26a314ae584d88bd10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_ea1109b1","line":12,"updated":"2016-08-26 07:40:32.000000000","message":"It\u0027s good practice to file a corresponding bug and add a bug link to commit message.","commit_id":"2380ee820b365005acd80c4cc5a66555b788c8fc"}],"openstack_dashboard/dashboards/admin/aggregates/tests.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d59c0b3cb68089d3ada53d83319be8f294b03fa0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            .escape(u\u0027The name \"%s\" is already used by another host aggregate.\u0027"},{"line_number":185,"context_line":"                    % aggregate.name)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self._test_generic_create_aggregate(workflow_data, aggregate,"},{"line_number":188,"context_line":"                                            existed_aggregates, 1,"},{"line_number":189,"context_line":"                                            expected_error_message)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_0abb8dc5","line":187,"updated":"2016-08-26 07:40:32.000000000","message":"Since \"_test_generic_create_aggregate\" is used here, it\u0027s logical to place this test right after the similar ones, \"test_create_aggregate\" and \"test_create_aggregate_fails_missing_fields\".","commit_id":"2380ee820b365005acd80c4cc5a66555b788c8fc"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f4bf817034bdc84afe2ec887a654a22fc5901b48","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @test.create_stubs({api.nova: (\u0027host_list\u0027, \u0027aggregate_details_list\u0027,"},{"line_number":80,"context_line":"                                   \u0027aggregate_create\u0027), })"},{"line_number":81,"context_line":"    def _test_generic_create_aggregate(self, workflow_data, aggregate,"},{"line_number":82,"context_line":"                                       existed_aggregates\u003d(),"},{"line_number":83,"context_line":"                                       error_count\u003d0,"},{"line_number":84,"context_line":"                                       expected_error_message\u003dNone):"},{"line_number":85,"context_line":"        api.nova.host_list(IsA(http.HttpRequest)).AndReturn(self.hosts.list())"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_5b470dbb","line":82,"range":{"start_line":82,"start_character":39,"end_line":82,"end_character":46},"updated":"2016-08-26 14:45:46.000000000","message":"Maybe change this to \"existing_aggregates\"?","commit_id":"a8dcd68a61d17e5cabea94b2bb9c3326022f0fe8"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f4bf817034bdc84afe2ec887a654a22fc5901b48","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                                       expected_error_message\u003dNone):"},{"line_number":85,"context_line":"        api.nova.host_list(IsA(http.HttpRequest)).AndReturn(self.hosts.list())"},{"line_number":86,"context_line":"        api.nova.aggregate_details_list(IsA(http.HttpRequest)) \\"},{"line_number":87,"context_line":"            .AndReturn(existed_aggregates)"},{"line_number":88,"context_line":"        if not expected_error_message:"},{"line_number":89,"context_line":"            api.nova.aggregate_create("},{"line_number":90,"context_line":"                IsA(http.HttpRequest),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_db115dae","line":87,"range":{"start_line":87,"start_character":23,"end_line":87,"end_character":30},"updated":"2016-08-26 14:45:46.000000000","message":"ditto","commit_id":"a8dcd68a61d17e5cabea94b2bb9c3326022f0fe8"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f4bf817034bdc84afe2ec887a654a22fc5901b48","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_create_aggregate_fails_duplicated_name(self):"},{"line_number":121,"context_line":"        aggregate \u003d self.aggregates.first()"},{"line_number":122,"context_line":"        existed_aggregates \u003d self.aggregates.list()"},{"line_number":123,"context_line":"        workflow_data \u003d self._get_create_workflow_data(aggregate)"},{"line_number":124,"context_line":"        expected_error_message \u003d html \\"},{"line_number":125,"context_line":"            .escape(u\u0027The name \"%s\" is already used by another host aggregate.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_7b7931fc","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":26},"updated":"2016-08-26 14:45:46.000000000","message":"ditto","commit_id":"a8dcd68a61d17e5cabea94b2bb9c3326022f0fe8"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f4bf817034bdc84afe2ec887a654a22fc5901b48","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                    % aggregate.name)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        self._test_generic_create_aggregate(workflow_data, aggregate,"},{"line_number":129,"context_line":"                                            existed_aggregates, 1,"},{"line_number":130,"context_line":"                                            expected_error_message)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    @test.create_stubs({api.nova: (\u0027host_list\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_7b605136","line":129,"range":{"start_line":129,"start_character":44,"end_line":129,"end_character":62},"updated":"2016-08-26 14:45:46.000000000","message":"ditto","commit_id":"a8dcd68a61d17e5cabea94b2bb9c3326022f0fe8"}]}
