)]}'
{"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"d963d1908a76b6d455ff6b821ea098c0e03d15f7","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        })"},{"line_number":322,"context_line":"      );"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"      if (model.availabilityZones.length \u003d\u003d\u003d 1) {"},{"line_number":325,"context_line":"        model.newInstanceSpec.availability_zone \u003d model.availabilityZones[0].value;"},{"line_number":326,"context_line":"      } else if (model.availabilityZones.length \u003e 1) {"},{"line_number":327,"context_line":"        // There are 2 or more; allow ability for nova scheduler to pick,"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa6399be_fa06a51a","line":324,"updated":"2016-10-13 21:09:48.000000000","message":"food for thought, rather than having the same value setting twice\n\nif (model.availabilityZones.length \u003e 1) {\n  model.availabilityZones.unshift({ ...\n  });\n}\n \nif (model.availabilityZones.length \u003e 0) {\n  model.newInstanceSpec.availability_zone \u003d model ...\n}","commit_id":"be6bcef45289ce1a934db478e5c9c7705890af18"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"b1c4af20709d1b88b3b3aa5c01333e54609e1c20","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        })"},{"line_number":322,"context_line":"      );"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"      if (model.availabilityZones.length \u003d\u003d\u003d 1) {"},{"line_number":325,"context_line":"        model.newInstanceSpec.availability_zone \u003d model.availabilityZones[0].value;"},{"line_number":326,"context_line":"      } else if (model.availabilityZones.length \u003e 1) {"},{"line_number":327,"context_line":"        // There are 2 or more; allow ability for nova scheduler to pick,"}],"source_content_type":"text/javascript","patch_set":1,"id":"3a71b18c_e243a86a","line":324,"in_reply_to":"3a71b18c_4e6d6d98","updated":"2016-12-08 22:48:45.000000000","message":"Yeah we do not save much in this case, thanks for the clarification.","commit_id":"be6bcef45289ce1a934db478e5c9c7705890af18"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"ba41da5302e5d971c240f00e8b8d89d061747d69","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        })"},{"line_number":322,"context_line":"      );"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"      if (model.availabilityZones.length \u003d\u003d\u003d 1) {"},{"line_number":325,"context_line":"        model.newInstanceSpec.availability_zone \u003d model.availabilityZones[0].value;"},{"line_number":326,"context_line":"      } else if (model.availabilityZones.length \u003e 1) {"},{"line_number":327,"context_line":"        // There are 2 or more; allow ability for nova scheduler to pick,"}],"source_content_type":"text/javascript","patch_set":1,"id":"3a71b18c_4e6d6d98","line":324,"in_reply_to":"3a71b18c_88dbfcec","updated":"2016-12-08 20:40:22.000000000","message":"Your pseudocode isn\u0027t quite right.  If model.availabilityZones.length \u003d\u003d\u003d 0 model.newInstanceSpec.availability_zone should remain unset.  If you wrap the conditionals right I think you \u0027save\u0027 one line of code.\n\nThat\u0027s not really valuable cleanup in my view.  If someone wants to change this to appease this cleanup suggestion, that\u0027s OK with me, but of course make sure the logic actually is sustained.","commit_id":"be6bcef45289ce1a934db478e5c9c7705890af18"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"2684b9750618079320c1b7fd64446dde148efed2","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        })"},{"line_number":322,"context_line":"      );"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"      if (model.availabilityZones.length \u003d\u003d\u003d 1) {"},{"line_number":325,"context_line":"        model.newInstanceSpec.availability_zone \u003d model.availabilityZones[0].value;"},{"line_number":326,"context_line":"      } else if (model.availabilityZones.length \u003e 1) {"},{"line_number":327,"context_line":"        // There are 2 or more; allow ability for nova scheduler to pick,"}],"source_content_type":"text/javascript","patch_set":1,"id":"3a71b18c_88dbfcec","line":324,"in_reply_to":"3a71b18c_c8c89477","updated":"2016-12-08 20:26:11.000000000","message":"Great, then lets do the cleanup. The logic will continue to work if zero is legitimate. If there is a cleaner way to write code, I am going to suggest it.","commit_id":"be6bcef45289ce1a934db478e5c9c7705890af18"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"177792094e77656079429df528e8edd018f341f3","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        })"},{"line_number":322,"context_line":"      );"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"      if (model.availabilityZones.length \u003d\u003d\u003d 1) {"},{"line_number":325,"context_line":"        model.newInstanceSpec.availability_zone \u003d model.availabilityZones[0].value;"},{"line_number":326,"context_line":"      } else if (model.availabilityZones.length \u003e 1) {"},{"line_number":327,"context_line":"        // There are 2 or more; allow ability for nova scheduler to pick,"}],"source_content_type":"text/javascript","patch_set":1,"id":"3a71b18c_c8c89477","line":324,"in_reply_to":"fa6399be_b0a1a9fa","updated":"2016-12-08 20:16:50.000000000","message":"It doesn\u0027t have to be at least one.  Zero is legitimate and often expected.  I\u0027ve tested this pretty thoroughly through the various situations.  If the concern is that this doesn\u0027t work, that\u0027s one thing, but I think that you\u0027re just suggesting \"cleanup\" modifications that may introduce differences.  By introducing differences you are possibly breaking the code.","commit_id":"be6bcef45289ce1a934db478e5c9c7705890af18"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"e33903134078e52c896c4c98cb225afe587020e5","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        })"},{"line_number":322,"context_line":"      );"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"      if (model.availabilityZones.length \u003d\u003d\u003d 1) {"},{"line_number":325,"context_line":"        model.newInstanceSpec.availability_zone \u003d model.availabilityZones[0].value;"},{"line_number":326,"context_line":"      } else if (model.availabilityZones.length \u003e 1) {"},{"line_number":327,"context_line":"        // There are 2 or more; allow ability for nova scheduler to pick,"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa6399be_b0a1a9fa","line":324,"in_reply_to":"fa6399be_fa06a51a","updated":"2016-10-13 23:47:00.000000000","message":"Assuming that availability zones has to be at least one, we can improve even more.\n\n  if (model.availabilityZones.length \u003e 1) { //unshift }\n  model.newInstanceSpec.availability_zone \u003d model.availabilityZones[0].value;","commit_id":"be6bcef45289ce1a934db478e5c9c7705890af18"}]}