)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3f1831759213ccea0cf24a7fc24fd8e07009c8f9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes the Cross-Site Request Forgery (CSRF) attack against"},{"line_number":10,"context_line":"the keypair generation pages:"},{"line_number":11,"context_line":"- HORIZON_URL/project/access_and_security/keypairs/PAIRNAME/generate/"},{"line_number":12,"context_line":"- HORIZON_URL/project/access_and_security/keypairs/PAIRNAME/download/"},{"line_number":13,"context_line":"These pages exposed creating and/or overwriting a keypair with a given"},{"line_number":14,"context_line":"name via a CSRF attack."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f044301_8b8e7925","line":11,"range":{"start_line":11,"start_character":22,"end_line":11,"end_character":50},"updated":"2017-05-03 22:51:39.000000000","message":"nit: The path is now different","commit_id":"f25956f71e08271cbed9857f04c4fabb741ceb4c"},{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"8b2189ce4f575328d4b9ac583fcee2ec253a5c13","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes the Cross-Site Request Forgery (CSRF) attack against"},{"line_number":10,"context_line":"the keypair generation pages:"},{"line_number":11,"context_line":"- HORIZON_URL/project/access_and_security/keypairs/PAIRNAME/generate/"},{"line_number":12,"context_line":"- HORIZON_URL/project/access_and_security/keypairs/PAIRNAME/download/"},{"line_number":13,"context_line":"These pages exposed creating and/or overwriting a keypair with a given"},{"line_number":14,"context_line":"name via a CSRF attack."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f044301_2ecb8c1e","line":11,"range":{"start_line":11,"start_character":22,"end_line":11,"end_character":50},"in_reply_to":"3f044301_8b8e7925","updated":"2017-05-08 23:46:14.000000000","message":"Done","commit_id":"f25956f71e08271cbed9857f04c4fabb741ceb4c"}],"openstack_dashboard/dashboards/project/key_pairs/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3f1831759213ccea0cf24a7fc24fd8e07009c8f9","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get_default_attrs(self):"},{"line_number":70,"context_line":"        url \u003d urlresolvers.reverse(self.url)"},{"line_number":71,"context_line":"        ngclick \u003d \"modal.createKeyPair(\" \\"},{"line_number":72,"context_line":"            \"{ successUrl: \u0027%s\u0027 })\" % url"},{"line_number":73,"context_line":"        self.attrs.update({"},{"line_number":74,"context_line":"            \u0027ng-controller\u0027: \u0027KeypairController as modal\u0027,"},{"line_number":75,"context_line":"            \u0027ng-click\u0027: ngclick"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_aba81577","line":72,"range":{"start_line":71,"start_character":18,"end_line":72,"end_character":41},"updated":"2017-05-03 22:51:39.000000000","message":"nit: Why not oneline? This fits into one line and we can avoid a backslash.","commit_id":"f25956f71e08271cbed9857f04c4fabb741ceb4c"},{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"8b2189ce4f575328d4b9ac583fcee2ec253a5c13","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get_default_attrs(self):"},{"line_number":70,"context_line":"        url \u003d urlresolvers.reverse(self.url)"},{"line_number":71,"context_line":"        ngclick \u003d \"modal.createKeyPair(\" \\"},{"line_number":72,"context_line":"            \"{ successUrl: \u0027%s\u0027 })\" % url"},{"line_number":73,"context_line":"        self.attrs.update({"},{"line_number":74,"context_line":"            \u0027ng-controller\u0027: \u0027KeypairController as modal\u0027,"},{"line_number":75,"context_line":"            \u0027ng-click\u0027: ngclick"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_0ed210d3","line":72,"range":{"start_line":71,"start_character":18,"end_line":72,"end_character":41},"in_reply_to":"3f044301_aba81577","updated":"2017-05-08 23:46:14.000000000","message":"Done","commit_id":"f25956f71e08271cbed9857f04c4fabb741ceb4c"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/keypair/create-keypair.html":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"f06c91cac65ecf4d9df75a85413b4b6846cdb01a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u003cspan class\u003d\"hz-icon-required fa\"\u003e\u003c/span\u003e"},{"line_number":36,"context_line":"      \u003c/label\u003e"},{"line_number":37,"context_line":"      \u003ctextarea class\u003d\"form-control\" id\u003d\"private-key\" rows\u003d\"15\""},{"line_number":38,"context_line":"                  ng-model\u003d\"ctrl.privateKey\" readonly\u003e\u003c/textarea\u003e"},{"line_number":39,"context_line":"    \u003c/div\u003e"},{"line_number":40,"context_line":"  \u003c/div\u003e"},{"line_number":41,"context_line":""}],"source_content_type":"text/html","patch_set":15,"id":"bf091321_2592e7f7","line":38,"updated":"2017-06-08 12:27:39.000000000","message":"Using a \u003cpre\u003e instead of a textarea, and dropping the \"form-control\" class, is much more clear visually. I\u0027d also drop an ng-if on the form-group div and just show it once the privateKey has been generated, otherwise there is just a blank mysterious field that cannot be interacted with.","commit_id":"8b20e66f90ec7271c83ed58b8b5231f1389b5259"},{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"ad020edb4a71c371adc9aaf0dcfa7dfc29da8442","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u003cspan class\u003d\"hz-icon-required fa\"\u003e\u003c/span\u003e"},{"line_number":36,"context_line":"      \u003c/label\u003e"},{"line_number":37,"context_line":"      \u003ctextarea class\u003d\"form-control\" id\u003d\"private-key\" rows\u003d\"15\""},{"line_number":38,"context_line":"                  ng-model\u003d\"ctrl.privateKey\" readonly\u003e\u003c/textarea\u003e"},{"line_number":39,"context_line":"    \u003c/div\u003e"},{"line_number":40,"context_line":"  \u003c/div\u003e"},{"line_number":41,"context_line":""}],"source_content_type":"text/html","patch_set":15,"id":"bf091321_7ee62219","line":38,"in_reply_to":"bf091321_2592e7f7","updated":"2017-06-08 18:12:07.000000000","message":"As indicated in the followup patch, using \u003cpre\u003e breaks the ability to copy the key to the clipboard.  Added a code comment to make this clear.\n\nAdded the ng-if as suggested","commit_id":"8b20e66f90ec7271c83ed58b8b5231f1389b5259"}],"openstack_dashboard/static/app/core/keypairs/keypair.controller.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"21995fa6c048124df978c45752da73b7bbfb0a05","unresolved":false,"context_lines":[{"line_number":33,"context_line":"   * @ngdoc controller"},{"line_number":34,"context_line":"   * @name KeypairController"},{"line_number":35,"context_line":"   * @param {string} basePath"},{"line_number":36,"context_line":"   * @param {Object} $uibModal"},{"line_number":37,"context_line":"   * @description"},{"line_number":38,"context_line":"   * Allows creation of key pairs."},{"line_number":39,"context_line":"   * @returns {undefined} No return value"}],"source_content_type":"text/javascript","patch_set":15,"id":"df140735_c79a4612","line":36,"updated":"2017-06-06 03:03:50.000000000","message":"Nit: this function takes 5 parameters but only two parameters are documented. Looks inconsistent.","commit_id":"8b20e66f90ec7271c83ed58b8b5231f1389b5259"},{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"b88da57337ecb87b9ef95f5ba3a88a31fc674d52","unresolved":false,"context_lines":[{"line_number":33,"context_line":"   * @ngdoc controller"},{"line_number":34,"context_line":"   * @name KeypairController"},{"line_number":35,"context_line":"   * @param {string} basePath"},{"line_number":36,"context_line":"   * @param {Object} $uibModal"},{"line_number":37,"context_line":"   * @description"},{"line_number":38,"context_line":"   * Allows creation of key pairs."},{"line_number":39,"context_line":"   * @returns {undefined} No return value"}],"source_content_type":"text/javascript","patch_set":15,"id":"bf091321_1ec60669","line":36,"in_reply_to":"df140735_c79a4612","updated":"2017-06-08 18:13:47.000000000","message":"Done","commit_id":"8b20e66f90ec7271c83ed58b8b5231f1389b5259"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"21995fa6c048124df978c45752da73b7bbfb0a05","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        $uibModal.open({"},{"line_number":59,"context_line":"          templateUrl: basePath + \u0027keypair/create-keypair.html\u0027,"},{"line_number":60,"context_line":"          controller: \u0027LaunchInstanceCreateKeyPairController as ctrl\u0027,"},{"line_number":61,"context_line":"          windowClass: \u0027modal-dialog-wizard\u0027,"},{"line_number":62,"context_line":"          resolve: {"},{"line_number":63,"context_line":"            existingKeypairs: getKeypairs"}],"source_content_type":"text/javascript","patch_set":15,"id":"df140735_22e57038","line":60,"updated":"2017-06-06 03:03:50.000000000","message":"Ideally keypair stuff in launch Instance are placed here and the launch-instance logic calls here. From the code structure perspective, having many logic under the launch instance looks tricky.\n\nNote that I do not think you need to address this in this patch. We can relocate them later.","commit_id":"8b20e66f90ec7271c83ed58b8b5231f1389b5259"}]}
