)]}'
{"openstack_dashboard/dashboards/admin/metadata_defs/tabs.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4cc082b48dd33c08bafa276aaa319c8486fb211e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"class NamespaceDetailTabs(tabs.TabGroup):"},{"line_number":67,"context_line":"    slug \u003d \"namespace_details\""},{"line_number":68,"context_line":"    tabs \u003d (OverviewTab, ContentsTab)"},{"line_number":69,"context_line":"    template_name \u003d \"horizon/common/_detail_tab_group.html\""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a3c09a3_4dc57959","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":59},"updated":"2017-01-16 09:57:51.000000000","message":"Rather than changing template for every single details page, just make a subclass of the tabs.TabGroup with this template defined. Something like DetailTabsGroup; that makes the intention much more clear, and doesnt require adding an extra line everywhere","commit_id":"6b5e926fa211576809b7b26a09ed00f2d3d3b712"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"c3b223ae5f54387e657bf38fc9664bcdfe734189","unresolved":false,"context_lines":[{"line_number":66,"context_line":"class NamespaceDetailTabs(tabs.TabGroup):"},{"line_number":67,"context_line":"    slug \u003d \"namespace_details\""},{"line_number":68,"context_line":"    tabs \u003d (OverviewTab, ContentsTab)"},{"line_number":69,"context_line":"    template_name \u003d \"horizon/common/_detail_tab_group.html\""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a3c09a3_c39ef4b7","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":59},"in_reply_to":"7a3c09a3_4dc57959","updated":"2017-01-18 19:42:55.000000000","message":"Done","commit_id":"6b5e926fa211576809b7b26a09ed00f2d3d3b712"}],"openstack_dashboard/dashboards/project/instances/tabs.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4e2f17774b1f7e2c004ce218eacd07ecfd40db93","unresolved":false,"context_lines":[{"line_number":111,"context_line":"class InstanceDetailTabs(tabs.TabGroup):"},{"line_number":112,"context_line":"    slug \u003d \"instance_details\""},{"line_number":113,"context_line":"    tabs \u003d (OverviewTab, LogTab, ConsoleTab, AuditTab)"},{"line_number":114,"context_line":"    classes \u003d [\"detail-tabs\"]"},{"line_number":115,"context_line":"    sticky \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_7474d89b","line":114,"updated":"2016-11-08 09:18:49.000000000","message":"What I meant here was that we should add the class to *all detail tabs* (so just add it to the detail template) but not to *all tabs*. Sorry for not being more clear.","commit_id":"edfc91f9ced907dd075721f091cac592f83c0c63"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"ea6f05cabce16b3463e1fbeb71d317fde2e2f0d9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"class InstanceDetailTabs(tabs.TabGroup):"},{"line_number":112,"context_line":"    slug \u003d \"instance_details\""},{"line_number":113,"context_line":"    tabs \u003d (OverviewTab, LogTab, ConsoleTab, AuditTab)"},{"line_number":114,"context_line":"    classes \u003d [\"detail-tabs\"]"},{"line_number":115,"context_line":"    sticky \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_949b1072","line":114,"in_reply_to":"9a629dbe_7474d89b","updated":"2016-11-08 17:36:05.000000000","message":"Np. I have added a patch. Thanks.","commit_id":"edfc91f9ced907dd075721f091cac592f83c0c63"}],"openstack_dashboard/static/dashboard/scss/_util.scss":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"52c611f2ac6da09cc5b9bd44d22bbf554e393ded","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ul {"},{"line_number":69,"context_line":"  list-style: none;"},{"line_number":70,"context_line":"  padding: 0;"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-scss","patch_set":3,"id":"9a629dbe_dc3162ee","line":71,"updated":"2016-11-07 18:47:01.000000000","message":"What I meant was, rather than reuse the rules (this will make ALL \u003cul\u003e elements unstyled) we should just make the necessary elements into \u003cul class\u003d\"list-unstyled\"\u003e which is already part of bootstrap.","commit_id":"1bf8a71a0c1afb7ef8f84f6ae8daf5f26f681ace"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"dc7de7443632ac4b718f9eb5d4fef20cd30c9901","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ul {"},{"line_number":69,"context_line":"  list-style: none;"},{"line_number":70,"context_line":"  padding: 0;"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-scss","patch_set":3,"id":"9a629dbe_48182785","line":71,"in_reply_to":"9a629dbe_dc3162ee","updated":"2016-11-08 00:28:34.000000000","message":"Done","commit_id":"1bf8a71a0c1afb7ef8f84f6ae8daf5f26f681ace"}],"openstack_dashboard/static/dashboard/scss/components/_nav.scss":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"52c611f2ac6da09cc5b9bd44d22bbf554e393ded","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \u0026.nav-tabs {"},{"line_number":3,"context_line":"        margin-bottom: $padding-base-horizontal;"},{"line_number":4,"context_line":"    }"},{"line_number":5,"context_line":"}"}],"source_content_type":"text/x-scss","patch_set":3,"id":"9a629dbe_1cd59a42","line":5,"updated":"2016-11-07 18:47:01.000000000","message":"I don\u0027t think we should have a sweeping change like this. Rather, it should just be specific to the area we are trying to address. Otherwise it\u0027ll likely cause double padding on some areas like forms.","commit_id":"1bf8a71a0c1afb7ef8f84f6ae8daf5f26f681ace"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"dc7de7443632ac4b718f9eb5d4fef20cd30c9901","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \u0026.nav-tabs {"},{"line_number":3,"context_line":"        margin-bottom: $padding-base-horizontal;"},{"line_number":4,"context_line":"    }"},{"line_number":5,"context_line":"}"}],"source_content_type":"text/x-scss","patch_set":3,"id":"9a629dbe_88123f61","line":5,"in_reply_to":"9a629dbe_1cd59a42","updated":"2016-11-08 00:28:34.000000000","message":"Done","commit_id":"1bf8a71a0c1afb7ef8f84f6ae8daf5f26f681ace"}],"openstack_dashboard/static/dashboard/scss/components/_tab.scss":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4cc082b48dd33c08bafa276aaa319c8486fb211e","unresolved":false,"context_lines":[{"line_number":1,"context_line":".tab-content {"},{"line_number":2,"context_line":"  .detail-tabs {"},{"line_number":3,"context_line":"    margin-top: $padding-base-horizontal;"},{"line_number":4,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":12,"id":"7a3c09a3_6dd4f51f","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":14},"updated":"2017-01-16 09:57:51.000000000","message":"no longer needed, just use the .detail-tabs class","commit_id":"6b5e926fa211576809b7b26a09ed00f2d3d3b712"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"c3b223ae5f54387e657bf38fc9664bcdfe734189","unresolved":false,"context_lines":[{"line_number":1,"context_line":".tab-content {"},{"line_number":2,"context_line":"  .detail-tabs {"},{"line_number":3,"context_line":"    margin-top: $padding-base-horizontal;"},{"line_number":4,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":12,"id":"7a3c09a3_43abe4d6","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":14},"in_reply_to":"7a3c09a3_6dd4f51f","updated":"2017-01-18 19:42:55.000000000","message":"Done","commit_id":"6b5e926fa211576809b7b26a09ed00f2d3d3b712"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4cc082b48dd33c08bafa276aaa319c8486fb211e","unresolved":false,"context_lines":[{"line_number":1,"context_line":".tab-content {"},{"line_number":2,"context_line":"  .detail-tabs {"},{"line_number":3,"context_line":"    margin-top: $padding-base-horizontal;"},{"line_number":4,"context_line":"  }"},{"line_number":5,"context_line":"}"}],"source_content_type":"text/x-scss","patch_set":12,"id":"7a3c09a3_addedd3c","line":3,"range":{"start_line":3,"start_character":16,"end_line":3,"end_character":40},"updated":"2017-01-16 09:57:51.000000000","message":"Should be vertical padding?","commit_id":"6b5e926fa211576809b7b26a09ed00f2d3d3b712"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"c3b223ae5f54387e657bf38fc9664bcdfe734189","unresolved":false,"context_lines":[{"line_number":1,"context_line":".tab-content {"},{"line_number":2,"context_line":"  .detail-tabs {"},{"line_number":3,"context_line":"    margin-top: $padding-base-horizontal;"},{"line_number":4,"context_line":"  }"},{"line_number":5,"context_line":"}"}],"source_content_type":"text/x-scss","patch_set":12,"id":"7a3c09a3_63b8e02b","line":3,"range":{"start_line":3,"start_character":16,"end_line":3,"end_character":40},"in_reply_to":"7a3c09a3_addedd3c","updated":"2017-01-18 19:42:55.000000000","message":"Done","commit_id":"6b5e926fa211576809b7b26a09ed00f2d3d3b712"}],"openstack_dashboard/static/dashboard/scss/horizon.scss":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"8b6458702f87588726e1b3e498373b4a4f7b2149","unresolved":false,"context_lines":[{"line_number":31,"context_line":"@import \"components/membership\";"},{"line_number":32,"context_line":"@import \"components/messages\";"},{"line_number":33,"context_line":"@import \"components/modals\";"},{"line_number":34,"context_line":"@import \"components/tab\";"},{"line_number":35,"context_line":"@import \"components/navbar\";"},{"line_number":36,"context_line":"@import \"components/network_topology\";"},{"line_number":37,"context_line":"@import \"components/network_topology_svg\";"}],"source_content_type":"text/x-scss","patch_set":7,"id":"9a629dbe_4344eeb5","line":34,"updated":"2016-11-10 20:54:28.000000000","message":"alphabetical","commit_id":"78193b5214fc35f8bd9166c70b1f00e1c71b806b"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"59474a72f9008fa155d4466b5351339f8b69a3b5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"@import \"components/membership\";"},{"line_number":32,"context_line":"@import \"components/messages\";"},{"line_number":33,"context_line":"@import \"components/modals\";"},{"line_number":34,"context_line":"@import \"components/tab\";"},{"line_number":35,"context_line":"@import \"components/navbar\";"},{"line_number":36,"context_line":"@import \"components/network_topology\";"},{"line_number":37,"context_line":"@import \"components/network_topology_svg\";"}],"source_content_type":"text/x-scss","patch_set":7,"id":"9a629dbe_5e076181","line":34,"in_reply_to":"9a629dbe_4344eeb5","updated":"2016-11-10 21:10:59.000000000","message":"Done","commit_id":"78193b5214fc35f8bd9166c70b1f00e1c71b806b"}]}
