)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f3cebced5f34b1e208266ff8a8154d3b28ac80b7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to https://bugs.launchpad.net/neutron/+bug/1204956,"},{"line_number":10,"context_line":"Neutron provide the API to get default quotas."},{"line_number":11,"context_line":"This patch use this api for more readable code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6965ba88d53e04b16a0d5d21211244d4f4551918"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5ff73747_70b551ee","line":11,"updated":"2017-04-24 01:07:45.000000000","message":"Could you file a bug on this? It helps us track the effort.","commit_id":"392da580c772c68bec6d36c10f9cb243ef86e6c2"}],"openstack_dashboard/usage/quotas.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eedbbcf1b32966db522ab83a8ef6b82e32c99e66","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    # TODO(jpichon): There is no API to get the default system quotas"},{"line_number":188,"context_line":"    # in Neutron (cf. LP#1204956), so for now handle tenant quotas here."},{"line_number":189,"context_line":"    # This should be handled in _get_quota_data() eventually."},{"line_number":190,"context_line":"    if not disabled_quotas:"},{"line_number":191,"context_line":"        return qs"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    # Check if neutron is enabled by looking for network"},{"line_number":194,"context_line":"    if \u0027network\u0027 not in disabled_quotas:"}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_30e6a918","side":"PARENT","line":191,"range":{"start_line":190,"start_character":4,"end_line":191,"end_character":17},"updated":"2017-04-24 01:06:42.000000000","message":"You cannot simply drop this condition.\nThe logic at [1] adds neutron quota data after calling get_tenant_quota_data. I added a comment in my proposed review [2]\n\n[1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/projects/views.py#L247-L253\n[2] https://review.openstack.org/#/c/456415/3/openstack_dashboard/usage/quotas.py L.197-200.","commit_id":"612c2e5e9569331f58e4de6fde2a470b75d5f04e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eedbbcf1b32966db522ab83a8ef6b82e32c99e66","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self.usages[name][\u0027available\u0027] \u003d available"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def _get_quota_data(request, tenant_mode\u003dTrue, disabled_quotas\u003dNone,"},{"line_number":141,"context_line":"                    tenant_id\u003dNone):"},{"line_number":142,"context_line":"    quotasets \u003d []"},{"line_number":143,"context_line":"    if not tenant_id:"}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_502c9546","line":140,"range":{"start_line":140,"start_character":29,"end_line":140,"end_character":45},"updated":"2017-04-24 01:06:42.000000000","message":"Do we still need tenant_mode? We have several \"if tenant_mode\" condition and there seems less value of _get_quota_data().","commit_id":"392da580c772c68bec6d36c10f9cb243ef86e6c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eedbbcf1b32966db522ab83a8ef6b82e32c99e66","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    if tenant_mode:"},{"line_number":173,"context_line":"        _neutron_tenant_quota_get(qs, request, tenant_id, disabled_quotas)"},{"line_number":174,"context_line":"    else:"},{"line_number":175,"context_line":"        if \u0027network\u0027 not in disabled_quotas:"},{"line_number":176,"context_line":"            qs.add(neutron.default_quota_get(request, tenant_id))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    return qs"}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_b004f9c7","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":44},"updated":"2017-04-24 01:06:42.000000000","message":"It is better to check any neutron related quotas are included rather than just checking \u0027network\u0027 in disabled_quotas.\n\n  if set(NEUTRON_QUOTA_FIELDS) - disabled_quotas:","commit_id":"392da580c772c68bec6d36c10f9cb243ef86e6c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eedbbcf1b32966db522ab83a8ef6b82e32c99e66","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        _neutron_tenant_quota_get(qs, request, tenant_id, disabled_quotas)"},{"line_number":174,"context_line":"    else:"},{"line_number":175,"context_line":"        if \u0027network\u0027 not in disabled_quotas:"},{"line_number":176,"context_line":"            qs.add(neutron.default_quota_get(request, tenant_id))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    return qs"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_5013750e","line":176,"range":{"start_line":176,"start_character":12,"end_line":176,"end_character":65},"updated":"2017-04-24 01:06:42.000000000","message":"Consider disabled_quotas as we do in L.167-169.","commit_id":"392da580c772c68bec6d36c10f9cb243ef86e6c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eedbbcf1b32966db522ab83a8ef6b82e32c99e66","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            # Rename floatingip to floating_ips since that\u0027s how it\u0027s"},{"line_number":210,"context_line":"            # expected in some places (e.g. Security \u0026 Access\u0027 Floating IPs)"},{"line_number":211,"context_line":"            fips_quota \u003d neutron_quotas.get(\u0027floatingip\u0027).limit"},{"line_number":212,"context_line":"            qs.add(base.QuotaSet({\u0027floating_ips\u0027: fips_quota}))"},{"line_number":213,"context_line":"    if \u0027security_groups\u0027 in disabled_quotas:"},{"line_number":214,"context_line":"        if \u0027security_group\u0027 in disabled_quotas:"},{"line_number":215,"context_line":"            qs.add(base.QuotaSet({\u0027security_groups\u0027: -1}))"}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_b0bbd9e3","line":212,"updated":"2017-04-24 01:06:42.000000000","message":"If you\u0027d like to add blank lines, a blank line is needed here too.","commit_id":"392da580c772c68bec6d36c10f9cb243ef86e6c2"}]}
