)]}'
{"doc/source/topics/settings.rst":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"df4ecf294585ebf3fd64920d72e7fcf896cd5c94","unresolved":false,"context_lines":[{"line_number":1404,"context_line":"``enable_fip_topology_check``"},{"line_number":1405,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1406,"context_line":""},{"line_number":1407,"context_line":".. versionadded:: 8.0.0(Liberty)"},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"Default: ``True``"},{"line_number":1410,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a74a57a_78d9b921","line":1407,"updated":"2016-11-28 02:41:20.000000000","message":"Unrelated change?","commit_id":"4fa006a482e46edd1e68dd59b18e379b5639fbdf"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"cde686a108dbd9f88ac984f91e31685d86872881","unresolved":false,"context_lines":[{"line_number":1404,"context_line":"``enable_fip_topology_check``"},{"line_number":1405,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1406,"context_line":""},{"line_number":1407,"context_line":".. versionadded:: 8.0.0(Liberty)"},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"Default: ``True``"},{"line_number":1410,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_b801153c","line":1407,"in_reply_to":"5a74a57a_78d9b921","updated":"2016-12-07 23:53:12.000000000","message":"Yes. Unrelated to this feature. I think it\u0027s something should be fixed but probably not worth opening a new bug.","commit_id":"4fa006a482e46edd1e68dd59b18e379b5639fbdf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a143948f6d8c2a2d6b6899abd66d25ff3e8be603","unresolved":false,"context_lines":[{"line_number":1436,"context_line":"``physical_networks``:"},{"line_number":1437,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":".. versionadded:: 11.0.0(Ocata)"},{"line_number":1440,"context_line":""},{"line_number":1441,"context_line":"Default: ``[]``"},{"line_number":1442,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_9e84700b","line":1439,"range":{"start_line":1439,"start_character":18,"end_line":1439,"end_character":31},"updated":"2017-03-05 19:39:37.000000000","message":"This needs to bumped to Pile.","commit_id":"5d6fad1f1ff6a45cd293e1334252621024708305"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"cdc0c0aa070ca6bcd653ef881179ea879ad5c9cd","unresolved":false,"context_lines":[{"line_number":1436,"context_line":"``physical_networks``:"},{"line_number":1437,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":".. versionadded:: 11.0.0(Ocata)"},{"line_number":1440,"context_line":""},{"line_number":1441,"context_line":"Default: ``[]``"},{"line_number":1442,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a30ddce_0b8c06d9","line":1439,"range":{"start_line":1439,"start_character":18,"end_line":1439,"end_character":31},"in_reply_to":"ba2be162_9e84700b","updated":"2017-03-09 21:44:27.000000000","message":"Done","commit_id":"5d6fad1f1ff6a45cd293e1334252621024708305"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a143948f6d8c2a2d6b6899abd66d25ff3e8be603","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"Default to an empty list and the physical network field on the admin create"},{"line_number":1444,"context_line":"network modal will be a regular input field where users can type in the name"},{"line_number":1445,"context_line":"of the physical network to be used."},{"line_number":1446,"context_line":"If it\u0027s set to a list of available physical networks, the physical network"},{"line_number":1447,"context_line":"field will be shown as a dropdown menu where users can select a physical"},{"line_number":1448,"context_line":"network to be used."},{"line_number":1449,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_be7f7413","line":1446,"range":{"start_line":1446,"start_character":3,"end_line":1446,"end_character":7},"updated":"2017-03-05 19:39:37.000000000","message":"According to the openstack-manuals convention, \"it is\" is preferred.","commit_id":"5d6fad1f1ff6a45cd293e1334252621024708305"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"cdc0c0aa070ca6bcd653ef881179ea879ad5c9cd","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"Default to an empty list and the physical network field on the admin create"},{"line_number":1444,"context_line":"network modal will be a regular input field where users can type in the name"},{"line_number":1445,"context_line":"of the physical network to be used."},{"line_number":1446,"context_line":"If it\u0027s set to a list of available physical networks, the physical network"},{"line_number":1447,"context_line":"field will be shown as a dropdown menu where users can select a physical"},{"line_number":1448,"context_line":"network to be used."},{"line_number":1449,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a30ddce_2b89cac9","line":1446,"range":{"start_line":1446,"start_character":3,"end_line":1446,"end_character":7},"in_reply_to":"ba2be162_be7f7413","updated":"2017-03-09 21:44:27.000000000","message":"Done","commit_id":"5d6fad1f1ff6a45cd293e1334252621024708305"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f4416c3db047f63b2e360c79ce051f5b45f2aa64","unresolved":false,"context_lines":[{"line_number":1447,"context_line":"``physical_networks``:"},{"line_number":1448,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1449,"context_line":""},{"line_number":1450,"context_line":".. versionadded:: 12.0.0(Pile)"},{"line_number":1451,"context_line":""},{"line_number":1452,"context_line":"Default: ``[]``"},{"line_number":1453,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a30ddce_e8a7abba","line":1450,"range":{"start_line":1450,"start_character":25,"end_line":1450,"end_character":29},"updated":"2017-03-10 05:53:34.000000000","message":"typo: \"Pike\"\n\nIn the previous comment, I made a typo of the release name :-(","commit_id":"f83b2ca4b8f74e5f65bfbf0143ceaa0f78504443"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"40b99590e455922d6140edbb65b86963082db520","unresolved":false,"context_lines":[{"line_number":1447,"context_line":"``physical_networks``:"},{"line_number":1448,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1449,"context_line":""},{"line_number":1450,"context_line":".. versionadded:: 12.0.0(Pile)"},{"line_number":1451,"context_line":""},{"line_number":1452,"context_line":"Default: ``[]``"},{"line_number":1453,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a30ddce_c8000b69","line":1450,"range":{"start_line":1450,"start_character":25,"end_line":1450,"end_character":29},"in_reply_to":"9a30ddce_e8a7abba","updated":"2017-03-10 16:59:05.000000000","message":"Done","commit_id":"f83b2ca4b8f74e5f65bfbf0143ceaa0f78504443"}],"openstack_dashboard/dashboards/admin/networks/forms.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"df4ecf294585ebf3fd64920d72e7fcf896cd5c94","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            else:"},{"line_number":220,"context_line":"                self.fields[\u0027network_type\u0027].choices \u003d network_type_choices"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        choices \u003d []"},{"line_number":223,"context_line":"        for net in getattr(settings, \u0027OPENSTACK_NEUTRON_NETWORK\u0027, {})\\"},{"line_number":224,"context_line":"                .get(\u0027physical_networks\u0027, []):"},{"line_number":225,"context_line":"            choices.append((net, net))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_a35082d5","line":222,"updated":"2016-11-28 02:41:20.000000000","message":"According to L159, if a extension is disabled, some fields including physical_network would be hidden. In that case, we also need to process L222-L232?\n\nAlso, I\u0027m not sure but an original field \u0027physical_networks\u0027 has some attributes like widget. Don\u0027t we need such attributes?","commit_id":"4fa006a482e46edd1e68dd59b18e379b5639fbdf"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"cde686a108dbd9f88ac984f91e31685d86872881","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            else:"},{"line_number":220,"context_line":"                self.fields[\u0027network_type\u0027].choices \u003d network_type_choices"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        choices \u003d []"},{"line_number":223,"context_line":"        for net in getattr(settings, \u0027OPENSTACK_NEUTRON_NETWORK\u0027, {})\\"},{"line_number":224,"context_line":"                .get(\u0027physical_networks\u0027, []):"},{"line_number":225,"context_line":"            choices.append((net, net))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_58cba11e","line":222,"in_reply_to":"5a74a57a_a35082d5","updated":"2016-12-07 23:53:12.000000000","message":"Good point. This feature is not applicable if the provider extension is not supported. Updated the code. Thanks.\n\nThemableChoiceField has a default widget ThemableSelectWidget.","commit_id":"4fa006a482e46edd1e68dd59b18e379b5639fbdf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a143948f6d8c2a2d6b6899abd66d25ff3e8be603","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            else:"},{"line_number":220,"context_line":"                self.fields[\u0027network_type\u0027].choices \u003d network_type_choices"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"            choices \u003d []"},{"line_number":223,"context_line":"            for net in getattr(settings, \u0027OPENSTACK_NEUTRON_NETWORK\u0027, {})\\"},{"line_number":224,"context_line":"                    .get(\u0027physical_networks\u0027, []):"},{"line_number":225,"context_line":"                choices.append((net, net))"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"            if choices:"},{"line_number":228,"context_line":"                self.fields[\u0027physical_network\u0027] \u003d forms.ThemableChoiceField("},{"line_number":229,"context_line":"                    label\u003d_(\"Physical Network\"),"},{"line_number":230,"context_line":"                    choices\u003dchoices,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba2be162_5e959830","line":227,"range":{"start_line":222,"start_character":12,"end_line":227,"end_character":23},"updated":"2017-03-05 19:39:37.000000000","message":"The original intention is to check whether physical_networks is empty or not. How about the following?\n\n  physnets \u003d getatttr(settings, \u0027OPENSTACK_NEUTRON_NETWORK\u0027, {})\\\n      .get(\u0027physical_networks\u0027, {})\n  if physnets:\n      self.fields[\u0027physical_network\u0027] \u003d forms......\n          ....\n          choices\u003d[(net, net) for net in physnets],\n          ....","commit_id":"5d6fad1f1ff6a45cd293e1334252621024708305"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"cdc0c0aa070ca6bcd653ef881179ea879ad5c9cd","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            else:"},{"line_number":220,"context_line":"                self.fields[\u0027network_type\u0027].choices \u003d network_type_choices"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"            choices \u003d []"},{"line_number":223,"context_line":"            for net in getattr(settings, \u0027OPENSTACK_NEUTRON_NETWORK\u0027, {})\\"},{"line_number":224,"context_line":"                    .get(\u0027physical_networks\u0027, []):"},{"line_number":225,"context_line":"                choices.append((net, net))"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"            if choices:"},{"line_number":228,"context_line":"                self.fields[\u0027physical_network\u0027] \u003d forms.ThemableChoiceField("},{"line_number":229,"context_line":"                    label\u003d_(\"Physical Network\"),"},{"line_number":230,"context_line":"                    choices\u003dchoices,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_6b8f42cc","line":227,"range":{"start_line":222,"start_character":12,"end_line":227,"end_character":23},"in_reply_to":"ba2be162_5e959830","updated":"2017-03-09 21:44:27.000000000","message":"Done","commit_id":"5d6fad1f1ff6a45cd293e1334252621024708305"}],"openstack_dashboard/dashboards/admin/networks/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a143948f6d8c2a2d6b6899abd66d25ff3e8be603","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from django import http"},{"line_number":18,"context_line":"from django.utils.http import urlunquote"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from horizon import forms"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from mox3.mox import IsA  # noqa"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba2be162_7e989c6a","line":20,"updated":"2017-03-05 19:39:37.000000000","message":"\u0027horizon\u0027 module is also a part of project packages. Move this after mox3.","commit_id":"5d6fad1f1ff6a45cd293e1334252621024708305"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"cdc0c0aa070ca6bcd653ef881179ea879ad5c9cd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from django import http"},{"line_number":18,"context_line":"from django.utils.http import urlunquote"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from horizon import forms"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from mox3.mox import IsA  # noqa"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_8bbe3663","line":20,"in_reply_to":"ba2be162_7e989c6a","updated":"2017-03-09 21:44:27.000000000","message":"Done","commit_id":"5d6fad1f1ff6a45cd293e1334252621024708305"}],"openstack_dashboard/local/local_settings.py.example":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"da2427c91281d034b15150ced8afab86afd07924","unresolved":false,"context_lines":[{"line_number":327,"context_line":"    # network field on the admin create network modal. If it\u0027s set to an empty"},{"line_number":328,"context_line":"    # list, the field will be a regular input field."},{"line_number":329,"context_line":"    # e.g. [\u0027default\u0027, \u0027test\u0027]"},{"line_number":330,"context_line":"    \u0027physical_networks\u0027: []"},{"line_number":331,"context_line":"}"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"# The OPENSTACK_HEAT_STACK settings can be used to disable password"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa6399be_0831da0b","line":330,"updated":"2016-10-11 10:45:46.000000000","message":"Could you add a new setting to doc/source/topics.settings.rst?","commit_id":"6747084116cc2ad3d7e46e7e5aeb42d2091ec352"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"1af34f93935eb6ed3a2a0ce6e6ae5dc0e3ff895a","unresolved":false,"context_lines":[{"line_number":327,"context_line":"    # network field on the admin create network modal. If it\u0027s set to an empty"},{"line_number":328,"context_line":"    # list, the field will be a regular input field."},{"line_number":329,"context_line":"    # e.g. [\u0027default\u0027, \u0027test\u0027]"},{"line_number":330,"context_line":"    \u0027physical_networks\u0027: []"},{"line_number":331,"context_line":"}"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"# The OPENSTACK_HEAT_STACK settings can be used to disable password"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa6399be_67dd1142","line":330,"in_reply_to":"fa6399be_0831da0b","updated":"2016-10-11 16:43:47.000000000","message":"Updated. Thanks.","commit_id":"6747084116cc2ad3d7e46e7e5aeb42d2091ec352"}]}
