)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8a828f55b04597e55a2f57dbe5ada31b1de9b580","unresolved":false,"context_lines":[{"line_number":7,"context_line":"remove part of \u0027import *\u0027 usage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is talked in #1188533, and in current codes, there are several"},{"line_number":10,"context_line":"places here:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"horizon/forms/__init__.py:18:from django.forms import *"},{"line_number":13,"context_line":"    this one used to form.some_class, can\u0027t remove \u0027import *\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAQn%2F%2FjeI%3D","line":10,"updated":"2013-07-29 10:47:41.000000000","message":"Please use \"bug #1188533\" or \"LP #1188533\". If this style is used, gerrit creates a link to Launchpad automatically.","commit_id":"b6c13248c9cec3279bcf1dfa62eede70fe59635d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8a828f55b04597e55a2f57dbe5ada31b1de9b580","unresolved":false,"context_lines":[{"line_number":10,"context_line":"places here:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"horizon/forms/__init__.py:18:from django.forms import *"},{"line_number":13,"context_line":"    this one used to form.some_class, can\u0027t remove \u0027import *\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"openstack_dashboard/settings.py:182:    from local.local_settings import *"},{"line_number":16,"context_line":"openstack_dashboard/test/settings.py:5:from horizon.test.settings import *"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAQn%2F%2Fjfc%3D","line":13,"updated":"2013-07-29 10:47:41.000000000","message":"I am not sure we should remove \"import *\" or keep it unchanged.\nIf we decide to keep it, it is better to add \"  # noqa\" to this line\nand enable H303 check in tox.ini.\n\n   from django.forms import *  # noqa","commit_id":"b6c13248c9cec3279bcf1dfa62eede70fe59635d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8a828f55b04597e55a2f57dbe5ada31b1de9b580","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"openstack_dashboard/settings.py:182:    from local.local_settings import *"},{"line_number":16,"context_line":"openstack_dashboard/test/settings.py:5:from horizon.test.settings import *"},{"line_number":17,"context_line":"    above two used to settings.SOME_CONFIG, can\u0027t remove \u0027import *\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"openstack_dashboard/dashboards/project/instances/workflows/__init__.py:1:from create_instance import *"},{"line_number":20,"context_line":"openstack_dashboard/dashboards/project/instances/workflows/__init__.py:2:from update_instance import *"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAQn%2F%2FjfY%3D","line":17,"updated":"2013-07-29 10:47:41.000000000","message":"using \"from local.local_settings import *\" looks a usual way in Django. We can skip flake8 check by adding \"  # noqa\". (http://flake8.readthedocs.org/en/2.0/)\n\n   from local.local_settings import *  # noqa\n\nNote that *two* spaces are required before #.","commit_id":"b6c13248c9cec3279bcf1dfa62eede70fe59635d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8a828f55b04597e55a2f57dbe5ada31b1de9b580","unresolved":false,"context_lines":[{"line_number":19,"context_line":"openstack_dashboard/dashboards/project/instances/workflows/__init__.py:1:from create_instance import *"},{"line_number":20,"context_line":"openstack_dashboard/dashboards/project/instances/workflows/__init__.py:2:from update_instance import *"},{"line_number":21,"context_line":"openstack_dashboard/dashboards/project/instances/workflows/__init__.py:3:from resize_instance import *"},{"line_number":22,"context_line":"    above three used to workflows.some_class, can\u0027t remove \u0027import *\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"openstack_dashboard/dashboards/project/images_and_snapshots/urls.py:21:from django.conf.urls.defaults import *"},{"line_number":25,"context_line":"    fix it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAQn%2F%2Fje0%3D","line":22,"updated":"2013-07-29 10:47:41.000000000","message":"We can remove \"import *\" by using the following. It is simple enough and I prefer to removing \"import *\".\n\n  from create_instance import LaunchInstance\n  from update_instance import UpdateInstance\n  from resize_instance import ResizeInstance","commit_id":"b6c13248c9cec3279bcf1dfa62eede70fe59635d"}],"openstack_dashboard/dashboards/project/instances/workflows/__init__.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"74e857e00321622da912ad0bd869ab0d1051dfb7","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"LaunchInstance \u003d LaunchInstance"},{"line_number":6,"context_line":"UpdateInstance \u003d UpdateInstance"},{"line_number":7,"context_line":"ResizeInstance \u003d ResizeInstance"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FgX4%3D","line":7,"updated":"2013-07-30 03:40:53.000000000","message":"Please use assert. It is just a convention in Horizon to avoid flake8 unused import errors (e.g., horizon/forms/__init__.py has the similar ones).\n\nassert LaunchInstace\nassert ResizeInstance\nassert UpdateInstance","commit_id":"29146700c969aaf56c0c2c6f98f924ae73b0d199"}]}
