)]}'
{"openstack_dashboard/dashboards/admin/networks/subnets/workflows.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"c1f60137a4ca8e1827768a5c7c5b42ab9e4e2d1c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            LOG.info(msg)"},{"line_number":71,"context_line":"            redirect \u003d self.get_failure_url()"},{"line_number":72,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":73,"context_line":"        subnet \u003d self._create_subnet(request, data, network)"},{"line_number":74,"context_line":"        return True if subnet else False"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_e4a7a6a4","line":73,"updated":"2016-12-06 21:30:47.000000000","message":"should we still pass in tenant_id as the 4th arg or could we change\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/networks/workflows.py#L565 to \n\nparams[\u0027tenant_id\u0027] \u003d data[\u0027tenant_id\u0027]","commit_id":"231a2331b13fc5682ae9f3258ad89e25fc523744"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9e61b447a04d86227245e718df8c4c0308ddd6ac","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            LOG.info(msg)"},{"line_number":71,"context_line":"            redirect \u003d self.get_failure_url()"},{"line_number":72,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":73,"context_line":"        subnet \u003d self._create_subnet(request, data, network)"},{"line_number":74,"context_line":"        return True if subnet else False"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5ff73747_162349aa","line":73,"in_reply_to":"3a71b18c_e4a7a6a4","updated":"2017-04-26 11:51:19.000000000","message":"Agree with Cindy. This is admin operation, so tenant_id must be specified.","commit_id":"231a2331b13fc5682ae9f3258ad89e25fc523744"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9ab1aac60bb26efc220c0888f0fb6a3cce679d5c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        network \u003d self.context_seed[\u0027network\u0027]"},{"line_number":60,"context_line":"        subnet \u003d self._create_subnet("},{"line_number":61,"context_line":"            request, data,"},{"line_number":62,"context_line":"            # network argument is required to show error message correctly."},{"line_number":63,"context_line":"            network\u003dnetwork,"},{"line_number":64,"context_line":"            # We must specify tenant_id of the network which a subnet is"},{"line_number":65,"context_line":"            # created for if admin user does not belong to the tenant."}],"source_content_type":"text/x-python","patch_set":12,"id":"df6247ed_a9c81d74","line":62,"updated":"2017-09-19 21:17:50.000000000","message":"nit: IMO, it\u0027s more readable if we move comment outside function call","commit_id":"5936e519981f15be8a33196acfe108006efe3b6f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5af9150132b8547df60a0d794a5fd61ddcc8ff3e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        network \u003d self.context_seed[\u0027network\u0027]"},{"line_number":60,"context_line":"        subnet \u003d self._create_subnet("},{"line_number":61,"context_line":"            request, data,"},{"line_number":62,"context_line":"            # network argument is required to show error message correctly."},{"line_number":63,"context_line":"            network\u003dnetwork,"},{"line_number":64,"context_line":"            # We must specify tenant_id of the network which a subnet is"},{"line_number":65,"context_line":"            # created for if admin user does not belong to the tenant."}],"source_content_type":"text/x-python","patch_set":12,"id":"7f96bb07_4df617fc","line":62,"in_reply_to":"1f485f77_dedde570","updated":"2018-11-20 12:14:08.000000000","message":"Done","commit_id":"5936e519981f15be8a33196acfe108006efe3b6f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c7983f423816f8421bf7f9e9b92ebad7eea1aa6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        network \u003d self.context_seed[\u0027network\u0027]"},{"line_number":60,"context_line":"        subnet \u003d self._create_subnet("},{"line_number":61,"context_line":"            request, data,"},{"line_number":62,"context_line":"            # network argument is required to show error message correctly."},{"line_number":63,"context_line":"            network\u003dnetwork,"},{"line_number":64,"context_line":"            # We must specify tenant_id of the network which a subnet is"},{"line_number":65,"context_line":"            # created for if admin user does not belong to the tenant."}],"source_content_type":"text/x-python","patch_set":12,"id":"1f485f77_dedde570","line":62,"in_reply_to":"df6247ed_a9c81d74","updated":"2017-11-14 17:46:10.000000000","message":"There are two comments on different arguments. Do you want to move both outside of the function? I am not sure which is clear.","commit_id":"5936e519981f15be8a33196acfe108006efe3b6f"}],"openstack_dashboard/dashboards/project/networks/subnets/views.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9ab1aac60bb26efc220c0888f0fb6a3cce679d5c","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def get_initial(self):"},{"line_number":54,"context_line":"        network \u003d self.get_object()"},{"line_number":55,"context_line":"        return {\"network_id\": self.kwargs[\u0027network_id\u0027],"},{"line_number":56,"context_line":"                \"network_name\": network.name_or_id,"},{"line_number":57,"context_line":"                \"network\": network,"},{"line_number":58,"context_line":"                \"dns_nameservers\": self.get_default_dns_servers()}"}],"source_content_type":"text/x-python","patch_set":12,"id":"df6247ed_49a521b5","line":55,"updated":"2017-09-19 21:17:50.000000000","message":"We don\u0027t need to return network_id and network_name now. All needed data should be getting from the network param","commit_id":"5936e519981f15be8a33196acfe108006efe3b6f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5af9150132b8547df60a0d794a5fd61ddcc8ff3e","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def get_initial(self):"},{"line_number":54,"context_line":"        network \u003d self.get_object()"},{"line_number":55,"context_line":"        return {\"network_id\": self.kwargs[\u0027network_id\u0027],"},{"line_number":56,"context_line":"                \"network_name\": network.name_or_id,"},{"line_number":57,"context_line":"                \"network\": network,"},{"line_number":58,"context_line":"                \"dns_nameservers\": self.get_default_dns_servers()}"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f96bb07_8dec1f2a","line":55,"in_reply_to":"1f485f77_1ef49df1","updated":"2018-11-20 12:14:08.000000000","message":"Done","commit_id":"5936e519981f15be8a33196acfe108006efe3b6f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c7983f423816f8421bf7f9e9b92ebad7eea1aa6","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def get_initial(self):"},{"line_number":54,"context_line":"        network \u003d self.get_object()"},{"line_number":55,"context_line":"        return {\"network_id\": self.kwargs[\u0027network_id\u0027],"},{"line_number":56,"context_line":"                \"network_name\": network.name_or_id,"},{"line_number":57,"context_line":"                \"network\": network,"},{"line_number":58,"context_line":"                \"dns_nameservers\": self.get_default_dns_servers()}"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f485f77_1ef49df1","line":55,"in_reply_to":"df6247ed_49a521b5","updated":"2017-11-14 17:46:10.000000000","message":"Yes, we can, but it increases the diff unrelated to the bug fix, so I didn\u0027t clean them up when I updated it.","commit_id":"5936e519981f15be8a33196acfe108006efe3b6f"}],"openstack_dashboard/dashboards/project/networks/subnets/workflows.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"721b789635248edbc3422c4869ad8f85b2b3773a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                       args\u003d(self.context.get(\u0027network_id\u0027),))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def handle(self, request, data):"},{"line_number":78,"context_line":"        network \u003d api.neutron.network_get(request,"},{"line_number":79,"context_line":"                                          self.context.get(\u0027network_id\u0027))"},{"line_number":80,"context_line":"        subnet \u003d self._create_subnet(request, data, network)"},{"line_number":81,"context_line":"        return True if subnet else False"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5f2577a7_d47fe412","line":79,"range":{"start_line":78,"start_character":8,"end_line":79,"end_character":73},"updated":"2017-09-14 22:55:36.000000000","message":"There is no need to retrieve a network object again.\n\nThe network object you want is already retrieved in \ndashboards/project/networks/subnets/views.py CreateView.get_initial() and it is passed to the workflow object as context_seed of __init__ method. \n\nWhat you need to do are:\n\n- Add the network object as \u0027network\u0027 to context_seed above\n- Add a \u0027network\u0027 to dashboards/project/networks/subnets/views.py CreateSubnetInfo.depends_on\n\nNow, you can retrieve the network object here from self.context_seed[\u0027network\u0027].","commit_id":"19ed17a1f82e2c63307e341beddb10c33e740f93"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"12d7383e72edfc629bf7e311dab878f2a0ef2ebb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                       args\u003d(self.context.get(\u0027network_id\u0027),))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def handle(self, request, data):"},{"line_number":78,"context_line":"        network \u003d api.neutron.network_get(request,"},{"line_number":79,"context_line":"                                          self.context.get(\u0027network_id\u0027))"},{"line_number":80,"context_line":"        subnet \u003d self._create_subnet(request, data, network)"},{"line_number":81,"context_line":"        return True if subnet else False"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5f2577a7_d67a36b8","line":79,"range":{"start_line":78,"start_character":8,"end_line":79,"end_character":73},"in_reply_to":"5f2577a7_d47fe412","updated":"2017-09-15 20:44:16.000000000","message":"Done","commit_id":"19ed17a1f82e2c63307e341beddb10c33e740f93"}]}
