)]}'
{"openstack_dashboard/defaults/__init__.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3d6aab5cf13c6d3b22d8095c9605a9f3554eac26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"bff0334d_f94e7b6d","updated":"2017-04-09 09:35:01.000000000","message":"IMHO we don\u0027t use \u0027defaults\u0027 as module name. If we support config files in future, this module will be a place to option definitions. \u0027config\u0027 or \u0027settings\u0027 looks fine to me (django already uses \u0027settings\u0027).","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7c868d8f28895c2ec3ba6882e80117f77c41b699","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"7ffa3b31_44b5a9cc","in_reply_to":"bff0334d_f94e7b6d","updated":"2017-04-18 15:02:36.000000000","message":"Well, this was moved from \u0027config\u0027 in response to a comment. I don\u0027t really care either way.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"}],"openstack_dashboard/defaults/config_django.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3d6aab5cf13c6d3b22d8095c9605a9f3554eac26","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # Shorthands"},{"line_number":25,"context_line":"    O \u003d cfg.Opt"},{"line_number":26,"context_line":"    t \u003d types"},{"line_number":27,"context_line":"    ct \u003d config_types"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"bff0334d_d62024af","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":15},"updated":"2017-04-09 09:35:01.000000000","message":"I don\u0027t see a big reason to use this kind of shortcuts.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7c868d8f28895c2ec3ba6882e80117f77c41b699","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # Shorthands"},{"line_number":25,"context_line":"    O \u003d cfg.Opt"},{"line_number":26,"context_line":"    t \u003d types"},{"line_number":27,"context_line":"    ct \u003d config_types"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"7ffa3b31_c4d539e7","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":15},"in_reply_to":"bff0334d_d62024af","updated":"2017-04-18 15:02:36.000000000","message":"It\u0027s mainly because then the options fit in one line and are much easier to read and scan quickly. If I expand them, each option will take at least three lines.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"7e9da042c18e728897ff4496b4b0535c7bbba9d7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    t \u003d types"},{"line_number":27,"context_line":"    ct \u003d config_types"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    django_group \u003d cfg.OptGroup(\u0027django\u0027, \"Django Geneal Configuration\")"},{"line_number":30,"context_line":"    config.register_group(django_group)"},{"line_number":31,"context_line":"    config.register_opts(group\u003ddjango_group, opts\u003d["},{"line_number":32,"context_line":"        O(\u0027debug\u0027, t.Boolean(), default\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":38,"id":"5a22e58a_5110074f","line":29,"range":{"start_line":29,"start_character":50,"end_line":29,"end_character":56},"updated":"2017-03-14 10:46:20.000000000","message":"I assume this is meant to be \"General\"? tbh you could just drop this word anyway","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7c868d8f28895c2ec3ba6882e80117f77c41b699","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    t \u003d types"},{"line_number":27,"context_line":"    ct \u003d config_types"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    django_group \u003d cfg.OptGroup(\u0027django\u0027, \"Django Geneal Configuration\")"},{"line_number":30,"context_line":"    config.register_group(django_group)"},{"line_number":31,"context_line":"    config.register_opts(group\u003ddjango_group, opts\u003d["},{"line_number":32,"context_line":"        O(\u0027debug\u0027, t.Boolean(), default\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":38,"id":"7ffa3b31_44036974","line":29,"range":{"start_line":29,"start_character":50,"end_line":29,"end_character":56},"in_reply_to":"5a22e58a_5110074f","updated":"2017-04-18 15:02:36.000000000","message":"Yeah, sorry for the typo, thanks for catching it.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3d6aab5cf13c6d3b22d8095c9605a9f3554eac26","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    django_group \u003d cfg.OptGroup(\u0027django\u0027, \"Django Geneal Configuration\")"},{"line_number":30,"context_line":"    config.register_group(django_group)"},{"line_number":31,"context_line":"    config.register_opts(group\u003ddjango_group, opts\u003d["},{"line_number":32,"context_line":"        O(\u0027debug\u0027, t.Boolean(), default\u003dTrue),"},{"line_number":33,"context_line":"        O(\u0027allowed_hosts\u0027, t.List(t.String())),"},{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"}],"source_content_type":"text/x-python","patch_set":38,"id":"bff0334d_1629ec99","line":32,"updated":"2017-04-09 09:35:01.000000000","message":"when considering the usage of oslo-config-generator in future, it is better to define options and option group outside of the function.\n\nSee an example in oslo_config generator.\n\nhttps://docs.openstack.org/developer/oslo.config/generator.html#defining-option-discovery-entry-points","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7c868d8f28895c2ec3ba6882e80117f77c41b699","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    django_group \u003d cfg.OptGroup(\u0027django\u0027, \"Django Geneal Configuration\")"},{"line_number":30,"context_line":"    config.register_group(django_group)"},{"line_number":31,"context_line":"    config.register_opts(group\u003ddjango_group, opts\u003d["},{"line_number":32,"context_line":"        O(\u0027debug\u0027, t.Boolean(), default\u003dTrue),"},{"line_number":33,"context_line":"        O(\u0027allowed_hosts\u0027, t.List(t.String())),"},{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"}],"source_content_type":"text/x-python","patch_set":38,"id":"7ffa3b31_8465f147","line":32,"in_reply_to":"bff0334d_1629ec99","updated":"2017-04-18 15:02:36.000000000","message":"I\u0027m not a big fan of global code that gets executed on import. It\u0027s harder to test and can lead to problems with import cycles. As far as I can tell from the documentation you linked to, oslo-config-generator doesn\u0027t care if the options are global or not -- it just calls the specified function? So there is no requirement for them to be global?\n\nBy the way, I didn\u0027t know about oslo-config-generator, I need to look at it closer, thanks.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3d6aab5cf13c6d3b22d8095c9605a9f3554eac26","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        O(\u0027debug\u0027, t.Boolean(), default\u003dTrue),"},{"line_number":33,"context_line":"        O(\u0027allowed_hosts\u0027, t.List(t.String())),"},{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"},{"line_number":36,"context_line":"        O(\u0027time_zone\u0027, t.String(), default\u003d\u0027UTC\u0027),"},{"line_number":37,"context_line":"        O(\u0027logging\u0027, ct.Literal({\"\": None}), default\u003d{"},{"line_number":38,"context_line":"            \u0027version\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":38,"id":"bff0334d_793dcbc2","line":35,"updated":"2017-04-09 09:35:01.000000000","message":"General comment: it is better to use cfg.StrOpt rather than cfg.Opt with config type. This is because the former is a way commonly used in OpenStack.\n\nIn addition, StrOpt supports secret\u003dTrue. In this case, it looks better to specify secret\u003dTrue.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"31f4cc8b144d353304556d69e92ea6e4fffcec6a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        O(\u0027debug\u0027, t.Boolean(), default\u003dTrue),"},{"line_number":33,"context_line":"        O(\u0027allowed_hosts\u0027, t.List(t.String())),"},{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"},{"line_number":36,"context_line":"        O(\u0027time_zone\u0027, t.String(), default\u003d\u0027UTC\u0027),"},{"line_number":37,"context_line":"        O(\u0027logging\u0027, ct.Literal({\"\": None}), default\u003d{"},{"line_number":38,"context_line":"            \u0027version\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":38,"id":"3f044301_9f50f7d6","line":35,"in_reply_to":"3f044301_1cd515ba","updated":"2017-05-03 19:34:33.000000000","message":"I added secret\u003dTrue, but left it as Opt with type\u003dString() for consistency with other options.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"211516e29d43afe7b55b50fdc7f741ee38cb5380","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        O(\u0027debug\u0027, t.Boolean(), default\u003dTrue),"},{"line_number":33,"context_line":"        O(\u0027allowed_hosts\u0027, t.List(t.String())),"},{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"},{"line_number":36,"context_line":"        O(\u0027time_zone\u0027, t.String(), default\u003d\u0027UTC\u0027),"},{"line_number":37,"context_line":"        O(\u0027logging\u0027, ct.Literal({\"\": None}), default\u003d{"},{"line_number":38,"context_line":"            \u0027version\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":38,"id":"3f044301_1cd515ba","line":35,"in_reply_to":"5ff73747_768b48c2","updated":"2017-05-03 19:17:55.000000000","message":"\u0027secret\u0027 is not specific to StrOpt. It is defined in the base class (Opt class). I tested with neutron by adding secret\u003dTrue to some option and the output was changed to \u0027****\u0027 in the output generated by log_opt_values() method.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"4ebe5d310fb530b91dc4b76bdeb705db6a803069","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        O(\u0027debug\u0027, t.Boolean(), default\u003dTrue),"},{"line_number":33,"context_line":"        O(\u0027allowed_hosts\u0027, t.List(t.String())),"},{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"},{"line_number":36,"context_line":"        O(\u0027time_zone\u0027, t.String(), default\u003d\u0027UTC\u0027),"},{"line_number":37,"context_line":"        O(\u0027logging\u0027, ct.Literal({\"\": None}), default\u003d{"},{"line_number":38,"context_line":"            \u0027version\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":38,"id":"5ff73747_768b48c2","line":35,"in_reply_to":"7ffa3b31_04d681c4","updated":"2017-05-03 17:19:03.000000000","message":"I\u0027m looking at the StrOpt, and as far as I can tell there is no \"secret\" parameter for it, and it simply calls Opt with type\u003dString.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7c868d8f28895c2ec3ba6882e80117f77c41b699","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        O(\u0027debug\u0027, t.Boolean(), default\u003dTrue),"},{"line_number":33,"context_line":"        O(\u0027allowed_hosts\u0027, t.List(t.String())),"},{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"},{"line_number":36,"context_line":"        O(\u0027time_zone\u0027, t.String(), default\u003d\u0027UTC\u0027),"},{"line_number":37,"context_line":"        O(\u0027logging\u0027, ct.Literal({\"\": None}), default\u003d{"},{"line_number":38,"context_line":"            \u0027version\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":38,"id":"7ffa3b31_04d681c4","line":35,"in_reply_to":"bff0334d_793dcbc2","updated":"2017-04-18 15:02:36.000000000","message":"Thanks, I didn\u0027t know about StrOpt. I guess oslo-config evolved a bit since I last read the documentation, I need to look at it again.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3d6aab5cf13c6d3b22d8095c9605a9f3554eac26","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"},{"line_number":36,"context_line":"        O(\u0027time_zone\u0027, t.String(), default\u003d\u0027UTC\u0027),"},{"line_number":37,"context_line":"        O(\u0027logging\u0027, ct.Literal({\"\": None}), default\u003d{"},{"line_number":38,"context_line":"            \u0027version\u0027: 1,"},{"line_number":39,"context_line":"            \u0027disable_existing_loggers\u0027: False,"},{"line_number":40,"context_line":"            \u0027formatters\u0027: {"}],"source_content_type":"text/x-python","patch_set":38,"id":"bff0334d_760f1837","line":37,"range":{"start_line":37,"start_character":11,"end_line":37,"end_character":18},"updated":"2017-04-09 09:35:01.000000000","message":"Can we use python logging.conf file rather than defining this as literal value? I think it is more common way to define a complex logging configuration in the python world and it is also used in the OpenStack community.\n\nEven if we cannot use python logging.conf, this style is not easy to configure. If so, I think it is better to use a separate YAML, JSON or INI file to configure the logging.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"795a0680a3f168be92df6b38e451aaded292722d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"},{"line_number":36,"context_line":"        O(\u0027time_zone\u0027, t.String(), default\u003d\u0027UTC\u0027),"},{"line_number":37,"context_line":"        O(\u0027logging\u0027, ct.Literal({\"\": None}), default\u003d{"},{"line_number":38,"context_line":"            \u0027version\u0027: 1,"},{"line_number":39,"context_line":"            \u0027disable_existing_loggers\u0027: False,"},{"line_number":40,"context_line":"            \u0027formatters\u0027: {"}],"source_content_type":"text/x-python","patch_set":38,"id":"7ffa3b31_75ca911a","line":37,"range":{"start_line":37,"start_character":11,"end_line":37,"end_character":18},"in_reply_to":"7ffa3b31_e4fdd53a","updated":"2017-04-18 16:02:50.000000000","message":"Thanks for checking. IMHO the proposed way is at least tricky. Horizon depends on Django and there is some problem we cannot avoid. This might be one of such things. If so, it looks better to me to keep the current way for the logging configuration. I don\u0027t think it is tricky to keep some configuration in the current Django way. I believe using \u0027Literal\u0027 type is the last resort and it is worth considering keeping the current way for such options before using \u0027Literal\u0027. \u0027Literal\u0027 type is another messy area in my experience.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7c868d8f28895c2ec3ba6882e80117f77c41b699","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"},{"line_number":36,"context_line":"        O(\u0027time_zone\u0027, t.String(), default\u003d\u0027UTC\u0027),"},{"line_number":37,"context_line":"        O(\u0027logging\u0027, ct.Literal({\"\": None}), default\u003d{"},{"line_number":38,"context_line":"            \u0027version\u0027: 1,"},{"line_number":39,"context_line":"            \u0027disable_existing_loggers\u0027: False,"},{"line_number":40,"context_line":"            \u0027formatters\u0027: {"}],"source_content_type":"text/x-python","patch_set":38,"id":"7ffa3b31_e4fdd53a","line":37,"range":{"start_line":37,"start_character":11,"end_line":37,"end_character":18},"in_reply_to":"bff0334d_760f1837","updated":"2017-04-18 15:02:36.000000000","message":"The problem is that the logging module doesn\u0027t support all the options in the .ini file, and we are using those options. A separate problem is that the actual logging configuration is performed by Django, and I didn\u0027t find a way to make it use a .ini file for that.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"}],"openstack_dashboard/defaults/config_email.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"7e9da042c18e728897ff4496b4b0535c7bbba9d7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        O(\u0027host_password\u0027, t.String()),"},{"line_number":31,"context_line":"    ])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    return config"}],"source_content_type":"text/x-python","patch_set":38,"id":"5a22e58a_11d68fc5","line":33,"updated":"2017-03-14 10:46:20.000000000","message":"Is there a reason to separate this from the Django Configuration?","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7c868d8f28895c2ec3ba6882e80117f77c41b699","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        O(\u0027host_password\u0027, t.String()),"},{"line_number":31,"context_line":"    ])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    return config"}],"source_content_type":"text/x-python","patch_set":38,"id":"7ffa3b31_240e1d3b","line":33,"in_reply_to":"5a22e58a_11d68fc5","updated":"2017-04-18 15:02:36.000000000","message":"It\u0027s configuration for a plugin. This particular plugin has been imported into Django\u0027s core, but it still acts like a plugin, and can be replaced with a different e-mail backend plugin if needed. I think it makes sense to group the options for plugins like this, as this makes it a little easier to manage, but there is no *technical* reason for this to be separate.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"}],"openstack_dashboard/defaults/config_session.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"7e9da042c18e728897ff4496b4b0535c7bbba9d7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        O(\u0027cookie_max_size\u0027, t.Integer(), default\u003d4093),"},{"line_number":33,"context_line":"        O(\u0027serializer\u0027, t.String(),"},{"line_number":34,"context_line":"          default\u003d\u0027django.contrib.sessions.serializers.PickleSerializer\u0027),"},{"line_number":35,"context_line":"    ])"}],"source_content_type":"text/x-python","patch_set":38,"id":"5a22e58a_e47bef79","line":35,"updated":"2017-03-14 10:46:20.000000000","message":"Same as email, I think this could just go under general django config.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"}],"openstack_dashboard/defaults/config_theme.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"7e9da042c18e728897ff4496b4b0535c7bbba9d7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    t \u003d types"},{"line_number":23,"context_line":"    ct \u003d config_types"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    group \u003d cfg.OptGroup(\u0027theme\u0027, \"Django Theme Configuration\")"},{"line_number":26,"context_line":"    config.register_group(group)"},{"line_number":27,"context_line":"    config.register_opts(group\u003dgroup, opts\u003d["},{"line_number":28,"context_line":"        O(\u0027site_branding\u0027, t.String(), default\u003d\u0027OpenStack Dashboard\u0027),"}],"source_content_type":"text/x-python","patch_set":38,"id":"5a22e58a_915fdf0d","line":25,"range":{"start_line":25,"start_character":35,"end_line":25,"end_character":42},"updated":"2017-03-14 10:46:20.000000000","message":"This isn\u0027t a Django thing really, so should just be theme config","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3d6aab5cf13c6d3b22d8095c9605a9f3554eac26","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    t \u003d types"},{"line_number":23,"context_line":"    ct \u003d config_types"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    group \u003d cfg.OptGroup(\u0027theme\u0027, \"Django Theme Configuration\")"},{"line_number":26,"context_line":"    config.register_group(group)"},{"line_number":27,"context_line":"    config.register_opts(group\u003dgroup, opts\u003d["},{"line_number":28,"context_line":"        O(\u0027site_branding\u0027, t.String(), default\u003d\u0027OpenStack Dashboard\u0027),"}],"source_content_type":"text/x-python","patch_set":38,"id":"bff0334d_9972cfac","line":25,"range":{"start_line":25,"start_character":35,"end_line":25,"end_character":42},"in_reply_to":"5a22e58a_22aa57d5","updated":"2017-04-09 09:35:01.000000000","message":"+1","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7c868d8f28895c2ec3ba6882e80117f77c41b699","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    t \u003d types"},{"line_number":23,"context_line":"    ct \u003d config_types"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    group \u003d cfg.OptGroup(\u0027theme\u0027, \"Django Theme Configuration\")"},{"line_number":26,"context_line":"    config.register_group(group)"},{"line_number":27,"context_line":"    config.register_opts(group\u003dgroup, opts\u003d["},{"line_number":28,"context_line":"        O(\u0027site_branding\u0027, t.String(), default\u003d\u0027OpenStack Dashboard\u0027),"}],"source_content_type":"text/x-python","patch_set":38,"id":"7ffa3b31_9f765ea4","line":25,"range":{"start_line":25,"start_character":35,"end_line":25,"end_character":42},"in_reply_to":"5a22e58a_22aa57d5","updated":"2017-04-18 15:02:36.000000000","message":"I think that theming and branding is actually complicated enough to warrant having its own configuration group. Maybe I shouldn\u0027t have called it \"Django\".","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"561bed855831d45fec4a4e75177691d4cba89511","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    t \u003d types"},{"line_number":23,"context_line":"    ct \u003d config_types"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    group \u003d cfg.OptGroup(\u0027theme\u0027, \"Django Theme Configuration\")"},{"line_number":26,"context_line":"    config.register_group(group)"},{"line_number":27,"context_line":"    config.register_opts(group\u003dgroup, opts\u003d["},{"line_number":28,"context_line":"        O(\u0027site_branding\u0027, t.String(), default\u003d\u0027OpenStack Dashboard\u0027),"}],"source_content_type":"text/x-python","patch_set":38,"id":"5a22e58a_22aa57d5","line":25,"range":{"start_line":25,"start_character":35,"end_line":25,"end_character":42},"in_reply_to":"5a22e58a_915fdf0d","updated":"2017-03-14 10:47:22.000000000","message":"Actually, maybe this should be under general Horizon config, like a config_horizon.py file","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"}],"openstack_dashboard/defaults/config_websso.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"7e9da042c18e728897ff4496b4b0535c7bbba9d7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \"acme_saml2\": (\"acme\", \"saml2\"),"},{"line_number":42,"context_line":"        }),"},{"line_number":43,"context_line":"    ])"},{"line_number":44,"context_line":"    return group"}],"source_content_type":"text/x-python","patch_set":38,"id":"5a22e58a_31954b40","line":44,"updated":"2017-03-14 10:46:20.000000000","message":"This should be under a config_keystone.py I think, as its not a Django thing, but a Keystone thing. This would align with any later config in here too.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7c868d8f28895c2ec3ba6882e80117f77c41b699","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \"acme_saml2\": (\"acme\", \"saml2\"),"},{"line_number":42,"context_line":"        }),"},{"line_number":43,"context_line":"    ])"},{"line_number":44,"context_line":"    return group"}],"source_content_type":"text/x-python","patch_set":38,"id":"7ffa3b31_1f6a4eb2","line":44,"in_reply_to":"5a22e58a_31954b40","updated":"2017-04-18 15:02:36.000000000","message":"I don\u0027t know, it\u0027s related to the django-auth plugin we are using.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"}],"openstack_dashboard/local/local_settings.conf.example":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"d3ebc2ca1275edd167ecb63f10124c7a338fe214","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#            \"LOCATION\": \"127.0.0.1:11211\""},{"line_number":48,"context_line":"#        }"},{"line_number":49,"context_line":"#    }"},{"line_number":50,"context_line":"caches \u003d {"},{"line_number":51,"context_line":"        \"default\": {"},{"line_number":52,"context_line":"            \"BACKEND\": \"django.core.cache.backends.locmem.LocMemCache\""},{"line_number":53,"context_line":"        }"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_c917f252","line":50,"updated":"2017-01-13 03:20:22.000000000","message":"Is this part of a specific oslo.config format, or is the file intended to be INI? I mostly ask for clarification, based on the topic of the change and the fact that I was not aware of a dict-like structure in ini.","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"6b4fc17b4fbff02df708a5a88a8d60ae18067493","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#            \"LOCATION\": \"127.0.0.1:11211\""},{"line_number":48,"context_line":"#        }"},{"line_number":49,"context_line":"#    }"},{"line_number":50,"context_line":"caches \u003d {"},{"line_number":51,"context_line":"        \"default\": {"},{"line_number":52,"context_line":"            \"BACKEND\": \"django.core.cache.backends.locmem.LocMemCache\""},{"line_number":53,"context_line":"        }"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_2a899d75","line":50,"updated":"2017-01-17 17:07:18.000000000","message":"So this *will* trip up operators. They\u0027re used to configuration formats already supported by oslo.config and used in other projects. For example, to configure the glance backing store you specify which stores you are going to use and then have separate configuration sections to configure them. To apply that here you would do:\n\n   caches \u003d localcache\n\n   [localcache]\n   backend \u003d django.core.cache.backends.locmem.LocMemCache\n\nOr\n\n   caches \u003d memcached\n\n   [memcached]\n   backend \u003d ...\n   location \u003d ...\n\nOperators will be more familiar with this and then they don\u0027t have to worry about interspersing Python syntax in an ini file.","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"df399fd76a202ed61c366e30dcdf19a2344003d4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#            \"LOCATION\": \"127.0.0.1:11211\""},{"line_number":48,"context_line":"#        }"},{"line_number":49,"context_line":"#    }"},{"line_number":50,"context_line":"caches \u003d {"},{"line_number":51,"context_line":"        \"default\": {"},{"line_number":52,"context_line":"            \"BACKEND\": \"django.core.cache.backends.locmem.LocMemCache\""},{"line_number":53,"context_line":"        }"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_e672f4e4","line":50,"in_reply_to":"7a3c09a3_02c1cce4","updated":"2017-01-13 18:49:49.000000000","message":"Ok, thanks. Is there some sort of serializer available that understands that type?\n\nIn OpenStack-Ansible, we have a custom Ansible plugin that allows us to generate ini, json, and yaml files for project configuration. In the past, Django\u0027s pure python approach made templating Horizon configuration difficult, but this change would definitely help us as long as we knew how to translate YAML dicts into this format.","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"5f3dd3d7d402652c50d5305980455247bbd6a911","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#            \"LOCATION\": \"127.0.0.1:11211\""},{"line_number":48,"context_line":"#        }"},{"line_number":49,"context_line":"#    }"},{"line_number":50,"context_line":"caches \u003d {"},{"line_number":51,"context_line":"        \"default\": {"},{"line_number":52,"context_line":"            \"BACKEND\": \"django.core.cache.backends.locmem.LocMemCache\""},{"line_number":53,"context_line":"        }"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_45db3a4f","line":50,"in_reply_to":"7a3c09a3_2a899d75","updated":"2017-01-17 17:27:27.000000000","message":"This is not \"interspersed Python syntax in an ini file\". This is plain and correct ini file syntax, where values of the variables happen to be strings describing python literals. All standard tools for handling ini files will work with it.\n\nThe settings that are being moved here all come from Django settings or are closely related to them. Any operator familiar with Django will immediately recognize the format and the structure. Any operator not familiar with Django should probably not be modifying them. Implementing a layer of a completely new format, as you propose here, would only introduce confusion, will make it harder to seek help on Django-related forums, and introduce new bugs.","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"24582bcdf3f52a97e89d520a0b0c20a22ee3037f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#            \"LOCATION\": \"127.0.0.1:11211\""},{"line_number":48,"context_line":"#        }"},{"line_number":49,"context_line":"#    }"},{"line_number":50,"context_line":"caches \u003d {"},{"line_number":51,"context_line":"        \"default\": {"},{"line_number":52,"context_line":"            \"BACKEND\": \"django.core.cache.backends.locmem.LocMemCache\""},{"line_number":53,"context_line":"        }"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_02c1cce4","line":50,"in_reply_to":"7a3c09a3_c917f252","updated":"2017-01-13 08:05:59.000000000","message":"We are using oslo.config, but this is a custom type that lets you specify a python structure -- we need it because some of the configuration options are quite complex and don\u0027t translate well into types normally available in oslo.config","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"68c76e3c73d1b4d7136ce79f72e470076e2e34d3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#            \"LOCATION\": \"127.0.0.1:11211\""},{"line_number":48,"context_line":"#        }"},{"line_number":49,"context_line":"#    }"},{"line_number":50,"context_line":"caches \u003d {"},{"line_number":51,"context_line":"        \"default\": {"},{"line_number":52,"context_line":"            \"BACKEND\": \"django.core.cache.backends.locmem.LocMemCache\""},{"line_number":53,"context_line":"        }"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_cf6164aa","line":50,"in_reply_to":"7a3c09a3_e672f4e4","updated":"2017-01-16 08:12:25.000000000","message":"It\u0027s a standard notation for Python literals, and we are using Python\u0027s own parser, so you just need to call repr() on a variable to get its serialization.","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"6b4fc17b4fbff02df708a5a88a8d60ae18067493","unresolved":false,"context_lines":[{"line_number":108,"context_line":"# Do not remove the mandatory credentials mechanism."},{"line_number":109,"context_line":"# Note: The last two tuples are sample mapping keys to a identity provider"},{"line_number":110,"context_line":"# and federation protocol combination (WEBSSO_IDP_MAPPING)."},{"line_number":111,"context_line":"#choices \u003d ["},{"line_number":112,"context_line":"#       [\"credentials\", \"Keystone Credentials\"],"},{"line_number":113,"context_line":"#       [\"oidc\", \"OpenID Connect\"],"},{"line_number":114,"context_line":"#       [\"saml2\", \"Security Assertion Markup Language\"],"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_4a7a6978","line":111,"updated":"2017-01-17 17:07:18.000000000","message":"This is the same thing as above, only it would be *improved* by having the concept of\n\n    choices \u003d credentials,oidc,saml2,acme_oidc,acme_saml2\n\n    [credentials]\n    description \u003d \"Keystone Credentials\"\n\nYes it\u0027s more lines, but it\u0027s also less fragile.","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"5f3dd3d7d402652c50d5305980455247bbd6a911","unresolved":false,"context_lines":[{"line_number":108,"context_line":"# Do not remove the mandatory credentials mechanism."},{"line_number":109,"context_line":"# Note: The last two tuples are sample mapping keys to a identity provider"},{"line_number":110,"context_line":"# and federation protocol combination (WEBSSO_IDP_MAPPING)."},{"line_number":111,"context_line":"#choices \u003d ["},{"line_number":112,"context_line":"#       [\"credentials\", \"Keystone Credentials\"],"},{"line_number":113,"context_line":"#       [\"oidc\", \"OpenID Connect\"],"},{"line_number":114,"context_line":"#       [\"saml2\", \"Security Assertion Markup Language\"],"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_c5748a37","line":111,"in_reply_to":"7a3c09a3_4a7a6978","updated":"2017-01-17 17:27:27.000000000","message":"This is asking for trouble, where you use the same \"credentials\" name in several places in different contexts, and not only not get any error message, but receive completely incomprehensible results.\n\nSo it\u0027s more lines, harder to read, *and* actually more fragile.","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"6b4fc17b4fbff02df708a5a88a8d60ae18067493","unresolved":false,"context_lines":[{"line_number":123,"context_line":"# specific WebSSO endpoint in keystone, otherwise it will use the value"},{"line_number":124,"context_line":"# as the protocol_id when redirecting to the WebSSO by protocol endpoint."},{"line_number":125,"context_line":"# NOTE: The value is expected to be a tuple formatted as:"},{"line_number":126,"context_line":"# [\u003cidp_id\u003e, \u003cprotocol_id\u003e]."},{"line_number":127,"context_line":"#idp_mapping \u003d {"},{"line_number":128,"context_line":"#       \"acme_oidc\": [\"acme\", \"oidc\"],"},{"line_number":129,"context_line":"#       \"acme_saml2\": [\"acme\", \"saml2\"]"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_6a7f2566","line":126,"updated":"2017-01-17 17:07:18.000000000","message":"Since these are mappings and related to the above, you can have something like\n\n    [acme_oidc]\n    description \u003d \"ACME - OpenID Connect\"\n    idp_mapping \u003d acme,oidc\n\nWhich you can translate into this dictionary internally","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"5f3dd3d7d402652c50d5305980455247bbd6a911","unresolved":false,"context_lines":[{"line_number":123,"context_line":"# specific WebSSO endpoint in keystone, otherwise it will use the value"},{"line_number":124,"context_line":"# as the protocol_id when redirecting to the WebSSO by protocol endpoint."},{"line_number":125,"context_line":"# NOTE: The value is expected to be a tuple formatted as:"},{"line_number":126,"context_line":"# [\u003cidp_id\u003e, \u003cprotocol_id\u003e]."},{"line_number":127,"context_line":"#idp_mapping \u003d {"},{"line_number":128,"context_line":"#       \"acme_oidc\": [\"acme\", \"oidc\"],"},{"line_number":129,"context_line":"#       \"acme_saml2\": [\"acme\", \"saml2\"]"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_850e0239","line":126,"in_reply_to":"7a3c09a3_6a7f2566","updated":"2017-01-17 17:27:27.000000000","message":"This patch is not about changing how Horizon settings are organized and what settings there are available. It\u0027s only concerned with translating them into a format that is easier to handle.\n\nI agree that there are many places where the settings are not organized optimally, and where a flatter structure is used, etc. Many of those settings were introduced without much thought and could be improved. However, the cost of changing them and breaking the backwards compatibility usually outweighs the gains from a better organization.\n\nOn top of that, this patch is already a huge change. You can keep finding small improvements like this one for a long time, and keep adding it to this patch, but that will not make it any more likely for it to be ever merged.\n\nI think that changes like the one you propose here should go into separate patches, and be discussed there.","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"6b4fc17b4fbff02df708a5a88a8d60ae18067493","unresolved":false,"context_lines":[{"line_number":132,"context_line":"[theme]"},{"line_number":133,"context_line":"# Change this patch to sections containing a label and static directory"},{"line_number":134,"context_line":"# containing two files: _variables.scss and _styles.scss"},{"line_number":135,"context_line":"#[theme:default]"},{"line_number":136,"context_line":"#label \u003d Default"},{"line_number":137,"context_line":"#path \u003d themes/default"},{"line_number":138,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_8a98d1c1","line":135,"updated":"2017-01-17 17:07:18.000000000","message":"I think this syntax was suggested by a different project but fundamentally shot down. I agree that this looks a bit more obvious to a developer, but I\u0027m not sure if that should decide if this is included or not based on what operators will be familiar with.","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"5f3dd3d7d402652c50d5305980455247bbd6a911","unresolved":false,"context_lines":[{"line_number":132,"context_line":"[theme]"},{"line_number":133,"context_line":"# Change this patch to sections containing a label and static directory"},{"line_number":134,"context_line":"# containing two files: _variables.scss and _styles.scss"},{"line_number":135,"context_line":"#[theme:default]"},{"line_number":136,"context_line":"#label \u003d Default"},{"line_number":137,"context_line":"#path \u003d themes/default"},{"line_number":138,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":37,"id":"7a3c09a3_1706c91c","line":135,"in_reply_to":"7a3c09a3_8a98d1c1","updated":"2017-01-17 17:27:27.000000000","message":"Can you tell us: 1) why it was shot down, 2) it looks more obvious compared to what, 3) what is the alternative you are suggesting here?","commit_id":"5c77e6d5f8bc1c75fc377a58ec374fd6611b659f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3d6aab5cf13c6d3b22d8095c9605a9f3554eac26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"bff0334d_b95473ff","updated":"2017-04-09 09:35:01.000000000","message":"How about using oslo-config-generator from the initial implementation? I can support the work.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"795a0680a3f168be92df6b38e451aaded292722d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"7ffa3b31_556d5502","in_reply_to":"7ffa3b31_3fa86ad9","updated":"2017-04-18 16:02:50.000000000","message":"I believe oslo.config documentation is well documented. I can also help the effort.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7c868d8f28895c2ec3ba6882e80117f77c41b699","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"7ffa3b31_3fa86ad9","in_reply_to":"bff0334d_b95473ff","updated":"2017-04-18 15:02:36.000000000","message":"I didn\u0027t know about that project, I need to look into it and see if it can be made working for our use cases. Thank you for the suggestion, I didn\u0027t know about it.","commit_id":"d06bf3242982095b8a0212bf34506e3cb21f3d35"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"cda85db3ef66d0fb49a1bf1ddacee105830f1c88","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# We recommend you use memcached for development; otherwise after every reload"},{"line_number":42,"context_line":"# of the django development server, you will have to login again. To useLLO"},{"line_number":43,"context_line":"# memcached set CACHES to something like"},{"line_number":44,"context_line":"#caches \u003d {"},{"line_number":45,"context_line":"#        \"default\": {"},{"line_number":46,"context_line":"#            \"BACKEND\": \"django.core.cache.backends.memcached.MemcachedCache\","},{"line_number":47,"context_line":"#            \"LOCATION\": \"127.0.0.1:11211\""}],"source_content_type":"application/octet-stream","patch_set":47,"id":"3f044301_36c62f4a","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":9},"updated":"2017-05-09 22:05:59.000000000","message":"A .ini parser will not be able to differentiate between what is an example, and what is a commented out directive. So effectively here, you\u0027re having twice the \"caches\" directive in the [django] section, once commented out, once active.\n\nPlease write something like this instead:\n\n# example: caches \u003d { ...\n\nThis way, you wont confuse scripts. Of course, the same applies later on for [email]/backend,","commit_id":"1bcbf9913d3cf8c06d220764ded8dd13e2aed030"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"363df3a57da17cca76368db12a0d14620ab248fd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# We recommend you use memcached for development; otherwise after every reload"},{"line_number":42,"context_line":"# of the django development server, you will have to login again. To useLLO"},{"line_number":43,"context_line":"# memcached set CACHES to something like"},{"line_number":44,"context_line":"#caches \u003d {"},{"line_number":45,"context_line":"#        \"default\": {"},{"line_number":46,"context_line":"#            \"BACKEND\": \"django.core.cache.backends.memcached.MemcachedCache\","},{"line_number":47,"context_line":"#            \"LOCATION\": \"127.0.0.1:11211\""}],"source_content_type":"application/octet-stream","patch_set":47,"id":"3f044301_20994278","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":9},"in_reply_to":"3f044301_36c62f4a","updated":"2017-05-10 07:47:21.000000000","message":"I don\u0027t think the ini parses makes such a distinction. As far as I know, all comment are treated the same.\n\nWe are moving towards the oslo-config-generator now, so we will probably get rid of this file anyways.","commit_id":"1bcbf9913d3cf8c06d220764ded8dd13e2aed030"}],"openstack_dashboard/settings.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"e315bf3e09848aef8878312263e1533c3f0ec927","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"ROOT_URLCONF \u003d \u0027openstack_dashboard.urls\u0027"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"HORIZON_CONFIG \u003d {"},{"line_number":62,"context_line":"    \u0027user_home\u0027: \u0027openstack_dashboard.views.get_user_home\u0027,"},{"line_number":63,"context_line":"    \u0027ajax_queue_limit\u0027: 10,"},{"line_number":64,"context_line":"    \u0027auto_fade_alerts\u0027: {"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba5201f7_b01cd878","side":"PARENT","line":61,"updated":"2016-12-29 04:49:03.000000000","message":"Why isn\u0027t this also broken out?","commit_id":"0372f8b9db555022b0240ae27e93cd85d77a1aea"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"0202b7ea847e868396a22e0dee84286206cbe323","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"ROOT_URLCONF \u003d \u0027openstack_dashboard.urls\u0027"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"HORIZON_CONFIG \u003d {"},{"line_number":62,"context_line":"    \u0027user_home\u0027: \u0027openstack_dashboard.views.get_user_home\u0027,"},{"line_number":63,"context_line":"    \u0027ajax_queue_limit\u0027: 10,"},{"line_number":64,"context_line":"    \u0027auto_fade_alerts\u0027: {"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba5201f7_dd63ef18","side":"PARENT","line":61,"in_reply_to":"ba5201f7_b01cd878","updated":"2017-01-03 14:40:15.000000000","message":"Because this is not Django configuration. This patch only deals with Django-specific settings. Further patches will move other parts of configuration into .conf files.","commit_id":"0372f8b9db555022b0240ae27e93cd85d77a1aea"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"e315bf3e09848aef8878312263e1533c3f0ec927","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"DEFAULT_EXCEPTION_REPORTER_FILTER \u003d \u0027horizon.exceptions.HorizonReporterFilter\u0027"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"POLICY_FILES_PATH \u003d os.path.join(ROOT_PATH, \"conf\")"},{"line_number":246,"context_line":"# Map of local copy of service policy files"},{"line_number":247,"context_line":"POLICY_FILES \u003d {"},{"line_number":248,"context_line":"    \u0027identity\u0027: \u0027keystone_policy.json\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba5201f7_93251eb0","side":"PARENT","line":245,"updated":"2016-12-29 04:49:03.000000000","message":"Don\u0027t suppose we could sneak in a name change for \"conf\" or should I try that later? :-)","commit_id":"0372f8b9db555022b0240ae27e93cd85d77a1aea"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"0202b7ea847e868396a22e0dee84286206cbe323","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"DEFAULT_EXCEPTION_REPORTER_FILTER \u003d \u0027horizon.exceptions.HorizonReporterFilter\u0027"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"POLICY_FILES_PATH \u003d os.path.join(ROOT_PATH, \"conf\")"},{"line_number":246,"context_line":"# Map of local copy of service policy files"},{"line_number":247,"context_line":"POLICY_FILES \u003d {"},{"line_number":248,"context_line":"    \u0027identity\u0027: \u0027keystone_policy.json\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba5201f7_7d73e3e7","side":"PARENT","line":245,"in_reply_to":"ba5201f7_93251eb0","updated":"2017-01-03 14:40:15.000000000","message":"It certainly is out of scope of this patch.","commit_id":"0372f8b9db555022b0240ae27e93cd85d77a1aea"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"e315bf3e09848aef8878312263e1533c3f0ec927","unresolved":false,"context_lines":[{"line_number":163,"context_line":"_config \u003d config.load_config(_files, ROOT_PATH, LOCAL_PATH)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"# Apply the general configuration."},{"line_number":166,"context_line":"config.apply_config(_config, __name__)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"try:"},{"line_number":169,"context_line":"    from local.local_settings import *  # noqa"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba5201f7_3310f24e","line":166,"updated":"2016-12-29 04:49:03.000000000","message":"This is terrible! Just kidding. Mostly :-) Please pass in globals() though, rather than muck about with sys.modules and module names and such.","commit_id":"73532cff37381d880b405f7c981bdab0da914687"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"0202b7ea847e868396a22e0dee84286206cbe323","unresolved":false,"context_lines":[{"line_number":163,"context_line":"_config \u003d config.load_config(_files, ROOT_PATH, LOCAL_PATH)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"# Apply the general configuration."},{"line_number":166,"context_line":"config.apply_config(_config, __name__)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"try:"},{"line_number":169,"context_line":"    from local.local_settings import *  # noqa"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba5201f7_3d3f9bd7","line":166,"in_reply_to":"ba5201f7_3310f24e","updated":"2017-01-03 14:40:15.000000000","message":"I think that globals() is terriblier, and more importantly, read-only. We want to be modify the contents of the module, so I\u0027m afraid.","commit_id":"73532cff37381d880b405f7c981bdab0da914687"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c5f5a8ddf21b28d280f024c57cdedc4cad852233","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    _LOG.warning(\"No local_settings file found.\")"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"# configure templates"},{"line_number":362,"context_line":"if not TEMPLATES[0][\u0027DIRS\u0027]:"},{"line_number":363,"context_line":"    TEMPLATES[0][\u0027DIRS\u0027] \u003d [os.path.join(ROOT_PATH, \u0027templates\u0027)]"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"# configure template debugging"}],"source_content_type":"text/x-python","patch_set":52,"id":"ff82abbf_d1b91215","line":362,"range":{"start_line":362,"start_character":0,"end_line":362,"end_character":28},"updated":"2017-11-27 08:37:12.000000000","message":"This never happens but we can clean up later if necesssary.","commit_id":"abfe4a30d9304b125876e3cf02b563e21f96d61f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"80b080934d1945d2c2ca6c7193f63bdf43eeb8b9","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    _LOG.warning(\"No local_settings file found.\")"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"# configure templates"},{"line_number":362,"context_line":"if not TEMPLATES[0][\u0027DIRS\u0027]:"},{"line_number":363,"context_line":"    TEMPLATES[0][\u0027DIRS\u0027] \u003d [os.path.join(ROOT_PATH, \u0027templates\u0027)]"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"# configure template debugging"}],"source_content_type":"text/x-python","patch_set":52,"id":"ff82abbf_7f422bad","line":362,"range":{"start_line":362,"start_character":0,"end_line":362,"end_character":28},"in_reply_to":"ff82abbf_776116a9","updated":"2017-11-28 15:01:24.000000000","message":"My understanding is same too.","commit_id":"abfe4a30d9304b125876e3cf02b563e21f96d61f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"c33c3ef2a6c91ec43dbb6defd3c664192ca9fe6f","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    _LOG.warning(\"No local_settings file found.\")"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"# configure templates"},{"line_number":362,"context_line":"if not TEMPLATES[0][\u0027DIRS\u0027]:"},{"line_number":363,"context_line":"    TEMPLATES[0][\u0027DIRS\u0027] \u003d [os.path.join(ROOT_PATH, \u0027templates\u0027)]"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"# configure template debugging"}],"source_content_type":"text/x-python","patch_set":52,"id":"ff82abbf_776116a9","line":362,"range":{"start_line":362,"start_character":0,"end_line":362,"end_character":28},"in_reply_to":"ff82abbf_d1b91215","updated":"2017-11-27 09:56:01.000000000","message":"This was a trick to use a computed value here — the defaults had None value in this place. That file is no longer part of this patch, so I will remove it — we can always add it later on if it\u0027s still needed.","commit_id":"abfe4a30d9304b125876e3cf02b563e21f96d61f"}],"openstack_dashboard/utils/config.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8435f13d197431caef8a29c6b26d1b15ead79cba","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return themes"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def apply_config(config, module_name):"},{"line_number":83,"context_line":"    \"\"\"Apply the configuration on the specified settings module.\"\"\""},{"line_number":84,"context_line":"    module \u003d sys.modules[module_name]"},{"line_number":85,"context_line":"    apply_config_group(config.django, module)"}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_02969a3d","line":82,"updated":"2017-01-12 03:51:33.000000000","message":"Continuing the conversation from patchset 34:\n\n1. globals() is writeable\n\n2. globals() *is* the contents of the module that it is invoked in\n\nPlease don\u0027t use sys.modules via a name when globals() can be used (as in this case) since the module system means we\u0027re accessing globals() indirectly. By passing in the name, and using sys.modules[name] you\u0027re just accessing globals() anyway.","commit_id":"5ee0c79486bc87b35e3f1e20a08329093f7f9358"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"de0dfe972fd781c84628f06179d363550b4b458c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return themes"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def apply_config(config, module_name):"},{"line_number":83,"context_line":"    \"\"\"Apply the configuration on the specified settings module.\"\"\""},{"line_number":84,"context_line":"    module \u003d sys.modules[module_name]"},{"line_number":85,"context_line":"    apply_config_group(config.django, module)"}],"source_content_type":"text/x-python","patch_set":36,"id":"9a57fde8_3810cd4e","line":82,"in_reply_to":"9a57fde8_d2fde26f","updated":"2017-01-12 09:05:29.000000000","message":"Done","commit_id":"5ee0c79486bc87b35e3f1e20a08329093f7f9358"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"73ff0d15171d4eb68d00d09fcac265615e8e8231","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return themes"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def apply_config(config, module_name):"},{"line_number":83,"context_line":"    \"\"\"Apply the configuration on the specified settings module.\"\"\""},{"line_number":84,"context_line":"    module \u003d sys.modules[module_name]"},{"line_number":85,"context_line":"    apply_config_group(config.django, module)"}],"source_content_type":"text/x-python","patch_set":36,"id":"9a57fde8_d2fde26f","line":82,"in_reply_to":"ba5201f7_02969a3d","updated":"2017-01-12 08:15:26.000000000","message":"I\u0027m sorry, you are right, I assumed it would behave the same way as locals(), which returns a new dictionary that you can modify, but that won\u0027t affect the original namespace in any way. I will make the change.","commit_id":"5ee0c79486bc87b35e3f1e20a08329093f7f9358"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c5f5a8ddf21b28d280f024c57cdedc4cad852233","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def apply_config_group(config_group, target, prefix\u003dNone):"},{"line_number":48,"context_line":"    for key, value in six.iteritems(config_group):"},{"line_number":49,"context_line":"        name \u003d key.upper()"},{"line_number":50,"context_line":"        if prefix:"},{"line_number":51,"context_line":"            name \u003d \u0027_\u0027.join([prefix.upper(), name])"},{"line_number":52,"context_line":"        target[name] \u003d value"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"ff82abbf_710606d1","line":51,"range":{"start_line":49,"start_character":8,"end_line":51,"end_character":51},"updated":"2017-11-27 08:37:12.000000000","message":"Hopefully oslo.config option definitions are easy to understand from the context of usual ini-based files, so I think it would be nice if we have some more flexible mapping. I am exploring a way to do this now. As the initial patch, I am okay with it.","commit_id":"abfe4a30d9304b125876e3cf02b563e21f96d61f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"c33c3ef2a6c91ec43dbb6defd3c664192ca9fe6f","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def apply_config_group(config_group, target, prefix\u003dNone):"},{"line_number":48,"context_line":"    for key, value in six.iteritems(config_group):"},{"line_number":49,"context_line":"        name \u003d key.upper()"},{"line_number":50,"context_line":"        if prefix:"},{"line_number":51,"context_line":"            name \u003d \u0027_\u0027.join([prefix.upper(), name])"},{"line_number":52,"context_line":"        target[name] \u003d value"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"ff82abbf_97d85a7b","line":51,"range":{"start_line":49,"start_character":8,"end_line":51,"end_character":51},"in_reply_to":"ff82abbf_710606d1","updated":"2017-11-27 09:56:01.000000000","message":"Our current option names don\u0027t really follow a consistent pattern — or rather they follow several different patterns, depending on when they have been added. I think that having different names in the ini files and different in python would be a big problem, so the correct solution for option names that don\u0027t make sense is to rename those option names globally.","commit_id":"abfe4a30d9304b125876e3cf02b563e21f96d61f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"80b080934d1945d2c2ca6c7193f63bdf43eeb8b9","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def apply_config_group(config_group, target, prefix\u003dNone):"},{"line_number":48,"context_line":"    for key, value in six.iteritems(config_group):"},{"line_number":49,"context_line":"        name \u003d key.upper()"},{"line_number":50,"context_line":"        if prefix:"},{"line_number":51,"context_line":"            name \u003d \u0027_\u0027.join([prefix.upper(), name])"},{"line_number":52,"context_line":"        target[name] \u003d value"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"ff82abbf_51ef1b1d","line":51,"range":{"start_line":49,"start_character":8,"end_line":51,"end_character":51},"in_reply_to":"ff82abbf_97d85a7b","updated":"2017-11-28 15:01:24.000000000","message":"I agree that our current option names do not follow a consistent pattern. Rob made a good clean up in the last cycle in the configuration guide and it has good grouping (at least to me)[1].\n\nFor example, I would like to see all glance related options in a single group [2]. This approach does not allow this and this is the reason I wrote this comment.\n\nIMHO it is better to organize oslo.config configs into appropriate groups (at least in ini-based configs), but it seems to need more discussion and clarify the goal of this blueprint.\n\n[1] https://docs.openstack.org/horizon/latest/configuration/settings.html\n[2] https://docs.openstack.org/horizon/latest/configuration/settings.html#glance","commit_id":"abfe4a30d9304b125876e3cf02b563e21f96d61f"}],"openstack_dashboard/utils/config_django.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"e315bf3e09848aef8878312263e1533c3f0ec927","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"},{"line_number":36,"context_line":"        O(\u0027time_zone\u0027, t.String(), default\u003d\u0027UTC\u0027),"},{"line_number":37,"context_line":"        O(\u0027logging\u0027, ct.Literal({\"\": None}), default\u003d{"},{"line_number":38,"context_line":"            \u0027version\u0027: 1,"},{"line_number":39,"context_line":"            \u0027disable_existing_loggers\u0027: False,"},{"line_number":40,"context_line":"            \u0027formatters\u0027: {"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba5201f7_13412e3a","line":37,"updated":"2016-12-29 04:49:03.000000000","message":"Python\u0027s standard logging already has an ini-style format, could we not use that?","commit_id":"73532cff37381d880b405f7c981bdab0da914687"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"4dd2e2d6a97231e05ed7987ae65d311ddaf1931a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        O(\u0027secure_proxy_ssl_header\u0027, t.List(t.String())),"},{"line_number":35,"context_line":"        O(\u0027secret_key\u0027, t.String()),"},{"line_number":36,"context_line":"        O(\u0027time_zone\u0027, t.String(), default\u003d\u0027UTC\u0027),"},{"line_number":37,"context_line":"        O(\u0027logging\u0027, ct.Literal({\"\": None}), default\u003d{"},{"line_number":38,"context_line":"            \u0027version\u0027: 1,"},{"line_number":39,"context_line":"            \u0027disable_existing_loggers\u0027: False,"},{"line_number":40,"context_line":"            \u0027formatters\u0027: {"}],"source_content_type":"text/x-python","patch_set":34,"id":"7a3c09a3_a6c6a165","line":37,"in_reply_to":"ba5201f7_13412e3a","updated":"2017-01-17 18:46:29.000000000","message":"I just realized I never replied to this.\n\nPython\u0027s logging \"ini\" format assumes a separate file (which we could do, actually it would make sense). It is also limited in what can be configured -- not all possible combinations of settings can be achieved, and not all options are available. It would also be tricky to reconcile this with Django, which pretty much forces the python configuration format in its internals -- we would probably need to monkeypatch it.","commit_id":"73532cff37381d880b405f7c981bdab0da914687"}],"openstack_dashboard/utils/config_types.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"e315bf3e09848aef8878312263e1533c3f0ec927","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if not isinstance(result, dict):"},{"line_number":95,"context_line":"                raise ValueError(\u0027Dictionary expected, but %r found.\u0027 % result)"},{"line_number":96,"context_line":"            if spec:"},{"line_number":97,"context_line":"                spec_value \u003d next(iter(spec.values()))  # Yay Python 3!"},{"line_number":98,"context_line":"                for value in result.values():"},{"line_number":99,"context_line":"                    self.validate(value, spec_value)"},{"line_number":100,"context_line":"                spec_key \u003d next(iter(spec.keys()))"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba5201f7_333e32b9","line":97,"updated":"2016-12-29 04:49:03.000000000","message":"or, list(spec.values())[0] which I believe is clearer","commit_id":"73532cff37381d880b405f7c981bdab0da914687"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"60d17d8c8cfd51c38f646f8edfdce4025cebdf47","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if not isinstance(result, dict):"},{"line_number":95,"context_line":"                raise ValueError(\u0027Dictionary expected, but %r found.\u0027 % result)"},{"line_number":96,"context_line":"            if spec:"},{"line_number":97,"context_line":"                spec_value \u003d next(iter(spec.values()))  # Yay Python 3!"},{"line_number":98,"context_line":"                for value in result.values():"},{"line_number":99,"context_line":"                    self.validate(value, spec_value)"},{"line_number":100,"context_line":"                spec_key \u003d next(iter(spec.keys()))"}],"source_content_type":"text/x-python","patch_set":34,"id":"7a3c09a3_86a28597","line":97,"in_reply_to":"ba5201f7_333e32b9","updated":"2017-01-17 18:48:37.000000000","message":"I disagree, and it also does an unnecessary memory allocation.","commit_id":"73532cff37381d880b405f7c981bdab0da914687"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"e315bf3e09848aef8878312263e1533c3f0ec927","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                spec_value \u003d next(iter(spec.values()))  # Yay Python 3!"},{"line_number":98,"context_line":"                for value in result.values():"},{"line_number":99,"context_line":"                    self.validate(value, spec_value)"},{"line_number":100,"context_line":"                spec_key \u003d next(iter(spec.keys()))"},{"line_number":101,"context_line":"                for key in result.keys():"},{"line_number":102,"context_line":"                    self.validate(key, spec_key)"},{"line_number":103,"context_line":"        if isinstance(spec, list):"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba5201f7_534bb659","line":100,"updated":"2016-12-29 04:49:03.000000000","message":"list(spec)[0]\n\nin either case, the .keys() is unnecessary","commit_id":"73532cff37381d880b405f7c981bdab0da914687"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"60d17d8c8cfd51c38f646f8edfdce4025cebdf47","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                spec_value \u003d next(iter(spec.values()))  # Yay Python 3!"},{"line_number":98,"context_line":"                for value in result.values():"},{"line_number":99,"context_line":"                    self.validate(value, spec_value)"},{"line_number":100,"context_line":"                spec_key \u003d next(iter(spec.keys()))"},{"line_number":101,"context_line":"                for key in result.keys():"},{"line_number":102,"context_line":"                    self.validate(key, spec_key)"},{"line_number":103,"context_line":"        if isinstance(spec, list):"}],"source_content_type":"text/x-python","patch_set":34,"id":"7a3c09a3_c6a80d7a","line":100,"in_reply_to":"ba5201f7_534bb659","updated":"2017-01-17 18:48:37.000000000","message":"I believe it is clearer and better shows the intention, not to mention fitting better to the similar line above.","commit_id":"73532cff37381d880b405f7c981bdab0da914687"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"874c7e53431169275d55e04432dbf63d866a7533","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return self.type_._formatter(value)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class URL(types.ConfigType):"},{"line_number":50,"context_line":"    \"\"\"A custom option type for a URL or part of URL.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    CLEAN_SLASH_RE \u003d re.compile(r\u0027(?\u003c!:)//\u0027)"}],"source_content_type":"text/x-python","patch_set":50,"id":"1f485f77_52e0d8cc","line":49,"updated":"2017-11-14 08:22:29.000000000","message":"Can we use oslo_config.types.URI here?","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"141387c133cc881ebaea302ce03a16265214e732","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return self.type_._formatter(value)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class URL(types.ConfigType):"},{"line_number":50,"context_line":"    \"\"\"A custom option type for a URL or part of URL.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    CLEAN_SLASH_RE \u003d re.compile(r\u0027(?\u003c!:)//\u0027)"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_f7220652","line":49,"in_reply_to":"1f485f77_24150c4b","updated":"2017-11-27 10:00:59.000000000","message":"That type doesn\u0027t do the trailing slash sanitization that we are doing here (and that the original settings code does).","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"64813e98b43ed8b096150c6d472f2e2a39685295","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return self.type_._formatter(value)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class URL(types.ConfigType):"},{"line_number":50,"context_line":"    \"\"\"A custom option type for a URL or part of URL.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    CLEAN_SLASH_RE \u003d re.compile(r\u0027(?\u003c!:)//\u0027)"}],"source_content_type":"text/x-python","patch_set":50,"id":"1f485f77_24150c4b","line":49,"in_reply_to":"1f485f77_52e0d8cc","updated":"2017-11-14 19:39:53.000000000","message":"+1 \n\nwe can use oslo_config.cfg.URIOpt for URLs.","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c6fd406dfd512d67696c4b279fec52b86db7b7f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return self.type_._formatter(value)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class URL(types.ConfigType):"},{"line_number":50,"context_line":"    \"\"\"A custom option type for a URL or part of URL.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    CLEAN_SLASH_RE \u003d re.compile(r\u0027(?\u003c!:)//\u0027)"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_bfe4330e","line":49,"in_reply_to":"ff82abbf_f7220652","updated":"2017-11-28 14:32:59.000000000","message":"Perhaps we need to improve oslo.config itself.\n\nUntil then, we can handle such sanitization as a utility function if needed. Having a new type is one of possible approaches, but having such forever does not sound a good idea.\n\nWe don\u0027t have any sanitization at now, so I am not sure we need a new config type. This is my point.","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"64813e98b43ed8b096150c6d472f2e2a39685295","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            encoding.force_text(value))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class Literal(types.ConfigType):"},{"line_number":102,"context_line":"    \"\"\"A custom option type for a Python literal.\"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def __init__(self, spec\u003dNone):"}],"source_content_type":"text/x-python","patch_set":50,"id":"1f485f77_38388c9e","line":101,"updated":"2017-11-14 19:39:53.000000000","message":"Honestly I have a doubt on the need of this type, but I am okay now. we can discuss the usage of this type setting by setting.","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"}],"openstack_dashboard/utils/tests.py":[{"author":{"_account_id":16628,"name":"Beth Elwell","email":"e.r.elwell@gmail.com","username":"bethelwell"},"change_message_id":"70538f2c910bb48fb4533526c8b965031c0bdb2e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import string"},{"line_number":14,"context_line":"import unittest"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from openstack_dashboard.utils import config_types"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a6eadb0_d2469722","line":13,"updated":"2016-12-13 14:58:12.000000000","message":"string unused causing jenkins error","commit_id":"1f12b01eac51a5e49249d41d1543b37b3ea62afe"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0b00153173ac63731d5c6392584bd7586fe654b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":50,"id":"ff82abbf_2f13915e","updated":"2017-11-22 07:13:37.000000000","message":"We have unit tests for utils in openstack_dashboard/test/tests/ so far. It is better to follow the convention.","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"17745a5551d7317a0d770fb0cfe24f777aaf8e2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":50,"id":"ff82abbf_2fddd16f","in_reply_to":"ff82abbf_2f13915e","updated":"2017-11-22 07:19:32.000000000","message":"Done in patch set 52","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"874c7e53431169275d55e04432dbf63d866a7533","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        literal \u003d config_types.Literal([0])"},{"line_number":21,"context_line":"        result \u003d literal(\"[1, 2, 3]\")"},{"line_number":22,"context_line":"        self.assertEqual([1, 2, 3], result)"},{"line_number":23,"context_line":"        with self.assertRaises(ValueError):"},{"line_number":24,"context_line":"            result \u003d literal(\"[1, \u00272\u0027, 3]\")"},{"line_number":25,"context_line":"        literal \u003d config_types.Literal({0: \"\"})"},{"line_number":26,"context_line":"        result \u003d literal(\"{1: \u0027a\u0027, 2: u\u0027b\u0027}\")"}],"source_content_type":"text/x-python","patch_set":50,"id":"1f485f77_527c58ea","line":23,"updated":"2017-11-14 08:22:29.000000000","message":"We can do it w/o \u0027with\u0027 statements:\nself.assertRaises(ValueError, literal, (\"[1, \u00272\u0027, 3]\")","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0b00153173ac63731d5c6392584bd7586fe654b9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        literal \u003d config_types.Literal([0])"},{"line_number":21,"context_line":"        result \u003d literal(\"[1, 2, 3]\")"},{"line_number":22,"context_line":"        self.assertEqual([1, 2, 3], result)"},{"line_number":23,"context_line":"        with self.assertRaises(ValueError):"},{"line_number":24,"context_line":"            result \u003d literal(\"[1, \u00272\u0027, 3]\")"},{"line_number":25,"context_line":"        literal \u003d config_types.Literal({0: \"\"})"},{"line_number":26,"context_line":"        result \u003d literal(\"{1: \u0027a\u0027, 2: u\u0027b\u0027}\")"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_d41ddc73","line":23,"in_reply_to":"1f485f77_527c58ea","updated":"2017-11-22 07:13:37.000000000","message":"Done","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c6fd406dfd512d67696c4b279fec52b86db7b7f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        literal \u003d config_types.Literal([0])"},{"line_number":21,"context_line":"        result \u003d literal(\"[1, 2, 3]\")"},{"line_number":22,"context_line":"        self.assertEqual([1, 2, 3], result)"},{"line_number":23,"context_line":"        with self.assertRaises(ValueError):"},{"line_number":24,"context_line":"            result \u003d literal(\"[1, \u00272\u0027, 3]\")"},{"line_number":25,"context_line":"        literal \u003d config_types.Literal({0: \"\"})"},{"line_number":26,"context_line":"        result \u003d literal(\"{1: \u0027a\u0027, 2: u\u0027b\u0027}\")"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_1fbbdfc4","line":23,"in_reply_to":"ff82abbf_37daae4a","updated":"2017-11-28 14:32:59.000000000","message":"I am fine with using \u0027with\u0027","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"141387c133cc881ebaea302ce03a16265214e732","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        literal \u003d config_types.Literal([0])"},{"line_number":21,"context_line":"        result \u003d literal(\"[1, 2, 3]\")"},{"line_number":22,"context_line":"        self.assertEqual([1, 2, 3], result)"},{"line_number":23,"context_line":"        with self.assertRaises(ValueError):"},{"line_number":24,"context_line":"            result \u003d literal(\"[1, \u00272\u0027, 3]\")"},{"line_number":25,"context_line":"        literal \u003d config_types.Literal({0: \"\"})"},{"line_number":26,"context_line":"        result \u003d literal(\"{1: \u0027a\u0027, 2: u\u0027b\u0027}\")"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_37daae4a","line":23,"in_reply_to":"ff82abbf_d41ddc73","updated":"2017-11-27 10:00:59.000000000","message":"The version with \"with\" is much more readable and I think is actually preferred in the style guide (but I can\u0027t find it). Callbacks are ugly.","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"64813e98b43ed8b096150c6d472f2e2a39685295","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        result \u003d literal(\"[1, 2, 3]\")"},{"line_number":22,"context_line":"        self.assertEqual([1, 2, 3], result)"},{"line_number":23,"context_line":"        with self.assertRaises(ValueError):"},{"line_number":24,"context_line":"            result \u003d literal(\"[1, \u00272\u0027, 3]\")"},{"line_number":25,"context_line":"        literal \u003d config_types.Literal({0: \"\"})"},{"line_number":26,"context_line":"        result \u003d literal(\"{1: \u0027a\u0027, 2: u\u0027b\u0027}\")"},{"line_number":27,"context_line":"        self.assertEqual({1: \u0027a\u0027, 2: u\u0027b\u0027}, result)"}],"source_content_type":"text/x-python","patch_set":50,"id":"1f485f77_38b9accb","line":24,"range":{"start_line":24,"start_character":12,"end_line":24,"end_character":43},"updated":"2017-11-14 19:39:53.000000000","message":"I am confused a bit. If literal() raises ValueError, this does not return anything, so a substitution to result never happens.\n\n\u0027result\u0027 here has no meaning, so I think it is better to drop \u0027result \u003d\u0027 to avoid unnecessary confusion.","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0b00153173ac63731d5c6392584bd7586fe654b9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        result \u003d literal(\"[1, 2, 3]\")"},{"line_number":22,"context_line":"        self.assertEqual([1, 2, 3], result)"},{"line_number":23,"context_line":"        with self.assertRaises(ValueError):"},{"line_number":24,"context_line":"            result \u003d literal(\"[1, \u00272\u0027, 3]\")"},{"line_number":25,"context_line":"        literal \u003d config_types.Literal({0: \"\"})"},{"line_number":26,"context_line":"        result \u003d literal(\"{1: \u0027a\u0027, 2: u\u0027b\u0027}\")"},{"line_number":27,"context_line":"        self.assertEqual({1: \u0027a\u0027, 2: u\u0027b\u0027}, result)"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_94175452","line":24,"range":{"start_line":24,"start_character":12,"end_line":24,"end_character":43},"in_reply_to":"1f485f77_38b9accb","updated":"2017-11-22 07:13:37.000000000","message":"Done","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"141387c133cc881ebaea302ce03a16265214e732","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        result \u003d literal(\"[1, 2, 3]\")"},{"line_number":22,"context_line":"        self.assertEqual([1, 2, 3], result)"},{"line_number":23,"context_line":"        with self.assertRaises(ValueError):"},{"line_number":24,"context_line":"            result \u003d literal(\"[1, \u00272\u0027, 3]\")"},{"line_number":25,"context_line":"        literal \u003d config_types.Literal({0: \"\"})"},{"line_number":26,"context_line":"        result \u003d literal(\"{1: \u0027a\u0027, 2: u\u0027b\u0027}\")"},{"line_number":27,"context_line":"        self.assertEqual({1: \u0027a\u0027, 2: u\u0027b\u0027}, result)"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_d7ea62d6","line":24,"range":{"start_line":24,"start_character":12,"end_line":24,"end_character":43},"in_reply_to":"ff82abbf_94175452","updated":"2017-11-27 10:00:59.000000000","message":"It\u0027s to keep the pattern with the other calls, to make it all easier to read.","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c6fd406dfd512d67696c4b279fec52b86db7b7f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        result \u003d literal(\"[1, 2, 3]\")"},{"line_number":22,"context_line":"        self.assertEqual([1, 2, 3], result)"},{"line_number":23,"context_line":"        with self.assertRaises(ValueError):"},{"line_number":24,"context_line":"            result \u003d literal(\"[1, \u00272\u0027, 3]\")"},{"line_number":25,"context_line":"        literal \u003d config_types.Literal({0: \"\"})"},{"line_number":26,"context_line":"        result \u003d literal(\"{1: \u0027a\u0027, 2: u\u0027b\u0027}\")"},{"line_number":27,"context_line":"        self.assertEqual({1: \u0027a\u0027, 2: u\u0027b\u0027}, result)"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_bfc99359","line":24,"range":{"start_line":24,"start_character":12,"end_line":24,"end_character":43},"in_reply_to":"ff82abbf_d7ea62d6","updated":"2017-11-28 14:32:59.000000000","message":"variable assignment really confuses me, but I might be the only one.","commit_id":"26c77e8418a452225e586034a6462e83baf6caf7"}]}
