)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"b5022b9f92afa5399973643572624b78ef4f6eb8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"In drawer, handle \u0027priority\u0027 attribute conversely against rows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027priority\u0027 attribute has be handled in drawer [1][2], but the behavior is same as in rows."},{"line_number":10,"context_line":"The behavior is that the items which have lower priority are hidden from both of row and drawer when widow width is narrower."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Drawer is used for the supplements against the row, so it should be handled conversely."},{"line_number":13,"context_line":"It means that items appear in drawer when they are hidden from row."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixes it."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a461143_eaf0eb68","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":67},"updated":"2017-02-02 20:09:38.000000000","message":"Just a nit. accordingly with Openstack Development best practices commit messages lines should be under 72 characters\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"003c0ee1f34bdaf8407580b1d1d668fb333c5969"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"4ea4340836850c3e171e72788018558e312e6141","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"In drawer, handle \u0027priority\u0027 attribute conversely against rows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027priority\u0027 attribute has be handled in drawer [1][2], but the behavior is same as in rows."},{"line_number":10,"context_line":"The behavior is that the items which have lower priority are hidden from both of row and drawer when widow width is narrower."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Drawer is used for the supplements against the row, so it should be handled conversely."},{"line_number":13,"context_line":"It means that items appear in drawer when they are hidden from row."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixes it."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa31d9ce_2017b352","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":67},"in_reply_to":"3a461143_eaf0eb68","updated":"2017-02-10 05:01:53.000000000","message":"Done","commit_id":"003c0ee1f34bdaf8407580b1d1d668fb333c5969"}],"horizon/static/framework/widgets/property/hz-resource-property.directive.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"5f916d2b545547e4b5e85ac3191996f6a930f0b3","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    function link(scope, element) {"},{"line_number":66,"context_line":"      var config \u003d scope.ctrl.config;"},{"line_number":67,"context_line":"      var priority \u003d config.priority ? config.priority : 1;"},{"line_number":68,"context_line":"      var style \u003d priority \u003e 1 ? \u0027rsp-alt-p\u0027 : \u0027rsp-p\u0027;"},{"line_number":69,"context_line":"      element.addClass(style + priority);"},{"line_number":70,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba5201f7_83ed7ef1","line":67,"updated":"2017-01-03 19:33:45.000000000","message":"We are also not doing a check for negative or non-integer priority. I dont want to over complicate this function, but we should at least log a warning here.","commit_id":"58cd96101609f802bf9518883201e21a76fd25ea"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"8a49a1c324f450c6c54e5fbc5018eecfffb3964a","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    function link(scope, element) {"},{"line_number":66,"context_line":"      var config \u003d scope.ctrl.config;"},{"line_number":67,"context_line":"      var priority \u003d config.priority ? config.priority : 1;"},{"line_number":68,"context_line":"      var style \u003d priority \u003e 1 ? \u0027rsp-alt-p\u0027 : \u0027rsp-p\u0027;"},{"line_number":69,"context_line":"      element.addClass(style + priority);"},{"line_number":70,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":2,"id":"7a3c09a3_2fb10890","line":67,"in_reply_to":"ba5201f7_83ed7ef1","updated":"2017-01-16 08:41:26.000000000","message":"Done. But I tried to check priority \"a\" or 0 in this place, it doesn\u0027t seem enough (rsp-pa or rsp-p0 was set in table row). the hz-dynamic-table seems to need the check.","commit_id":"58cd96101609f802bf9518883201e21a76fd25ea"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"b5022b9f92afa5399973643572624b78ef4f6eb8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    function link(scope, element) {"},{"line_number":67,"context_line":"      var config \u003d scope.ctrl.config;"},{"line_number":68,"context_line":"      var priority \u003d config.priority ? config.priority : 1;"},{"line_number":69,"context_line":"      if (angular.isNumber(priority) \u003d\u003d\u003d false || priority \u003c 1) {"},{"line_number":70,"context_line":"        priority \u003d 1;"},{"line_number":71,"context_line":"        $log.warn(\"Please set an integer of 1 or more for priority of hz-resource-property. \" +"},{"line_number":72,"context_line":"          \"Otherwise priority is set 1.\");"}],"source_content_type":"text/javascript","patch_set":6,"id":"3a461143_aa4423b7","line":69,"range":{"start_line":69,"start_character":10,"end_line":69,"end_character":46},"updated":"2017-02-02 20:09:38.000000000","message":"I think this could be simplified to !angular.isNumber(priority)","commit_id":"003c0ee1f34bdaf8407580b1d1d668fb333c5969"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"4ea4340836850c3e171e72788018558e312e6141","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    function link(scope, element) {"},{"line_number":67,"context_line":"      var config \u003d scope.ctrl.config;"},{"line_number":68,"context_line":"      var priority \u003d config.priority ? config.priority : 1;"},{"line_number":69,"context_line":"      if (angular.isNumber(priority) \u003d\u003d\u003d false || priority \u003c 1) {"},{"line_number":70,"context_line":"        priority \u003d 1;"},{"line_number":71,"context_line":"        $log.warn(\"Please set an integer of 1 or more for priority of hz-resource-property. \" +"},{"line_number":72,"context_line":"          \"Otherwise priority is set 1.\");"}],"source_content_type":"text/javascript","patch_set":6,"id":"fa31d9ce_003b8fec","line":69,"range":{"start_line":69,"start_character":10,"end_line":69,"end_character":46},"in_reply_to":"3a461143_aa4423b7","updated":"2017-02-10 05:01:53.000000000","message":"Done","commit_id":"003c0ee1f34bdaf8407580b1d1d668fb333c5969"},{"author":{"_account_id":16628,"name":"Beth Elwell","email":"e.r.elwell@gmail.com","username":"bethelwell"},"change_message_id":"b88fcec957d8c376b903f37d0180a9fa6d940e19","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      if (!angular.isNumber(priority) || priority \u003c 1) {"},{"line_number":70,"context_line":"        priority \u003d 1;"},{"line_number":71,"context_line":"        $log.warn(\"Please set an integer of 1 or more for priority of hz-resource-property. \" +"},{"line_number":72,"context_line":"          \"Otherwise priority is set 1.\");"},{"line_number":73,"context_line":"      }"},{"line_number":74,"context_line":"      var style \u003d priority \u003e 1 ? \u0027rsp-alt-p\u0027 : \u0027rsp-p\u0027;"},{"line_number":75,"context_line":"      element.addClass(style + priority);"}],"source_content_type":"text/javascript","patch_set":8,"id":"ba2be162_5ee187cf","line":72,"updated":"2017-03-02 12:43:24.000000000","message":"might be worth adding note that 1 \u003d\u003d high priority and/or what the highest priority number is - if a user isn\u0027t setting priority at all they might not be aware of this?","commit_id":"8aaa7d9b6086d3ceedce25e1ba6687706f7c0b08"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"2a55adae818d8d88b07da3321330007565510c79","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      if (!angular.isNumber(priority) || priority \u003c 1) {"},{"line_number":70,"context_line":"        priority \u003d 1;"},{"line_number":71,"context_line":"        $log.warn(\"Please set an integer of 1 or more for priority of hz-resource-property. \" +"},{"line_number":72,"context_line":"          \"Otherwise priority is set 1.\");"},{"line_number":73,"context_line":"      }"},{"line_number":74,"context_line":"      var style \u003d priority \u003e 1 ? \u0027rsp-alt-p\u0027 : \u0027rsp-p\u0027;"},{"line_number":75,"context_line":"      element.addClass(style + priority);"}],"source_content_type":"text/javascript","patch_set":8,"id":"ba2be162_aa0bf68c","line":72,"in_reply_to":"ba2be162_5ee187cf","updated":"2017-03-03 04:00:42.000000000","message":"Done","commit_id":"8aaa7d9b6086d3ceedce25e1ba6687706f7c0b08"}],"horizon/static/framework/widgets/property/hz-resource-property.directive.spec.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"5f916d2b545547e4b5e85ac3191996f6a930f0b3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      $scope.$digest();"},{"line_number":48,"context_line":"      expect(element.hasClass(\"rsp-alt-p2\")).toBeTruthy();"},{"line_number":49,"context_line":"    });"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    it(\"sets class when item\u0027s priority is not set\", function() {"},{"line_number":52,"context_line":"      $scope.item \u003d {name: \u0027value of name\u0027};"},{"line_number":53,"context_line":"      // table column doesn\u0027t have an attribute of \u0027priority\u0027"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba5201f7_a3d36237","line":50,"updated":"2017-01-03 19:33:45.000000000","message":"This is a bit of a pain, but we should really add a case for when priority is 1 or 0 as well to cover all cases.","commit_id":"58cd96101609f802bf9518883201e21a76fd25ea"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"8a49a1c324f450c6c54e5fbc5018eecfffb3964a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      $scope.$digest();"},{"line_number":48,"context_line":"      expect(element.hasClass(\"rsp-alt-p2\")).toBeTruthy();"},{"line_number":49,"context_line":"    });"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    it(\"sets class when item\u0027s priority is not set\", function() {"},{"line_number":52,"context_line":"      $scope.item \u003d {name: \u0027value of name\u0027};"},{"line_number":53,"context_line":"      // table column doesn\u0027t have an attribute of \u0027priority\u0027"}],"source_content_type":"text/javascript","patch_set":2,"id":"7a3c09a3_2a3bb6d2","line":50,"in_reply_to":"ba5201f7_a3d36237","updated":"2017-01-16 08:41:26.000000000","message":"Done","commit_id":"58cd96101609f802bf9518883201e21a76fd25ea"},{"author":{"_account_id":16628,"name":"Beth Elwell","email":"e.r.elwell@gmail.com","username":"bethelwell"},"change_message_id":"b88fcec957d8c376b903f37d0180a9fa6d940e19","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      expect(element.hasClass(\"rsp-alt-p2\")).toBeTruthy();"},{"line_number":61,"context_line":"    });"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    it(\"sets class when item\u0027s priority is set as illegally\", function() {"},{"line_number":64,"context_line":"      $scope.item \u003d {name: \u0027value of name\u0027};"},{"line_number":65,"context_line":"      tableColumnInfo \u003d [{id: \u0027name\u0027, priority: 0 }];"},{"line_number":66,"context_line":"      spyOn(registry, \u0027getResourceType\u0027).and.returnValue(testResource);"}],"source_content_type":"text/javascript","patch_set":8,"id":"ba2be162_1ed8ef1c","line":63,"updated":"2017-03-02 12:43:24.000000000","message":"probably don\u0027t need the \u0027as\u0027 here","commit_id":"8aaa7d9b6086d3ceedce25e1ba6687706f7c0b08"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"2a55adae818d8d88b07da3321330007565510c79","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      expect(element.hasClass(\"rsp-alt-p2\")).toBeTruthy();"},{"line_number":61,"context_line":"    });"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    it(\"sets class when item\u0027s priority is set as illegally\", function() {"},{"line_number":64,"context_line":"      $scope.item \u003d {name: \u0027value of name\u0027};"},{"line_number":65,"context_line":"      tableColumnInfo \u003d [{id: \u0027name\u0027, priority: 0 }];"},{"line_number":66,"context_line":"      spyOn(registry, \u0027getResourceType\u0027).and.returnValue(testResource);"}],"source_content_type":"text/javascript","patch_set":8,"id":"ba2be162_cafcaa74","line":63,"in_reply_to":"ba2be162_1ed8ef1c","updated":"2017-03-03 04:00:42.000000000","message":"Done","commit_id":"8aaa7d9b6086d3ceedce25e1ba6687706f7c0b08"}]}