)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17814,"name":"fengzhr","email":"fengzhr@awcloud.com","username":"space"},"change_message_id":"9849df7ec5d78687c615bc8eac37ad09217c8972","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"If the flavor_id not in full_flavors, don\u0027t make a new API request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Flavours are cached from api.nova.flavor_list(), therefore if we have"},{"line_number":10,"context_line":"machine for which flavour is not in the obtained list, it means the"},{"line_number":11,"context_line":"machine has been created using flavour which is not available anymore."},{"line_number":12,"context_line":"Additional API calls are just decreasing the performance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_2d420c11","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":8},"updated":"2017-03-20 01:51:38.000000000","message":"Flavors","commit_id":"fa05da78650f2f57e9cc78e3ba001274474a9999"},{"author":{"_account_id":23757,"name":"Mateusz Kowalski","email":"mko@redhat.com","username":"makowals"},"change_message_id":"f2c4df5c76a4f1147eb74d85f2e100f548035280","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"If the flavor_id not in full_flavors, don\u0027t make a new API request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Flavours are cached from api.nova.flavor_list(), therefore if we have"},{"line_number":10,"context_line":"machine for which flavour is not in the obtained list, it means the"},{"line_number":11,"context_line":"machine has been created using flavour which is not available anymore."},{"line_number":12,"context_line":"Additional API calls are just decreasing the performance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_d98cd681","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":8},"in_reply_to":"1a1ced50_2d420c11","updated":"2017-03-20 10:04:19.000000000","message":"Can any native speaker comment on this ?\n\nhttps://en.oxforddictionaries.com/definition/flavour","commit_id":"fa05da78650f2f57e9cc78e3ba001274474a9999"},{"author":{"_account_id":16251,"name":"Stefan Paetow","email":"stefan.paetow@jisc.ac.uk","username":"spaetow"},"change_message_id":"8fffd8e9dcd980f48421be08d89fcb737a2e25f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"If the flavor_id not in full_flavors, don\u0027t make a new API request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Flavours are cached from api.nova.flavor_list(), therefore if we have"},{"line_number":10,"context_line":"machine for which flavour is not in the obtained list, it means the"},{"line_number":11,"context_line":"machine has been created using flavour which is not available anymore."},{"line_number":12,"context_line":"Additional API calls are just decreasing the performance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_06428510","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":8},"in_reply_to":"1a1ced50_d98cd681","updated":"2017-03-20 11:29:51.000000000","message":"As far as I (a European) is concerned, flavour is fine. But if Openstack in general insists on using the American style (flavor), then I guess it should be corrected.","commit_id":"fa05da78650f2f57e9cc78e3ba001274474a9999"},{"author":{"_account_id":17814,"name":"fengzhr","email":"fengzhr@awcloud.com","username":"space"},"change_message_id":"9849df7ec5d78687c615bc8eac37ad09217c8972","unresolved":false,"context_lines":[{"line_number":7,"context_line":"If the flavor_id not in full_flavors, don\u0027t make a new API request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Flavours are cached from api.nova.flavor_list(), therefore if we have"},{"line_number":10,"context_line":"machine for which flavour is not in the obtained list, it means the"},{"line_number":11,"context_line":"machine has been created using flavour which is not available anymore."},{"line_number":12,"context_line":"Additional API calls are just decreasing the performance."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_ad56fccf","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":25},"updated":"2017-03-20 01:51:38.000000000","message":"flavor","commit_id":"fa05da78650f2f57e9cc78e3ba001274474a9999"},{"author":{"_account_id":17814,"name":"fengzhr","email":"fengzhr@awcloud.com","username":"space"},"change_message_id":"9849df7ec5d78687c615bc8eac37ad09217c8972","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Flavours are cached from api.nova.flavor_list(), therefore if we have"},{"line_number":10,"context_line":"machine for which flavour is not in the obtained list, it means the"},{"line_number":11,"context_line":"machine has been created using flavour which is not available anymore."},{"line_number":12,"context_line":"Additional API calls are just decreasing the performance."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I190ae0bd70fc19a9d2d402a808f465c23c842fa7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_ed5e34e8","line":11,"range":{"start_line":11,"start_character":31,"end_line":11,"end_character":38},"updated":"2017-03-20 01:51:38.000000000","message":"flavor","commit_id":"fa05da78650f2f57e9cc78e3ba001274474a9999"}],"openstack_dashboard/dashboards/project/instances/views.py":[{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"00b7878be960fd8e550d1b2c33badc2c24e90b49","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Gather our flavors and images and correlate our instances to them"},{"line_number":74,"context_line":"        try:"},{"line_number":75,"context_line":"            flavors \u003d api.nova.flavor_list(self.request)"},{"line_number":76,"context_line":"        except Exception:"},{"line_number":77,"context_line":"            flavors \u003d []"},{"line_number":78,"context_line":"            exceptions.handle(self.request, ignore\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_1c27e8ca","side":"PARENT","line":75,"updated":"2017-01-11 22:26:31.000000000","message":"if this fails, flavors will be an empty list","commit_id":"29beb99e93eb56d74d4e08e90cd824677fdcd155"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"00b7878be960fd8e550d1b2c33badc2c24e90b49","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    self.request,"},{"line_number":113,"context_line":"                    message\u003d_(\u0027Unable to retrieve IP addresses from Neutron.\u0027),"},{"line_number":114,"context_line":"                    ignore\u003dTrue)"},{"line_number":115,"context_line":"            full_flavors \u003d OrderedDict([(str(flavor.id), flavor)"},{"line_number":116,"context_line":"                                       for flavor in flavors])"},{"line_number":117,"context_line":"            image_map \u003d OrderedDict([(str(image.id), image)"},{"line_number":118,"context_line":"                                    for image in images])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_9c19188b","side":"PARENT","line":115,"updated":"2017-01-11 22:26:31.000000000","message":"if flavors is an empty list then, full_flavors will be an empty Dict","commit_id":"29beb99e93eb56d74d4e08e90cd824677fdcd155"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"00b7878be960fd8e550d1b2c33badc2c24e90b49","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                            instance.image \u003d image_map[instance.image[\u0027id\u0027]]"},{"line_number":127,"context_line":"                try:"},{"line_number":128,"context_line":"                    flavor_id \u003d instance.flavor[\"id\"]"},{"line_number":129,"context_line":"                    if flavor_id in full_flavors:"},{"line_number":130,"context_line":"                        instance.full_flavor \u003d full_flavors[flavor_id]"},{"line_number":131,"context_line":"                    else:"},{"line_number":132,"context_line":"                        # If the flavor_id is not in full_flavors list,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_af2ce099","side":"PARENT","line":129,"updated":"2017-01-11 22:26:31.000000000","message":"if full_flavors is empty for some reason, then you\u0027ll need the api call in the \u0027else\u0027 to get try to get the flavor data","commit_id":"29beb99e93eb56d74d4e08e90cd824677fdcd155"},{"author":{"_account_id":16251,"name":"Stefan Paetow","email":"stefan.paetow@jisc.ac.uk","username":"spaetow"},"change_message_id":"893833d271e1c33017653409f1e2a8bba478abdc","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                            instance.image \u003d image_map[instance.image[\u0027id\u0027]]"},{"line_number":127,"context_line":"                try:"},{"line_number":128,"context_line":"                    flavor_id \u003d instance.flavor[\"id\"]"},{"line_number":129,"context_line":"                    if flavor_id in full_flavors:"},{"line_number":130,"context_line":"                        instance.full_flavor \u003d full_flavors[flavor_id]"},{"line_number":131,"context_line":"                    else:"},{"line_number":132,"context_line":"                        # If the flavor_id is not in full_flavors list,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_efb0d8df","side":"PARENT","line":129,"in_reply_to":"9a57fde8_afed5927","updated":"2017-03-16 11:38:46.000000000","message":"Would it make sense to add the message \u0027Unable to retrieve...\u0027 if flavor_id is *not* in full_flavors? Or amend it to say \u0027Unknown flavor for instance %s\u0027? Just a thought... At least then you *log* that the instance doesn\u0027t have a recognised flavour, especially when someone then wonders why that instance doesn\u0027t show one. :-)","commit_id":"29beb99e93eb56d74d4e08e90cd824677fdcd155"},{"author":{"_account_id":23757,"name":"Mateusz Kowalski","email":"mko@redhat.com","username":"makowals"},"change_message_id":"a0213c45ad9cf8e7e0d9d3cc074b9e0b6b7dea0a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                            instance.image \u003d image_map[instance.image[\u0027id\u0027]]"},{"line_number":127,"context_line":"                try:"},{"line_number":128,"context_line":"                    flavor_id \u003d instance.flavor[\"id\"]"},{"line_number":129,"context_line":"                    if flavor_id in full_flavors:"},{"line_number":130,"context_line":"                        instance.full_flavor \u003d full_flavors[flavor_id]"},{"line_number":131,"context_line":"                    else:"},{"line_number":132,"context_line":"                        # If the flavor_id is not in full_flavors list,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a57fde8_afed5927","side":"PARENT","line":129,"in_reply_to":"ba5201f7_af2ce099","updated":"2017-01-12 07:21:55.000000000","message":"But this is exactly what I don\u0027t want to do. If full_flavors does not contain flavor_id (for whatever reason), there is a flood of API calls because it calls API for each loop iteration.\n\nOne of the cases is if machines are using flavor_id which is not available anymore. Then it\u0027s not present in flavors -- so also in full_flavors -- and the performance is awful (number of API calls \u003d\u003d number of machines).","commit_id":"29beb99e93eb56d74d4e08e90cd824677fdcd155"},{"author":{"_account_id":16251,"name":"Stefan Paetow","email":"stefan.paetow@jisc.ac.uk","username":"spaetow"},"change_message_id":"37ceb1114bc5de78f67cdc25b25d856a379ff5e8","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                if flavor_id in full_flavors:"},{"line_number":130,"context_line":"                    instance.full_flavor \u003d full_flavors[flavor_id]"},{"line_number":131,"context_line":"                else:"},{"line_number":132,"context_line":"                    # If the flavor_id is not in full_flavors list, put an info"},{"line_number":133,"context_line":"                    # in the log file"},{"line_number":134,"context_line":"                    msg \u003d (\u0027Unable to retrieve flavor \"%s\" for instance \"%s\".\u0027"},{"line_number":135,"context_line":"                           % (flavor_id, instance.id))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a1ff146_569c2069","line":132,"range":{"start_line":132,"start_character":72,"end_line":132,"end_character":74},"updated":"2017-03-16 13:19:44.000000000","message":"Delete \u0027an\u0027, then this is good to go IMO.","commit_id":"43822d1fd3660f65ee8d993f625022d3cb191558"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"ae285d212e40fb25ff78395acb9ec17aa6a01a6b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                else:"},{"line_number":132,"context_line":"                    # If the flavor_id is not in full_flavors list, put info"},{"line_number":133,"context_line":"                    # in the log file"},{"line_number":134,"context_line":"                    msg \u003d (\u0027Unable to retrieve flavor \"%s\" for instance \"%s\".\u0027"},{"line_number":135,"context_line":"                           % (flavor_id, instance.id))"},{"line_number":136,"context_line":"                    LOG.info(msg)"},{"line_number":137,"context_line":"        return instances"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_b51afe6c","line":134,"updated":"2017-03-17 00:11:30.000000000","message":"I think the logging should be removed as well. The message doesn\u0027t make much sense since no api request is made.","commit_id":"2364fbcb348108719b1ba1efdecdcf70b70c49a2"},{"author":{"_account_id":16251,"name":"Stefan Paetow","email":"stefan.paetow@jisc.ac.uk","username":"spaetow"},"change_message_id":"8bdd168f2b81e143fd25fcfa1f4e493e5c700c97","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                else:"},{"line_number":132,"context_line":"                    # If the flavor_id is not in full_flavors list, put info"},{"line_number":133,"context_line":"                    # in the log file"},{"line_number":134,"context_line":"                    msg \u003d (\u0027Unable to retrieve flavor \"%s\" for instance \"%s\".\u0027"},{"line_number":135,"context_line":"                           % (flavor_id, instance.id))"},{"line_number":136,"context_line":"                    LOG.info(msg)"},{"line_number":137,"context_line":"        return instances"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_aa252bc3","line":134,"in_reply_to":"1a1ced50_b51afe6c","updated":"2017-03-17 12:10:39.000000000","message":"I disagree. Given that at the Milan Mid Cycle Ops meetup the logging/monitoring sessions indicated that operators would like to see *more* logging (as well as consistency in the logging formats), you would want to actually log when the flavour of an image is not in the existing flavours list. This is to be *helpful*.","commit_id":"2364fbcb348108719b1ba1efdecdcf70b70c49a2"}]}