)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17505,"name":"Saverio Proto","email":"saverio.proto@switch.ch","username":"zioproto"},"change_message_id":"326494b7eba8e6bf44bbfbd2f39eab02312347f7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rob Cresswell \u003crobert.cresswell@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-15 21:00:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add config for default create colume option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the ability to configure the default \"create volume\""},{"line_number":10,"context_line":"value when launching an instance with Cinder enabled."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1f013ff3_a6637adc","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":36},"updated":"2017-05-16 07:22:09.000000000","message":"volume not colume","commit_id":"e75ecedf0cbdc8fafa4998ced6737700f3d97f59"}],"doc/source/topics/settings.rst":[{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"fdf28b741ce22ad54d89b17692bda59972383e78","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        \"disable_instance_snapshot\": False,"},{"line_number":671,"context_line":"        \"disable_volume\": False,"},{"line_number":672,"context_line":"        \"disable_volume_snapshot\": False,"},{"line_number":673,"context_line":"        \"disable_default_volume_creation\": False,"},{"line_number":674,"context_line":"    }"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"A dictionary of settings which can be used to provide the default values for"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f044301_1d97c4ee","line":673,"updated":"2017-05-10 15:14:26.000000000","message":"Why not simply something like: \"enable_default_create_volume\": True ?","commit_id":"f69117299676eafb40b1ae88cd59953631fc6f87"},{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"fdf28b741ce22ad54d89b17692bda59972383e78","unresolved":false,"context_lines":[{"line_number":682,"context_line":"The ``enable_scheduler_hints`` setting specifies whether or not Scheduler Hints"},{"line_number":683,"context_line":"can be provided when launching an instance."},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"The ``disable_default_volume_creation`` setting allows you to do not select by"},{"line_number":686,"context_line":"default the option of creating a volume in the workflow for image and instance"},{"line_number":687,"context_line":"snapshot sources."},{"line_number":688,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f044301_ddb5dc7f","line":685,"updated":"2017-05-10 15:14:26.000000000","message":"This text could be simplified if we inverted the option as suggested above.","commit_id":"f69117299676eafb40b1ae88cd59953631fc6f87"},{"author":{"_account_id":23757,"name":"Mateusz Kowalski","email":"mko@redhat.com","username":"makowals"},"change_message_id":"f99ad19f83ba8ba244edeb7f6c244b1dfceb10e7","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        \"disable_instance_snapshot\": False,"},{"line_number":671,"context_line":"        \"disable_volume\": False,"},{"line_number":672,"context_line":"        \"disable_volume_snapshot\": False,"},{"line_number":673,"context_line":"        \"enable_default_create_volume\": False,"},{"line_number":674,"context_line":"    }"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"A dictionary of settings which can be used to provide the default values for"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f044301_13068c1e","line":673,"updated":"2017-05-10 22:03:14.000000000","message":"This one is enable_ ...","commit_id":"b7aee57954979b53749ddd8270b4e229be44555e"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js":[{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"fdf28b741ce22ad54d89b17692bda59972383e78","unresolved":false,"context_lines":[{"line_number":571,"context_line":"      }"},{"line_number":572,"context_line":"      function onVolumeServiceEnabled() {"},{"line_number":573,"context_line":"        model.volumeBootable \u003d true;"},{"line_number":574,"context_line":"        if (!config || !config.disable_default_volume_creation) {"},{"line_number":575,"context_line":"          novaExtensions"},{"line_number":576,"context_line":"            .ifNameEnabled(\u0027BlockDeviceMappingV2Boot\u0027)"},{"line_number":577,"context_line":"            .then(onBootToVolumeSupported);"}],"source_content_type":"text/javascript","patch_set":5,"id":"3f044301_f8a1c6f9","line":574,"updated":"2017-05-10 15:14:26.000000000","message":"This looks wrong: boot-to-volume should still be supported if \"config.disable_default_volume_creation\" is set, it should just not be the default.","commit_id":"f69117299676eafb40b1ae88cd59953631fc6f87"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.spec.js":[{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"fdf28b741ce22ad54d89b17692bda59972383e78","unresolved":false,"context_lines":[{"line_number":457,"context_line":"          expect(model.allowCreateVolumeFromImage).toBe(false);"},{"line_number":458,"context_line":"        });"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        it(\u0027should disable create volume if disable_default_volume_creation is true\u0027, function() {"},{"line_number":461,"context_line":"          settings.LAUNCH_INSTANCE_DEFAULTS.disable_default_volume_creation \u003d true;"},{"line_number":462,"context_line":"          model.initialize(true);"},{"line_number":463,"context_line":"          scope.$apply();"}],"source_content_type":"text/javascript","patch_set":5,"id":"3f044301_783a56cc","line":460,"updated":"2017-05-10 15:14:26.000000000","message":"The option shouldn\u0027t be disabled, it should just not be selected by default.","commit_id":"f69117299676eafb40b1ae88cd59953631fc6f87"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"f030beeb8d80574233a096e0e85844d663a441a4","unresolved":false,"context_lines":[{"line_number":159,"context_line":"          settings \u003d {"},{"line_number":160,"context_line":"            LAUNCH_INSTANCE_DEFAULTS: {"},{"line_number":161,"context_line":"              config_drive: false,"},{"line_number":162,"context_line":"              enable_default_create_volume: false,"},{"line_number":163,"context_line":"              disable_image: false,"},{"line_number":164,"context_line":"              disable_instance_snapshot: false,"},{"line_number":165,"context_line":"              disable_volume: false,"}],"source_content_type":"text/javascript","patch_set":7,"id":"3f044301_19610306","line":162,"range":{"start_line":162,"start_character":44,"end_line":162,"end_character":49},"updated":"2017-05-11 13:29:05.000000000","message":"We should keep the default at true. While I understand that it used to be false, that change to true was now about a year ago and I dont want to keep changing it back and forth. Exposing the config is enough.","commit_id":"68079c6b9834a45b9472fb19b89b776628e8864e"},{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"777b51afdeff3c3f41a2eeec797a11d69a052cfd","unresolved":false,"context_lines":[{"line_number":493,"context_line":"          model.initialize(true);"},{"line_number":494,"context_line":"          scope.$apply();"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"          expect(model.newInstanceSpec.config_drive).toBe(false);"},{"line_number":497,"context_line":"        });"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        it(\u0027should not set availability zone if the zone list is empty\u0027, function () {"}],"source_content_type":"text/javascript","patch_set":14,"id":"df140735_e4abf5d2","line":496,"updated":"2017-06-06 13:37:34.000000000","message":"I think \"config_drive\" should be \"create_volume_default\".  I\u0027ll push a revised patchset.","commit_id":"dff5eaf13a9b395686f90debb12c811957c1a4cd"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.js":[{"author":{"_account_id":23757,"name":"Mateusz Kowalski","email":"mko@redhat.com","username":"makowals"},"change_message_id":"1cc433bc53fb5183c3ed55e0e228c2c7411ef963","unresolved":false,"context_lines":[{"line_number":433,"context_line":"      if ((selectedSource \u003d\u003d\u003d bootSourceTypes.IMAGE ||"},{"line_number":434,"context_line":"           selectedSource \u003d\u003d\u003d bootSourceTypes.INSTANCE_SNAPSHOT) \u0026\u0026"},{"line_number":435,"context_line":"           $scope.model.volumeBootable \u0026\u0026"},{"line_number":436,"context_line":"           $scope.model.allowCreateVolumeFromImage) {"},{"line_number":437,"context_line":"        $scope.model.newInstanceSpec.vol_create \u003d true;"},{"line_number":438,"context_line":"      } else {"},{"line_number":439,"context_line":"        $scope.model.newInstanceSpec.vol_create \u003d false;"}],"source_content_type":"text/javascript","patch_set":8,"id":"1f013ff3_c274489c","line":436,"updated":"2017-05-15 14:10:00.000000000","message":"Could we please make it clear if this is about \"disabling creating a volume from an image\" or \"disabling creating a volume from an image by default\" ?\n\nI assume it\u0027s the latter, but some variable names indicate it\u0027s the first one","commit_id":"588496f32506388951cf9988e1c331e42f4359df"},{"author":{"_account_id":17505,"name":"Saverio Proto","email":"saverio.proto@switch.ch","username":"zioproto"},"change_message_id":"261c6d4a26514283ce1617efcc024a2f23b8afca","unresolved":false,"context_lines":[{"line_number":433,"context_line":"      if ((selectedSource \u003d\u003d\u003d bootSourceTypes.IMAGE ||"},{"line_number":434,"context_line":"           selectedSource \u003d\u003d\u003d bootSourceTypes.INSTANCE_SNAPSHOT) \u0026\u0026"},{"line_number":435,"context_line":"           $scope.model.volumeBootable \u0026\u0026"},{"line_number":436,"context_line":"           $scope.model.allowCreateVolumeFromImage) {"},{"line_number":437,"context_line":"        $scope.model.newInstanceSpec.vol_create \u003d true;"},{"line_number":438,"context_line":"      } else {"},{"line_number":439,"context_line":"        $scope.model.newInstanceSpec.vol_create \u003d false;"}],"source_content_type":"text/javascript","patch_set":8,"id":"1f013ff3_82e3e005","line":436,"in_reply_to":"1f013ff3_c274489c","updated":"2017-05-15 14:18:16.000000000","message":"It is the latter. But I need help with this patch, that I initially did not start, I just tried to rebase it.","commit_id":"588496f32506388951cf9988e1c331e42f4359df"}],"openstack_dashboard/local/local_settings.py.example":[{"author":{"_account_id":9155,"name":"Eddie Ramirez","email":"eddie.ramirez@intel.com","username":"ediardo"},"change_message_id":"eee2382a302c7f9c7a38f288a61394bc60ae8b6b","unresolved":false,"context_lines":[{"line_number":244,"context_line":"# properties found in the Launch Instance modal."},{"line_number":245,"context_line":"#LAUNCH_INSTANCE_DEFAULTS \u003d {"},{"line_number":246,"context_line":"#    \u0027config_drive\u0027: False,"},{"line_number":247,"context_line":"#    \u0027enable_scheduler_hints\u0027: True,"},{"line_number":248,"context_line":"#    \u0027disable_volume_creation\u0027: False,"},{"line_number":249,"context_line":"#    \u0027disable_image\u0027: False,"},{"line_number":250,"context_line":"#    \u0027disable_instance_snapshot\u0027: False,"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a430d35_ffe5aba3","line":247,"range":{"start_line":247,"start_character":35,"end_line":247,"end_character":36},"updated":"2017-02-07 17:50:22.000000000","message":"I\u0027m glad you noticed this :)","commit_id":"fd4e7e83280224d0e638eddd9b79cccd4797d7b0"},{"author":{"_account_id":9155,"name":"Eddie Ramirez","email":"eddie.ramirez@intel.com","username":"ediardo"},"change_message_id":"eee2382a302c7f9c7a38f288a61394bc60ae8b6b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"#LAUNCH_INSTANCE_DEFAULTS \u003d {"},{"line_number":246,"context_line":"#    \u0027config_drive\u0027: False,"},{"line_number":247,"context_line":"#    \u0027enable_scheduler_hints\u0027: True,"},{"line_number":248,"context_line":"#    \u0027disable_volume_creation\u0027: False,"},{"line_number":249,"context_line":"#    \u0027disable_image\u0027: False,"},{"line_number":250,"context_line":"#    \u0027disable_instance_snapshot\u0027: False,"},{"line_number":251,"context_line":"#    \u0027disable_volume\u0027: False,"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a430d35_9f53c738","line":248,"range":{"start_line":248,"start_character":0,"end_line":248,"end_character":38},"updated":"2017-02-07 17:50:22.000000000","message":"This is OCD Talking (not important): what if we put all disable_volume_* together?","commit_id":"fd4e7e83280224d0e638eddd9b79cccd4797d7b0"},{"author":{"_account_id":23757,"name":"Mateusz Kowalski","email":"mko@redhat.com","username":"makowals"},"change_message_id":"f99ad19f83ba8ba244edeb7f6c244b1dfceb10e7","unresolved":false,"context_lines":[{"line_number":257,"context_line":"#    \u0027disable_instance_snapshot\u0027: False,"},{"line_number":258,"context_line":"#    \u0027disable_volume\u0027: False,"},{"line_number":259,"context_line":"#    \u0027disable_volume_snapshot\u0027: False,"},{"line_number":260,"context_line":"#    \u0027disable_default_volume_creation\u0027: False,"},{"line_number":261,"context_line":"#}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"# The Xen Hypervisor has the ability to set the mount point for volumes"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3f044301_f306801c","line":260,"updated":"2017-05-10 22:03:14.000000000","message":"while that one disable_. They should be consistent","commit_id":"b7aee57954979b53749ddd8270b4e229be44555e"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"2d78c3958d5f5251e2bd5779268e578c43ff9248","unresolved":false,"context_lines":[{"line_number":257,"context_line":"#    \u0027disable_instance_snapshot\u0027: False,"},{"line_number":258,"context_line":"#    \u0027disable_volume\u0027: False,"},{"line_number":259,"context_line":"#    \u0027disable_volume_snapshot\u0027: False,"},{"line_number":260,"context_line":"#    \u0027enable_default_create_volume\u0027: True,"},{"line_number":261,"context_line":"#}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"# The Xen Hypervisor has the ability to set the mount point for volumes"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"ff0f0b1f_9c3a3796","line":260,"updated":"2017-05-26 03:17:43.000000000","message":"Should be \"create_volume_default\".","commit_id":"c10c7ff645451ed4d6a6597dbb2626f7f8e0d706"}]}
