)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4054376771ef8c25289f7d16f55643fa6eb51ea3","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages"},{"line_number":13,"context_line":"Change-Id: I51f50935f1eeffe4960562d6309dfdf05814e595"},{"line_number":14,"context_line":"Closes-Bug: #1661262"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ffe62b97_51d18c22","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":20},"updated":"2017-03-28 19:52:08.000000000","message":"The bug was marked as duplicate of bug 1596829 so I updated the commit message.","commit_id":"a62ef10e33e9d39e08fc6debaaf3d87ed40a51af"}],"horizon/base.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"86f1a187ef48cac64a5c7a2fb800ba4b0e699bb5","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        except Exception as exc:"},{"line_number":310,"context_line":"            # Logging here since this will often be called in a template"},{"line_number":311,"context_line":"            # where the exception would be hidden."},{"line_number":312,"context_line":"            LOG.info(\"Error reversing absolute URL for %(self)s: %(exc)s\","},{"line_number":313,"context_line":"                     {\u0027self\u0027: self, \u0027exc\u0027: exc})"},{"line_number":314,"context_line":"            raise"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_8703b90c","line":312,"range":{"start_line":312,"start_character":55,"end_line":312,"end_character":72},"updated":"2017-03-02 11:49:32.000000000","message":"We currently do not translate log message in horizon, so the positional variables are okay. However I think it is better to follow the guideline for developer to forget to follow the guideline for translatable messages.\n\nChanging % to , is the right change.","commit_id":"1f3d0c224141392d0f0ea71497991950dd12cb3a"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"dbd033273290910772aa51c8a2b96f80845c0e06","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        except Exception as exc:"},{"line_number":310,"context_line":"            # Logging here since this will often be called in a template"},{"line_number":311,"context_line":"            # where the exception would be hidden."},{"line_number":312,"context_line":"            LOG.info(\"Error reversing absolute URL for %(self)s: %(exc)s\","},{"line_number":313,"context_line":"                     {\u0027self\u0027: self, \u0027exc\u0027: exc})"},{"line_number":314,"context_line":"            raise"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_3d9cdc68","line":312,"range":{"start_line":312,"start_character":55,"end_line":312,"end_character":72},"in_reply_to":"ba2be162_8703b90c","updated":"2017-03-02 12:13:32.000000000","message":"Nope, as it would imply that we pass a tuple to the logger, which is an object. But our format strings says that we need 2 parameters not just one. In this case, the following code would be okay:\n  LOG.info(\"Error reversing absolute URL for %(self)s: %(exc)s\", self, exc)\n\nBut that would make the call look bad. And ofc, if modification is requied, the code mentioned above is a way more fault prone. That\u0027s the reason for the named interpolation.","commit_id":"1f3d0c224141392d0f0ea71497991950dd12cb3a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"86f1a187ef48cac64a5c7a2fb800ba4b0e699bb5","unresolved":false,"context_lines":[{"line_number":526,"context_line":"            # Logging here since this will often be called in a template"},{"line_number":527,"context_line":"            # where the exception would be hidden."},{"line_number":528,"context_line":"            LOG.exception(\"Error reversing absolute URL for %(self)s.\","},{"line_number":529,"context_line":"                          {\u0027self\u0027: self})"},{"line_number":530,"context_line":"            raise"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_ec737ce5","line":529,"updated":"2017-03-02 11:49:32.000000000","message":"-1 to this change .This message contains only one variable.\nThe guideline says: \"Any message with more than one variable should use named interpolation instead of positional ....\" [1]. Thus this change does not follow the guideline.\n\n\n[1] https://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-translated-messages","commit_id":"1f3d0c224141392d0f0ea71497991950dd12cb3a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"921d51326263ba63eaafcbd116605cff84069638","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        except Exception:"},{"line_number":526,"context_line":"            # Logging here since this will often be called in a template"},{"line_number":527,"context_line":"            # where the exception would be hidden."},{"line_number":528,"context_line":"            LOG.exception(\"Error reversing absolute URL for %(self)s.\","},{"line_number":529,"context_line":"                          {\u0027self\u0027: self})"},{"line_number":530,"context_line":"            raise"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_169c1a68","line":528,"range":{"start_line":528,"start_character":60,"end_line":528,"end_character":69},"updated":"2017-03-28 19:22:56.000000000","message":"-\u003e %s","commit_id":"fc43537348d2f506bc77b93b8ec6a9b0e94fa2d2"}],"horizon/test/helpers.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2610e3edd81d700e6c5c73a4ffd06af0c566bb28","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    from horizon.test.webdriver import WebDriver"},{"line_number":54,"context_line":"except ImportError as e:"},{"line_number":55,"context_line":"    LOG.warning(\"%s, force WITH_SELENIUM\u003dFalse\", str(e))"},{"line_number":56,"context_line":"    os.environ[\u0027WITH_SELENIUM\u0027] \u003d \u0027\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfeb2761_a234a14b","line":55,"range":{"start_line":55,"start_character":49,"end_line":55,"end_character":55},"updated":"2017-03-31 11:45:34.000000000","message":"%s does the same conversion as str() does, so this can be simply \u0027e\u0027.","commit_id":"1d407823d159f3a5759a380b860c0f32ec6ee38e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6179937d6840bae166c869b30e5653f58cddb8b3","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    from horizon.test.webdriver import WebDriver"},{"line_number":54,"context_line":"except ImportError as e:"},{"line_number":55,"context_line":"    LOG.warning(\"%s, force WITH_SELENIUM\u003dFalse\", str(e))"},{"line_number":56,"context_line":"    os.environ[\u0027WITH_SELENIUM\u0027] \u003d \u0027\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfeb2761_028fcdcc","line":55,"range":{"start_line":55,"start_character":49,"end_line":55,"end_character":55},"in_reply_to":"dfeb2761_a234a14b","updated":"2017-03-31 12:02:34.000000000","message":"Done","commit_id":"1d407823d159f3a5759a380b860c0f32ec6ee38e"}],"openstack_dashboard/api/glance.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2610e3edd81d700e6c5c73a4ffd06af0c566bb28","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                    filename \u003d image_data.file.name"},{"line_number":354,"context_line":"                msg \u003d (\u0027Failed to remove temporary image file \u0027"},{"line_number":355,"context_line":"                       \u0027%(file)s (%(e)s)\u0027)"},{"line_number":356,"context_line":"                LOG.warning(msg, {\u0027file\u0027: filename, \u0027e\u0027: str(e)})"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"def get_image_upload_mode():"}],"source_content_type":"text/x-python","patch_set":8,"id":"dfeb2761_e213c9b7","line":356,"range":{"start_line":356,"start_character":57,"end_line":356,"end_character":63},"updated":"2017-03-31 11:45:34.000000000","message":"No need for str(). Use \u0027e\u0027 instead.","commit_id":"1d407823d159f3a5759a380b860c0f32ec6ee38e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6179937d6840bae166c869b30e5653f58cddb8b3","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                    filename \u003d image_data.file.name"},{"line_number":354,"context_line":"                msg \u003d (\u0027Failed to remove temporary image file \u0027"},{"line_number":355,"context_line":"                       \u0027%(file)s (%(e)s)\u0027)"},{"line_number":356,"context_line":"                LOG.warning(msg, {\u0027file\u0027: filename, \u0027e\u0027: str(e)})"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"def get_image_upload_mode():"}],"source_content_type":"text/x-python","patch_set":8,"id":"dfeb2761_22abf11d","line":356,"range":{"start_line":356,"start_character":57,"end_line":356,"end_character":63},"in_reply_to":"dfeb2761_e213c9b7","updated":"2017-03-31 12:02:34.000000000","message":"Done","commit_id":"1d407823d159f3a5759a380b860c0f32ec6ee38e"}],"openstack_dashboard/api/keystone.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"86f1a187ef48cac64a5c7a2fb800ba4b0e699bb5","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        endpoint \u003d _get_endpoint_url(request, endpoint_type)"},{"line_number":187,"context_line":"        insecure \u003d getattr(settings, \u0027OPENSTACK_SSL_NO_VERIFY\u0027, False)"},{"line_number":188,"context_line":"        cacert \u003d getattr(settings, \u0027OPENSTACK_SSL_CACERT\u0027, None)"},{"line_number":189,"context_line":"        LOG.debug(\"Creating a new keystoneclient connection to %(endpoint)s.\","},{"line_number":190,"context_line":"                  {\u0027endpoint\u0027: endpoint})"},{"line_number":191,"context_line":"        remote_addr \u003d request.environ.get(\u0027REMOTE_ADDR\u0027, \u0027\u0027)"},{"line_number":192,"context_line":"        conn \u003d api_version[\u0027client\u0027].Client(token\u003dtoken_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_873019a0","line":189,"range":{"start_line":189,"start_character":63,"end_line":189,"end_character":75},"updated":"2017-03-02 11:49:32.000000000","message":"Keep the previous one. I already described the reason in the first file.","commit_id":"1f3d0c224141392d0f0ea71497991950dd12cb3a"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"dbd033273290910772aa51c8a2b96f80845c0e06","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        endpoint \u003d _get_endpoint_url(request, endpoint_type)"},{"line_number":187,"context_line":"        insecure \u003d getattr(settings, \u0027OPENSTACK_SSL_NO_VERIFY\u0027, False)"},{"line_number":188,"context_line":"        cacert \u003d getattr(settings, \u0027OPENSTACK_SSL_CACERT\u0027, None)"},{"line_number":189,"context_line":"        LOG.debug(\"Creating a new keystoneclient connection to %(endpoint)s.\","},{"line_number":190,"context_line":"                  {\u0027endpoint\u0027: endpoint})"},{"line_number":191,"context_line":"        remote_addr \u003d request.environ.get(\u0027REMOTE_ADDR\u0027, \u0027\u0027)"},{"line_number":192,"context_line":"        conn \u003d api_version[\u0027client\u0027].Client(token\u003dtoken_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_bdb44cd1","line":189,"range":{"start_line":189,"start_character":63,"end_line":189,"end_character":75},"in_reply_to":"ba2be162_873019a0","updated":"2017-03-02 12:13:32.000000000","message":"Yes, you\u0027re right on that point and will clean this up","commit_id":"1f3d0c224141392d0f0ea71497991950dd12cb3a"}],"openstack_dashboard/dashboards/admin/images/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2610e3edd81d700e6c5c73a4ffd06af0c566bb28","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    if filter_string \u003e\u003d 0:"},{"line_number":128,"context_line":"                        filters[filter_field] \u003d filter_string"},{"line_number":129,"context_line":"                    else:"},{"line_number":130,"context_line":"                        LOG.warning(invalid_msg, {\u0027field\u0027: filter_field,"},{"line_number":131,"context_line":"                                    \u0027string\u0027: filter_string})"},{"line_number":132,"context_line":"                except ValueError:"},{"line_number":133,"context_line":"                    LOG.warning(invalid_msg, {\u0027field\u0027: filter_field,"},{"line_number":134,"context_line":"                                \u0027string\u0027: filter_string})"}],"source_content_type":"text/x-python","patch_set":8,"id":"dfeb2761_c27d65e8","line":131,"range":{"start_line":130,"start_character":49,"end_line":131,"end_character":60},"updated":"2017-03-31 11:45:34.000000000","message":"I think the indent level does not match.","commit_id":"1d407823d159f3a5759a380b860c0f32ec6ee38e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6179937d6840bae166c869b30e5653f58cddb8b3","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    if filter_string \u003e\u003d 0:"},{"line_number":128,"context_line":"                        filters[filter_field] \u003d filter_string"},{"line_number":129,"context_line":"                    else:"},{"line_number":130,"context_line":"                        LOG.warning(invalid_msg, {\u0027field\u0027: filter_field,"},{"line_number":131,"context_line":"                                    \u0027string\u0027: filter_string})"},{"line_number":132,"context_line":"                except ValueError:"},{"line_number":133,"context_line":"                    LOG.warning(invalid_msg, {\u0027field\u0027: filter_field,"},{"line_number":134,"context_line":"                                \u0027string\u0027: filter_string})"}],"source_content_type":"text/x-python","patch_set":8,"id":"dfeb2761_a245c172","line":131,"range":{"start_line":130,"start_character":49,"end_line":131,"end_character":60},"in_reply_to":"dfeb2761_c27d65e8","updated":"2017-03-31 12:02:34.000000000","message":"Done","commit_id":"1d407823d159f3a5759a380b860c0f32ec6ee38e"}],"openstack_dashboard/dashboards/identity/groups/tables.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"b194e8bd1e0696306fa66f7bd4c2cfe55b752359","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        return api.keystone.keystone_can_edit_group()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def delete(self, request, obj_id):"},{"line_number":86,"context_line":"        LOG.info(\u0027Deleting group \"%s\".\u0027 % obj_id)"},{"line_number":87,"context_line":"        api.keystone.group_delete(request, obj_id)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_c84286ab","line":86,"updated":"2017-03-28 23:53:37.000000000","message":"this also should be changed.","commit_id":"a94bc37458e68584fb8afaecd3dd5b31d1f0fa07"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"97f19eb8aecd796360e42dc7f9bb392e5997ddeb","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        return api.keystone.keystone_can_edit_group()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def delete(self, request, obj_id):"},{"line_number":86,"context_line":"        LOG.info(\u0027Deleting group \"%s\".\u0027 % obj_id)"},{"line_number":87,"context_line":"        api.keystone.group_delete(request, obj_id)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_cb611dd6","line":86,"in_reply_to":"ffe62b97_c84286ab","updated":"2017-03-30 09:33:39.000000000","message":"Done","commit_id":"a94bc37458e68584fb8afaecd3dd5b31d1f0fa07"}]}
