)]}'
{"openstack_dashboard/dashboards/admin/instances/tables.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"a0ffb2a6af05ab85ee53c8bbb5cec8a35eb8f9b2","unresolved":false,"context_lines":[{"line_number":195,"context_line":"class AdminAuditTable(AuditTable):"},{"line_number":196,"context_line":"    def user_link(datum):"},{"line_number":197,"context_line":"        return urlresolvers.reverse(\"horizon:identity:users:detail\","},{"line_number":198,"context_line":"                                    args\u003d(datum.user_id,))"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    user_id \u003d tables.Column(\u0027user_id\u0027, verbose_name\u003d_(\u0027User ID\u0027),"},{"line_number":201,"context_line":"                            link\u003duser_link)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_463b799c","line":198,"updated":"2017-03-09 08:19:10.000000000","message":"This is not a method, can you please move it out of the class scope?","commit_id":"738a0aba8beab4b14fd5d98d4f1d9b90fff1d6fd"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"f1bb3ac0996d705fa0063a2804321d87f02a07da","unresolved":false,"context_lines":[{"line_number":195,"context_line":"class AdminAuditTable(AuditTable):"},{"line_number":196,"context_line":"    def user_link(datum):"},{"line_number":197,"context_line":"        return urlresolvers.reverse(\"horizon:identity:users:detail\","},{"line_number":198,"context_line":"                                    args\u003d(datum.user_id,))"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    user_id \u003d tables.Column(\u0027user_id\u0027, verbose_name\u003d_(\u0027User ID\u0027),"},{"line_number":201,"context_line":"                            link\u003duser_link)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_8a9d5e0c","line":198,"in_reply_to":"9a30ddce_463b799c","updated":"2017-03-09 16:59:15.000000000","message":"Done","commit_id":"738a0aba8beab4b14fd5d98d4f1d9b90fff1d6fd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"36af702b1ba33877dff0a8eed049533d7e97589c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from openstack_dashboard import api"},{"line_number":25,"context_line":"from openstack_dashboard.dashboards.project.instances.audit_tables import \\"},{"line_number":26,"context_line":"    AuditTable"},{"line_number":27,"context_line":"from openstack_dashboard.dashboards.project.instances \\"},{"line_number":28,"context_line":"    import tables as project_tables"},{"line_number":29,"context_line":"from openstack_dashboard import policy"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_86599237","line":26,"updated":"2017-03-11 17:02:22.000000000","message":"We don\u0027t use attribute level import. Use module-level import instead.\n\n  from ..... import audit_tables","commit_id":"6c42569f8d95635e3ae82f7945f377e9c4cc9e76"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"714cd314133415aee1de86744cfaeb5c5b6621da","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from openstack_dashboard import api"},{"line_number":25,"context_line":"from openstack_dashboard.dashboards.project.instances.audit_tables import \\"},{"line_number":26,"context_line":"    AuditTable"},{"line_number":27,"context_line":"from openstack_dashboard.dashboards.project.instances \\"},{"line_number":28,"context_line":"    import tables as project_tables"},{"line_number":29,"context_line":"from openstack_dashboard import policy"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_a9b662f6","line":26,"in_reply_to":"9a30ddce_86599237","updated":"2017-03-12 17:39:16.000000000","message":"Done","commit_id":"6c42569f8d95635e3ae82f7945f377e9c4cc9e76"}],"openstack_dashboard/dashboards/admin/instances/views.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"59225cb09e28c04e8a36aaa200dc6e3bbc5ec52f","unresolved":false,"context_lines":[{"line_number":220,"context_line":"class DetailView(views.DetailView):"},{"line_number":221,"context_line":"    redirect_url \u003d \u0027horizon:admin:instances:index\u0027"},{"line_number":222,"context_line":"    image_url \u003d \u0027horizon:admin:images:detail\u0027"},{"line_number":223,"context_line":"    volume_url \u003d \u0027horizon:admin:volumes:volumes:detail\u0027"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def _get_actions(self, instance):"},{"line_number":226,"context_line":"        table \u003d project_tables.AdminInstancesTable(self.request)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_b6ea7a0d","side":"PARENT","line":223,"updated":"2017-03-10 00:09:12.000000000","message":"This URL has changed to \u0027horizon:admin:volumes:detail\u0027","commit_id":"72f4d07edc7141b4f91503140af49e102669a72b"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"e8c9a2b777ac4bede5160cd63feff1650a35bff8","unresolved":false,"context_lines":[{"line_number":220,"context_line":"class DetailView(views.DetailView):"},{"line_number":221,"context_line":"    redirect_url \u003d \u0027horizon:admin:instances:index\u0027"},{"line_number":222,"context_line":"    image_url \u003d \u0027horizon:admin:images:detail\u0027"},{"line_number":223,"context_line":"    volume_url \u003d \u0027horizon:admin:volumes:volumes:detail\u0027"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def _get_actions(self, instance):"},{"line_number":226,"context_line":"        table \u003d project_tables.AdminInstancesTable(self.request)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_5c069420","side":"PARENT","line":223,"in_reply_to":"9a30ddce_b6ea7a0d","updated":"2017-03-10 21:02:11.000000000","message":"Done","commit_id":"72f4d07edc7141b4f91503140af49e102669a72b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"36af702b1ba33877dff0a8eed049533d7e97589c","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    tab_group_class \u003d tabs.AdminInstanceDetailTabs"},{"line_number":223,"context_line":"    redirect_url \u003d \u0027horizon:admin:instances:index\u0027"},{"line_number":224,"context_line":"    image_url \u003d \u0027horizon:admin:images:detail\u0027"},{"line_number":225,"context_line":"    volume_url \u003d \u0027horizon:admin:volumes:detail\u0027"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def _get_actions(self, instance):"},{"line_number":228,"context_line":"        table \u003d project_tables.AdminInstancesTable(self.request)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_065da214","line":225,"updated":"2017-03-11 17:02:22.000000000","message":"The change itself is correct but this is unrelated to the bug fixed in this commit. I think it should be fixed separately.","commit_id":"6c42569f8d95635e3ae82f7945f377e9c4cc9e76"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"714cd314133415aee1de86744cfaeb5c5b6621da","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    tab_group_class \u003d tabs.AdminInstanceDetailTabs"},{"line_number":223,"context_line":"    redirect_url \u003d \u0027horizon:admin:instances:index\u0027"},{"line_number":224,"context_line":"    image_url \u003d \u0027horizon:admin:images:detail\u0027"},{"line_number":225,"context_line":"    volume_url \u003d \u0027horizon:admin:volumes:detail\u0027"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def _get_actions(self, instance):"},{"line_number":228,"context_line":"        table \u003d project_tables.AdminInstancesTable(self.request)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_09c84e73","line":225,"in_reply_to":"9a30ddce_065da214","updated":"2017-03-12 17:39:16.000000000","message":"This was added as per Richard\u0027s review comment.","commit_id":"6c42569f8d95635e3ae82f7945f377e9c4cc9e76"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5c2acbd74651a1d996387ba8413606e9421ed648","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    tab_group_class \u003d tabs.AdminInstanceDetailTabs"},{"line_number":223,"context_line":"    redirect_url \u003d \u0027horizon:admin:instances:index\u0027"},{"line_number":224,"context_line":"    image_url \u003d \u0027horizon:admin:images:detail\u0027"},{"line_number":225,"context_line":"    volume_url \u003d \u0027horizon:admin:volumes:detail\u0027"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def _get_actions(self, instance):"},{"line_number":228,"context_line":"        table \u003d project_tables.AdminInstancesTable(self.request)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_29a8b276","line":225,"in_reply_to":"9a30ddce_09c84e73","updated":"2017-03-12 18:09:13.000000000","message":"This has been fixed in https://review.openstack.org/#/c/444597/ now.\nCould you rebase on top of the latest master?","commit_id":"6c42569f8d95635e3ae82f7945f377e9c4cc9e76"}]}