)]}'
{"openstack_dashboard/api/nova.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"0e91fe9f85a9f299c64edcee8aee1bc3f0261c7b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        from openstack_dashboard.api import glance"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if not self.image:"},{"line_number":121,"context_line":"            return None"},{"line_number":122,"context_line":"        if hasattr(self.image, \u0027name\u0027):"},{"line_number":123,"context_line":"            return self.image.name"},{"line_number":124,"context_line":"        if \u0027name\u0027 in self.image:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_78189780","line":121,"updated":"2017-03-31 05:59:06.000000000","message":"If it would be changed, here also should be changed, right?\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/views.py#L132","commit_id":"a35cf2da28d2732acebc297f44a222f2cd7028da"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9228515b90588b63654946756b2d308ca30b60d5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        from openstack_dashboard.api import glance"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if not self.image:"},{"line_number":121,"context_line":"            return None"},{"line_number":122,"context_line":"        if hasattr(self.image, \u0027name\u0027):"},{"line_number":123,"context_line":"            return self.image.name"},{"line_number":124,"context_line":"        if \u0027name\u0027 in self.image:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_753163ec","line":121,"in_reply_to":"dfeb2761_2804d414","updated":"2017-04-19 07:28:29.000000000","message":"I agree with Ying.\n\nGenerally speaking, get_data() in view.py should return raw data (without translated string) and translated strings should be handled in the table code, but it is a separate topic.","commit_id":"a35cf2da28d2732acebc297f44a222f2cd7028da"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"8d5492f1b1685a6fc7f213bb52b2c2bf56fae8e1","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        from openstack_dashboard.api import glance"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if not self.image:"},{"line_number":121,"context_line":"            return None"},{"line_number":122,"context_line":"        if hasattr(self.image, \u0027name\u0027):"},{"line_number":123,"context_line":"            return self.image.name"},{"line_number":124,"context_line":"        if \u0027name\u0027 in self.image:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_2804d414","line":121,"in_reply_to":"dfeb2761_78189780","updated":"2017-04-01 13:56:56.000000000","message":"We still want to show a translated dash when the image is not available so I don\u0027t see anything needs to change on the views.py. What do you think needs to be change?","commit_id":"a35cf2da28d2732acebc297f44a222f2cd7028da"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e19e61781e2b1473acbea71c487b4c246c0f108d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                return image.name"},{"line_number":130,"context_line":"            except (glance_exceptions.ClientException,"},{"line_number":131,"context_line":"                    horizon_exceptions.ServiceCatalogException):"},{"line_number":132,"context_line":"                return None"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @property"},{"line_number":135,"context_line":"    def internal_name(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_dd61c83b","line":132,"range":{"start_line":132,"start_character":16,"end_line":132,"end_character":27},"updated":"2017-03-31 12:17:41.000000000","message":"None is actually unnecessary. Just \"return\" returns None in python. I am okay with either, but something worth mentioned is \"return\" only is used in most OpenStack projects.","commit_id":"a35cf2da28d2732acebc297f44a222f2cd7028da"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"8d5492f1b1685a6fc7f213bb52b2c2bf56fae8e1","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                return image.name"},{"line_number":130,"context_line":"            except (glance_exceptions.ClientException,"},{"line_number":131,"context_line":"                    horizon_exceptions.ServiceCatalogException):"},{"line_number":132,"context_line":"                return None"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @property"},{"line_number":135,"context_line":"    def internal_name(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_c8120859","line":132,"range":{"start_line":132,"start_character":16,"end_line":132,"end_character":27},"in_reply_to":"dfeb2761_dd61c83b","updated":"2017-04-01 13:56:56.000000000","message":"Yes, I think it\u0027s okay to be explicit here.","commit_id":"a35cf2da28d2732acebc297f44a222f2cd7028da"}],"openstack_dashboard/dashboards/project/instances/templates/instances/_detail_overview.html":[{"author":{"_account_id":9155,"name":"Eddie Ramirez","email":"eddie.ramirez@intel.com","username":"ediardo"},"change_message_id":"71f33181959af4ce9a531f1292627cedd1b65bda","unresolved":false,"context_lines":[{"line_number":101,"context_line":"      {% endwith %}"},{"line_number":102,"context_line":"      {% if instance.image %}"},{"line_number":103,"context_line":"        \u003cdt\u003e{% trans \"Image Name\" %}\u003c/dt\u003e"},{"line_number":104,"context_line":"        {% if instance.image_name !\u003d \"-\" %}"},{"line_number":105,"context_line":"          \u003cdd\u003e\u003ca href\u003d\"{{ instance.image_url }}\"\u003e{{ instance.image_name }}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":106,"context_line":"        {% else %}"},{"line_number":107,"context_line":"          \u003cdd\u003e{{ instance.image_name }}\u003c/dd\u003e"},{"line_number":108,"context_line":"        {% endif %}"},{"line_number":109,"context_line":"        \u003cdt\u003e{% trans \"Image ID\" %}\u003c/dt\u003e"},{"line_number":110,"context_line":"        \u003cdd\u003e{{ instance.image.id }}\u003c/dd\u003e"},{"line_number":111,"context_line":"      {% else %}"}],"source_content_type":"text/html","patch_set":2,"id":"ba2be162_eba62252","line":108,"range":{"start_line":104,"start_character":8,"end_line":108,"end_character":19},"updated":"2017-03-01 22:00:57.000000000","message":"How about:\n  \u003cdd\u003e\n  {% if instance.image_name !\u003d \"-\" %}\n          \u003ca href\u003d\"{{ instance.image_url }}\"\u003e{{ instance.image_name }}\u003c/a\u003e\n        {% else %}\n          {{ instance.image_name }}\n        {% endif %}\n\u003c/dd\u003e","commit_id":"f7e536ef1e0dbdf9ff9091bd105fea5248f19fe5"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"d4a5d22a57cdc941295a03a4bd8b34faeb96b263","unresolved":false,"context_lines":[{"line_number":101,"context_line":"      {% endwith %}"},{"line_number":102,"context_line":"      {% if instance.image %}"},{"line_number":103,"context_line":"        \u003cdt\u003e{% trans \"Image Name\" %}\u003c/dt\u003e"},{"line_number":104,"context_line":"        {% if instance.image_name !\u003d \"-\" %}"},{"line_number":105,"context_line":"          \u003cdd\u003e\u003ca href\u003d\"{{ instance.image_url }}\"\u003e{{ instance.image_name }}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":106,"context_line":"        {% else %}"},{"line_number":107,"context_line":"          \u003cdd\u003e{{ instance.image_name }}\u003c/dd\u003e"},{"line_number":108,"context_line":"        {% endif %}"},{"line_number":109,"context_line":"        \u003cdt\u003e{% trans \"Image ID\" %}\u003c/dt\u003e"},{"line_number":110,"context_line":"        \u003cdd\u003e{{ instance.image.id }}\u003c/dd\u003e"},{"line_number":111,"context_line":"      {% else %}"}],"source_content_type":"text/html","patch_set":2,"id":"ba2be162_06d1ab57","line":108,"range":{"start_line":104,"start_character":8,"end_line":108,"end_character":19},"in_reply_to":"ba2be162_eba62252","updated":"2017-03-01 22:11:12.000000000","message":"That\u0027s better. Thanks. Added a patch set.","commit_id":"f7e536ef1e0dbdf9ff9091bd105fea5248f19fe5"}]}
